< bitcoin-git>
bitcoin/master fad21a1 MarcoFalke: test: Explain that a bug should be filed when the test fail
< bitcoin-git>
bitcoin/master e478b11 MarcoFalke: Merge #19110: test: Explain that a bug should be filed when the tests fail...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #19110: test: Explain that a bug should be filed when the tests fail (master...2005-testBug) https://github.com/bitcoin/bitcoin/pull/19110
< hebasto>
is -dropmessagestest command-line debug arg still useful? it seems no test coverage for it
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #19114: scripted-diff: TxoutType C++11 scoped enum class (master...2005-enumClassTxoutType) https://github.com/bitcoin/bitcoin/pull/19114
< aqua422>
any plan to add some kind of webhooks for incoming transactions (spotted in mempool, and for x confs)?
< aqua422>
I figured that polling via rpc a few millions of addresses continuously is not the ideal way
< aqua422>
*only wallet related addresses btw
< shesek>
aqua422, this exists via the `walletnotify` option, which allows you to run a custom command whenever a new wallet transaction is added to the mempool or mined in a block
< aqua422>
shesek the issue with that feature is that it spawns a new thread every time a tx is added
< shesek>
you can also try https://github.com/shesek/bwt, which sits on top of bitcoind and provides real-time updates in the form of webhooks and server-sent events (a streaming long-lived http connection)
< shesek>
aqua422, why is that a problem? are you dealing with a really high-volume wallet?
< aqua422>
shesek a few million addresses and pretty high volume, yes. At the moment we just have a database where we store all addresses and loop through them on different with bitcoin core running
< aqua422>
it works, but I don't like the polling aspect
< aqua422>
I'm just gonna patch bitcoin core my needs now though
< phantomcircuit>
aqua422, "loop through them on different" ?
< phantomcircuit>
if you don't care about unconfirmed transactions it's easy
< phantomcircuit>
otherwise the walletnotify thing and then poll on new blocks
< bitcoin-git>
[bitcoin] pstratem opened pull request #19116: [WIP] wallet: use BlockFilterIndex in ScanForWalletTransactions (master...2020-05-29-generate-pubkeys) https://github.com/bitcoin/bitcoin/pull/19116
< phantomcircuit>
CKeyID is the same thing as PKHash right?
< phantomcircuit>
they're both a uint160 of the serialized public key
< sipa>
yeah, same data, but CKeyID has the added semantics of "p2pkh address"
< sipa>
eh
< sipa>
the other way around
< phantomcircuit>
sipa, yeah i see, can i just convert a CKeyID blindly to PKHash to call GetScriptForDestination ?