00:32 < yanmaani1> if I create a CTxIn and pass it to wallet.CreateTransaction(), is there some expected process which would cause nSequence to be changed?

00:43 < yanmaani> nvm I'm stupid

07:47 < bitcoin-git> [bitcoin] sipa opened pull request #22166: Add support for inferring tr() descriptors (master...202106_infer_tap) https://github.com/bitcoin/bitcoin/pull/22166

10:00 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22167: refactor: Remove char serialize (master...2105-uin8t) https://github.com/bitcoin/bitcoin/pull/22167

11:37 < bitcoin-git> [bitcoin] promag opened pull request #22168: wallet: Avoid exception when loading with unsupported external signer (master...2021-06-wallet-extsig) https://github.com/bitcoin/bitcoin/pull/22168

13:37 < bitcoin-git> [gui] promag closed pull request #88: Support block hash alias in console (master...2020-09-block-alias-console) https://github.com/bitcoin-core/gui/pull/88

13:57 < bitcoin-git> [bitcoin] jonatack opened pull request #22169: p2p, rpc, fuzz: various tiny follow-ups (master...p2p-rpc-fuzz-various-followups) https://github.com/bitcoin/bitcoin/pull/22169

14:54 < michaelfolkson2> Do you do requests for your Twitch channel achow101? :) Wouldn't mind some Twitch review of some of the Taproot wallet support PRs e.g. #21365 and #22166. Or a Taproot wallet support PR you are working on but hasn't been opened yet

14:55 <@gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub

14:55 <@gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub

15:11 < n1rna> hiall

15:11 < n1rna> quick question

15:12 < n1rna> I can't seem to be able to run the `verify-commit` script successfully

15:12 < n1rna> this is what I'm getting right now

15:12 < n1rna> ```

15:12 < n1rna> ~/p/bitcoin$ ./contrib/verify-commits/verify-commits.py origin/master

15:12 < n1rna> Using verify-commits data from /home/nima/p/bitcoin/contrib/verify-commits

15:12 < n1rna> No parent of 38ab7d0765e52b8c9d93a677de70736a2e3a58a0 was signed with a trusted key!

15:12 < n1rna> Parents are:

15:12 < n1rna> commit 898dd9e262e4911fdf729bfe84b026c4e869802d

15:12 < n1rna> Merge: 8f5c9a7fd fa2b6c62c

15:12 < n1rna> Author: MarcoFalke <falke.marco@gmail.com>

15:12 < n1rna> Date: Sat Jun 5 08:41:34 2021 +0200

15:12 < n1rna> Merge bitcoin/bitcoin#22150: test: Remove unused node from feature_nulldummy

15:12 < n1rna> fa2b6c62cd9a43d5896bb4b06a3ae64b7199843f test: Remove unused node from feature_nulldummy (MarcoFalke)

15:12 < n1rna> Pull request description:

15:12 < n1rna> This is confusing and might even slow down the test.

15:12 < n1rna> This reverts a change that was added a year ago in d438d60 and then the need for it was removed by 95d5d5e six months ago.

15:12 <@gribble> https://github.com/bitcoin/bitcoin/issues/22150 | test: Remove unused node from feature_nulldummy by MarcoFalke · Pull Request #22150 · bitcoin/bitcoin · GitHub

15:12 < n1rna> Top commit has no ACKs.

15:12 < n1rna> Tree-SHA512: 9a86792e9a634cf7bbd4e7a21b1acdfc3baba1b1962fe2b9b73848436d10351d2326dca01313c097ba2342dde7207add73e731d053c0bfa888a5d8f2b233a7cf

15:12 < n1rna> commit 69b8b5d72c47d42a9e69e6666af89606057be15b

15:12 < n1rna> Author: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

15:12 < n1rna> Date: Wed May 12 21:39:48 2021 +0300

15:13 < n1rna> sorry for the formatting

15:13 < n1rna> but what am I doing wrong?

15:14 < n1rna> I also tried running this before running the verify script

15:14 < n1rna> `git log --merges --before="2 days ago" -1 --format='%H' > ./contrib/verify-commits/trusted-sha512-root-commit`

15:14 < n1rna> but no difference

15:18 < n1rna> Looks like marco's commits with `falke.marco@gmail.com` are not signed

15:27 < n1rna> any insights?

16:39 < bitcoin-git> [bitcoin] baptistapedro opened pull request #22171: Create sanitizestring.cpp (master...fuzz-fix-SanitizeStr) https://github.com/bitcoin/bitcoin/pull/22171

17:17 < achow101> michaelfolkson: sure

17:17 < achow101> n1rna: please don't paste terminal outputsl like that, it's very spammy

17:17 < achow101> n1rna: the commits are signed, but marco's key has expired

17:28 < bitcoin-git> [bitcoin] jonatack opened pull request #22172: doc: update tor.md, release notes with removal of tor v2 support (master...tor-v2-removal-documentation) https://github.com/bitcoin/bitcoin/pull/22172

17:55 < bitcoin-git> [bitcoin] achow101 opened pull request #22173: wallet: Do not load external signers wallets when unsupported (master...check-external-signer-flags) https://github.com/bitcoin/bitcoin/pull/22173

18:02 < bitcoin-git> [bitcoin] promag closed pull request #22168: wallet: Avoid exception when loading with unsupported external signer (master...2021-06-wallet-extsig) https://github.com/bitcoin/bitcoin/pull/22168

18:33 < n1rna> achow101 sorry for pasting the output. I sholdve used pastebin

19:39 < kanzure> MarcoFalke: i think you're using copy-paste for your "close github comment" comment text since it's always the same; might be worth updating the IRC channel network in the message.

20:09 < darosior> n1rna: had the same issue, you can get Marco's key from OpenPGP iirc

20:37 < bitcoin-git> [bitcoin] hebasto opened pull request #22174: build, qt: Fix libraries linking order for Linux hosts (master...210606-order) https://github.com/bitcoin/bitcoin/pull/22174

20:41 < hebasto> ^ hope it does not breach qt pull embargo :)