< bitcoin-git> [bitcoin] prayank23 opened pull request #22316: doc: Add 5 privacy recommendations in tor.md (master...tor-privacy-recommend) https://github.com/bitcoin/bitcoin/pull/22316
< bitcoin-git> [bitcoin] prayank23 opened pull request #22317: doc: Highlight DNS requests part in tor.md (master...highlight-dns-request) https://github.com/bitcoin/bitcoin/pull/22317
< luke-jr> how to restart bitcoinbuilds CI jobs? https://bitcoinbuilds.org/?job=8eba38f6-e542-4497-9330-d9a0f1183f80 seems stalled for nothing related to PR
< bitcoin-git> [bitcoin] prayank23 closed pull request #21157: doc: Improve Tor docs (master...tor-docs-add) https://github.com/bitcoin/bitcoin/pull/21157
< bitcoin-git> [bitcoin] hebasto opened pull request #22318: build: Avoid @GLIBC_2.25 symbols for compatibility (master...210623-random) https://github.com/bitcoin/bitcoin/pull/22318
< meshcollider> dongcarl: it's been a while but it may be a mistake, I think -r is a diff-tree flag not a diff flag
< meshcollider> To recurse into subtrees
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c93e123dc72b...03aa59a4e58f
< bitcoin-git> bitcoin/master fafd916 MarcoFalke: test: Add missing sync_all to feature_coinstatsindex
< bitcoin-git> bitcoin/master 03aa59a MarcoFalke: Merge bitcoin/bitcoin#22313: test: Add missing sync_all to feature_coinsta...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22313: test: Add missing sync_all to feature_coinstatsindex (master...2106-testSync) https://github.com/bitcoin/bitcoin/pull/22313
< bitcoin-git> [bitcoin] fanquake opened pull request #22320: build: set minimum required Boost to 1.64.0 (master...minimum_ubuntu_18_04) https://github.com/bitcoin/bitcoin/pull/22320
< bitcoin-git> [bitcoin] hebasto opened pull request #22321: build: Avoid qt-specific @GLIBC_2.28 symbols for compatibility (master...210623-statx) https://github.com/bitcoin/bitcoin/pull/22321
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/03aa59a4e58f...d6e0d78c3155
< bitcoin-git> bitcoin/master d197977 Vasil Dimov: banman: save the banlist in a JSON format on disk
< bitcoin-git> bitcoin/master dd4e957 Vasil Dimov: test: ensure banlist can be read from disk after restart
< bitcoin-git> bitcoin/master 24b10eb Vasil Dimov: doc: fix grammar in doc/files.md
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20966: banman: save the banlist in a JSON format on disk (master...json_bans) https://github.com/bitcoin/bitcoin/pull/20966
< vasild> * Added support for running Bitcoin Core as an [I2P (Invisible Internet Project)](https://en.wikipedia.org/wiki/I2P) service and connect to such services. See doc/i2p.md for details. (#20685)
<@gribble> https://github.com/bitcoin/bitcoin/issues/20685 | Add I2P support using I2P SAM by vasild · Pull Request #20685 · bitcoin/bitcoin · GitHub
< vasild> MarcoFalke: am I supposed to edit https://github.com/bitcoin-core/bitcoin-devwiki/wiki/22.0-Release-Notes-draft directly and add the above?
< jonatack> vasild: I think so. The notes are in the wiki for team editing until -final.
< vasild> done
< jonatack> vasild: Probably place it under "Notable changes"
< vasild> why would it be in a wiki otherwise
< vasild> yes, there, just before dropping support for torv2
< jonatack> just saw it lgtm
< vasild> it assumes #22250 is merged (which adds doc/i2p.md)
<@gribble> https://github.com/bitcoin/bitcoin/issues/22250 | doc: add basic I2P documentation by vasild · Pull Request #22250 · bitcoin/bitcoin · GitHub
< vasild> I think it is reasonable to s/8333/0/ all i2p ports in addrman as a temporary measure
< vasild> it will only be a problem if some bitcoin node exists which uses SAM 3.2 and "listens" on port 8333 only (checks TO_PORT and drops the incoming connection if it is not 8333)
< vasild> and it advertises itself as foo:8333 and we change that to foo:0
< jonatack> sgtm. we need something like that if I2P addrs are valid with port number 0 only, which is unfortunate. i don't know of a way to remove or update the existing I2P addrman entries manually from 8333 to 0 (other than deleting peers.dat) so outbound and addnode connections work.
< jonatack> and unfortunate that setting the port number to 0 or ignoring the port number would be necessary for SAM < 3.2, i wonder if the remedy is worse than having (short-lived) double connections
< fanquake> That's annoying. Just another reason to bump the minimum required macOS version
< hebasto> for 22.0 or later?
< fanquake> Then we'll get std::unordered_map::merge and std::filesystem
< fanquake> I would have thought our 10.14 build in the CI would have caught this, as it's building against a 10.15.x SDK, but setting the runtime version to 10.14.x
< hebasto> yeah, build fails with sdk 10.14.6
< bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/d6e0d78c3155...567670bec5ec
< bitcoin-git> bitcoin/master 29e5dd1 Pieter Wuille: consensus refactor: extract ComputeTapleafHash, ComputeTaprootMerkleRoot
< bitcoin-git> bitcoin/master c7388e5 Pieter Wuille: Report address as solvable based on inferred descriptor
< bitcoin-git> bitcoin/master d637a9b Pieter Wuille: Taproot descriptor inference
< bitcoin-git> [bitcoin] meshcollider merged pull request #22166: Add support for inferring tr() descriptors (master...202106_infer_tap) https://github.com/bitcoin/bitcoin/pull/22166
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22322: fuzz: Check banman roundtrip (master...2106-fuzzBanman) https://github.com/bitcoin/bitcoin/pull/22322
< bitcoin-git> [bitcoin] jonatack opened pull request #22323: script, doc: spelling update (master...spelling-update) https://github.com/bitcoin/bitcoin/pull/22323
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #22327: cli: Avoid truncating -rpcwaittimeout (master...2106-cliTrunkTime) https://github.com/bitcoin/bitcoin/pull/22327
< vasild> #22179 May be considered for 22.0, it also has 3 ACKs
<@gribble> https://github.com/bitcoin/bitcoin/issues/22179 | Torv2 removal followups by vasild · Pull Request #22179 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/567670bec5ec...c0e30933e0d3
< bitcoin-git> bitcoin/master 184d453 Jon Atack: script, doc: spelling update
< bitcoin-git> bitcoin/master c0e3093 MarcoFalke: Merge bitcoin/bitcoin#22323: doc: spelling update
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22323: doc: spelling update (master...spelling-update) https://github.com/bitcoin/bitcoin/pull/22323
< vasild> jonatack: addrman does not support holding >1 entries that have the same address (and differ only by port), hmm...
< vasild> and if it already holds i2p:8333 and we try to add i2p:0, then it will leave the original (will not update the port) :-(
< jonatack> i tried this too... rpc addpeeraddress no go... edit-in-place or remove-then-add?
< vasild> What about dropping both #21514 and #22112 and leaving #21389 unfixed?
<@gribble> https://github.com/bitcoin/bitcoin/issues/21514 | p2p: Ignore ports on I2P addresses by vasild · Pull Request #21514 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/22112 | Force port 0 in I2P by vasild · Pull Request #22112 · bitcoin/bitcoin · GitHub
<@gribble> https://github.com/bitcoin/bitcoin/issues/21389 | It is possible to open >1 connections to the same I2P node · Issue #21389 · bitcoin/bitcoin · GitHub
< vasild> editing addrman's entries (changing ports) would require re-bucketing
< jonatack> yes, as i wrote this morning: "i wonder if the remedy is worse than having (short-lived) double connections"
< vasild> Why short-lived?
< jonatack> only that i see that they are infrequent and don't last long
< jonatack> e.g. less than 5 minutes, most often 1 or 2 minutes
< vasild> I have no explanation for that, but short-lived or long-lived is not very important
< jonatack> they seem to have become very rare as well (for me). i currently know of 14 i2p peers and am usually connected to 11-12 of them at a time, e.g. right now 6 outbound, 6 inbound
< jonatack> (double connections become very rare, they used to be common)
< vasild> the issue 21389 only happens when addnode is (mis)used
< vasild> or -connect=...
< vasild> (mis)used == addnode same i2p addr with different ports
< jonatack> either same one in and out (both sides adding the other) or two in at once (maybe because addnode was used twice, with and with port)
< jonatack> *with and without port
< vasild> yes
< vasild> maybe we played more with addnode before and recently have left it alone
< jonatack> wait until SAM 3.2 then?
< vasild> and do what if/when we start using SAM 3.2?
< jonatack> that's probably true about less addnode use
< jamesob> maintainers: anything else you'd like to see for #21526 to merge? once that goes in I can open a number of other smaller AU PRs
<@gribble> https://github.com/bitcoin/bitcoin/issues/21526 | validation: UpdateTip/CheckBlockIndex assumeutxo support by jamesob · Pull Request #21526 · bitcoin/bitcoin · GitHub
< jonatack> looking at https://geti2p.net/en/docs/api/samv3, SAM 3.2 introduces options FROM_PORT and TO_PORT, and in SAM 3.3, "incoming packets and streams will be routed based on I2P protocol and to-port"
< vasild> jonatack: posted a summary at https://github.com/bitcoin/bitcoin/issues/21389#issuecomment-866925116, will sleep over this and re-evaluate
< jonatack> vasild: good summary, same. thanks!
< bitcoin-git> [bitcoin] theStack opened pull request #22330: test: use MiniWallet for simple doublespend sub-test in feature_rbf.py (master...202106-test-feature_rbf_use_miniwallet_for_doublespend) https://github.com/bitcoin/bitcoin/pull/22330
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c0e30933e0d3...7317e14a44c6
< bitcoin-git> bitcoin/master 615c1ad James O'Beirne: refactor: wrap CCoinsViewCursor in unique_ptr
< bitcoin-git> bitcoin/master 0f8a5a4 James O'Beirne: move-only(ish): don't expose CCoinsViewDBCursor
< bitcoin-git> bitcoin/master 7ad414f James O'Beirne: doc: add comment about CCoinsViewDBCursor constructor
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #22263: refactor: wrap CCoinsViewCursor in unique_ptr (master...2021-06-cursor-unique-ptr) https://github.com/bitcoin/bitcoin/pull/22263
< bitcoin-git> [bitcoin] dhruv opened pull request #22331: [crypto] Fix K1/K2 use in ChaCha20-Poly1305 AEAD (master...15649-followups) https://github.com/bitcoin/bitcoin/pull/22331
< jamesob> where's the list of PRs that need review before feature freeze?
< jamesob> sipa: danke