< bitcoin-git>
bitcoin/master fa72fce MarcoFalke: test: Use ConnmanTestMsg from test lib in denialofservice_tests
< bitcoin-git>
bitcoin/master 551933f fanquake: Merge bitcoin/bitcoin#22203: test: Use ConnmanTestMsg from test lib in den...
< bitcoin-git>
[bitcoin] fanquake merged pull request #22203: test: Use ConnmanTestMsg from test lib in denialofservice_tests (master...2106-testConnman) https://github.com/bitcoin/bitcoin/pull/22203
< bitcoin-git>
bitcoin/master ef99d03 bruno: test: check anchors.dat when node starts for the first time
< bitcoin-git>
bitcoin/master 6985038 MarcoFalke: Merge bitcoin/bitcoin#22118: test: check anchors.dat when node starts for ...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #22118: test: check anchors.dat when node starts for the first time (master...2021-05-improv-anchors-test) https://github.com/bitcoin/bitcoin/pull/22118
< michaelfolkson>
But getting the error "Missing checksum"
< michaelfolkson>
I need to add the checksum of the P2TR address to the descriptor somewhere...?
< michaelfolkson>
Maybe directly after the internal key... or at the end of the descriptor?
< darosior>
michaelfolkson: bitcoind RPC API makes the checksum part of descriptors (see doc/descriptors.md) mandatory, you can get one using `getdescriptorinfo`
< Kiminuo>
I'm confused. Should I compile with or without `--enable-debug`?
< michaelfolkson>
Kiminuo: If it says beware of configuring without --enable-debug, that seems to suggest you should configure with it :)
< laanwj>
if you want to have realistic benchmarks, don't use --enable-debug
< laanwj>
what you usually want to know is how something performs in release and releases are not built with that
< Kiminuo>
but then the sentence is incorrect, isn't it? I mean " Beware of configuring without `--enable-debug` as this would impact benchmarking by unlatching log printers and lock analysis."
< Kiminuo>
Yes, that's what I would expect.
< laanwj>
yes, i agree the sentence is confusing
< Kiminuo>
I would expect it to say: "Beware of configuring with `--enable-debug` as this would impact benchmarking by unlatching log printers and lock analysis."
< Kiminuo>
(without -> with)
< michaelfolkson>
darosior: Thanks, getdescriptorinfo requires a valid descriptor though right? I don't have a valid Taproot descriptor without generating a checksum and adding to the descriptor somewhere
< laanwj>
Kiminuo: i mean, if you did want to profile the lock analysis specifically you'd want to benchmark with debug, but not otherwise, in any case would be good to word it differently
< darosior>
michaelfolkson: hand made descriptor (thus w/o checksum) -> getdescriptorinfo -> append the checksum -> importdescriptors
< darosior>
So, no, getdescriptorinfo doesnt require a checksum
< michaelfolkson>
darosior: Awesome, that worked. I'll see where the checksum should be appended, I'm guessing at the end of the descriptor
< Kiminuo>
laanwj: Thanks for the explanation!
< darosior>
Yes <desc>#<checksum>, see doc/descriptors.md :)
< earnestly>
(Would be nice if 'MarcoFalke' signed their commits)
< earnestly>
In this sense it doesn't matter if they have a public key or not (i.e. if it's on a keyserver), it's that the commit itself isn't signed by their key
< earnestly>
(I'm not sure because github does mess with this using their own keys and such)
< earnestly>
michaelfolkson: Ah, perhaps it is the issue. I misread the github UI
< earnestly>
michaelfolkson: Thanks, this works
< michaelfolkson>
No problem
< darosior>
earnestly: Marco signs their merge commits with "B8B3 F1C0 E58C 15DB 6A81 D30C 3648 A882 F431 6B9B", which is what matters when you want to verify the master branch.
< earnestly>
darosior: Yeah thanks I managed to find it from openpgp
< earnestly>
It's nice that the devs do sign their commits and not just releases
< laanwj>
we sign all merge commits
< laanwj>
(and sometimes more, but all top-level merge commits need to be signed)
< bitcoin-git>
[bitcoin] sipsorcery opened pull request #22224: Update msvc and appveyor builds to use Qt5.12.11 binaries (master...msvc_qt5.12.11) https://github.com/bitcoin/bitcoin/pull/22224