theStack has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 255 seconds]
<bitcoin-git>
[bitcoin] ishaanam opened pull request #25375: rpc: add minconf option to sendall and fund transaction calls (master...fundrawtransaction_minconf) https://github.com/bitcoin/bitcoin/pull/25375
<jeremyrubin>
achow101: i noticed a small bug in the PSBT spec I believe. 174 says "The internal key does not have leaf hashes, so can be indicated with a hashes len of 0.", however, it is not true that the internal key may not show up in some tap leaf as well. However, it should be clear which key is the internal key by the taproot intenral key field, so it
<jeremyrubin>
shouldn't be ambigious even if it does have more than one branch.
brunoerg has joined #bitcoin-core-dev
Alina-malina has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 255 seconds]
<jeremyrubin>
it also says "4 byte master key fingerprint " and i think this should just be the fingerprint, not nesc master?
<jeremyrubin>
it's also not clear (IMO) if the derivation path is required if the ExtendedPrivKey itself corresponds to the internal key
brunoerg has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
bomb-on has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
bomb-on has quit [Ping timeout: 256 seconds]
Ben25 has joined #bitcoin-core-dev
Ben25 has quit [Quit: Ping timeout (120 seconds)]
mikehu44 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<_aj_>
hmm, seems my PC doesn't handle generate(999) too well - node 1 receives blocks relatively slowly, then hits the "Large reorg, won't direct fetch" path, which makes things slower still, then it eventually times out. 9x generate(111) works fine.
brunoerg has quit [Ping timeout: 258 seconds]
Alina-malina has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<achow101>
jeremyrubin: yes, I think the intent of that sentence was to answer the question of where to put the key origin info for the internal key. The fingerprint is almost always the master key fingerprint. It's the identifier for the key to derive from.
<achow101>
I'm not sure where you see an extended private key anywhere?
weylin_ has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
Saloframes has quit [Read error: Connection reset by peer]
<_aj_>
laanwj: still don't really see why it's slow, but seems like debugging it would mean actually understanding how net_processing does header processing / block queuing :-/
Guyver2 has left #bitcoin-core-dev [Closing Window]
brunoerg has joined #bitcoin-core-dev
jespada has quit [Read error: Connection reset by peer]
jespada has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
jespada_ has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 240 seconds]
kexkey has quit [Ping timeout: 256 seconds]
kexkey has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
jespada_ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
hashfunc16b8 has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
kouloumos has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
<fanquake>
laanwj: thanks for the LTO testing so far
<fanquake>
going to follow up with a PR with the changes for Guix
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
<laanwj>
fanquake: yes, i think that's the final step (besides Qt, but as all of that will change when going to Qt6 i suppose going down that rabbit hole may not be worth it)
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
dougefish_ has joined #bitcoin-core-dev
zxrqmz88 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
gharbeia has joined #bitcoin-core-dev
dougefish has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
zxrqmz88 has quit [Quit: Quit]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mruddy closed pull request #24957: prune, import: allow pruning to work during loadblock import (master...issue_23852_import_prune) https://github.com/bitcoin/bitcoin/pull/24957
<sdaftuar>
laanwj: i suspect the issue you're referring to has to do with the inv/getheader response cycle. it's broken in two ways that manifest themselves when a peer is sending us a bunch of inv's back to back
Guest89 has quit [Quit: Client closed]
<sdaftuar>
laanwj: first we currently allow multiple getheaders in flight to the same peer; second, for no real good reason we use the "hashstop" feature of getheaders which causes ther esponse to truncate prematurely (ie the peer might not send their whole chain even if they have more headers to give us)
<sdaftuar>
i plan to fix both these issues soon actually, so if this is the issue you're seeing in p2p_blockfilters.py, then i'll add that to the use case for my change :)
<sdaftuar>
the multiple getheaders in flight to a peer causes n^2 bandwidth usage in regtest when you generate a bunch of blocks at once. i think an easy fix would be to generate 1 block first and sync the nodes; at that point compact blocks should be enabled and the remaining blocks should relay quickly without the n^2 bandwidth overhead
<_aj_>
sdaftuar: locally
TallTim_ is now known as TallTim
<sdaftuar>
_aj_: do you have debug logs you can share?
<_aj_>
sdaftuar: sure, let me get some fresh ones
<_aj_>
sdaftuar: oh, except i guess i need to clean up my network first oops, gimme a few
<_aj_>
sdaftuar: 1 doesn't seem to be enough to trigger hb compact blocks, but 2 does?
furszy has quit []
<sdaftuar>
ah, interesting
<sdaftuar>
does that seem to solve the flakiness issue?
<_aj_>
looks like it massively reduces the time between node0 hitting height=999 and node1 also getting to that height
<sdaftuar>
awesome. i'll think about the 1 vs 2 observation; could be i'm forgetting how it works exactly or that there's a race condition around the hb announcement request going out that you might have run into
AaronvanW has quit [Quit: Leaving...]
<bitcoin-git>
[bitcoin] kouloumos opened pull request #25379: test: use MiniWallet to simplify mempool_package_limits.py tests (master...simplify-mempool_package_limits.py) https://github.com/bitcoin/bitcoin/pull/25379
furszy has joined #bitcoin-core-dev
DavidBakin has quit [Remote host closed the connection]
furszy has quit []
<bitcoin-git>
[bitcoin] darosior opened pull request #25380: Detect and ignore transactions that were CPFP'd in the fee estimator (master...fee_estimator_disable_cpfp) https://github.com/bitcoin/bitcoin/pull/25380
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
yashraj has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] glozow opened pull request #25382: doc and test requirement that replacement must have higher feerate than direct conflicts (master...2022-06-rbf-feerate-rule) https://github.com/bitcoin/bitcoin/pull/25382
vasild has joined #bitcoin-core-dev
yashraj has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master 216c9b0 brunoerg: test: passing a value below 5 MB to -maxmempool should throw an error
<bitcoin-git>
bitcoin/master 6acba84 MacroFake: Merge bitcoin/bitcoin#25358: test: passing a value below 5 MB to -maxmempo...
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25358: test: passing a value below 5 MB to -maxmempool should throw an error (master...2022-06-test-minimum-maxmempool) https://github.com/bitcoin/bitcoin/pull/25358
_flood has quit [Read error: Connection reset by peer]
<bitcoin-git>
[bitcoin] furszy opened pull request #25383: wallet: don't read db every time that a new 'WalletBatch' is created (master...2022_wallet_db_read) https://github.com/bitcoin/bitcoin/pull/25383
flooded has joined #bitcoin-core-dev
yashraj has quit []
evanlinjin has quit [Ping timeout: 240 seconds]
Nekorand has joined #bitcoin-core-dev
Nekorand has quit [Client Quit]
Guest2260 has joined #bitcoin-core-dev
Guest2260 has quit [Client Quit]
jarthur has quit [Quit: jarthur]
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
Guest4487 has joined #bitcoin-core-dev
Guest4487 has quit [Client Quit]
david-bakin has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
_cold is now known as cold
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 255 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
kexkey has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
evbo has quit [Ping timeout: 244 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
kouloumos has quit [Quit: Connection closed for inactivity]
bw_ has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
gnusha has joined #bitcoin-core-dev
bw has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
gnusha has quit [*.net *.split]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
gnusha has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
bomb-on has quit [Quit: aллилѹіа!]
brunoerg has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
emcy has quit [Ping timeout: 244 seconds]
emcy has joined #bitcoin-core-dev
emcy has quit [Ping timeout: 246 seconds]
emcy has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
bitdex has joined #bitcoin-core-dev
zxrqmz88 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
zxrqmz88 has quit [Quit: Quit]
zxrqmz88 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<david-bakin>
unfortunately 25097 does NOT yet have tapSCRIPT though it has tapROOT tests - but I am STILL trying to develop them on my own (specifically, I need to build some that I can build and put in the form of inputs to VerifyScript)
<david-bakin>
(and btw jamesob I'm still working on this gnarly issue - I'll probably send you an email tonight detailing issues)