noxim has joined #bitcoin-core-dev
noxim has quit [Changing host]
noxim has joined #bitcoin-core-dev
noxim has quit [Ping timeout: 248 seconds]
jonatack has quit [Ping timeout: 252 seconds]
kexkey_ has quit [Ping timeout: 260 seconds]
ziggie has joined #bitcoin-core-dev
kexkey has joined #bitcoin-core-dev
kexkey has quit [Client Quit]
kexkey has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 248 seconds]
noxim has joined #bitcoin-core-dev
noxim has quit [Changing host]
noxim has joined #bitcoin-core-dev
noxim has quit [Ping timeout: 260 seconds]
noxim has joined #bitcoin-core-dev
noxim has quit [Changing host]
noxim has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jb55 has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
_flood has quit [Ping timeout: 272 seconds]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
Guest6281 has quit [Quit: Client closed]
ziggie has quit [Quit: Connection closed for inactivity]
jonatack1 has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 260 seconds]
<PaperSword> When using ParseUInt64 does the function just return false when the input string value overflows?
jonatack1 has quit [Ping timeout: 260 seconds]
Guest44 has joined #bitcoin-core-dev
Guest44 has quit [Client Quit]
jonatack1 has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
<PaperSword> Does the vertical separator man that parameter can be called be either name? /src/rpc/blockchain.cpp {"verbosity|verbose", RPCArg::Type::NUM, RPCArg::Default
<PaperSword> mean*
jonatack1 has quit [Ping timeout: 252 seconds]
kexkey has quit [Ping timeout: 248 seconds]
kexkey has joined #bitcoin-core-dev
shiza has quit [Ping timeout: 248 seconds]
shiza has joined #bitcoin-core-dev
jonatack1 has joined #bitcoin-core-dev
route-bee has quit [Remote host closed the connection]
Aaronvan_ has quit [Quit: Leaving...]
salvatoshi has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
ziggie has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark opened pull request #26468: scripted diff: fix E275 lint (master...fix_E275_lint) https://github.com/bitcoin/bitcoin/pull/26468
NorrinRadd has quit [Ping timeout: 252 seconds]
mikehu44 has joined #bitcoin-core-dev
<vasild> PaperSword: you probably already figured it out, but: yes, yes. See ToIntegral() and RPCArg::m_names, or try bitcoin-cli -named getblock blockhash=00000000000000000b46c6a2bd4725568f62b7a859a53bf63de962099a5c3753 verbose=0
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
<bitcoin-git> [bitcoin] russeree opened pull request #26469: rpc: getblock: implement with block height as input parameter. (master...merge_getblock_getblock_hash) https://github.com/bitcoin/bitcoin/pull/26469
kexkey has quit [Ping timeout: 260 seconds]
kexkey has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark closed pull request #26468: scripted diff: fix E275 lint (master...fix_E275_lint) https://github.com/bitcoin/bitcoin/pull/26468
<PaperSword> Thanks so much @vasild
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] michaelfolkson closed pull request #25553: test: Rename inner key to internal key (master...2022-07-test-internal-key) https://github.com/bitcoin/bitcoin/pull/25553
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
yanmaani3 has joined #bitcoin-core-dev
yanmaani2 has quit [Ping timeout: 255 seconds]
cold has quit [Ping timeout: 268 seconds]
midnight has quit [Ping timeout: 272 seconds]
cold has joined #bitcoin-core-dev
midnight has joined #bitcoin-core-dev
gleb071225 has quit [Ping timeout: 248 seconds]
noxim has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] russeree closed pull request #26469: rpc: getblock: implement with block height as input parameter. (master...merge_getblock_getblock_hash) https://github.com/bitcoin/bitcoin/pull/26469
noxim has joined #bitcoin-core-dev
noxim has quit [Changing host]
noxim has joined #bitcoin-core-dev
johnzweng has quit [Quit: Leaving...]
noxim has quit [Ping timeout: 246 seconds]
noxim has joined #bitcoin-core-dev
noxim has quit [Changing host]
noxim has joined #bitcoin-core-dev
<PaperSword> While squashing commits I messed up the rebase on my PR and it auto closed. Is there a way to reopen?
<PaperSword> https://github.com/bitcoin/bitcoin/pull/26469 rebased to the head and pushed. My downstream branch is fixed me.
johnzweng has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sipa reopened pull request #26469: rpc: getblock: implement with block height as input parameter. (master...merge_getblock_getblock_hash) https://github.com/bitcoin/bitcoin/pull/26469
<PaperSword> Thank you.
<sipa> You may need to re-push again, check if the PR matches your code.
<PaperSword> It does.
<_aj_> did it close because you deleted the branch, or some other reason?
<PaperSword> git fetch origin
<PaperSword> git reset --hard origin/master
<PaperSword> git push --force
<_aj_> oh, deleting all the commits in the PR, i guess that makes sense
<PaperSword> I realize that I needed to recommit my changes before pushing.
<PaperSword> Yeah it instantly closes.
<sipa> Ok that would cause your branch to be equal to master, which github detects as "it has been merged".
<PaperSword> That's good to know.
<PaperSword> I also have a mempool pr same thing happened to it quite some time ago.
<PaperSword> I will leave it closed and work on it some more, request to open later.
<PaperSword> Just for ref.
<_aj_> PaperSword: "git rebase -i origin/master" is what i use; or i have a little git-rebase-common script that does "git rebase -i $(git merge-base origin/master HEAD)" if i want to reorder commits without changing the branch point
<PaperSword> Thanks, I will work more with the interactive rebasing process.
<_aj_> (do what works best for you; that's just what i find works well for me)
<PaperSword> Of course! I still have so much to learn with git.
<_aj_> PaperSword: just open a new PR for 24935? i don't think you can rename the branch a PR points at
<PaperSword> I will after building the testing requirements for b10c and adding mempool telemetry metrics.
<PaperSword> Right now it's pretty simple and only logs eviction and addition events in a tsv format
AaronvanW has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 260 seconds]
kexkey has joined #bitcoin-core-dev
Guyver2_ has quit [Quit: Going offline, see ya! (www.adiirc.com)]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 246 seconds]
noxim has quit [Ping timeout: 260 seconds]
noxim has joined #bitcoin-core-dev
noxim has quit [Changing host]
noxim has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #26470: guix: Clean up `libexec/build.sh` (master...221108-guix) https://github.com/bitcoin/bitcoin/pull/26470
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
sudoforge has quit [Quit: 404]
bitdex has quit [Quit: = ""]
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
ziggie has quit [Quit: Connection closed for inactivity]
johnzweng has quit [Ping timeout: 260 seconds]
johnzweng has joined #bitcoin-core-dev
noxim has quit [Ping timeout: 260 seconds]
cold has quit [Ping timeout: 260 seconds]
noxim has joined #bitcoin-core-dev
noxim has quit [Changing host]
noxim has joined #bitcoin-core-dev
cold has joined #bitcoin-core-dev
gleb071225 has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark reopened pull request #26468: scripted diff: fix E275 lint (master...fix_E275_lint) https://github.com/bitcoin/bitcoin/pull/26468
pablomartin has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark opened pull request #26471: Don't share mempool with dbcache in -blocksonly mode (master...blocksonly_mempool_cache) https://github.com/bitcoin/bitcoin/pull/26471
<bitcoin-git> [bitcoin] willcl-ark closed pull request #26468: scripted diff: fix E275 lint (master...fix_E275_lint) https://github.com/bitcoin/bitcoin/pull/26468
amovfx has quit [Ping timeout: 248 seconds]
jonatack1 has quit [Quit: WeeChat 3.7.1]
hg has joined #bitcoin-core-dev
NorrinRadd has joined #bitcoin-core-dev
hg has quit [Ping timeout: 248 seconds]
hg has joined #bitcoin-core-dev
Guest7 has quit [Quit: Client closed]
Guest7 has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
Guest7 has quit [Quit: Client closed]
sudoforge has joined #bitcoin-core-dev
Guest7 has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 252 seconds]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 246 seconds]
pablomartin_ has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
noxim has quit [Ping timeout: 248 seconds]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Ping timeout: 255 seconds]
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
hg has quit [Ping timeout: 260 seconds]
hg has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 248 seconds]
___nick___ has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
bytes1440000 has joined #bitcoin-core-dev
<bytes1440000> Only questions
<bytes1440000> Will this PR be closed and we get v24.0?
<bytes1440000> Will vasild get appointed as maintainer?
<bytes1440000> Will "bitcoin core devs" ever consider importance of knots maintained by luke dashjr?
<bytes1440000> will we ever get users, devs etc. who support and undertand covenants?
<bytes1440000> will we ever get CTV?
<bytes1440000> No answers, no shitposting, quit.
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
amovfx has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] hebasto opened pull request #26473: test: Randomize data in `getarg_tests/logargs` test (master...221108-logargs) https://github.com/bitcoin/bitcoin/pull/26473
<bitcoin-git> [bitcoin] sdaftuar closed pull request #26438: Remove mempoolfullrbf option (master...2022-10-remove-mempoolfullrbf) https://github.com/bitcoin/bitcoin/pull/26438
hg has quit [Ping timeout: 260 seconds]
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 closed pull request #26456: [24.x] Remove mempoolfullrbf option (24.x...24.x-revert-mempoolfullrbf) https://github.com/bitcoin/bitcoin/pull/26456
___nick___ has quit [Client Quit]
<bitcoin-git> [bitcoin] fanquake opened pull request #26474: [23.x] guix: use `--build={arch}-guix-linux-gnu` in cross toolchain (23.x...23_x_aarch64_on_aarch64) https://github.com/bitcoin/bitcoin/pull/26474
___nick___ has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
champo has joined #bitcoin-core-dev
Guest7 has quit [Quit: Client closed]
champo has quit [Quit: Client closed]
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ariard closed pull request #25600: p2p: Advertise `NODE_FULL_RBF` and connect to 4 outbound full-rbf peers if `-mempoolfullrbf` is set (master...2022-07-fullrbf-p2p) https://github.com/bitcoin/bitcoin/pull/25600
champo has joined #bitcoin-core-dev
champo has quit [Quit: Client closed]
Talkless has quit [Quit: Konversation terminated!]
___nick___ has quit [Ping timeout: 260 seconds]
___nick___ has joined #bitcoin-core-dev
noxim has joined #bitcoin-core-dev
noxim has quit [Changing host]
noxim has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
noxim has quit [Ping timeout: 260 seconds]
_Sam-- has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 248 seconds]
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
PaperSwordAlt has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 246 seconds]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 248 seconds]
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
amovfx has joined #bitcoin-core-dev
<achow101> FYI later this week I'm going to be closing the PRs that I left a "are you still working on this" comment last month if there has been no response. So if you did get such a comment, and are indeed still working on it, then please say so.
amovfx has quit [Ping timeout: 248 seconds]
luke-jr has quit [Ping timeout: 272 seconds]
amovfx has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
TheRec has quit [Read error: Connection reset by peer]
amovfx has quit [Ping timeout: 252 seconds]
_andrewtoth_ has joined #bitcoin-core-dev
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 248 seconds]
amovfx has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
noxim has joined #bitcoin-core-dev
noxim has quit [Changing host]
noxim has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
noxim has quit [Ping timeout: 248 seconds]
amovfx has joined #bitcoin-core-dev
Guest9119 has joined #bitcoin-core-dev
Guest9119 has quit [Client Quit]
sudoforge has quit [Quit: 404]
sudoforge has joined #bitcoin-core-dev