<harding>
I'm happy to help make edits based on constructive feedback but I don't plan to participate in any arguments or edit warring about it, and it's obviously ok if y'all decide to just remove the whole thing.
yashraj has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
yashraj has quit [Ping timeout: 252 seconds]
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 255 seconds]
amovfx has quit [Ping timeout: 252 seconds]
PaperSword has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
yashraj has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
yashraj has quit [Ping timeout: 260 seconds]
yashraj has joined #bitcoin-core-dev
yashraj has quit [Remote host closed the connection]
yashraj has joined #bitcoin-core-dev
yashraj has quit [Remote host closed the connection]
ziggie has quit [Quit: Connection closed for inactivity]
amovfx has quit [Ping timeout: 248 seconds]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 246 seconds]
CongLe has joined #bitcoin-core-dev
CongLe has quit [Client Quit]
mikehu44 has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
amovfx has joined #bitcoin-core-dev
raj has quit [Killed (NickServ (GHOST command used by raj_!uid72176@id-72176.lymington.irccloud.com))]
raj has joined #bitcoin-core-dev
raj has quit [Killed (NickServ (GHOST command used by raj_!uid72176@id-72176.lymington.irccloud.com))]
raj_ has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 248 seconds]
pablomartin_ has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
pablomartin_ has quit [Ping timeout: 252 seconds]
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 248 seconds]
noxim has quit [Ping timeout: 252 seconds]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 246 seconds]
noxim has joined #bitcoin-core-dev
noxim has quit [Changing host]
noxim has joined #bitcoin-core-dev
noxim has quit [Ping timeout: 246 seconds]
landabaso has joined #bitcoin-core-dev
noxim has joined #bitcoin-core-dev
noxim has quit [Changing host]
noxim has joined #bitcoin-core-dev
landabaso has quit [Quit: Client closed]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 248 seconds]
sudoforge has quit [Quit: 404]
luke-jr has quit [Ping timeout: 260 seconds]
luke-jr has joined #bitcoin-core-dev
stevenroose has quit [Ping timeout: 246 seconds]
stevenroose has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
Guest25 has joined #bitcoin-core-dev
Guest2555 has joined #bitcoin-core-dev
achow101 has quit [*.net *.split]
reardencode has quit [*.net *.split]
da2ce7 has quit [*.net *.split]
koolazer has quit [*.net *.split]
kcalvinalvin has quit [*.net *.split]
sanket1729 has quit [*.net *.split]
jeremyrubin has quit [*.net *.split]
dongcarl has quit [*.net *.split]
gnusha has quit [*.net *.split]
jrayhawk has quit [*.net *.split]
andytoshi has quit [*.net *.split]
michaelfolkson has quit [*.net *.split]
kanzure has quit [*.net *.split]
kanzure has joined #bitcoin-core-dev
landabaso has joined #bitcoin-core-dev
reardencode has joined #bitcoin-core-dev
da2ce7 has joined #bitcoin-core-dev
michaelfolkson has joined #bitcoin-core-dev
Guest2555 has quit [Client Quit]
Guest25 has quit [Client Quit]
achow101 has joined #bitcoin-core-dev
sanket1729 has joined #bitcoin-core-dev
kcalvinalvin has joined #bitcoin-core-dev
dongcarl has joined #bitcoin-core-dev
andytoshi has joined #bitcoin-core-dev
gnusha has joined #bitcoin-core-dev
koolazer has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 248 seconds]
salvatoshi has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
Guyver2 has joined #bitcoin-core-dev
noxim has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
Guyver2 has left #bitcoin-core-dev [Closing Window]
amovfx has quit [Ping timeout: 252 seconds]
arturomf94[m] has quit [Quit: You have been kicked for being idle]
amovfx has joined #bitcoin-core-dev
<fanquake>
To github.com:bitcoin-core/bitcoin-detached-sigs.git
<fanquake>
* [new tag] v24.0rc4 -> v24.0rc4
amovfx has quit [Ping timeout: 252 seconds]
Flow has quit [Ping timeout: 252 seconds]
<fanquake>
* [new tag] v23.1rc1 -> v23.1rc1
Flow has joined #bitcoin-core-dev
landabaso has quit [Quit: Client closed]
amovfx has joined #bitcoin-core-dev
kexkey has quit [Ping timeout: 260 seconds]
kexkey has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
amovfx has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 246 seconds]
<hebasto>
UPD. CMake-based build system integrated with 6 of 16 CI task for now -- https://cirrus-ci.com/build/5620151671324672. It's nice to see how CMake provides compile database building out-of-the box :)
SpellChecker_ has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 252 seconds]
szkl has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
jrayhawk has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
AaronvanW has quit [Remote host closed the connection]
jrayhawk has quit [Ping timeout: 260 seconds]
bitdex has quit [Quit: = ""]
jrayhawk has joined #bitcoin-core-dev
<sipa>
@hebasto Nice!
<hebasto>
sipa: ty
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 255 seconds]
AaronvanW has joined #bitcoin-core-dev
_Sam-- has quit [Ping timeout: 252 seconds]
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 268 seconds]
amovfx has quit [Ping timeout: 252 seconds]
AaronvanW has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
<sipa>
@harding Nice writeup.
sudoforge has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
<harding>
sipa: thanks!
<instagibbs>
harding, I'd try and not bury the lede that default is status quo
<instagibbs>
text looks good otherwise
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 268 seconds]
_Sam-- has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 252 seconds]
Guest89 has joined #bitcoin-core-dev
Guest89 has quit [Client Quit]
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26480: test: Remove wallet option from non-wallet tests (master...2211-test-wallet-options-💣) https://github.com/bitcoin/bitcoin/pull/26480
<darosior>
Text looks good to me too
<stevenroose>
Does anyone maintain a guix channel with packages for all different versions of bitcoind? Or even just the latest which tagged commits to place make inferiors for specific versions?
jon_atack has quit [Ping timeout: 252 seconds]
Guest89 has joined #bitcoin-core-dev
Guest89 has quit [Client Quit]
<lightlike>
harding: Agree with the text, I find the wording "Notice of policy change" too strong - I would have expected a change in the default policy just from reading the heading, not an option that is off per default.
<harding>
instagibbs, lightlike: good feedback, thanks, working on an edit.
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
halosghost has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 255 seconds]
vasild has quit [Ping timeout: 255 seconds]
vasild_ has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #26481: bench: Suppress output when running with `-sanity-check` option (master...221110-bench) https://github.com/bitcoin/bitcoin/pull/26481
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
jon_atack has quit [Quit: WeeChat 3.7.1]
<fanquake>
although the CI lint job is somewhat the exception, and doesn't have a direct ci/test/setup_env script
<halosghost>
I guess I'm misunderstanding what the headache is then ☺
<halosghost>
ahh
<halosghost>
gotcha
jonatack has joined #bitcoin-core-dev
<fanquake>
having a dedicated image like this, that can be trivially spun up / down, with less overhead than the regular ci scripts is also likely useful
salvatoshi has quit [Ping timeout: 252 seconds]
<instagibbs>
subtle version differences mean locally reproducing what CI will complain about is harder
<instagibbs>
can mean*
<fanquake>
Yea, and having an env that mimics the CI, means we can avoid changes that basically just refactor for the sake of squelling warnings coming from some updated dep that arbitrarily changed something
<halosghost>
that's what I use act for ☺
<fanquake>
we don't use github actions
<halosghost>
then it's kind of an immaterial suggestion with no value
<halosghost>
nevermind ☺
AaronvanW has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] achow101 closed pull request #19078: test: Add salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078
<bitcoin-git>
[bitcoin] achow101 closed pull request #19420: http: Track active requests and wait for last to finish (master...2020-06-track-requests) https://github.com/bitcoin/bitcoin/pull/19420
amovfx has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] achow101 closed pull request #24150: refactor: move index class members from protected to private (master...move-index-class-members-from-protected-to-private) https://github.com/bitcoin/bitcoin/pull/24150
amovfx has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 closed pull request #24199: Add cs_main annotation to WriteBatchSync(), drop lock in CDiskBlockIndex (master...remove-cs_main-lock-in-CDiskBlockIndex) https://github.com/bitcoin/bitcoin/pull/24199
<bitcoin-git>
[bitcoin] achow101 closed pull request #25097: test: Unit tests for taproot/tapscript coverage in `interpreter.cpp` (master...23279-taproot-unit-tests) https://github.com/bitcoin/bitcoin/pull/25097
<bitcoin-git>
[bitcoin] achow101 reopened pull request #24150: refactor: move index class members from protected to private (master...move-index-class-members-from-protected-to-private) https://github.com/bitcoin/bitcoin/pull/24150
<bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #24199: Add cs_main annotation to WriteBatchSync(), drop lock in CDiskBlockIndex (master...remove-cs_main-lock-in-CDiskBlockIndex) https://github.com/bitcoin/bitcoin/pull/24199
salvatoshi has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
AaronvanW has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
amovfx has joined #bitcoin-core-dev
<instagibbs>
harding, LGTM
<lightlike>
same, thanks!
Evel-Knievel has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
salvatoshi has quit [Quit: Leaving]
vasild has quit [Ping timeout: 255 seconds]
AaronvanW has quit [Ping timeout: 260 seconds]
bomb-on has quit [Quit: aллилѹіа!]
vasild has joined #bitcoin-core-dev
<glozow>
harding: thank you for the writeup, lgtm
AaronvanW has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
Aaronvan_ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 260 seconds]
amovfx has quit [Ping timeout: 252 seconds]
amovfx has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
<luke-jr>
"zero conf" is a dishonest propaganda term. NACK using it.
PaperSword has quit [Read error: Connection reset by peer]
<laanwj>
luke-jr: likely!
<achow101>
luke-jr: looks like you are in bitcoin but not in bitcoin-core. I'm suruprised it took us this long to notice
PaperSword has joined #bitcoin-core-dev
<achow101>
someone with owner permissions will need to add you
<laanwj>
anything to add / remove from the list?
<lightlike>
#25600 was closed and can be removed from "chasing concept ack"
<gribble>
https://github.com/bitcoin/bitcoin/issues/25600 | p2p: Advertise `NODE_FULL_RBF` and connect to 4 outbound full-rbf peers if `-mempoolfullrbf` is set by ariard · Pull Request #25600 · bitcoin/bitcoin · GitHub
<luke-jr>
laanwj: I just rebased/addressed #22693 which seems like there's interest in sooner rather than later
_Sam-- has quit [Remote host closed the connection]
amovfx has quit [Ping timeout: 252 seconds]
champo has joined #bitcoin-core-dev
jonatack has quit [Quit: WeeChat 3.7.1]
champo has quit [Client Quit]
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
Aaronvan_ is now known as AaronvanW
vasild has quit [Ping timeout: 255 seconds]
vasild has joined #bitcoin-core-dev
yanmaani3 has quit [Read error: Connection reset by peer]
SpellChecker has quit [Read error: Connection reset by peer]
_andrewtoth_ has quit [Read error: Connection reset by peer]
_andrewtoth_ has joined #bitcoin-core-dev
yanmaani3 has joined #bitcoin-core-dev
<luke-jr>
made various corrections ot the RBF release notes, including removing the "zero conf" propaganda term
amovfx has joined #bitcoin-core-dev
<luke-jr>
noteworthy the recommendation at the end is also changed such that it first suggests simply not accepting unconfirmed transactions at all
SpellChecker has joined #bitcoin-core-dev
<luke-jr>
though on further thought, that may be too absolute and need some language changes, since merchants typically do accept unconfirmed (eg) credit card transactions and such
<sipa>
I don't understand what the issue is with zeroconf, and I don't think first-seen is the same thing (I'd associate zeroconf with the business practice of considering a transaction accepted at zero confirmations, while I'd associate first-seen with the node relay policy of not replacing anything)
<instagibbs>
if you don't like the term, the polite thing to do is add "so-called" so readers who use the term understand what you're talking about
amovfx has quit [Ping timeout: 246 seconds]
<NorrinRadd>
yeah i don't think there's anything "propaganda" about it
<sipa>
Right, to me it has a pretty negative connotation even
<sipa>
Calling it "instant payments" or so would be propaganda.
<luke-jr>
it's not confirmed, "zero conf" implies it is
<sipa>
I don't understand.
<sipa>
zero confirmation literally means no confirmations.
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
<luke-jr>
no, it means confirmation with zero blocks
<sipa>
Huh, I'd never even consider interpreting it that way.
<sipa>
Nor have I ever seen anyone doing so.
<luke-jr>
just like "1 conf" is confirmation with 1 block
<NorrinRadd>
agree with sipa. the apple dns protocol, zero conf, equally means zero configuration. because it'd work with no dns server & not require manually setting IP settings; names could resolve also
<sipa>
I don't mind saying "so-called zeroconf" or so, but I think your changes to the writeup made it substantially less clear.
<brunoerg>
seems weird for me luke's interpretation, never heard about it before
<luke-jr>
also, discussing merchants' bad practices really doesn't belong in this doc at all IMO
<luke-jr>
they're bad and unsafe regardless of full RBF
_andrewtoth_ has quit [Remote host closed the connection]
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
<bitcoin-git>
[bitcoin] sdulfari opened pull request #26487: log: improve some validation log messages to include hashPrevBlock (master...hash-prev-blk-error-msg) https://github.com/bitcoin/bitcoin/pull/26487
<harding>
luke-jr: I have no clue what you're talking about.
vasild has quit [Remote host closed the connection]
<luke-jr>
harding: that's what you seem to imply by going back to a version before corrections were made
andrewtoth_ has quit [Remote host closed the connection]
berndj has quit [Read error: Software caused connection abort]
andrewtoth_ has joined #bitcoin-core-dev
berndj has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
<harding>
luke-jr: I didn't see a correction, just an opinionated edit. I have an opinion too, and it favored the previous text. However, since your only specific complaint here was about "zero conf" being a propaganda term, I implemented the suggestion from two other people here to precede it by "so-called". If you have other constructive feedback, I'd be happy to try to address it on my gist.
amovfx has quit [Ping timeout: 252 seconds]
<luke-jr>
if my edit involved opinion, it was the removal of it
<luke-jr>
release notes aren't a place to push your (incorrect) "opinions" about the effects of policies
vasild has joined #bitcoin-core-dev
<harding>
luke-jr: I didn't say that my draft contained my opinions about the effects of policies. I said that, in my opinion, I favored the previous text.
<luke-jr>
the previous text contained factual errors which I corrected
sipsorcery has quit [Ping timeout: 252 seconds]
<luke-jr>
the way wikis typically work is that if you think it can be further improved, you edit it further. not fork an older version with errors
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
Ara has quit [Read error: Software caused connection abort]
Ara has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
AaronvanW has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
<sipa>
@[luke-jr] I find your version worse than @harding's, for two reasons (1) avoiding the term zeroconf - imo the accepted term for a certain practice - in favor of a term whose understood meaning is very different, and (2) calling a certain subset of users incompetent.
<harding>
luke-jr: again, I don't see any errors in the older version nor any corrections in your version. One of the other typical ways wikis work is that, when two editors cannot agree on a way to intergate their differing edits, they allow other editors to take over and help resolve the disagreement. That's what I've attempted to do by externally providing my alternative version. If other members of this project decide to use it or to find a
<harding>
compromise, great! If not, at least I know I tried my best to notify users about the potential consequences of the current change and potential future changes in this direction.
<sipa>
In addition, I don't understand what specifically you object to, apart from finding the term zeroconf misleading (that's fine, we can address that by calling it so-called zeroconf).
<sipa>
It would be more constructive to discuss alternatives than to flat-out say that someone else's version is wrong.
_andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
<PaperSword>
Is the max value the RPC can accept for a block height a int32_t? as per 928 src/rest.cpp?
<PaperSword>
Sorry if that was a double, got an error from irssi