amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 246 seconds]
halosghost has quit [Quit: WeeChat 3.7.1]
amovfx has quit [Ping timeout: 252 seconds]
_andrewtoth_ has quit [Remote host closed the connection]
pablomartin has quit [Ping timeout: 268 seconds]
andrewtoth has joined #bitcoin-core-dev
BUSY has quit [Ping timeout: 255 seconds]
AaronvanW has quit [Ping timeout: 260 seconds]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
AaronvanW has joined #bitcoin-core-dev
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 260 seconds]
amovfx has quit [Ping timeout: 255 seconds]
<luke-jr>
sipa: if they were competent, they would be successful double spending …
<luke-jr>
but again, if you have a better way to say it, feel free
<luke-jr>
and no, "zeroconf" is a term used mainly for propaganda, not an accepted term
<luke-jr>
PaperSword: the software cannot handle a height outside of int32 range right now at all IIRC
<luke-jr>
PaperSword: which is fine, it won't matter until like AD 40800 or so
amovfx has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
jrawsthorne has quit [Read error: Software caused connection abort]
jrawsthorne has joined #bitcoin-core-dev
<PaperSword>
Thanks @luke-jr, Yeah that's just fine as it could be updated as a softfork pretty sure! Just wanted to double check on that my getblock(height) implementation fully utilized the max range of possible inputs.
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
<luke-jr>
PaperSword: it can't be
<sipa>
luke-jr: I'm not disagreeing about the incompetent part; I just don't think it's the kind of language we ought to use in release notes
<sipa>
re timestamp range; it's in theory fixable with a softfork a la forward blocks - but that brings huge downsides too
sandipndev has quit [Read error: Software caused connection abort]
sandipndev has joined #bitcoin-core-dev
<ariard>
ack harding's release notes about the possible effects of the `mempoolfullrbf`; left few improvement comment on the gist
<ariard>
luke-jr: it's one thing to question users level of knowledge -- another to warn about the potential harmful effects of their application practices in light of transaction-relay changes
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
<luke-jr>
ariard: there are no potential harmful effects though
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
livestradamus has quit [Remote host closed the connection]
livestradamus has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #19078: test: Extend salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078
brunoerg has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
AaronvanW has quit [Remote host closed the connection]
test__ has joined #bitcoin-core-dev
flooded has quit [Read error: Connection reset by peer]
_andrewtoth_ has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 252 seconds]
bitdex has quit [Quit: = ""]
AaronvanW has joined #bitcoin-core-dev
kexkey has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Ping timeout: 246 seconds]
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #19078: test: Extend salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078
sudoforge has joined #bitcoin-core-dev
amovfx has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
<stickies-v>
ack harding's release notes (with some minor comments left), I think keeping the release notes simple and actionable is key, and zero-conf is a well-known term among users and merchants. Calling it something else would unnecessarily confuse the people we're trying to reach, in my view
<brunoerg>
stickies-v: I agree
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
<fanquake>
I also agree. Language like "and those attempting it usually incompetent." is obviously not something we are going to put into release notes.
vasild has quit [Ping timeout: 255 seconds]
yanmaani3 has quit [Remote host closed the connection]
yanmaani3 has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
mikehu44_ has quit [Ping timeout: 260 seconds]
Guest27 has joined #bitcoin-core-dev
Guest27 has quit [Client Quit]
ghost43 has quit [Remote host closed the connection]
SpellChecker has quit [Remote host closed the connection]
Talkless has joined #bitcoin-core-dev
Talkless has quit [Client Quit]
ghost43 has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<lightlike>
I agree too. Left a question about other implementations at the gist.
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
gossie has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
bytes1440000 has joined #bitcoin-core-dev
<bytes1440000>
I had no incentives and have incentives but luke-jr deserved more for reviews
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
bytes1440000 has joined #bitcoin-core-dev
<bytes1440000>
I am already shadow banned on github because notifications not expected, and some issues here. Maybe I need a new account because bitcoin core is not just some devs, there are some people who cannot read things they dont like.
<bytes1440000>
TOS doesnt matter FYI
brunoerg has quit []
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 260 seconds]
sipsorcery has joined #bitcoin-core-dev
<PaperSword>
Is there a simple way to run the CI tests? I am currently running ./ci/test_run_all.sh and it just exists with 'configure exit 1'
<brunoerg>
you can set up the CI on your personal repo
<PaperSword>
a fork of core being my repo right? Do I need to setup a configuration file to get the ci test to run?
luke-jr has quit [Ping timeout: 246 seconds]
luke-jr has joined #bitcoin-core-dev
<sipa>
if you cloned the bitcoin core repo, you already have that config file, because it is part of the repo
brunoerg has quit []
_andrewtoth_ has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
amovfx has quit [Remote host closed the connection]
amovfx has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]