SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
jonatack has quit [Quit: WeeChat 3.7.1]
jonatack has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 240 seconds]
jonatack1 has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 256 seconds]
jonatack2 has joined #bitcoin-core-dev
jonatack2 has quit [Client Quit]
jonatack1 has quit [Ping timeout: 268 seconds]
jonatack has joined #bitcoin-core-dev
<lightlike>
Maybe it's in fact only happening in case of a disconnect race, but if you allow incoming peers and there are constantly spy nodes connecting/disconnecting you as seems to be the case on mainnet recently ( https://b10c.me/observations/05-inbound-connection-flooder-down/) these races are more common than one would think.
<bitcoin-git>
[bitcoin] jonatack opened pull request #26516: Always return getpeerinfo "relaytxes" field (master...2022-11-getpeerinfo-relayxes) https://github.com/bitcoin/bitcoin/pull/26516
<lightlike>
For example, my node has received ~3 new incoming connections per second recently on average - summing up to over 7 Million connections over a month. So if you poll getpeerinfo once per second in this situation, the chance of a race with a disconnect is probably significant.
<jonatack>
lightlike: how many peers do you have?
<jonatack>
I think you may be right about the disconnection only.
* jonatack
sleep
<lightlike>
didn't change the default, so ~125. The growth in NodeId can be inferred from the debug log, where new outbound connections are logged with the respective Node Id.
<bitcoin-git>
[gui] jonatack opened pull request #681: Fix Transaction Relay tooltip text in Peers details window (master...relaytxes-tooltip-fix) https://github.com/bitcoin-core/gui/pull/681
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
<jonatack>
lightlike: oh, i don't doubt you, i have also seen high peer id numbers at times relative to node uptime
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 240 seconds]
jon_atack has quit [Client Quit]
vasild has quit [Ping timeout: 255 seconds]
jonatack has joined #bitcoin-core-dev
generatecoll has joined #bitcoin-core-dev
generatecoll has quit [Quit: Client closed]
<bitcoin-git>
[bitcoin] Randy808 opened pull request #26517: test: Changed small_txpuzzle_randfee to return the virtual size instead of the transaction hex for feerate calculation. (master...use-vsize-for-fee-tests) https://github.com/bitcoin/bitcoin/pull/26517
vasild has joined #bitcoin-core-dev
jamesob3 has joined #bitcoin-core-dev
instagibbs_ has joined #bitcoin-core-dev
instagibbs has quit [Ping timeout: 248 seconds]
jamesob has quit [Ping timeout: 252 seconds]
jamesob3 is now known as jamesob
roasbeef has quit [Ping timeout: 260 seconds]
roasbeef has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 255 seconds]
bitdex has quit [Ping timeout: 255 seconds]
vasild has joined #bitcoin-core-dev
gossie has quit [Quit: = "bye bye"]
bitdex has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
NorrinRadd has quit [Ping timeout: 256 seconds]
_andrewtoth_ has quit [Remote host closed the connection]
<b10c>
lightlike: that sounds similar to what I've observed, but more extreme. I've seen 1 inbound per sec vs your 3 inbound per sec
<bitcoin-git>
bitcoin/master 7a53033 Jon Atack: Fix Transaction Relay tooltip text in Peers details window
<bitcoin-git>
bitcoin/master 82fe672 MacroFake: Merge bitcoin-core/gui#681: Fix Transaction Relay tooltip text in Peers de...
Zenton has joined #bitcoin-core-dev
laanwj has quit [Ping timeout: 255 seconds]
Guest53 has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 256 seconds]
Zenton has quit [Remote host closed the connection]
Zenton has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26519: test: Add getpeerinfo test for missing version message (master...2211-test-rpc-no-ver-📂) https://github.com/bitcoin/bitcoin/pull/26519
Guest53 has quit [Quit: Client closed]
Guest53 has joined #bitcoin-core-dev
Guest53 has quit [Client Quit]
<bitcoin-git>
[bitcoin] theStack opened pull request #26520: doc: test: update/fix TestShell example instructions (master...202211-test-doc-update_test_shell_instrs) https://github.com/bitcoin/bitcoin/pull/26520
gwillen has quit [Ping timeout: 260 seconds]
john-moffett has quit [Quit: Client closed]
gwillen has joined #bitcoin-core-dev
szkl has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
AaronvanW has quit [Remote host closed the connection]
john-moffett has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<earnestly>
Is there a known problem with building: config.status: error: Something went wrong bootstrapping makefile fragments for automatic dependency tracking.
<fanquake>
are you using make instead of gmake?
<fanquake>
you may see that error on *BSD if that is the make
<fanquake>
*the case
<earnestly>
fanquake: Interesting, it is GNU make but since you prompted me to get the version, it's getting linking errors. Hopefully it's just a borked build on my end
<earnestly>
This old machine has a long forgotten mix of random git builds (make was one of them, libguile updated just recently but that make wasn't rebuilt against it). Seems fine now
<earnestly>
Thanks for the prompt
<bitcoin-git>
[gui] hebasto merged pull request #680: Fixes MacOS 13 segfault by preventing certain notifications after main window is destroyed (master...202211MacSegfaultOnQuit) https://github.com/bitcoin-core/gui/pull/680
<glozow>
achow101: afaik no, they should just be dropped
<achow101>
that's what I thought. but sometimes in this test an unconfirmed descendant of a reorged coinbase is appearing back in the mempool when that coinbase is re-reorged back in
<glozow>
fascinating... is it possible the descendant was in the reorg chain?
<achow101>
no, it's definitely unconfirmed
<achow101>
I'm wondering if it's maybe queued for relay when the first reorg happens?
<glozow>
that may be true, like it's in `mapRelay` or something and the tx gets relayed back again?
<glozow>
yeah maybe nodes[1] gets it, then sends it back to nodes[0]?
<achow101>
node1 is the originator though
<achow101>
I think it might be that node0 just never received it until after the second reorg, and it might just need a self.sync_mempool() before invalidateblock
zeropoint has joined #bitcoin-core-dev
<glozow>
sounds plausible
<achow101>
ok, that seems to have fixed the problem
vasild has quit [Remote host closed the connection]
<luke-jr>
achow101: btw, just saying it as someone who objected to that other PR recently being locked: I don't mind if this new repeat is locked.
<achow101>
I'm considering just closing it
webchat123 has joined #bitcoin-core-dev
<luke-jr>
or that
webchat123 has quit [Client Quit]
Guest53 has quit [Quit: Client closed]
TommyC_ has joined #bitcoin-core-dev
TommyC_ has quit [Ping timeout: 260 seconds]
Talkless has quit [Quit: Konversation terminated!]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
_andrewtoth_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Guest33 has joined #bitcoin-core-dev
Guest33 has quit [Client Quit]
<jonatack>
luke-jr: achow101: as an alternate pov, perhaps consider letting the discussion run if it doesn't cost anything. like with taproot activation, people like to feel they were able to express their concerns and feedback and be heard. the original pr was only open for a month before merge, and suhas closing the revert didn't necessarily mean the discussion was over.
<jonatack>
achow101: though i agree with your feedback on the pull
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
<luke-jr>
jonatack: I'm simply saying I don't object
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 256 seconds]
<ariard>
If #26525 got unlocked, I would like to comment at least ; Not changing my position from #26438 and ~0 on current #26525, however for sure we should think more how we design and release policy changes in the future