<vasild>
lightlike: I stared at that code and didn't see any bug because I thought that the intention of that function was to delete the first element only. I would even consider that it is not a bug unless it is explicitly documented somewhere that CoinsResult::Erase() deletes all matches.
<vasild>
the comment says that Erase() (and other methods) are to mimic vector, and std::vector::erase() deletes just a single element.
<bitcoin-git>
bitcoin/master 1984db1 Hennadii Stepanov: refactor: Rename local variable to distinguish it from type alias
<bitcoin-git>
bitcoin/master 8b79686 glozow: Merge bitcoin/bitcoin#26624: refactor: Rename local variable to distinguis...
<bitcoin-git>
[bitcoin] glozow merged pull request #26624: refactor: Rename local variable to distinguish it from type alias (master...221202-name) https://github.com/bitcoin/bitcoin/pull/26624
<bitcoin-git>
[bitcoin] fanquake closed pull request #26393: build: make configure --enable-debug override CXXFLAGS from depends (master...build_depends_debug_flags) https://github.com/bitcoin/bitcoin/pull/26393
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26640: test: Run mempool_compatibility.py with MiniWallet (master...2212-test-mini-wallet-mempool-🚌) https://github.com/bitcoin/bitcoin/pull/26640
<bitcoin-git>
bitcoin/master 71abee8 fanquake: Merge bitcoin/bitcoin#25993: doc: Add I2P guidance related to bandwidth an...
<bitcoin-git>
[bitcoin] fanquake merged pull request #25993: doc: Add I2P guidance related to bandwidth and i2pd software version (master...i2pd_bandwidth) https://github.com/bitcoin/bitcoin/pull/25993
<bitcoin-git>
[bitcoin] fanquake closed pull request #25893: doc: Clarify multiple wallets for same signer (final) (master...external_signer) https://github.com/bitcoin/bitcoin/pull/25893
<bitcoin-git>
bitcoin/master f39d926 Sjors Provoost: rpc: warn that nodes ignore requests for old stale blocks
<bitcoin-git>
bitcoin/master 5b3f05b MarcoFalke: Merge bitcoin/bitcoin#24226: rpc: warn that nodes ignore requests for old ...
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24226: rpc: warn that nodes ignore requests for old stale blocks (master...2022/02/dontfetcholdblocks) https://github.com/bitcoin/bitcoin/pull/24226
greypw2546002 has quit [Quit: I'll be back!]
greypw2546002 has joined #bitcoin-core-dev
robertnielsen has quit [Quit: Ping timeout (120 seconds)]
<bitcoin-git>
[bitcoin] hebasto opened pull request #26642: clang-tidy: Add more `performance-*` checks and related fixes (master...221205-ci-tidy) https://github.com/bitcoin/bitcoin/pull/26642
halosghost has quit [Quit: WeeChat 3.7.1]
<achow101>
guix builders: 22.1 code signatures are pushed
someone235 has quit [Quit: Connection closed for inactivity]
<furszy>
fanquake: shouldn't we add some release-notes for the wallet's bug on the 24.x branch?
yanmaani1 has quit [Remote host closed the connection]
<fanquake>
We could add a note, but that doesn’t need to be part of that backport PR.
yanmaani1 has joined #bitcoin-core-dev
<furszy>
hmm, would make sense to target master with that?
<fanquake>
What do you mean
<furszy>
open a PR targeting master that adds a small release-notes for v24.0.1
<fanquake>
That’s not required
<fanquake>
I’ll deal with release notes and version bumping tomorrow, after the backports have actually been reviewed.
<achow101>
We can just update the draft for 24.0 in the dev wiki and copy that over during the final release process
<fanquake>
There’s not really much that needs updating in any case. We can add a note that 24.0 was a no-op. That’s about it.
<furszy>
ok great. The PR master targeting master wasn't making much sense in my head. While we add a note/warning for users who upgraded to 24 and use the manual input selection functionality, we are golden.
Talkless has quit [Quit: Konversation terminated!]
<bitcoin-git>
[bitcoin] achow101 opened pull request #26643: wallet: Move fee underpayment check to after all fee has been set (master...move-fee-underpay-check) https://github.com/bitcoin/bitcoin/pull/26643
bitdex has quit [Remote host closed the connection]
metallicc has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] furszy opened pull request #26644: wallet: bugfix, 'wallet_load_ckey' unit test fails with bdb (master...2022_walletdb_fix_bdb_deadlock) https://github.com/bitcoin/bitcoin/pull/26644