javi404 has quit [*.net *.split]
cryptapus has quit [*.net *.split]
theStack has quit [*.net *.split]
phantomcircuit has quit [*.net *.split]
MacroFake has quit [*.net *.split]
andytoshi has quit [*.net *.split]
sanket1729 has quit [*.net *.split]
kcalvinalvin has quit [*.net *.split]
gribble has quit [*.net *.split]
dhruv has quit [*.net *.split]
uasf has quit [*.net *.split]
grubmn has quit [*.net *.split]
furszy has quit [*.net *.split]
cfields has quit [*.net *.split]
grubmn has joined #bitcoin-core-dev
furszy has joined #bitcoin-core-dev
uasf has joined #bitcoin-core-dev
cryptapus has joined #bitcoin-core-dev
javi404 has joined #bitcoin-core-dev
phantomcircuit has joined #bitcoin-core-dev
cfields has joined #bitcoin-core-dev
sanket1729 has joined #bitcoin-core-dev
MacroFake has joined #bitcoin-core-dev
kcalvinalvin has joined #bitcoin-core-dev
andytoshi has joined #bitcoin-core-dev
dhruv has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
furszy has quit [Changing host]
furszy has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 255 seconds]
bitdex has joined #bitcoin-core-dev
Aaronvan_ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 256 seconds]
yanmaani1 has quit [Ping timeout: 255 seconds]
theStack has joined #bitcoin-core-dev
yanmaani1 has joined #bitcoin-core-dev
_andrewtoth_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
luke-jr has quit [Ping timeout: 252 seconds]
luke-jr has joined #bitcoin-core-dev
Guest39 has joined #bitcoin-core-dev
Guest39 has left #bitcoin-core-dev [#bitcoin-core-dev]
vasild_ has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 255 seconds]
vasild_ has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
b_101 has quit [Ping timeout: 268 seconds]
lopo has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] sipa opened pull request #26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0 (master...secp256k1) https://github.com/bitcoin/bitcoin/pull/26691
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Quit: bye]
<bitcoin-git> [bitcoin] kristapsk opened pull request #26692: doc: Fix typo in comment (master...fix-typo-implemenation) https://github.com/bitcoin/bitcoin/pull/26692
Evel-Knievel has quit [Ping timeout: 260 seconds]
SpellChecker_ has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
as2333 has quit [Quit: as2333]
Evel-Knievel has joined #bitcoin-core-dev
kexkey has quit [Read error: Connection reset by peer]
kexkey has joined #bitcoin-core-dev
cfields has quit [Ping timeout: 256 seconds]
cfields has joined #bitcoin-core-dev
Evel-Knievel has quit [Ping timeout: 260 seconds]
Aaronvan_ has quit [Remote host closed the connection]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
AaronvanW has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6061eb656410...968f03e65c98
<bitcoin-git> bitcoin/master a451e83 James O'Beirne: fix: validation: cast now() to seconds for maxtipage comparison
<bitcoin-git> bitcoin/master e4be0e9 James O'Beirne: test: add -maxtipage test for the maximum allowable value
<bitcoin-git> bitcoin/master 968f03e fanquake: Merge bitcoin/bitcoin#26477: validation: fix broken maxtipage comparison
<bitcoin-git> [bitcoin] fanquake closed pull request #26477: validation: fix broken maxtipage comparison (master...2022-11-fix-maxtipage) https://github.com/bitcoin/bitcoin/pull/26477
AaronvanW has quit [Ping timeout: 268 seconds]
vasild has quit [Ping timeout: 255 seconds]
<bitcoin-git> [bitcoin] fanquake closed pull request #26692: doc: Fix typo in comment (master...fix-typo-implemenation) https://github.com/bitcoin/bitcoin/pull/26692
Evel-Knievel has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 264 seconds]
vasild has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 255 seconds]
SpellChecker has joined #bitcoin-core-dev
Guest54 has joined #bitcoin-core-dev
Guest54 has quit [Client Quit]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<stickies-v> in https://github.com/bitcoin/bitcoin/blob/968f03e65c98a9a36aea6c57a29306839b0ada57/src/util/result.h#L65-L69, it seems that we want to return an rvalue ref (`T&&`) but since the return type is just `T` - my intuition is that we will be passing by value instead? I think I must be wrong, but I don't understand why - any insights (or links/pointers) appreciated (cc author ryanofsky)
Guest170 has joined #bitcoin-core-dev
Guest170 has quit [Client Quit]
darosior has quit [Ping timeout: 256 seconds]
ghost43 has quit [Ping timeout: 255 seconds]
ghost43 has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 268 seconds]
jonatack has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
Guest27 has joined #bitcoin-core-dev
<stickies-v> ^ hebasto answered me offline, I'll try and summarize here (any misinterprations my own): to avoid dangling references, we don't want to return an rvalue reference `T&&` but return by value instead. However, if `T` properly implements a move constructor, we can construct `T` without doing any copy operations
Guest27 has quit [Client Quit]
<bitcoin-git> [bitcoin] willcl-ark opened pull request #26693: build: special instruction check script (master...18603_si_check) https://github.com/bitcoin/bitcoin/pull/26693
halosghost has joined #bitcoin-core-dev
<jonatack> stickies-v: https://en.cppreference.com/w/cpp/language/copy_elision or searching on RVO (return value optimization) might be relevant (ignore me if not :)
<stickies-v> yeah thanks jonatack I'm aware of both concepts and they are relevant practically, my question was a bit more theoretical
<bitcoin-git> [bitcoin] kdmukai opened pull request #26694: test: `get_previous_releases.py`: M1/M2 macs can't run the unsigned v23.0 arm64 binary; fall back to x86_64 binary (master...2022-12-fix_mac_arm64_previous_releases) https://github.com/bitcoin/bitcoin/pull/26694
<bitcoin-git> [bitcoin] glozow opened pull request #26695: bench: BlockAssembler on a mempool with packages (master...2022-12-bench-miner) https://github.com/bitcoin/bitcoin/pull/26695
<bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/968f03e65c98...a4baf3f17748
<bitcoin-git> bitcoin/master e2c3b18 Ryan Ofsky: test: Add RPC tests for same named parameter specified more than once
<bitcoin-git> bitcoin/master 6bd1d20 Ryan Ofsky: rpc: Make it an error server-side to specify same named parameter multiple...
<bitcoin-git> bitcoin/master d1ca563 Ryan Ofsky: bitcoin-cli: Make it an error to specify the "args" parameter two differen...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26628: RPC: Reject RPC requests with same named parameter specified multiple times (master...pr/nmult) https://github.com/bitcoin/bitcoin/pull/26628
javi404 has quit [Quit: No Ping reply in 180 seconds.]
javi404 has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 260 seconds]
luke-jr has joined #bitcoin-core-dev
as2333 has joined #bitcoin-core-dev
bcdarc_ has joined #bitcoin-core-dev
_0x0ff has joined #bitcoin-core-dev
_0x0ff has quit [Changing host]
_0x0ff has joined #bitcoin-core-dev
Murch1 has joined #bitcoin-core-dev
otoburb has quit [Ping timeout: 252 seconds]
jonasschnelli has quit [Ping timeout: 252 seconds]
asoltys_ has joined #bitcoin-core-dev
kinlo has quit [Ping timeout: 252 seconds]
jkczyz has quit [Ping timeout: 252 seconds]
achow101 has quit [Ping timeout: 252 seconds]
kakolainen[m] has quit [Ping timeout: 252 seconds]
sugarpuff has quit [Ping timeout: 252 seconds]
bcdarc has quit [Ping timeout: 252 seconds]
bomb-on has quit [Ping timeout: 252 seconds]
katsu_ has quit [Ping timeout: 252 seconds]
sanket_cell has quit [Ping timeout: 252 seconds]
jespada has quit [Ping timeout: 252 seconds]
Murch has quit [Ping timeout: 252 seconds]
asoltys has quit [Ping timeout: 252 seconds]
jkczyz_ is now known as jkczyz
_0x0ff is now known as katsu_
achow101 has joined #bitcoin-core-dev
sanket_cell has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
<stickies-v> anything wrong with our cirrus instances? suddenly all my CI jobs failing: https://github.com/bitcoin/bitcoin/pull/26506/checks?check_run_id=10070556876 - can't see anything in recent commits that would trigger it
Talkless has joined #bitcoin-core-dev
<stickies-v> getting error message `Failed to checkout 135e8326adee7f86da83e8aa409905a1de4a5b2e: object not found!` when that commit is definitely on origin: https://github.com/bitcoin/bitcoin/commit/135e8326adee7f86da83e8aa409905a1de4a5b2e
kinlo has joined #bitcoin-core-dev
<stickies-v> oh, it seems github is having some issues: https://www.githubstatus.com/ : `Git Operations` and `Pull Requests` is showing as `Degraded`
sugarpuff has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
rozehnal_paul has joined #bitcoin-core-dev
<bitcoin-git> [gui] meshcollider closed pull request #536: Add address error location to GUI (master...202201_bech32_error_gui) https://github.com/bitcoin-core/gui/pull/536
rozehnal_paul has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a4baf3f17748...8f3021155e8c
<bitcoin-git> bitcoin/master e5daf97 Andrew Chow: wallet: Rename nFeeRet in CreateTransactionInternal to current_fee
<bitcoin-git> bitcoin/master c1a84f1 Andrew Chow: wallet: Move fee underpayment check to after fee setting
<bitcoin-git> bitcoin/master 798430d Andrew Chow: wallet: Sanity check fee paid cannot be negative
<bitcoin-git> [bitcoin] achow101 merged pull request #26643: wallet: Move fee underpayment check to after all fee has been set (master...move-fee-underpay-check) https://github.com/bitcoin/bitcoin/pull/26643
brunoerg has quit []
Talkless has quit [Quit: Konversation terminated!]
bomb-on has quit [Quit: aллилѹіа!]
javi404 has quit [Ping timeout: 260 seconds]
sipsorcery has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
javi404 has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 256 seconds]
___nick___ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8f3021155e8c...ffa32ab108a4
<bitcoin-git> bitcoin/master e75d227 John Moffett: Minor fix: Don't directly delete abandoned txes
<bitcoin-git> bitcoin/master ffa32ab Hennadii Stepanov: Merge bitcoin-core/gui#682: Don't directly delete abandoned txes from GUI
<bitcoin-git> [gui] hebasto merged pull request #682: Don't directly delete abandoned txes from GUI (master...2022_11_FixAbandonTxGUI) https://github.com/bitcoin-core/gui/pull/682
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
halosghost has quit [Quit: WeeChat 3.7.1]
jonatack has quit [Ping timeout: 268 seconds]
szkl has joined #bitcoin-core-dev
MacroFake has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
MacroFake has joined #bitcoin-core-dev
darosior has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ffa32ab108a4...daf881de9db1
<bitcoin-git> bitcoin/master daf881d Andrew Chow: Merge bitcoin/bitcoin#23319: rpc: Return fee and prevout (utxos) to getraw...
<bitcoin-git> bitcoin/master f866971 Douglas Chimento: rpc: Return fee and prevout(s) to getrawtransaction
<bitcoin-git> [bitcoin] achow101 merged pull request #23319: rpc: Return fee and prevout (utxos) to getrawtransaction (master...23264-fee-getrawtransaction) https://github.com/bitcoin/bitcoin/pull/23319
Jackielove4u has quit [Quit: Connection closed for inactivity]
bitdex has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 252 seconds]
SpellChecker has quit [Remote host closed the connection]
bitdex has quit [Ping timeout: 255 seconds]
bitdex has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev