andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #26688: Move `CopyrightHolders()` and `LicenseInfo()` into `libbitcoin_common` (master...221212-common) https://github.com/bitcoin/bitcoin/pull/26688
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 255 seconds]
vasild has joined #bitcoin-core-dev
halosghost has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] josibake opened pull request #26689: test: add add_wallet_options to TestShell (master...josibake-add-wallet-options-test-shell) https://github.com/bitcoin/bitcoin/pull/26689
SpellChecker has quit [Ping timeout: 255 seconds]
SpellChecker has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
jarthur_ has joined #bitcoin-core-dev
jarthur has quit [Ping timeout: 255 seconds]
jarthur_ is now known as jarthur
sipsorcery has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
cotsuka has quit [Quit: Bye!]
cotsuka has joined #bitcoin-core-dev
as2333 has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
Talkless has joined #bitcoin-core-dev
sipsorcery has quit [Read error: Connection reset by peer]
sipsorcery has joined #bitcoin-core-dev
lopo has joined #bitcoin-core-dev
metallicc has quit [Remote host closed the connection]
b_101_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 246 seconds]
b_101 has joined #bitcoin-core-dev
Guest34 has joined #bitcoin-core-dev
Guest34 has quit [Client Quit]
b_101_ has quit [Ping timeout: 260 seconds]
<bitcoin-git>
[bitcoin] achow101 opened pull request #26690: wallet: Refactor database cursor into its own object with proper return codes (master...walletdb-cursor-unstupidfy) https://github.com/bitcoin/bitcoin/pull/26690
Talkless has quit [Quit: Konversation terminated!]
kdmukai has joined #bitcoin-core-dev
Guest79 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 246 seconds]
kdmukai85 has joined #bitcoin-core-dev
kdmukai85 has quit [Client Quit]
Guest79 has quit [Quit: Client closed]
<kdmukai>
Sitting here with Sjors, trying to run feature_backwards_compatibility.py on my M1 Mac. We successfully ran get_previous_releases.py but test is dying when it tries to spin up the v23.0 node. If we try to run the v23.0 binary manually in releases/v23.0/bin/ the process just immediately dies. Confirmed that it did grab the arm64 binary for v23.0. We
<kdmukai>
then just directly downloaded the dmg version from https://bitcoincore.org/bin/bitcoin-core-23.0/ and that installed and ran fine. When Sjors ran a diff on the two v23.0 bitcoin-qt binaries (the one from the tar.gz vs what was unpacked from the dmg), they came up as different, which confounded Sjors.
Guest19 has joined #bitcoin-core-dev
<kdmukai>
v22.0 in releases/v22.0/bin/ starts up fine.
as2333 has quit [Quit: as2333]
darosior has quit [Quit: Ping timeout (120 seconds)]
<fanquake>
kdmukai: wouldn’t the difference be code-signed vs not? That’d explain the diff, and the non-code signed binary failing to run.
<fanquake>
The bitcoin-qt in the tarball wont be code signed. It likely would have just run ok on previous versions of macOS. However with newer versions of macOS that is less likely the case
Guest19 has quit [Quit: Client closed]
<fanquake>
if you run codesign —display —versbose and pass either bitcoin-qt bin, you’ll see what I mean.
<kdmukai>
fanquake: ya. "bitcoin-qt: code object is not signed at all" vs "Signature size=8958" etc.
brunoerg has quit []
<fanquake>
I assume the 22.0 bin works for you, because it’s actually a x86_64 binary, running under emulation, and isn’t subject to the stricter arm code-signing requirements (given we didn’t ship native M1 macOS bins for 22.0)
<kdmukai>
fanquake: Yes, v22.0 runs fine on my M1.
<kdmukai>
fanquake: And just confirmed that the x86_64 binary for v23.0 runs fine, as expected.
halosghost has quit [Ping timeout: 256 seconds]
<provoostenator>
Should we start codesigning bitcoind for macOS builds?
<provoostenator>
Had had any problems on Intel.
<provoostenator>
* haven't
halosghost has joined #bitcoin-core-dev
<fanquake>
Something we could consider for 25.x
andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
sipsorcery has quit [Read error: Connection reset by peer]
sipsorcery has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 255 seconds]
SpellChecker has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
vasild has quit [Remote host closed the connection]
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
<achow101>
don't we codesign mac arm builds?
<achow101>
oh, you're talking about the tarball. we don't codesign those
<achow101>
I'm not certain we can sign the individual binaries. technically we are signing the app bundle and so the signature actually covers some things that aren't in the bin itself