BitcoinErrorLog has quit [Ping timeout: 260 seconds]
sipsorcery has quit [Ping timeout: 252 seconds]
zeropoint has quit [Quit: leaving]
miles1 has joined #bitcoin-core-dev
john-moffett has quit [Read error: Connection reset by peer]
SpellChecker has quit [Ping timeout: 255 seconds]
SpellChecker has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
Zenton has quit [Read error: Connection reset by peer]
Zenton has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 255 seconds]
SpellChecker has joined #bitcoin-core-dev
mimmy has quit [Quit: ZNC 1.9.x-git-187-32d4a4d5 - https://znc.in]
mimmy has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 255 seconds]
bitdex has joined #bitcoin-core-dev
ziggie has quit [Quit: Connection closed for inactivity]
mimmy has quit [Quit: ZNC 1.9.x-git-187-32d4a4d5 - https://znc.in]
mimmy has joined #bitcoin-core-dev
miles1 has quit [Quit: WeeChat 3.7.1]
Pasha has joined #bitcoin-core-dev
Cory has quit [Ping timeout: 252 seconds]
miles_ has joined #bitcoin-core-dev
miles_ has quit [Quit: WeeChat 3.7.1]
mudsip has joined #bitcoin-core-dev
mudsip has quit []
miles_ has joined #bitcoin-core-dev
miles_ has left #bitcoin-core-dev [#bitcoin-core-dev]
infernix has quit [Ping timeout: 256 seconds]
ghost43 has quit [Ping timeout: 255 seconds]
infernix has joined #bitcoin-core-dev
Guest56 has joined #bitcoin-core-dev
Guest56 has quit [Client Quit]
yanmaani1 has quit [Ping timeout: 255 seconds]
ghost43 has joined #bitcoin-core-dev
yanmaani1 has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<josie[m]> fanquake: first time ive helped with backports, so what's the best way to help review? just compile and test that each set of commits fixes the thing it's supposed to fix? im assuming we aren't actually reviewing/changing any of the code since the commits themselves have already been reviewed and merged?
<fanquake> josie: that assumption doesn't always hold. some of the commits in that PR don't match what was merged into master, as the 24.x and master branches have diverged somewhat in the wallet code, so that changes need just as much sanity-checking/review.
<fanquake> *so the
<josie[m]> fanquake: cool, thxs!
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5d9b5305af4a...edbe4f808a05
<bitcoin-git> bitcoin/master c6e7f22 MarcoFalke: util: Add StrFormatInternalBug and STR_INTERNAL_BUG
<bitcoin-git> bitcoin/master 3eb041f Andrew Chow: wallet: Change coin selection fee assert to error
<bitcoin-git> bitcoin/master edbe4f8 MarcoFalke: Merge bitcoin/bitcoin#26611: wallet: Change coin selection fee assert to e...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26611: wallet: Change coin selection fee assert to error (master...coin-sel-dont-assert) https://github.com/bitcoin/bitcoin/pull/26611
dongcarl4 has joined #bitcoin-core-dev
dongcarl has quit [Ping timeout: 268 seconds]
dongcarl4 is now known as dongcarl
ziggie has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26645: util: Include full version id in bug reports (master...2212-full-version-id-🍁) https://github.com/bitcoin/bitcoin/pull/26645
<bitcoin-git> [bitcoin] glozow opened pull request #26646: validation, bugfix: provide more info in *MempoolAcceptResult (master...package-single-tx-result) https://github.com/bitcoin/bitcoin/pull/26646
<bitcoin-git> [bitcoin] fanquake closed pull request #16365: Log RPC parameters (arguments) if -debug=rpcparams (master...log-rpc-args) https://github.com/bitcoin/bitcoin/pull/16365
<bitcoin-git> [bitcoin] fanquake closed pull request #20407: rpc: Support -rpcauthfile argument (master...2020-11-rpcauthfile) https://github.com/bitcoin/bitcoin/pull/20407
bomb-on has quit [Quit: aллилѹіа!]
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/edbe4f808a05...8ccab65f289e
<bitcoin-git> bitcoin/master 203886c fanquake: Fixup clang-tidy named argument comments
<bitcoin-git> bitcoin/master 8ccab65 MarcoFalke: Merge bitcoin/bitcoin#26238: clang-tidy: fixup named argument comments
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26238: clang-tidy: fixup named argument comments (master...fix_named_argument_cmnts) https://github.com/bitcoin/bitcoin/pull/26238
<bitcoin-git> [bitcoin] fanquake closed pull request #19434: http: Detect remote disconnect (master...2020-06-remote-disconnect) https://github.com/bitcoin/bitcoin/pull/19434
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 10 commits to 24.x: https://github.com/bitcoin/bitcoin/compare/f668a3a85933...3afbc7d67d8e
<bitcoin-git> bitcoin/24.x 7a97a56 Andrew Chow: wallet: Avoid null pointer deref when cleaning up migratewallet
<bitcoin-git> bitcoin/24.x 95fded1 Andrew Chow: wallet: Explicitly say migratewallet on encrypted wallets is unsupported
<bitcoin-git> bitcoin/24.x d464b2a Andrew Chow: tests: Test for migrating encrypted wallets
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26616: [24.x] Backports for 24.0.1 (24.x...24_0_1_backports) https://github.com/bitcoin/bitcoin/pull/26616
Guest74 has joined #bitcoin-core-dev
Guest74 has quit [Client Quit]
ExEric3 has quit [Ping timeout: 256 seconds]
ExEric3 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #26647: 24.0.1 final changes (24.x...24_0_1_final_changes) https://github.com/bitcoin/bitcoin/pull/26647
<bitcoin-git> [bitcoin] fanquake opened pull request #26648: doc: move release notes to 24.0.1 and add notice (master...add_24_0_1_docs_redirect) https://github.com/bitcoin/bitcoin/pull/26648
bitdex has quit [Quit: = ""]
someone235 has joined #bitcoin-core-dev
kexkey has quit [Quit: kexkey]
cryptapus has quit [Quit: Konversation terminated!]
cryptapus has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
BitcoinErrorLog has joined #bitcoin-core-dev
<BitcoinErrorLog> Is 3 days enough for removal of "too heated" status? Conversation is happening in the mailing list and some people may want to comment in the PR. https://github.com/bitcoin/bitcoin/pull/26525
kexkey has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] brunoerg closed pull request #24499: test: add script to mutate cpp files (master...2022-03-mutation-test) https://github.com/bitcoin/bitcoin/pull/24499
someone235 has quit [Quit: Connection closed for inactivity]
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #26649: refactor: Use AutoFile and HashVerifier (without ser-type and ser-version) where possible (master...2212-ser-type-ver-👬) https://github.com/bitcoin/bitcoin/pull/26649
<bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 24.x: https://github.com/bitcoin/bitcoin/compare/3afbc7d67d8e...b3f866a8dfd6
<bitcoin-git> bitcoin/24.x 1b19c89 fanquake: build: bump version to 24.0.1 final
<bitcoin-git> bitcoin/24.x c119b0a fanquake: doc: generate manual pages for 24.0.1 final
<bitcoin-git> bitcoin/24.x a9ea715 fanquake: doc: adjust release notes for 24.0.1
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26647: 24.0.1 final changes (24.x...24_0_1_final_changes) https://github.com/bitcoin/bitcoin/pull/26647
robertnielsen has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] fanquake pushed tag v24.0.1: https://github.com/bitcoin/bitcoin/compare/v24.0.1
<instagibbs> #proposedmeetingtopic #26398 see if we can resolve the direction here given all the opinions have been given
<gribble> https://github.com/bitcoin/bitcoin/issues/26398 | Replace MIN_STANDARD_TX_NONWITNESS_SIZE to preclude 64 non-witness bytes only by instagibbs · Pull Request #26398 · bitcoin/bitcoin · GitHub
Pasha has quit [Ping timeout: 256 seconds]
Cory has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8ccab65f289e...ef744c03e56d
<bitcoin-git> bitcoin/master 6b563ca Aurèle Oulès: wallet: Check max tx weight in coin selector
<bitcoin-git> bitcoin/master c7c7ee9 Aurèle Oulès: test: Check max transaction weight in CoinSelection
<bitcoin-git> bitcoin/master ef744c0 Andrew Chow: Merge bitcoin/bitcoin#25729: wallet: Check max transaction weight in CoinS...
<bitcoin-git> [bitcoin] achow101 merged pull request #25729: wallet: Check max transaction weight in CoinSelection (master...2022-07-coin-selection-check-max-weight) https://github.com/bitcoin/bitcoin/pull/25729
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
zeropoint has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
sipsorcery has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ef744c03e56d...1ff79292e399
<bitcoin-git> bitcoin/master 38941a7 Hennadii Stepanov: refactor: Move `txmempool_entry.h` --> `kernel/mempool_entry.h`
<bitcoin-git> bitcoin/master 1ff7929 MarcoFalke: Merge bitcoin/bitcoin#26609: refactor: Move `txmempool_entry.h` --> `kerne...
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #26609: refactor: Move `txmempool_entry.h` -- `kernel/mempool_entry.h` (master...221130-move) https://github.com/bitcoin/bitcoin/pull/26609
halosghost has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1ff79292e399...0abb5b2dd625
<bitcoin-git> bitcoin/master 896fca1 fanquake: doc: move release notes to 24.0.1 and add notice
<bitcoin-git> bitcoin/master 0abb5b2 fanquake: Merge bitcoin/bitcoin#26648: doc: move release notes to 24.0.1 and add not...
<bitcoin-git> [bitcoin] fanquake merged pull request #26648: doc: move release notes to 24.0.1 and add notice (master...add_24_0_1_docs_redirect) https://github.com/bitcoin/bitcoin/pull/26648
dviola has quit [Ping timeout: 264 seconds]
dviola has joined #bitcoin-core-dev
yanmaani1 has quit [Ping timeout: 255 seconds]
yanmaani1 has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
andrewtoth has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
<bitcoin-git> [gui] hebasto merged pull request #683: doc: Drop no longer relevant comment (master...221202-doc) https://github.com/bitcoin-core/gui/pull/683
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0abb5b2dd625...0596aa40f77a
<bitcoin-git> bitcoin/master 5d332da Hennadii Stepanov: doc: Drop no longer relevant comment
<bitcoin-git> bitcoin/master 0596aa4 Hennadii Stepanov: Merge bitcoin-core/gui#683: doc: Drop no longer relevant comment
<bitcoin-git> [gui] hebasto closed pull request #236: Bugfix: Allow the user to start anyway when loading a wallet errors (master...gui_init_walleterror_cont) https://github.com/bitcoin-core/gui/pull/236
sipsorcery has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 265 seconds]
andrewtoth_ has joined #bitcoin-core-dev
andrewtoth has quit [Ping timeout: 255 seconds]
Talkless has quit [Quit: Konversation terminated!]
sipsorcery has joined #bitcoin-core-dev
merlinB has joined #bitcoin-core-dev
Jonhandsome has joined #bitcoin-core-dev
Jonhandsome has quit [Ping timeout: 260 seconds]
_andrewtoth_ has joined #bitcoin-core-dev
brunoerg has quit []
andrewtoth_ has quit [Ping timeout: 255 seconds]
rozehnal_paul has joined #bitcoin-core-dev
halosghost has quit [Quit: WeeChat 3.7.1]
andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
jonatack has quit [Quit: WeeChat 3.7.1]
jonatack has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
merlinB_ has joined #bitcoin-core-dev
merlinB has quit [Ping timeout: 260 seconds]
rozehnal_paul has quit [Quit: Connection closed]
sipsorcery has quit [Ping timeout: 256 seconds]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev