<bitcoin-git>
bitcoin/master ba29143 fanquake: ci: use Debian Bookworm and Valgrind 3.19 in Valgrind jobs
<bitcoin-git>
bitcoin/master e047ae8 fanquake: valgrind: update supps for Debian Bookworm.
<bitcoin-git>
bitcoin/master cd603ed fanquake: Merge bitcoin/bitcoin#27444: ci: use Debian Bookworm and Valgrind 3.19 in ...
<bitcoin-git>
[bitcoin] fanquake merged pull request #27444: ci: use Debian Bookworm and Valgrind 3.19 in Valgrind jobs (master...valgrind_3_20_source_clang_16) https://github.com/bitcoin/bitcoin/pull/27444
AaronvanW has joined #bitcoin-core-dev
arturomf94[m] has quit [Read error: Connection reset by peer]
bohruz[m] has quit [Read error: Connection reset by peer]
sipa has quit [Read error: Connection reset by peer]
kakolainen[m] has quit [Read error: Connection reset by peer]
euclid[m] has quit [Read error: Connection reset by peer]
provoostenator has quit [Read error: Connection reset by peer]
Fractal[m]1 has quit [Read error: Connection reset by peer]
sequences[m] has quit [Read error: Connection reset by peer]
stratospher[m] has quit [Read error: Connection reset by peer]
Murch has quit [Read error: Connection reset by peer]
ishaanam[m] has quit [Read error: Connection reset by peer]
Urko[m] has quit [Read error: Connection reset by peer]
willcl_ark has quit [Read error: Connection reset by peer]
dunxen has quit [Read error: Connection reset by peer]
vincenzopalazzo has quit [Read error: Connection reset by peer]
BlueMatt[m] has quit [Write error: Connection reset by peer]
denise[m] has quit [Read error: Connection reset by peer]
b10c[m] has quit [Read error: Connection reset by peer]
bitcoin-git has quit [Write error: Connection reset by peer]
kayabanerve[m] has quit [Read error: Connection reset by peer]
Murch has joined #bitcoin-core-dev
Murch has quit [Remote host closed the connection]
Murch has joined #bitcoin-core-dev
b10c[m] has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
willcl_ark has joined #bitcoin-core-dev
kakolainen[m] has joined #bitcoin-core-dev
sipa has joined #bitcoin-core-dev
vincenzopalazzo has joined #bitcoin-core-dev
sequences[m] has joined #bitcoin-core-dev
kayabanerve[m] has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
denise[m] has joined #bitcoin-core-dev
stratospher[m] has joined #bitcoin-core-dev
bohruz[m] has joined #bitcoin-core-dev
Fractal[m] has joined #bitcoin-core-dev
euclid[m] has joined #bitcoin-core-dev
Urko[m] has joined #bitcoin-core-dev
ishaanam[m] has joined #bitcoin-core-dev
arturomf94[m] has joined #bitcoin-core-dev
provoostenator has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
PaperSword has quit [Quit: PaperSword]
Fractal[m] has quit [Ping timeout: 240 seconds]
BlueMatt[m] has quit [Ping timeout: 240 seconds]
dunxen has quit [Ping timeout: 240 seconds]
sipa has quit [Ping timeout: 248 seconds]
Murch has quit [Ping timeout: 248 seconds]
Urko[m] has quit [Ping timeout: 265 seconds]
provoostenator has quit [Ping timeout: 246 seconds]
bohruz[m] has quit [Ping timeout: 246 seconds]
denise[m] has quit [Ping timeout: 246 seconds]
kakolainen[m] has quit [Ping timeout: 246 seconds]
bitcoin-git has quit [Ping timeout: 246 seconds]
ishaanam[m] has quit [Ping timeout: 260 seconds]
arturomf94[m] has quit [Ping timeout: 260 seconds]
willcl_ark has quit [Ping timeout: 260 seconds]
stratospher[m] has quit [Ping timeout: 252 seconds]
b10c[m] has quit [Ping timeout: 264 seconds]
euclid[m] has quit [Ping timeout: 265 seconds]
kayabanerve[m] has quit [Ping timeout: 265 seconds]
vincenzopalazzo has quit [Ping timeout: 256 seconds]
sequences[m] has quit [Ping timeout: 256 seconds]
BlueMatt[m] has joined #bitcoin-core-dev
willcl_ark has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Urko[m] has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
Fractal[m] has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
sipa has joined #bitcoin-core-dev
arturomf94[m] has joined #bitcoin-core-dev
ishaanam[m] has joined #bitcoin-core-dev
Murch has joined #bitcoin-core-dev
dviola has left #bitcoin-core-dev [#bitcoin-core-dev]
b10c[m] has joined #bitcoin-core-dev
bohruz[m] has joined #bitcoin-core-dev
provoostenator has joined #bitcoin-core-dev
denise[m] has joined #bitcoin-core-dev
kakolainen[m] has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #27459: ci: explicitly install libclang-rt-dev in valgrind jobs (master...explicit_libclang_rt_dev) https://github.com/bitcoin/bitcoin/pull/27459
<achow101>
the prs in the milestone are #27231 #27374 #27253 #27145 and #25968. it's not clear to me that these are all bug fixes that should be inclued in the milestone
<gribble>
https://github.com/bitcoin/bitcoin/issues/27374 | p2p: skip netgroup diversity of new connections for tor/i2p/cjdns by stratospher · Pull Request #27374 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/27231 | Fix logging RPC and -debugexclude with 0/none values, add test coverage, improve docs by jonatack · Pull Request #27231 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/27253 | httpserver, rest: fix segmentation fault on evhttp_uri_get_query by pablomartin4btc · Pull Request #27253 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/27145 | wallet: when a block is disconnected, update transactions that are no longer conflicted by ishaanam · Pull Request #27145 · bitcoin/bitcoin · GitHub
<sipa>
#25968 can be dropped from the milestone, I think
Talkless has quit [Quit: Konversation terminated!]
<achow101>
I'm not sure if #27374 is a bug fix, but the rest seem to be bug fixes of relatively long-standing issues, so aren't critical/blockers for this release
<gribble>
https://github.com/bitcoin/bitcoin/issues/27374 | p2p: skip netgroup diversity of new connections for tor/i2p/cjdns by stratospher · Pull Request #27374 · bitcoin/bitcoin · GitHub
<Murch>
I think #27145 can be dropped from the milestone as well
<gribble>
https://github.com/bitcoin/bitcoin/issues/27145 | wallet: when a block is disconnected, update transactions that are no longer conflicted by ishaanam · Pull Request #27145 · bitcoin/bitcoin · GitHub
<Murch>
It’s also a long standing issue
<achow101>
yes, removed it
<achow101>
#27231 and #27253 seem fine to keep but shouldn't be blockers. we can drop them if they aren't in by rc2 or something
<gribble>
https://github.com/bitcoin/bitcoin/issues/27253 | httpserver, rest: fix segmentation fault on evhttp_uri_get_query by pablomartin4btc · Pull Request #27253 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/27231 | Fix logging RPC and -debugexclude with 0/none values, add test coverage, improve docs by jonatack · Pull Request #27231 · bitcoin/bitcoin · GitHub
<fanquake>
I mean they should be in before branch off, or they just go to 26.x
<jonatack>
agree. i've iterated a few times on the latter one and it's probably done/ready, but indeed not critical
<achow101>
real_or_random: is it a bugfix, so it could be considered for inclusion. it's a question of severity, i.e. is the bug being fixed a big enough issue that we should include it for 25.0
<real_or_random>
It's really hard to say if this is exploitable but given that this is a security fix and some people will compile manually, I feel it's better to have it in
<real_or_random>
not sure what sipa thinks.
<real_or_random>
if my analysis in the PR is correct, the patch to convince CI is just the two lines there.
<bitcoin-git>
[bitcoin] theuni opened pull request #27461: verify-commits: error and exit cleanly when git is too old. (master...verify-commits-git-version-error) https://github.com/bitcoin/bitcoin/pull/27461
pakaro has joined #bitcoin-core-dev
pakaro has quit [Client Quit]
<achow101>
i've added it to the milestone
preimage has quit [Quit: WeeChat 3.8]
brunoerg has quit [Remote host closed the connection]