brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 276 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
earnestly has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
<sipa>
@real_or_random Seems your guess about what was wrong was indeed right, though I had to also prevent some Bitcoin Core CI linters from checking the libsecp python script.
<sipa>
I think that's correct in that core's CI shouldn't enforce its lint standards on subtrees, but also independently... it'd probably be better quality python code if we did address some of the lint findings.
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
ryanofsky has quit [Ping timeout: 252 seconds]
ryanofsky has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] 1440000bytes closed pull request #27454: doc: remove incorrect line from example (master...walletcreatefundedpsbt-example) https://github.com/bitcoin/bitcoin/pull/27454
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
<real_or_random>
makes sense
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
<fanquake>
the python lint stuff doesn’t need to be a blocker, we can just exclude the subtree
<fanquake>
real_or_random: great. also, it makes no difference to us wether you make an new release with the fix or not, as we'll just pull master into our subtree
brunoerg has joined #bitcoin-core-dev
plvicente has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
vysn has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
b_101 has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
pakaro has joined #bitcoin-core-dev
realies has quit [Read error: Connection reset by peer]
pakaro has quit [Client Quit]
realies has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
Guest67 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guest67 has quit [Ping timeout: 260 seconds]
bitdex has quit [Quit: = ""]
<real_or_random>
yep, we're not planning to make a new release. that bug in the build system is pretty obscure and probably affects only core's ci
<bitcoin-git>
bitcoin/master 1fefcf2 Cory Fields: verify-commits: error and exit cleanly when git is too old.
<bitcoin-git>
bitcoin/master 69460bd Andrew Chow: Merge bitcoin/bitcoin#27461: verify-commits: error and exit cleanly when g...
<bitcoin-git>
[bitcoin] achow101 merged pull request #27461: verify-commits: error and exit cleanly when git is too old. (master...verify-commits-git-version-error) https://github.com/bitcoin/bitcoin/pull/27461
<vasild>
9979 didn't have objections, was closed, I guess, due to lack of interest/too much effort
<pinheadmz>
fair 'nuff
<pinheadmz>
my approach is just to start with proxy bc i think its cool Tor supports unix sockets
<pinheadmz>
so the big Q is... will unix sockets ever be used for P2P? does it need to live in CNetAddr? Or is that just setting up abig mess for networking
<vasild>
yeah
<pinheadmz>
I guess the alternative is modifying ConnectSocketDirectly() so it doesnt need a CService for the first arg?
<pinheadmz>
but some other generic socket container ?
<pinheadmz>
vasild if we construct Proxy with string, then Proxy would call Lookup() / LookipNumeric() ? and create the CService internally if its not a UNIX socket
<vasild>
yes, if we do P2P over unix sockets, then we have to expand `enum Network` and CNetAddr with the unix stuff
<pinheadmz>
so the Q is - follow through with all these proxy mods /vs/ have another Network value
<pinheadmz>
im not clear on why the latter is techdebt-y ? we have NET_INTERNAL we have to deal with already ...
pablomartin has joined #bitcoin-core-dev
<vasild>
"follow through with all these proxy mods /vs/ have another Network value" -- right. Would be nice to get some feedback from people. I guess this mainly depends on our desire to do p2p over unix sockets.
<vasild>
pinheadmz: I have to look more into it, could be missing something, but it looks to me that adding another NET_UNIX just to tell CreateSock (via CService of type NET_UNIX) to create a different type of socket is a bit too much.