ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
TallTim_ has joined #bitcoin-core-dev
TallTim has quit [Ping timeout: 246 seconds]
TallTim_ is now known as TallTim
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
jarthur_ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
jarthur has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
dongcarl has quit [Ping timeout: 264 seconds]
dongcarl has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
vysn has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
rolf has joined #bitcoin-core-dev
rolf has quit [Client Quit]
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 245 seconds]
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
salvatoshi has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
salvatoshi has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
Guyver2 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75135c673ee6...334f45fe62c7
<bitcoin-git> bitcoin/master bea9fc2 Cory Fields: wallet: sqlite: force sqlite3.h to be included by the cpp files
<bitcoin-git> bitcoin/master 334f45f fanquake: Merge bitcoin/bitcoin#28040: wallet: sqlite: don't include sqlite files fr...
<bitcoin-git> [bitcoin] fanquake merged pull request #28040: wallet: sqlite: don't include sqlite files from our headers (master...sqlite-no-include-from-headers) https://github.com/bitcoin/bitcoin/pull/28040
jarthur has quit [Quit: jarthur]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/334f45fe62c7...299f17a69e1b
<bitcoin-git> bitcoin/master fabed7e MarcoFalke: test: Restore unlimited timeout in IndexWaitSynced
<bitcoin-git> bitcoin/master 299f17a fanquake: Merge bitcoin/bitcoin#28036: test: Restore unlimited timeout in IndexWaitS...
<bitcoin-git> [bitcoin] fanquake merged pull request #28036: test: Restore unlimited timeout in IndexWaitSynced (master...2307-test-restore-timeout-) https://github.com/bitcoin/bitcoin/pull/28036
ZeroMaster has quit [Read error: Connection reset by peer]
flooded has joined #bitcoin-core-dev
ZeroMaster has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 245 seconds]
abubakarsadiq has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
AaronvanW has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/299f17a69e1b...a9dde841e159
<bitcoin-git> bitcoin/master fade43e MarcoFalke: Allow FastRandomContext::randbytes for all byte types
<bitcoin-git> bitcoin/master fac6af1 MarcoFalke: Allow std::byte serialization
<bitcoin-git> bitcoin/master a9dde84 fanquake: Merge bitcoin/bitcoin#28012: util: Allow FastRandomContext::randbytes for ...
<bitcoin-git> [bitcoin] fanquake merged pull request #28012: util: Allow FastRandomContext::randbytes for std::byte, Allow std::byte serialization (master...2306-fs_stuff-) https://github.com/bitcoin/bitcoin/pull/28012
brunoerg has quit [Ping timeout: 246 seconds]
greypw2546002161 has quit [Quit: I'll be back!]
greypw2546002161 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a9dde841e159...cf4da5ec29f9
<bitcoin-git> bitcoin/master fa1e27f MarcoFalke: fuzz: Generate rpc fuzz targets individually
<bitcoin-git> bitcoin/master cf4da5e fanquake: Merge bitcoin/bitcoin#28015: fuzz: Generate rpc fuzz targets individually
<bitcoin-git> [bitcoin] fanquake merged pull request #28015: fuzz: Generate rpc fuzz targets individually (master...2306-fuzz-rpc-individual-) https://github.com/bitcoin/bitcoin/pull/28015
<vasild> jonatack: wrt https://github.com/bitcoin/bitcoin/issues/22759#issuecomment-1609907115 does bitcoind recover by itself, unattended? That is - to create new i2p session and start accepting/making i2p connections again.
<vasild> from the log it looks like so, I just want to confirm that
<vasild> that the .../... from the log is not a restart of bitcoind
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
andrew_mo_ has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
brunoerg has quit [Ping timeout: 245 seconds]
bomb-on has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] dergoegge opened pull request #28043: fuzz: Test headers pre-sync through p2p interface (master...2023-07-fuzz-pow) https://github.com/bitcoin/bitcoin/pull/28043
test_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
flooded has quit [Ping timeout: 245 seconds]
<jonatack> vasild: yes, i have to restart i2prouter but bitcoind handles it as you describe
<vasild> ok, looking into it
<jonatack> the scenario happens fairly often for me at the moment, as here we often have strong lightning/thunderstorms during the night and so i unplug the power supply from the laptop until morning
<jonatack> if the battery becomes too low during the night, the laptop goes into sleep, and on re-awakening i see these thousands of logs as detailed in that issue
<jonatack> and restart i2prouter, and bitcoind takes it from there on its own
<vasild> but why unplug? it is a good opportunity to charge your laptop with 1000000 volts
<jonatack> heh :) but it would be good to avoid hitting the debug log that hard in those cases
<jonatack> to be more clear, the logging occurs on awakening the laptop until i restart i2prouter successfully
<vasild> and there are many many "Error accepting:" errors without "Error listening:" between them?
<jonatack> there are a few
<jonatack> lost in a sea of error accepting ones
<vasild> ok
<jonatack> error listening, followed by RemoveLocal
<jonatack> then AddLocal as bitcoind valiantly attempts to re-establish. i can send you a gist with some examples, if helpful, but the full logging during a minute or two is very long
<jonatack> sent privately
<jonatack> fwiw i wonder if we should rate limit i2p inbound connection acceptance
<bitcoin-git> [bitcoin] furszy opened pull request #28044: test: indexes, fix on error infinite loop (master...2023_test_fix_infinite_loop) https://github.com/bitcoin/bitcoin/pull/28044
<bitcoin-git> [bitcoin] furszy closed pull request #28026: test: bugfix, synchronize indexes synchronously (master...2023_fix_index_timeout) https://github.com/bitcoin/bitcoin/pull/28026
Chris_Stewart_5 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] dergoegge opened pull request #28045: rfc: Nuke getblocks message (master...2023-07-nuke-getblocks) https://github.com/bitcoin/bitcoin/pull/28045
<vasild> I wrote a reproducable unit test case for this. Now considering how to fix it...
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
ZeroMaster has quit [Ping timeout: 246 seconds]
ZeroMaster has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
martinus has joined #bitcoin-core-dev
ZeroMaster has quit [Read error: Connection reset by peer]
ZeroMaster has joined #bitcoin-core-dev
ZeroMaster has quit [Read error: Connection reset by peer]
<bitcoin-git> [bitcoin] dergoegge closed pull request #28045: rfc: Nuke getblocks message (master...2023-07-nuke-getblocks) https://github.com/bitcoin/bitcoin/pull/28045
ZeroMaster has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #28046: Rebased cmake-staging branch (post PR#15) (master...230707-linear) https://github.com/bitcoin/bitcoin/pull/28046
<bitcoin-git> [bitcoin] hebasto closed pull request #28046: Rebased cmake-staging branch (post PR#15) (master...230707-linear) https://github.com/bitcoin/bitcoin/pull/28046
<hebasto> sorry -- wrong repo
ZeroMaster has quit [Read error: Connection reset by peer]
ZeroMaster has joined #bitcoin-core-dev
ZeroMaster has quit [Ping timeout: 245 seconds]
<jonatack> vasild: nice!
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
bugs_ has joined #bitcoin-core-dev
b_101 has quit [Quit: Lost terminal]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
preimage has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
b_101 has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 246 seconds]
b_101 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/cf4da5ec29f9...87e19b047cf3
<bitcoin-git> bitcoin/master 1b64f64 furszy: wallet: migration bugfix, clone 'send' record label to all wallets
<bitcoin-git> bitcoin/master a277f83 furszy: wallet: migration bugfix, persist empty labels
<bitcoin-git> bitcoin/master 7ecc29a furszy: test: wallet, add coverage for addressbook migration
<bitcoin-git> [bitcoin] fanquake merged pull request #28038: wallet: address book migration bug fixes (master...2023_bugfix_addressbook_migration) https://github.com/bitcoin/bitcoin/pull/28038
ZeroMaster has joined #bitcoin-core-dev
ZeroMaster has quit [Remote host closed the connection]
ZeroMaster has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #28047: [25.x] Further backports for 25.1 (25.x...further_25_x_backports) https://github.com/bitcoin/bitcoin/pull/28047
pablomartin has quit [Ping timeout: 246 seconds]
ZeroMaster has quit [Read error: Connection reset by peer]
ZeroMaster has joined #bitcoin-core-dev
ZeroMaster has quit [Read error: Connection reset by peer]
pablomartin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky opened pull request #28048: kernel: Remove StartShutdown calls from validation code (master...pr/stopafter) https://github.com/bitcoin/bitcoin/pull/28048
<vasild> jonatack: a preliminary patch is at https://github.com/vasild/bitcoin/tree/i2p_accept_issue22759 it would be nice if you can check if it fixes the issue in real life conditions.
* vasild dinner...
<bitcoin-git> [bitcoin] hebasto closed pull request #25797: build: Add CMake-based build system (master...220807-cmake) https://github.com/bitcoin/bitcoin/pull/25797
<jonatack> vasild: thank you, will test
<bitcoin-git> [bitcoin] achow101 pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/87e19b047cf3...79e8247ddb16
<bitcoin-git> bitcoin/master 43369f3 Cory Fields: wallet: bdb: drop default parameter
<bitcoin-git> bitcoin/master 4216f69 Cory Fields: wallet: bdb: move TxnBegin to cpp file since it uses a bdb function
<bitcoin-git> bitcoin/master e5e5aa1 Cory Fields: wallet: bdb: move SpanFromDbt to below SafeDbt's implementation
<bitcoin-git> [bitcoin] achow101 merged pull request #28039: wallet: don't include bdb files from our headers (master...bdb-no-include-from-headers) https://github.com/bitcoin/bitcoin/pull/28039
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
Guest49 has joined #bitcoin-core-dev
Guest49 has quit [Client Quit]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 246 seconds]
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 246 seconds]
jarthur has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
<Murch> Heads-up: I’ve moved my GitHub account from Xekyo to Murchandamus.
p2plife- has quit [Ping timeout: 240 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_m_ has joined #bitcoin-core-dev
Jackielove4u has quit [Quit: Connection closed for inactivity]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 246 seconds]
<pinheadmz> Very professional. Personally, Im sticking with the hacker nick i came up with at age 16, forever
<preimage> lol
andrew_mo_ has quit [Ping timeout: 245 seconds]
preimage has quit [Quit: WeeChat 3.8]
<luke-jr> Murch: TIL you were Xekyo
<sipa> :D
<instagibbs> "Murch" claims he's "Murchandamus" now... very convenient
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] furszy opened pull request #28050: test: make assumeUTXO test capture the expected fatal error (master...2023_test_capture_assumeUTXO_fatal_error) https://github.com/bitcoin/bitcoin/pull/28050
Zorbak has joined #bitcoin-core-dev
Zorbak has quit [Client Quit]
Talkless has quit [Quit: Konversation terminated!]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
bugs_ has quit [Quit: Leaving]
AaronvanW has quit [Quit: Leaving...]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky opened pull request #28051: Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly (master...pr/noshut) https://github.com/bitcoin/bitcoin/pull/28051
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]