ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Ping timeout: 272 seconds]
AaronvanW has quit [Ping timeout: 250 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_m_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 272 seconds]
andrew_mo_ has quit [Ping timeout: 272 seconds]
Guest77 has joined #bitcoin-core-dev
Guest77 has quit [Client Quit]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 246 seconds]
andrew_m_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew___ has joined #bitcoin-core-dev
andrew_m_ has quit [Read error: Connection reset by peer]
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew___ has quit [Ping timeout: 264 seconds]
andrew_mo_ has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_m_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 240 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
AaronvanW has quit [Ping timeout: 240 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
andrew_mo_ has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
test_ has quit [Ping timeout: 246 seconds]
andrew_m_ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
cerealport has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 272 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_m_ has quit [Ping timeout: 245 seconds]
conman has joined #bitcoin-core-dev
achow101 has quit [Quit: Bye]
achow101 has joined #bitcoin-core-dev
cerealport has quit [Remote host closed the connection]
achow101 has quit [Client Quit]
achow101 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
conman has quit [Remote host closed the connection]
conman has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
AaronvanW has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_m_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
da2ce7_ has quit [Quit: ZNC 1.8.2 - https://znc.in]
da2ce7 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
test__ has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 250 seconds]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has quit [Ping timeout: 264 seconds]
test__ has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke reopened pull request #28006: refactor: Open file in FileCommit (master...2306-fs-stuff-) https://github.com/bitcoin/bitcoin/pull/28006
andrew_mo_ has quit [Ping timeout: 246 seconds]
<MacroFake> #proposedmeetingtopic Not sure if I'll make it to the meeting, but if not, can someone pls add #28070 to hi-prio ad-hoc? (It's a (tiny) bugfix and (tiny) blocker)
<gribble> https://github.com/bitcoin/bitcoin/issues/28070 | test: Drop 22.x node from TxindexCompatibilityTest by MarcoFalke · Pull Request #28070 · bitcoin/bitcoin · GitHub
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
<vasild> added
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 258 seconds]
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
salvatoshi has quit [Remote host closed the connection]
andrew_mo_ has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] hebasto closed pull request #26504: Add `UNREACHABLE` macro (master...221115-enum) https://github.com/bitcoin/bitcoin/pull/26504
andrew_mo_ has joined #bitcoin-core-dev
AmishBTC has quit [Remote host closed the connection]
AmishBTC has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
AaronvanW has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/5608e1d3b4ba...04afe55e2900
<bitcoin-git> bitcoin/master 7d83502 Andrew Chow: bumpfee: Allow original change position to be specified
<bitcoin-git> bitcoin/master 4f4d440 Andrew Chow: test: Test bumpfee reduce_output
<bitcoin-git> bitcoin/master e8c31f1 Andrew Chow: tests: Test for bumping single output transaction
<bitcoin-git> [bitcoin] fanquake merged pull request #26467: bumpfee: Allow the user to choose which output is change (master...bumpfee-choose-change-txout) https://github.com/bitcoin/bitcoin/pull/26467
andrew_mo_ has quit [Ping timeout: 245 seconds]
salvatoshi has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/04afe55e2900...355bbcba01e1
<bitcoin-git> bitcoin/master fa1471e MarcoFalke: refactor: Remove duplicate allNetMessageTypesVec
<bitcoin-git> bitcoin/master fa6245d MarcoFalke: fuzz: Generate process_message targets individually
<bitcoin-git> bitcoin/master 355bbcb fanquake: Merge bitcoin/bitcoin#28066: fuzz: Generate process_message targets indivi...
<bitcoin-git> [bitcoin] fanquake merged pull request #28066: fuzz: Generate process_message targets individually (master...2307-fuzz-p2p-msg-) https://github.com/bitcoin/bitcoin/pull/28066
flooded has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
AaronvanW has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 258 seconds]
<bitcoin-git> [bitcoin] fanquake opened pull request #28110: doc: correct Fedora systemtap dep (master...fedora_systemtap_install) https://github.com/bitcoin/bitcoin/pull/28110
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 258 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/355bbcba01e1...1fde20faf813
<bitcoin-git> bitcoin/master 8c38509 fanquake: contrib: move user32.dll from bitcoind.exe libs
<bitcoin-git> bitcoin/master 1fde20f fanquake: Merge bitcoin/bitcoin#28099: contrib: move user32.dll from bitcoind.exe li...
<bitcoin-git> [bitcoin] fanquake merged pull request #28099: contrib: move user32.dll from bitcoind.exe libs (master...user32_dll_qt_only) https://github.com/bitcoin/bitcoin/pull/28099
brunoerg has quit [Ping timeout: 258 seconds]
andrew_mo_ has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
test_ has quit [Ping timeout: 240 seconds]
jamesob50 has joined #bitcoin-core-dev
jamesob44368 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
cerealport has joined #bitcoin-core-dev
jamesob5 has quit [Ping timeout: 272 seconds]
jamesob4436 has quit [Ping timeout: 272 seconds]
jamesob50 is now known as jamesob5
jamesob44368 is now known as jamesob4436
brunoerg has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1fde20faf813...ac7c1772f9a0
<bitcoin-git> bitcoin/master c95a443 John Moffett: Show descriptive error messages when FileCommit fails
<bitcoin-git> bitcoin/master 5408a55 John Moffett: Consolidate Win32-specific error formatting
<bitcoin-git> bitcoin/master ac7c177 fanquake: Merge bitcoin/bitcoin#26654: util: Show descriptive error messages when Fi...
<bitcoin-git> [bitcoin] fanquake merged pull request #26654: util: Show descriptive error messages when FileCommit fails (master...2022_12_BetterSystemErrorLogging) https://github.com/bitcoin/bitcoin/pull/26654
andrew_mo_ has joined #bitcoin-core-dev
cerealport has quit [Remote host closed the connection]
bitdex has quit [Quit: = ""]
andrew_mo_ has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 246 seconds]
Guyver2 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] darosior opened pull request #28112: descriptor: do not parse from script unspendable Miniscript descriptors (master...miniscript_from_script_unspendable) https://github.com/bitcoin/bitcoin/pull/28112
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git> [bitcoin] darosior closed pull request #28112: descriptor: do not parse from script unspendable Miniscript descriptors (master...miniscript_from_script_unspendable) https://github.com/bitcoin/bitcoin/pull/28112
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
Guest80 has joined #bitcoin-core-dev
Guest80 has quit [Client Quit]
Bierchen has joined #bitcoin-core-dev
Bierchen has quit [Client Quit]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
abubakarsadiq has joined #bitcoin-core-dev
<jamesob5> meetin' time
<instagibbs> james the fifth
<achow101> #startmeeting
<glozow> hi
<achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild
<jamesob5> hi
<brunoerg> hi
<sipa> hi
<hebasto> hi
<stickies-v> hi
<lightlike> Hi
jamesob5 is now known as jamesob
<abubakarsadiq> hi
<darosior> hi
<furszy> hi
<TheCharlatan> hi
<kanzure> hi
<dergoegge> hi
<LarryRuane> hi
<achow101> #topic package relay updates (glozow)
<cfields> hi
<_aj_> hi
<glozow> I have updated #26711 with a new approach (linearization to help group txns, then submit ancestor subpackages, abort all if there are non-fee failures). No more O(n^2) validation. Though there's a CI failure I need to fix.
<gribble> https://github.com/bitcoin/bitcoin/issues/26711 | validate package transactions with their in-package ancestor sets by glozow · Pull Request #26711 · bitcoin/bitcoin · GitHub
<sipa> cool
andrew_mo_ has joined #bitcoin-core-dev
<Murch> hi
<achow101> #topic BIP 324 updates (sipa)
<josie> hi
<sipa> About to jump on subway, be back in a few min.
<achow101> lol ok
<achow101> #topic libbitcoinkernel updates (TheCharlatan)
<instagibbs> glozow can you drop some pseudo-code on the PR comment :)
<instagibbs> on the new algo
<TheCharlatan> no updates this week
<glozow> instagibbs: will do 👍 and will take out of draft after I make ci green
<achow101> TheCharlatan: #28048 was merged this week, so #27866 is priority now?
<gribble> https://github.com/bitcoin/bitcoin/issues/28048 | kernel: Remove StartShutdown calls from validation code by ryanofsky · Pull Request #28048 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/27866 | blockstorage: Return on fatal flush errors by TheCharlatan · Pull Request #27866 · bitcoin/bitcoin · GitHub
<TheCharlatan> Still need to rework that one
<bitcoin-git> [bitcoin] TheCharlatan opened pull request #28113: kernel: Remove UniValue from kernel library (master...kernelRmUnivalue) https://github.com/bitcoin/bitcoin/pull/28113
<achow101> ah ok
<stickies-v> I don't think we have any reviewable PRs atm then, right? given that #28051 needs rebase
<TheCharlatan> Take this one instead ^
<gribble> https://github.com/bitcoin/bitcoin/issues/28051 | Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly by ryanofsky · Pull Request #28051 · bitcoin/bitcoin · GitHub
andrew_mo_ has quit [Ping timeout: 245 seconds]
<stickies-v> (and also draft)
<josie> oh thank goodness. had to work with univalue this week and never want to touch it again
<luke-jr> lol
<ryanofsky> I'm happy to update 28051, but I think it is more of a code cleanup, and not directly related to kernel stuff
<achow101> updated the board
<achow101> #topic assumeutxo updates (jamesob)
<jamesob> same ol', waiting on review/merge of #27746 and then will rebase the big guy on top of resulting master
<luke-jr> extra space at the start there
<gribble> https://github.com/bitcoin/bitcoin/issues/27746 | Rework validation logic for assumeutxo by sdaftuar · Pull Request #27746 · bitcoin/bitcoin · GitHub
<achow101> 27746 is back on the top of my list since it just got rebased
<jamesob> hopefully after that's in, we can get some review/testing effort around the big guy and be done with this thing
<achow101> #topic BIP 324 updates take 2 (sipa)
<sipa> (am back)
<achow101> #27985 was merged, so #28008 is next, yes?
<gribble> https://github.com/bitcoin/bitcoin/issues/27985 | Add support for RFC8439 variant of ChaCha20 by sipa · Pull Request #27985 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/28008 | BIP324 ciphersuite by sipa · Pull Request #28008 · bitcoin/bitcoin · GitHub
<sipa> Yeah, dependencies for 28008 are in, so next one is 28008.
<jamesob> (as an aside, been reviewing 28008 for the last few days)
<sipa> Since we ended up converting a bunch of code to Spans/std::bytes in the process, I also opened #28100, though that's more a refactor, and could go in before or after 28008, or not at all.
<gribble> https://github.com/bitcoin/bitcoin/issues/28100 | crypto: more `Span ` modernization & follow-ups by sipa · Pull Request #28100 · bitcoin/bitcoin · GitHub
<sipa> I've been spending time thinking about next steps, which is the integration into net code, where I'm beginning to feel some restructuring of the code would be better too.
<achow101> cool
<sipa> In particular, currently all the packet checksumming happens inside the net_processing thread, while the packet checksum verification happens in the net thread. It'd be both cleaner, and I think more desirable from a resource allocation perspective, to do both in the net thread (which is generally low computationally).
<sipa> So I'm looking into seeing how big of a change that'd be, and if it's not too much, that's probably the next PR I'll open.
<achow101> looking forward to it
<achow101> #topic Ad-hoc high priority for review
<achow101> anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
<achow101> darosior: #27255 needs rebasing
<gribble> https://github.com/bitcoin/bitcoin/issues/27255 | MiniTapscript: port Miniscript to Tapscript by darosior · Pull Request #27255 · bitcoin/bitcoin · GitHub
<darosior> achow101: i'm on it
ExEric3 has quit [Remote host closed the connection]
ExEric3 has joined #bitcoin-core-dev
<sipa> I did start reviewing 27255, but want to get through a few more commits before posting.
<darosior> Cool!
<hebasto> achow101: mind adding #26762 for hi prio for me?
<gribble> https://github.com/bitcoin/bitcoin/issues/26762 | bugfix: Make `CCheckQueue` RAII-styled (attempt 2) by hebasto · Pull Request #26762 · bitcoin/bitcoin · GitHub
<achow101> hebasto: added
<hebasto> ty :)
<achow101> any other topics to dicsuss today?
<achow101> #endmeeting
andrew_mo_ has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ac7c1772f9a0...79954903b24a
<bitcoin-git> bitcoin/master bbbb89d Sebastian Falbesoner: test: miner: add coverage for `-blockmintxfee` setting
<bitcoin-git> bitcoin/master 7995490 fanquake: Merge bitcoin/bitcoin#27620: test: miner: add coverage for `-blockmintxfee...
<bitcoin-git> [bitcoin] fanquake merged pull request #27620: test: miner: add coverage for `-blockmintxfee` setting (master...202305-test-add_blockmintxfee_coverage) https://github.com/bitcoin/bitcoin/pull/27620
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/79954903b24a...7edce77ff372
<bitcoin-git> bitcoin/master 286e0c7 furszy: wallet: loading, log descriptor parsing error details
<bitcoin-git> bitcoin/master cc781a2 furszy: descriptor: InferScript, do not return top-level only func as sub descript...
<bitcoin-git> bitcoin/master dd9633b furszy: test: wallet, add coverage for watch-only raw sh script migration
<bitcoin-git> [bitcoin] achow101 merged pull request #28067: descriptors: do not return top-level only funcs as sub descriptors (master...2023_wallet_infer_watchonly_sh_script) https://github.com/bitcoin/bitcoin/pull/28067
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_mo_ has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
test__ has joined #bitcoin-core-dev
jamesob4436 has quit [Ping timeout: 246 seconds]
jamesob has quit [Ping timeout: 240 seconds]
flooded has quit [Ping timeout: 246 seconds]
flooded has joined #bitcoin-core-dev
jamesob4436 has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 245 seconds]
jamesob has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7edce77ff372...b3022af0e25a
<bitcoin-git> bitcoin/master e667bd6 Martin Zumsande: test: fix intermittent failure in wallet_resendwallettransactions.py
<bitcoin-git> bitcoin/master b3022af Andrew Chow: Merge bitcoin/bitcoin#28108: test: fix intermittent failure in wallet_rese...
<bitcoin-git> [bitcoin] achow101 merged pull request #28108: test: fix intermittent failure in wallet_resendwallettransactions.py (master...202307_resend_fix) https://github.com/bitcoin/bitcoin/pull/28108
test__ has quit [Ping timeout: 245 seconds]
Chris_St1 has quit [Ping timeout: 272 seconds]
Chris_St1 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
<bitcoin-git> bitcoin/master 12edf7b fanquake: doc: correct Fedora systemtap dep
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b3022af0e25a...e0c8294f2967
<bitcoin-git> bitcoin/master e0c8294 fanquake: Merge bitcoin/bitcoin#28110: doc: correct Fedora systemtap dep
<bitcoin-git> [bitcoin] fanquake merged pull request #28110: doc: correct Fedora systemtap dep (master...fedora_systemtap_install) https://github.com/bitcoin/bitcoin/pull/28110
bugs_ has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e0c8294f2967...d23fda05842b
<bitcoin-git> bitcoin/master fadc523 MarcoFalke: doc: Add doc comment to ci/test_imagefile
<bitcoin-git> bitcoin/master ffff4b5 MarcoFalke: lint: Add missing `set -ex` to ci/lint/06_script.sh
<bitcoin-git> bitcoin/master d23fda0 fanquake: Merge bitcoin/bitcoin#28103: test: Add missing `set -ex` to ci/lint/06_scr...
<bitcoin-git> [bitcoin] fanquake merged pull request #28103: test: Add missing `set -ex` to ci/lint/06_script.sh (master...2307-lint-ex-) https://github.com/bitcoin/bitcoin/pull/28103
andrew_mo_ has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
jamesob has quit [Quit: The Lounge - https://thelounge.chat]
jamesob4436 has quit [Quit: The Lounge - https://thelounge.chat]
andrew_mo_ has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
jamesob44368 has joined #bitcoin-core-dev
jamesob has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
Talkless has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
andrew_mo_ has quit [Ping timeout: 240 seconds]
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
andrew_mo_ has quit [Ping timeout: 245 seconds]
luke-jr has quit [Ping timeout: 252 seconds]
andrew_mo_ has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 272 seconds]
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
Dimosian has joined #bitcoin-core-dev
Dimosian has quit [Client Quit]
andrew_mo_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
bugs_ has quit [Quit: Leaving]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_m_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 264 seconds]
<hebasto> is there a "standard" way to ensure that SSE4 implementation of sha256 is being tested?
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_m_ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 240 seconds]
<hebasto> I mean, in `crypto_tests`
<sipa> you could disable the avx and sse4.1 detection in sha256.cpp
<sipa> the self test should take care of things then
<hebasto> thanks
<sipa> (and debug.log will report the sse4 implementation being used)
<sipa> it'd be good to have a test-only way to force a sha256 implementation
andrew_m_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 245 seconds]
<hebasto> re "it'd be good to have a test-only way to force a sha256 implementation" -- a similar solution for benchmarking suggested in #27598, btw
<gribble> https://github.com/bitcoin/bitcoin/issues/27598 | bench: Add SHA256 implementation specific benchmarks by hebasto · Pull Request #27598 · bitcoin/bitcoin · GitHub
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] jonatack opened pull request #28116: test: update tool_wallet coverage for unexpected writes to wallet (master...2023-07-tool-wallet-test-readonly-updates) https://github.com/bitcoin/bitcoin/pull/28116
Talkless has quit [Quit: Konversation terminated!]
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #28006: refactor: Open file in FileCommit (master...2306-fs-stuff-) https://github.com/bitcoin/bitcoin/pull/28006
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 240 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #28106: ci: Set DEBUG=1 for valgrind fuzz task (master...2307-ci-valgrind-DEBUG-) https://github.com/bitcoin/bitcoin/pull/28106
andrew_mo_ has quit [Ping timeout: 272 seconds]
___nick___ has quit [Ping timeout: 250 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Read error: Connection reset by peer]
andrew_mo_ has quit [Ping timeout: 272 seconds]
szkl has joined #bitcoin-core-dev
Chris_St1 has quit [Ping timeout: 246 seconds]
Chris_St1 has joined #bitcoin-core-dev
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
vysn has quit [Remote host closed the connection]
test_ is now known as _flood
Guest95 has joined #bitcoin-core-dev
Guest95 has quit [Client Quit]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 272 seconds]
andrew_mo_ has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 272 seconds]
brunoerg has quit [Ping timeout: 245 seconds]
flooded has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
_flood has quit [Ping timeout: 245 seconds]
luke-jr has quit [Ping timeout: 250 seconds]
b_101_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 272 seconds]
preimage has quit [Quit: WeeChat 4.0.2]
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]