ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
b_101_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
b_101 has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
b_101_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
upekkha has quit []
upekkha has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
b_101_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 244 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
vyHamii has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
jamesob3 has joined #bitcoin-core-dev
jamesob has quit [Ping timeout: 264 seconds]
jamesob3 is now known as jamesob
jamesob44368815 has joined #bitcoin-core-dev
jamesob4436881 has quit [Ping timeout: 258 seconds]
jamesob44368815 is now known as jamesob4436881
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
jamesob has quit [Quit: The Lounge - https://thelounge.chat]
jamesob4436881 has quit [Quit: The Lounge - https://thelounge.chat]
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Ping timeout: 244 seconds]
jamesob44368817 has joined #bitcoin-core-dev
jamesob has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 264 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_m_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 244 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
andrew_mo_ has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 244 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 264 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
gribble has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 264 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
conman has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has quit [Ping timeout: 244 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<PaperSword> Does .size() when called again and again get optimized away by the compiler? I am just wondering why not use a const if the length of the string doesn't change.
andrew_mo_ has quit [Ping timeout: 250 seconds]
bitdex has quit [Quit: = ""]
<PaperSword> example https://github.com/bitcoin/bitcoin/blob/f57e724a809feb139c5ae71c4db65635427e4802/src/bech32.cpp#L400 .size is called many times against the input argument.
<PaperSword> I do believe this was done with intention but was curious
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [*.net *.split]
cmirror has quit [*.net *.split]
vyHamii has quit [*.net *.split]
b_101_ has quit [*.net *.split]
upekkha has quit [*.net *.split]
AaronvanW has quit [*.net *.split]
jonatack2 has quit [*.net *.split]
jamesob44368817 has quit [*.net *.split]
jamesob has quit [*.net *.split]
Mercury has quit [*.net *.split]
puchka has quit [*.net *.split]
Zenton has quit [*.net *.split]
furszy has quit [*.net *.split]
windsok has quit [*.net *.split]
hebasto has quit [*.net *.split]
PaperSword has quit [*.net *.split]
schmidty has quit [*.net *.split]
willcl-ark has quit [*.net *.split]
javi404 has quit [*.net *.split]
angusp has quit [*.net *.split]
utzig has quit [*.net *.split]
murrayn has quit [*.net *.split]
tinova4 has quit [*.net *.split]
ajonas has quit [*.net *.split]
hardtotell has quit [*.net *.split]
Jackielove4u has quit [*.net *.split]
meshcollider has quit [*.net *.split]
andytoshi has quit [*.net *.split]
BlueMatt has quit [*.net *.split]
jarolrod_ has quit [*.net *.split]
berndj has quit [*.net *.split]
dlb76 has quit [*.net *.split]
dunxen has quit [*.net *.split]
jeremyrubin has quit [*.net *.split]
midnight has quit [*.net *.split]
Traca[m] has quit [*.net *.split]
stacie_ has quit [*.net *.split]
gribble has quit [*.net *.split]
mekster669493 has quit [*.net *.split]
warren has quit [*.net *.split]
meebey has quit [*.net *.split]
b10c_ has quit [*.net *.split]
ExEric3 has quit [*.net *.split]
instagibbs has quit [*.net *.split]
dongcarl has quit [*.net *.split]
theHeap has quit [*.net *.split]
aureleoules has quit [*.net *.split]
cold has quit [*.net *.split]
Murch has quit [*.net *.split]
sr_gi[m] has quit [*.net *.split]
ryanofsky has quit [*.net *.split]
core-meetingbot has quit [*.net *.split]
lowhope_ has quit [*.net *.split]
sturles has quit [*.net *.split]
vasild has quit [*.net *.split]
ghost43 has quit [*.net *.split]
SpellChecker has quit [*.net *.split]
qxs has quit [*.net *.split]
denise[m] has quit [*.net *.split]
virtu has quit [*.net *.split]
laanwj has quit [*.net *.split]
ishaanam[m] has quit [*.net *.split]
chaserene has quit [*.net *.split]
FelixWeis_ has quit [*.net *.split]
fjahr has quit [*.net *.split]
koolazer has quit [*.net *.split]
johnzweng has quit [*.net *.split]
pinheadmz[m] has quit [*.net *.split]
stickies-v has quit [*.net *.split]
sdaftuar has quit [*.net *.split]
luke-jr has quit [*.net *.split]
flooded has quit [*.net *.split]
TallTim has quit [*.net *.split]
Chris_Stewart_5 has quit [*.net *.split]
katsu_ has quit [*.net *.split]
TheRec has quit [*.net *.split]
earnestly has quit [*.net *.split]
Cory has quit [*.net *.split]
MatrixBot1234561 has quit [*.net *.split]
cornfeedhobo has quit [*.net *.split]
phantomcircuit has quit [*.net *.split]
ariard has quit [*.net *.split]
codo has quit [*.net *.split]
yancy has quit [*.net *.split]
gnusha has quit [*.net *.split]
Lightsword has quit [*.net *.split]
harding has quit [*.net *.split]
mxz has quit [*.net *.split]
nanotube has quit [*.net *.split]
bomb-on has quit [*.net *.split]
Flow has quit [*.net *.split]
Ara has quit [*.net *.split]
gwillen has quit [*.net *.split]
moneyball___ has quit [*.net *.split]
josibake____ has quit [*.net *.split]
dodo has quit [*.net *.split]
lightlike has quit [*.net *.split]
grubaroni has quit [*.net *.split]
dariusp has quit [*.net *.split]
MacroFake has quit [*.net *.split]
lightningbot has quit [*.net *.split]
face has quit [*.net *.split]
arik__ has quit [*.net *.split]
jonasschnelli has quit [*.net *.split]
jrayhawk has quit [*.net *.split]
josie has quit [*.net *.split]
hirish_ has quit [*.net *.split]
darosior has quit [*.net *.split]
sgiath has quit [*.net *.split]
theStack has quit [*.net *.split]
asoltys has quit [*.net *.split]
otoburb has quit [*.net *.split]
stevenroose has quit [*.net *.split]
neha has quit [*.net *.split]
qubenix has quit [*.net *.split]
rahl has quit [*.net *.split]
nickler has quit [*.net *.split]
jnewbery has quit [*.net *.split]
kanzure has quit [*.net *.split]
achow101 has quit [*.net *.split]
dergoegge has quit [*.net *.split]
w0xlt has quit [*.net *.split]
RubenSomsen has quit [*.net *.split]
S3RK has quit [*.net *.split]
glozow has quit [*.net *.split]
helo has quit [*.net *.split]
da2ce7 has quit [*.net *.split]
_aj_ has quit [*.net *.split]
sanket_cell has quit [*.net *.split]
realies has quit [*.net *.split]
jinxd has quit [*.net *.split]
adiabat_ has quit [*.net *.split]
roasbeef has quit [*.net *.split]
JTL has quit [*.net *.split]
cfields has quit [*.net *.split]
conman has quit [*.net *.split]
amiti_ has quit [*.net *.split]
BUSY has quit [*.net *.split]
jetpack has quit [*.net *.split]
infernix has quit [*.net *.split]
real_or_random has quit [*.net *.split]
baakeydow has quit [*.net *.split]
hugohn___ has quit [*.net *.split]
kouloumos has quit [*.net *.split]
sugarpuff has quit [*.net *.split]
EPiSKiNG- has quit [*.net *.split]
elichai2 has quit [*.net *.split]
jb55 has quit [*.net *.split]
Nebraskka has quit [*.net *.split]
emzy has quit [*.net *.split]
GoldmanSats_ has quit [*.net *.split]
kalle has quit [*.net *.split]
jesseposner has quit [*.net *.split]
fanquake has quit [*.net *.split]
sequences[m] has quit [*.net *.split]
stratospher[m] has quit [*.net *.split]
kakolainen[m] has quit [*.net *.split]
bitcoin-git has quit [*.net *.split]
sipa has quit [*.net *.split]
BlueMatt[m] has quit [*.net *.split]
kayabanerve[m] has quit [*.net *.split]
provoostenator has quit [*.net *.split]
vincenzopalazzo has quit [*.net *.split]
pinheadmz has quit [*.net *.split]
justache has quit [Max SendQ exceeded]
otoburb has joined #bitcoin-core-dev
neha has joined #bitcoin-core-dev
stevenroose has joined #bitcoin-core-dev
asoltys has joined #bitcoin-core-dev
qubenix has joined #bitcoin-core-dev
rahl has joined #bitcoin-core-dev
jnewbery has joined #bitcoin-core-dev
kanzure has joined #bitcoin-core-dev
nickler has joined #bitcoin-core-dev
dodo has joined #bitcoin-core-dev
dariusp has joined #bitcoin-core-dev
grubaroni has joined #bitcoin-core-dev
lightlike has joined #bitcoin-core-dev
MacroFake has joined #bitcoin-core-dev
lightningbot has joined #bitcoin-core-dev
arik__ has joined #bitcoin-core-dev
face has joined #bitcoin-core-dev
jonasschnelli has joined #bitcoin-core-dev
glozow has joined #bitcoin-core-dev
helo has joined #bitcoin-core-dev
josibake____ has joined #bitcoin-core-dev
S3RK has joined #bitcoin-core-dev
moneyball___ has joined #bitcoin-core-dev
RubenSomsen has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
theStack has joined #bitcoin-core-dev
dergoegge has joined #bitcoin-core-dev
Ara has joined #bitcoin-core-dev
gwillen has joined #bitcoin-core-dev
mxz has joined #bitcoin-core-dev
harding has joined #bitcoin-core-dev
gnusha has joined #bitcoin-core-dev
Lightsword has joined #bitcoin-core-dev
yancy has joined #bitcoin-core-dev
codo has joined #bitcoin-core-dev
ariard has joined #bitcoin-core-dev
phantomcircuit has joined #bitcoin-core-dev
sgiath has joined #bitcoin-core-dev
darosior has joined #bitcoin-core-dev
cornfeedhobo has joined #bitcoin-core-dev
MatrixBot1234561 has joined #bitcoin-core-dev
Flow has joined #bitcoin-core-dev
Cory has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
TheRec has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
hirish_ has joined #bitcoin-core-dev
katsu_ has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
sdaftuar has joined #bitcoin-core-dev
achow101 has joined #bitcoin-core-dev
josie has joined #bitcoin-core-dev
jrayhawk has joined #bitcoin-core-dev
TallTim has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
Chris_Stewart_5 has joined #bitcoin-core-dev
angusp has joined #bitcoin-core-dev
utzig has joined #bitcoin-core-dev
hebasto has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
windsok has joined #bitcoin-core-dev
furszy has joined #bitcoin-core-dev
Zenton has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
Mercury has joined #bitcoin-core-dev
jamesob44368817 has joined #bitcoin-core-dev
jamesob has joined #bitcoin-core-dev
berndj has joined #bitcoin-core-dev
jarolrod_ has joined #bitcoin-core-dev
dlb76 has joined #bitcoin-core-dev
BlueMatt has joined #bitcoin-core-dev
andytoshi has joined #bitcoin-core-dev
meshcollider has joined #bitcoin-core-dev
Jackielove4u has joined #bitcoin-core-dev
hardtotell has joined #bitcoin-core-dev
ajonas has joined #bitcoin-core-dev
sturles has joined #bitcoin-core-dev
lowhope has joined #bitcoin-core-dev
core-meetingbot has joined #bitcoin-core-dev
ryanofsky has joined #bitcoin-core-dev
tinova4 has joined #bitcoin-core-dev
javi404 has joined #bitcoin-core-dev
murrayn has joined #bitcoin-core-dev
willcl-ark has joined #bitcoin-core-dev
schmidty has joined #bitcoin-core-dev
aureleoules has joined #bitcoin-core-dev
theHeap has joined #bitcoin-core-dev
cold has joined #bitcoin-core-dev
instagibbs has joined #bitcoin-core-dev
ExEric3 has joined #bitcoin-core-dev
b10c_ has joined #bitcoin-core-dev
meebey has joined #bitcoin-core-dev
warren has joined #bitcoin-core-dev
mekster669493 has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
qxs has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
jetpack has joined #bitcoin-core-dev
stickies-v has joined #bitcoin-core-dev
johnzweng has joined #bitcoin-core-dev
koolazer has joined #bitcoin-core-dev
fjahr has joined #bitcoin-core-dev
FelixWeis_ has joined #bitcoin-core-dev
cfields has joined #bitcoin-core-dev
JTL has joined #bitcoin-core-dev
roasbeef has joined #bitcoin-core-dev
adiabat_ has joined #bitcoin-core-dev
jinxd has joined #bitcoin-core-dev
realies has joined #bitcoin-core-dev
sanket_cell has joined #bitcoin-core-dev
_aj_ has joined #bitcoin-core-dev
da2ce7 has joined #bitcoin-core-dev
pinheadmz has joined #bitcoin-core-dev
stacie_ has joined #bitcoin-core-dev
jeremyrubin has joined #bitcoin-core-dev
midnight has joined #bitcoin-core-dev
fanquake has joined #bitcoin-core-dev
jesseposner has joined #bitcoin-core-dev
kalle has joined #bitcoin-core-dev
GoldmanSats_ has joined #bitcoin-core-dev
emzy has joined #bitcoin-core-dev
Nebraskka has joined #bitcoin-core-dev
jb55 has joined #bitcoin-core-dev
elichai2 has joined #bitcoin-core-dev
EPiSKiNG- has joined #bitcoin-core-dev
sugarpuff has joined #bitcoin-core-dev
hugohn___ has joined #bitcoin-core-dev
kouloumos has joined #bitcoin-core-dev
baakeydow has joined #bitcoin-core-dev
real_or_random has joined #bitcoin-core-dev
BUSY has joined #bitcoin-core-dev
amiti_ has joined #bitcoin-core-dev
conman has joined #bitcoin-core-dev
jonatack2 has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
upekkha has joined #bitcoin-core-dev
b_101_ has joined #bitcoin-core-dev
vyHamii has joined #bitcoin-core-dev
cmirror has joined #bitcoin-core-dev
dongcarl has joined #bitcoin-core-dev
bw_ has quit [Max SendQ exceeded]
brunoerg has joined #bitcoin-core-dev
justache has joined #bitcoin-core-dev
bw_ has joined #bitcoin-core-dev
uasf has quit [Remote host closed the connection]
Murch has joined #bitcoin-core-dev
uasf has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
infernix has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
<PaperSword> 0x0000555555c7ac6b in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::size (this=<optimized out>) at /usr/include/c++/11/bits/basic_string.h:921
<PaperSword> 921 { return _M_string_length;
<PaperSword> GDB says it is not optimized out but the call itself just retrieves a private member of the string object?
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<vasild> PaperSword: I think the compiler may optimize it or may not, better not rely on it doing either
<vasild> it is true that the string variable is const and the size() method is const too, so maybe the compiler will optimize it, but again maybe one compiler will and another will not or also different versions of the same compiler may behave differently or with different compilation flags
<vasild> one thing is for sure - if you want it to be optimized/cached then do it explicitly by saving the return value of the function (size() in this case) into a local variable
<vasild> now, in this particular case size() is very fast becasue it only retrieves a local variable
<vasild> https://en.cppreference.com/w/cpp/string/basic_string/size: Complexity Constant (since C++11)
andrew_mo_ has quit [Ping timeout: 246 seconds]
<vasild> the only overhead is the function call itself which may as well be optimized if size() is inlined
<vasild> I guess the code was written with many calls to .size() because that is the easiest way and the overhead (if any) is very small % of the body of LocateErrors()
<vasild> it is not like the code is something like for (...) { x += str.size(); }
<vasild> I guess that if in LocateErrors() you call size() just once and put the result in a local variable and use that variable in all places, it will not make any difference in any benchmarks
andrew_mo_ has joined #bitcoin-core-dev
<PaperSword> I think your second point is correct. It it's still calling the function and retrieving the private member. Thanks for your input :D
andrew_mo_ has quit [Ping timeout: 246 seconds]
test_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 245 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 246 seconds]
qxs has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 246 seconds]
qxs has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
jespada has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
jespada has joined #bitcoin-core-dev
jespada has quit [Read error: Connection reset by peer]
jespada_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jespada_ has quit [Read error: Connection reset by peer]
jespada has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark opened pull request #28167: init: Add option for rpccookie permissions (replace 26088) (master...2023-07-rpccookie-perms) https://github.com/bitcoin/bitcoin/pull/28167
andrew_mo_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
Chris_Stewart_5 has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #28168: refactor: Remove unused raw-pointer read helper from univalue (master...2307-remove-code-) https://github.com/bitcoin/bitcoin/pull/28168
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f57e724a809f...04f66ce500b7
<bitcoin-git> bitcoin/master 08eb5f1 fanquake: ci: document that -Wreturn-type has been fixed upstream (Windows)
<bitcoin-git> bitcoin/master 04f66ce fanquake: Merge bitcoin/bitcoin#28092: ci: document that -Wreturn-type has been fixe...
<bitcoin-git> [bitcoin] fanquake merged pull request #28092: ci: document that -Wreturn-type has been fixed upstream (mingw-w64) (master...update_windows_return_type_docs) https://github.com/bitcoin/bitcoin/pull/28092
Chris_Stewart_5 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] ChrisCho-H opened pull request #28169: script: check op_verif and op_vernotif (master...script/check-op-verif) https://github.com/bitcoin/bitcoin/pull/28169
vyHamii has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Client Quit]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/04f66ce500b7...dfe2dc1d8443
<bitcoin-git> bitcoin/master 0fc3dee brunoerg: test: remove unecessary `decoderawtransaction` calls
<bitcoin-git> bitcoin/master 108c625 brunoerg: test: remove unused `totalOut` code
<bitcoin-git> bitcoin/master dfe2dc1 fanquake: Merge bitcoin/bitcoin#28164: test: remove unused code in `wallet_fundrawtr...
<bitcoin-git> [bitcoin] fanquake merged pull request #28164: test: remove unused code in `wallet_fundrawtransaction` (master...2023-07-fix-test-fundrawtransaction) https://github.com/bitcoin/bitcoin/pull/28164
katsu_ has quit [Quit: disconnected]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
AaronvanW has quit [Quit: Leaving...]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
katsu_ has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 240 seconds]
andrew_mo_ has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 240 seconds]
vasild has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
Guyver2 has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
jespada has quit [Ping timeout: 246 seconds]
jespada has joined #bitcoin-core-dev
<achow101> #startmeeting
denise[m] has joined #bitcoin-core-dev
ishaanam[m] has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
<achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild
<hebasto> hi
<TheCharlatan> hi
<darosior> hi
laanwj has joined #bitcoin-core-dev
<lightlike> Hi
<cfields> hi
<theStack> hi
<abubakarsadiq> hi
<glozow> hi
<achow101> #topic package relay updates (glozow)
<dergoegge> hi
Traca[m] has joined #bitcoin-core-dev
provoostenator has joined #bitcoin-core-dev
kakolainen[m] has joined #bitcoin-core-dev
sipa has joined #bitcoin-core-dev
vincenzopalazzo has joined #bitcoin-core-dev
<furszy> hi
stratospher[m] has joined #bitcoin-core-dev
kayabanerve[m] has joined #bitcoin-core-dev
<Murch> Hi
sr_gi[m] has joined #bitcoin-core-dev
sequences[m] has joined #bitcoin-core-dev
chaserene has joined #bitcoin-core-dev
pinheadmz[m] has joined #bitcoin-core-dev
virtu has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
<provoostenator> Hi
<glozow> Nothing new. Seeking approach feedback on #26711, still working on #28031 (I'm working on some refactors due to the need to synchronize with other tx download things).
<gribble> https://github.com/bitcoin/bitcoin/issues/26711 | validate package transactions with their in-package ancestor sets by glozow · Pull Request #26711 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/28031 | Package Relay 1/3: Introduce TxPackageTracker as Orphan Resolution Module by glozow · Pull Request #28031 · bitcoin/bitcoin · GitHub
<sipa> Hi.
<achow101> #topic libbitcoinkernel updates (TheCharlatan)
andrew_mo_ has joined #bitcoin-core-dev
<TheCharlatan> managed to get another kernel dep (univalue) removed this week, thank you reviewers :)
<achow101> TheCharlatan: what's the next pr?
<TheCharlatan> You can take #27866 again.
<provoostenator> Hi
<gribble> https://github.com/bitcoin/bitcoin/issues/27866 | blockstorage: Return on fatal flush errors by TheCharlatan · Pull Request #27866 · bitcoin/bitcoin · GitHub
<_aj_> zzz
<achow101> #topic assumeutxo updates (jamesob)
<achow101> #27746 has been getting review, still hoping to get that in soon
<gribble> https://github.com/bitcoin/bitcoin/issues/27746 | Rework validation logic for assumeutxo by sdaftuar · Pull Request #27746 · bitcoin/bitcoin · GitHub
<achow101> #topic BIP 324 updates (sipa)
preimage has joined #bitcoin-core-dev
<sipa> Hi, two PRs open currently.
<sipa> #28008, the BIP324 cipher suite has been making good progress in review.
<gribble> https://github.com/bitcoin/bitcoin/issues/28008 | BIP324 ciphersuite by sipa · Pull Request #28008 · bitcoin/bitcoin · GitHub
<sipa> The other one is some preparatory work with changes to the P2P net code, without any cryptography involved (if that perhaps scares off some reviewers).
<sipa> They do not depend on one another.
andrew_mo_ has quit [Ping timeout: 246 seconds]
<sipa> #28165
<gribble> https://github.com/bitcoin/bitcoin/issues/28165 | net: transport abstraction by sipa · Pull Request #28165 · bitcoin/bitcoin · GitHub
<sipa> I'm working on a follow-up that will depend on both of these, that adds the actual v2 transport code, which may offer a way to force (with a test-only option) actual BIP324 connections to test with.
<achow101> looking forward to that
<fanquake> nice
<sipa> That's it for me, unless there are any questions.
<achow101> #topic Ad-hoc high priority for review
<achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
<achow101> or any other topics to discuss?
<theStack> can i have #27432 added? still chasing concept acks
<gribble> https://github.com/bitcoin/bitcoin/issues/27432 | contrib: add tool to convert compact-serialized UTXO set to SQLite database by theStack · Pull Request #27432 · bitcoin/bitcoin · GitHub
<achow101> theStack: added
<theStack> thanks
<achow101> #endmeeting
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 246 seconds]
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 244 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
<bitcoin-git> [gui] fanquake closed pull request #744: Drop macOS ForceActivation workaround (master...drop_macos_force_workaround) https://github.com/bitcoin-core/gui/pull/744
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dfe2dc1d8443...272c4f3f1041
<bitcoin-git> bitcoin/master 5f41afc stickies-v: refactor: set ignore_incoming_txs in ApplyArgsManOptions
<bitcoin-git> bitcoin/master 8a31597 stickies-v: refactor: deduplicate ignores_incoming_txs
<bitcoin-git> bitcoin/master 272c4f3 Andrew Chow: Merge bitcoin/bitcoin#28148: refactor: consistently use ApplyArgsManOption...
<bitcoin-git> [bitcoin] achow101 merged pull request #28148: refactor: consistently use ApplyArgsManOptions for PeerManager::Options (master...2023-07/blocksonly-peerman-opts) https://github.com/bitcoin/bitcoin/pull/28148
<bitcoin-git> [bitcoin] furszy opened pull request #28170: net: adaptive connections services flags (master...2023_net_adaptable_desirable_flags) https://github.com/bitcoin/bitcoin/pull/28170
andrew_mo_ has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
ve0kea has joined #bitcoin-core-dev
ve0kea has quit [Quit: leaving]
<bitcoin-git> [bitcoin] pinheadmz opened pull request #28171: test: blockstore test with chattr instead of chmod (master...blockstore-tests-chattr) https://github.com/bitcoin/bitcoin/pull/28171
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
bugs_ has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
jamesob2 has joined #bitcoin-core-dev
jamesob443688173 has joined #bitcoin-core-dev
jamesob44368817 has quit [Ping timeout: 244 seconds]
jamesob has quit [Ping timeout: 244 seconds]
jamesob443688173 is now known as jamesob44368817
jamesob2 is now known as jamesob
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] hebasto closed pull request #27771: ci: Use docker image cache for "Win64 native [vs2022]" task (master...230528-docker-win) https://github.com/bitcoin/bitcoin/pull/27771
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 258 seconds]
andrew_m_ has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_m_ has quit [Ping timeout: 245 seconds]
Chris_Stewart_5 has quit [Ping timeout: 246 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_m_ has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/272c4f3f1041...cbf385058bd6
<bitcoin-git> bitcoin/master d60229e Antoine Poinsot: fuzz: make the parsed descriptor testing into a function
<bitcoin-git> bitcoin/master 90a2474 Antoine Poinsot: fuzz: add a new, more efficient, descriptor parsing target
<bitcoin-git> bitcoin/master 131314b Antoine Poinsot: fuzz: increase coverage of the descriptor targets
<bitcoin-git> [bitcoin] achow101 merged pull request #27888: Fuzz: a more efficient descriptor parsing target (master...efficient_desc_target) https://github.com/bitcoin/bitcoin/pull/27888
flooded has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]
test__ has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has quit [Ping timeout: 246 seconds]
flooded has quit [Ping timeout: 246 seconds]
mudsip has quit []
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 246 seconds]
jonatack2 has quit [Quit: WeeChat 3.8]
jonatack has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 240 seconds]
Guyver2_ has joined #bitcoin-core-dev
<jonatack> Advice on file location for univalue helpers to be included/called from both rpc/util and bitcoin-tx.cpp?
Guyver2 has quit [Ping timeout: 245 seconds]
Talkless has quit [Quit: Konversation terminated!]
Guyver2_ has left #bitcoin-core-dev [#bitcoin-core-dev]
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] jonatack opened pull request #28172: rpc, util: avoid string copies in ParseHash/ParseHex functions (master...2023-07-avoid-string-copies-in-ParseHex-functions) https://github.com/bitcoin/bitcoin/pull/28172
andrew_mo_ has quit [Ping timeout: 250 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 260 seconds]
luke-jr has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
b_101_ has quit [Ping timeout: 260 seconds]
flooded has joined #bitcoin-core-dev
test__ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Remote host closed the connection]
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #28173: ci: Run Windows native task on GitHub Actions (master...230727-actions) https://github.com/bitcoin/bitcoin/pull/28173
andrew_mo_ has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] aureleoules opened pull request #28174: docs: Rewrite README to make it more appealing (master...2023-07-update-readme) https://github.com/bitcoin/bitcoin/pull/28174
andrew_mo_ has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
brunoerg has quit []
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
preimage has quit [Quit: WeeChat 4.0.2]
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
jonatack has quit [Read error: Connection reset by peer]
jon_atack has joined #bitcoin-core-dev
vysn has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] luke-jr opened pull request #28175: CONTRIBUTING: Caution against using AI/LLMs (ChatGPT, Copilot, etc) (master...doc_no_ai) https://github.com/bitcoin/bitcoin/pull/28175
andrew_mo_ has joined #bitcoin-core-dev
luke-jr has quit [Remote host closed the connection]
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]