<PaperSword>
Question about bech32.cpp why is there no case in LocateErrors for conditions where there are multiple separators which technically can be thought of in many cases as an invalid base32 character.
<PaperSword>
and example is this 'bc1q.....1' would give the result "Invalid separator position" though technically the first separator is valid and the last 1 is just invalid bech32 character. Changes to the way this is handles could benefit the error decoding in key_io.cpp in a few cases.
<PaperSword>
Also the error saying invalid separator position where there are multiple separators is misleading as well since there are plural separators.
brunoerg has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
szkl has quit [Quit: Connection closed for inactivity]
<bitcoin-git>
[bitcoin] furszy opened pull request #28139: test: create wallet specific for test_locked_wallet case (master...2023_isolate_test_locked_wallet) https://github.com/bitcoin/bitcoin/pull/28139
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
Chris_Stewart_5 has quit [Ping timeout: 244 seconds]
preimage has joined #bitcoin-core-dev
Chris_Stewart_5 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Ping timeout: 250 seconds]
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 252 seconds]
vasild has joined #bitcoin-core-dev
b_101 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 245 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 264 seconds]
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 244 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Read error: Connection reset by peer]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 246 seconds]
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Read error: Connection reset by peer]
bugs_ has joined #bitcoin-core-dev
andrew_m_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 246 seconds]
b_101 has joined #bitcoin-core-dev
b_101_ has joined #bitcoin-core-dev
b_101 has quit [Ping timeout: 250 seconds]
warren has quit [Quit: QUIT]
warren has joined #bitcoin-core-dev
andrew_m_ has quit [Remote host closed the connection]
b_101 has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
b_101_ has quit [Ping timeout: 250 seconds]
andrew_mo_ has quit [Ping timeout: 260 seconds]
vysn has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
Chris_Stewart_5 has joined #bitcoin-core-dev
jonatack has quit [Quit: WeeChat 3.8]
mudsip has joined #bitcoin-core-dev
mudsip has quit []
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_m_ has quit [Ping timeout: 258 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
mudsip has joined #bitcoin-core-dev
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Remote host closed the connection]
Talkless has quit [Quit: Konversation terminated!]
andrew_mo_ has quit [Remote host closed the connection]
andrew_mo_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 244 seconds]
andrew_m_ has quit [Ping timeout: 244 seconds]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 260 seconds]
andrew_mo_ has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
andrew_m_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 250 seconds]
flooded has quit [Ping timeout: 245 seconds]
andrew_m_ has quit [Ping timeout: 260 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
bugs_ has quit [Quit: Leaving]
andrew_mo_ has joined #bitcoin-core-dev
andrew_mo_ has quit [Ping timeout: 245 seconds]
andrew_mo_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 opened pull request #28142: wallet: Allow users to create a wallet that encrypts all database records (master...encrypt-watch-only) https://github.com/bitcoin/bitcoin/pull/28142
andrew_mo_ has quit [Remote host closed the connection]