ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
benwestgate has quit [Quit: Leaving.]
benwestgate has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]
benwestgate has quit [Quit: Leaving.]
benwestgate has joined #bitcoin-core-dev
benwestgate has quit [Quit: Leaving.]
vyHamii has joined #bitcoin-core-dev
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
benwestgate has joined #bitcoin-core-dev
brunoerg has quit []
emzy has joined #bitcoin-core-dev
benwestgate has quit [Quit: Leaving.]
Guest5 has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 258 seconds]
Guest5 has quit [Quit: Client closed]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
vysn has joined #bitcoin-core-dev
jetpack has quit [Server closed connection]
jetpack has joined #bitcoin-core-dev
dermoth has quit [Ping timeout: 248 seconds]
AaronvanW has quit [Quit: Leaving...]
AaronvanW has joined #bitcoin-core-dev
dermoth has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
da2ce7 has quit [Ping timeout: 250 seconds]
infernix has quit [Server closed connection]
da2ce7 has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 255 seconds]
javi404 has quit [Ping timeout: 248 seconds]
javi404 has joined #bitcoin-core-dev
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
justache has quit [Server closed connection]
justache has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
infernix has joined #bitcoin-core-dev
javi404 has quit [Ping timeout: 258 seconds]
javi404 has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
vincenzopalazzo has joined #bitcoin-core-dev
vincenzopalazzo has quit [Remote host closed the connection]
abubakarsadiq has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 255 seconds]
Guest32 has joined #bitcoin-core-dev
Guest32 has quit [Client Quit]
benwestgate has joined #bitcoin-core-dev
emzy has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
Guyver2 has left #bitcoin-core-dev [Closing Window]
vyHamii has quit [Remote host closed the connection]
emzy has joined #bitcoin-core-dev
DarrylTheFiish has joined #bitcoin-core-dev
DarrylTheFish has quit [Ping timeout: 246 seconds]
DarrylTheFiiish has joined #bitcoin-core-dev
DarrylTheFiish has quit [Ping timeout: 255 seconds]
benwestgate has quit [Quit: Leaving.]
DarrylTheFiish has joined #bitcoin-core-dev
DarrylTheFiiish has quit [Ping timeout: 246 seconds]
lowhope_ has quit [Server closed connection]
lowhope_ has joined #bitcoin-core-dev
benwestgate has joined #bitcoin-core-dev
DarrylTheFiiish has joined #bitcoin-core-dev
BlueMatt has quit [Server closed connection]
BlueMatt has joined #bitcoin-core-dev
DarrylTheFiish has quit [Ping timeout: 255 seconds]
da2ce7 has quit [Ping timeout: 246 seconds]
bitdex has quit [Quit: = ""]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 240 seconds]
SebastianvStaa6 has joined #bitcoin-core-dev
<glozow> hi
<TheCharlatan> hi
puchka has quit [Ping timeout: 258 seconds]
<jamesob> hi
<glozow> #startmeeting
<stickies-v> hi
<glozow> achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild
<gleb> hi
<hebasto> hi
<glozow> Don't see any pre-proposed meeting topics this week. Any last minute topics?
<lightlike> hi
<theStack> hi
<furszy> hi
<cfields> hi
<glozow> #topic package relay updates
<glozow> logging PR got merged (yay). #28251 is the PR open for review
<gribble> https://github.com/bitcoin/bitcoin/issues/28251 | validation: fix coins disappearing mid-package evaluation by glozow · Pull Request #28251 · bitcoin/bitcoin · GitHub
<glozow> #topic BIP 324 updates (sipa)
<glozow> oop. is sipa here?
<instagibbs> #28196 looks to be moving along nicely
<gribble> https://github.com/bitcoin/bitcoin/issues/28196 | BIP324 connection support by sipa · Pull Request #28196 · bitcoin/bitcoin · GitHub
<glozow> indeed!
<sipa> hi
<sipa> lightlike summoned me
<sipa> things are going well, we're close with 28196 i think
<sipa> after that my plan is to add more tests to #28331 and undraft it
<gribble> https://github.com/bitcoin/bitcoin/issues/28331 | BIP324 integration by sipa · Pull Request #28331 · bitcoin/bitcoin · GitHub
SebastianvStaa has joined #bitcoin-core-dev
<glozow> awesome!
<sipa> to make it default-on (which 28331 does not yet do), i think we'll want more functional tests than i expect will be included in 28331, including those from #24748
<gribble> https://github.com/bitcoin/bitcoin/issues/24748 | test/BIP324: functional tests for v2 P2P encryption by stratospher · Pull Request #24748 · bitcoin/bitcoin · GitHub
<sipa> happy to answer any questions, but that's it from me
puchka has joined #bitcoin-core-dev
<glozow> #topic libbitcoinkernel updates (TheCharlatan)
<instagibbs> feature freeze oct 1
<TheCharlatan> Opened #28423 to remove protocol.h, netaddress.h and compat.h from the list of headers that need to be included in order to use the kernel library.
<gribble> https://github.com/bitcoin/bitcoin/issues/28423 | kernel: Remove protocol.h/netaddress.h/compat.h from kernel headers by TheCharlatan · Pull Request #28423 · bitcoin/bitcoin · GitHub
<TheCharlatan> Since #27866 looks like it is close to being ready for merge, I'd like to make #28051 the new priority PR.
<gribble> https://github.com/bitcoin/bitcoin/issues/27866 | blockstorage: Return on fatal flush errors by TheCharlatan · Pull Request #27866 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/28051 | Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly by ryanofsky · Pull Request #28051 · bitcoin/bitcoin · GitHub
<TheCharlatan> There are a number of other ready for review PRs though, they can be found on the project board: https://github.com/orgs/bitcoin/projects/3
SebastianvStaa6 has quit [Ping timeout: 258 seconds]
<TheCharlatan> that's it
<glozow> replaced 27866 with 28051 in the board
<ryanofsky> I'm working on splitting up 28051 to make it easier to review
<TheCharlatan> ah, in that case, let's go with #28385
<gribble> https://github.com/bitcoin/bitcoin/issues/28385 | [refactor] rewrite DisconnectedBlockTransactions to not use boost by glozow · Pull Request #28385 · bitcoin/bitcoin · GitHub
<glozow> :O
puchka has quit [Ping timeout: 255 seconds]
<glozow> ok
<glozow> I will fix CI asap
<glozow> #topic assumeutxo updates (jamesob)
<jamesob> Review on #27596 is going well - reviewers are into the later commits (mostly RPC/test code), and the outstanding feedback is pretty minor. Per usual ryanofsky has given very good feedback. I plan on addressing that today and writing some release notes for the `loadtxoutset` RPC command, which will essentially tell people how to use assumeutxo. The
<jamesob> change has been tested by a few in substance for awhile, so I'm hoping we're close.
<gribble> https://github.com/bitcoin/bitcoin/issues/27596 | assumeutxo (2) by jamesob · Pull Request #27596 · bitcoin/bitcoin · GitHub
<glozow> should I add #27596 as the primary blocker PR?
<gribble> https://github.com/bitcoin/bitcoin/issues/27596 | assumeutxo (2) by jamesob · Pull Request #27596 · bitcoin/bitcoin · GitHub
<jamesob> sure
<glozow> #topic ad hoc high priority for review
<glozow> anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4?
<glozow> ok sounds like no
<glozow> as instagibbs pointed out, we have feature freeze on oct 1
<glozow> #endmeeting
<luke-jr> btw if anyone has experience with Lightning and looking for work: https://luke.dashjr.org/jobs/202309-Lightning-job-description.html
brunoerg has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
<sipa> MacroFake: any idea why DrahtBot repeatedly requests and unrequests reviews from vincenzopalazzo on #28196 ?
<gribble> https://github.com/bitcoin/bitcoin/issues/28196 | BIP324 connection support by sipa · Pull Request #28196 · bitcoin/bitcoin · GitHub
adiabat_ has quit [Server closed connection]
adiabat_ has joined #bitcoin-core-dev
SebastianvStaa has quit [Quit: Connection closed]
da2ce7 has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
pablomartin is now known as pablomartin4btc
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 246 seconds]
brunoerg has quit [Remote host closed the connection]
test__ has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 240 seconds]
salvatoshi has quit [Ping timeout: 245 seconds]
pablomartin4btc has quit [Ping timeout: 245 seconds]
dberkelmans has joined #bitcoin-core-dev
yancy has quit [Server closed connection]
yancy has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
dberkelmans has quit [Quit: Client closed]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<jon_atack> MacroFake: what are the criteria for DrahtBot to request PR re-reviews? I see it happening for quite a few PRs, but not for other PRs.
<jon_atack> High prio #27231 has seen a lot of review and may be ready for merge.
<gribble> https://github.com/bitcoin/bitcoin/issues/27231 | Fix logging RPC and -debugexclude with 0/none values, add test coverage, improve docs by jonatack · Pull Request #27231 · bitcoin/bitcoin · GitHub
<jon_atack> Once merged, I'd like to replace it with #28248 on the high prio board.
<gribble> https://github.com/bitcoin/bitcoin/issues/28248 | p2p: bugfixes, logic and logging improvements by jonatack · Pull Request #28248 · bitcoin/bitcoin · GitHub
<jon_atack> Anyone interested in p2p peer connection behavior may find that one interesting.
Nekorand has joined #bitcoin-core-dev
boris- has joined #bitcoin-core-dev
boris has quit [Ping timeout: 240 seconds]
jamesob has quit [Ping timeout: 260 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
test__ has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<_aj_> umm, why is https://github.com/bitcoin/bitcoin/pull/26567/commits/9b7ec393b82ca9d7ada77d06e0835df0386a8b85 trying to do witness calculations over a CTxOut?
<_aj_> yeah
<_aj_> the two GetSerializeSize()'s will just return the same value always
pablomartin has joined #bitcoin-core-dev
<instagibbs> 4-1+1, what's not to like
<instagibbs> :P
<_aj_> it made my patchset dropping SERIALIZE_TRNSACTION_NO_WITNESS fail on rebase :P
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
pablomartin is now known as pablomartinbtc
salvatoshi has joined #bitcoin-core-dev
salvatoshi has quit [Client Quit]
<cfields> _aj_: nice, you converting CTransaction and friends to use SerParams ?
brunoerg has quit [Remote host closed the connection]
bugs_ has quit [Quit: Leaving]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit []
<cfields> nice
<cfields> _aj_: you've probably noticed, but CKeyPool can use a dummy version as well.
<cfields> I didn't include it in the current PR because that wasn't enough for me to finish whatever I was doing as the walletdb stuff still had to deal with SERIALIZE_TRNSACTION_NO_WITNESS.
Guest49 has joined #bitcoin-core-dev
Guest49 has left #bitcoin-core-dev [#bitcoin-core-dev]
Toordog has joined #bitcoin-core-dev
<Toordog> What is the proper way to initiate a discussion about an improvement idea and validate or invalidate the idea with code knowledgeable people?
pablomartinbtc has quit [Remote host closed the connection]
pablomartinbtc has joined #bitcoin-core-dev
pablomartin4btc has joined #bitcoin-core-dev
pablomartinbtc has quit [Ping timeout: 258 seconds]
EPiSKiNG- has quit [Server closed connection]
EPiSKiNG- has joined #bitcoin-core-dev
jon_atack has quit [Quit: WeeChat 3.8]
test_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 258 seconds]
Nekorand has quit [Ping timeout: 246 seconds]
pablomartin4btc has quit [Remote host closed the connection]
pablomartin4btc has joined #bitcoin-core-dev
pablomartin4btc has quit [Ping timeout: 255 seconds]
<_aj_> cfields: didn't notice - haven't looked at the version stuff yet
unlost has quit [K-Lined]
cm_ has joined #bitcoin-core-dev
cm has quit [Ping timeout: 258 seconds]
cm_ is now known as cm
test__ has joined #bitcoin-core-dev
test_ has quit [Remote host closed the connection]
Toordog has quit [Quit: Client closed]