<achow101>
we could plausibly get it all in before feature freeze. that'd be cool
<josie>
when is the feature freeze?
<sipa>
my thinking is getting 28331 in, default off, then increase testing (like through 24748, and whatever else people think of), and then later enable v2transport by default
<achow101>
josie: oct 1
preimage has joined #bitcoin-core-dev
<instagibbs>
sipa would be great to get that in for 26
freesprung has quit [Quit: Ping timeout (120 seconds)]
<jamesob>
lots of good feedback from ryanofsky which I'll be addressing in the next day or two (in the middle of working on an OP_VAULT demo...). But I think things are looking pretty good, pretty close?
freesprung has joined #bitcoin-core-dev
<achow101>
review has been happening, looking close
<instagibbs>
\o/
<jamesob>
Russ' comments were good, but don't change the fundamental approach of anything, so I think we're in good shape. The substance of that PR's approach has gone unchanged for a while.
<achow101>
cool, hopefully we can also get that in before feature freeze
<jamesob>
I'm not going to be at the upcoming coredev (on babywatch!) so Russ will be presenting on the state of the project in my absence
<vincenzopalazzo>
hi
<jamesob>
but hopefully by then or not too shortly after we'll have phase 1 in the bag...
<Murch>
Not sure it needs to be on High Priority, but I’d love to get another look from anyone with a concept ACK or the issuers of the stale ACKs if they want to chime in before the merge :)
<achow101>
Murch: will look. fanquake: added
<Murch>
Thanks!
<pinheadmz>
#27850 also just adds test, been through a lot, finally got ACKs
<achow101>
Murch: I promise we can have that discussion at coredev
<josie>
Murch: spicy
<Murch>
furszy and I have already been warming up debate points ;)
<achow101>
#endmeeting
<glozow>
Are we cancelling next week's irc meeting btw?
<luke-jr>
🌊
<achow101>
glozow: that's probably a good idea
<josie>
+1 for cancelling
<sipa>
yeah
<glozow>
👍
<vincenzopalazzo>
I had a stupind question, there is any way to enable a description imported with `importdescriptors`?
<achow101>
vincenzopalazzo: what do you mean by enable?
<furszy>
active descriptor?
<furszy>
murch: :).
<vincenzopalazzo>
achow101, good question, I am debugging the `Transaction needs a change address, but we can't generate it. Error: No bech32 addresses available` and I found that the descriptor is disabled
<achow101>
vincenzopalazzo: we call those "active". reimport it with "active": true
<vincenzopalazzo>
Oh right sorry! I was just now grabbing the documentation
<furszy>
an also "internal": true
<vincenzopalazzo>
achow101, I am importing it as active: true
<furszy>
*and
<vincenzopalazzo>
furszy, yeah my code works as expected, but in one of my instances there is this problem where the descriptor is `inactive`
<achow101>
vincenzopalazzo: you also imported with "internal": true?
<achow101>
you can check all of that with listdescriptors
<vincenzopalazzo>
achow101, yeah my code works as expected and I am able to build the transaction in the correct way
<vincenzopalazzo>
BTW I will take a look at the core code to see what it is going on, I wanted just confirm that I was not missing information at the API level
<achow101>
unsure what the problem would be then, could be a bug, could also be a corrupted wallet somehow
<vincenzopalazzo>
I see, it is not too bad if I import always the same descriptor with the same configuration, or this can lead in a corrupted wallet?
<achow101>
it shouldn't corrupt
<vincenzopalazzo>
achow101, ok I will report what I will be able to find next week, thanks
<achow101>
are you sure the descriptor(s) produces bech32 addresses?
<vincenzopalazzo>
mh not sure how to check this? `"desc": "wpkh([ece41477/84'/1'/0']tpubDDUKjzMPGkrmBEUz576EyeNpfnaSnUtY2CrqXQ1QTmEnJ2P3xLJSpQJQecUKkRyDqNu8oHYzLhM2ZuucaceitdM6yoTvQ6VHAhXhkN7TC1w/1/*)#rt99q6tt"`
flooded has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 255 seconds]
<sipa>
yes, that should produce bech32 addresses
warren has quit [Server closed connection]
warren has joined #bitcoin-core-dev
real_or_random has quit [Read error: Connection reset by peer]
valwal has quit [Read error: Connection reset by peer]
dergoegge has quit [Read error: Connection reset by peer]
hugohn___ has quit [Read error: Connection reset by peer]
w0xlt has quit [Read error: Connection reset by peer]
glozow has quit [Read error: Connection reset by peer]
gleb has quit [Read error: Connection reset by peer]
arik__ has quit [Ping timeout: 245 seconds]
ajonas has quit [Ping timeout: 245 seconds]
larryruane_ has quit [Read error: Connection reset by peer]
stacie_ has quit [Read error: Connection reset by peer]
jesseposner has quit [Read error: Connection reset by peer]
fanquake has quit [Read error: Connection reset by peer]
FelixWeis_ has quit [Read error: Connection reset by peer]
dariusp has quit [Read error: Connection reset by peer]
coreyphillips has quit [Read error: Connection reset by peer]
jkczyz has quit [Read error: Connection reset by peer]
jarolrod___ has quit [Ping timeout: 246 seconds]
RubenSomsen has quit [Ping timeout: 246 seconds]
amiti_ has quit [Read error: Connection reset by peer]
sugarpuff has quit [Read error: Connection reset by peer]
bw_ has quit [Ping timeout: 248 seconds]
josibake____ has quit [Read error: Connection reset by peer]
moneyball___ has quit [Read error: Connection reset by peer]
hebasto has quit [Ping timeout: 252 seconds]
kouloumos has quit [Ping timeout: 245 seconds]
GoldmanSats_ has quit [Read error: Connection reset by peer]
abubakarsadiq has quit [Read error: Connection reset by peer]
rodarmor has quit [Read error: Connection reset by peer]
schmidty has quit [Read error: Connection reset by peer]
stickies-v has quit [Ping timeout: 258 seconds]
fjahr has quit [Ping timeout: 258 seconds]
valwal has joined #bitcoin-core-dev
fjahr_ has joined #bitcoin-core-dev
glozow has joined #bitcoin-core-dev
ajonas has joined #bitcoin-core-dev
elichai2 has quit [Ping timeout: 246 seconds]
FelixWeis_ has joined #bitcoin-core-dev
amiti_ has joined #bitcoin-core-dev
lightlike has quit [Ping timeout: 246 seconds]
moneyball___ has joined #bitcoin-core-dev
gleb has joined #bitcoin-core-dev
GoldmanSats_ has joined #bitcoin-core-dev
larryruane_ has joined #bitcoin-core-dev
lightlike has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
hugohn___ has joined #bitcoin-core-dev
dariusp has joined #bitcoin-core-dev
coreyphillips has joined #bitcoin-core-dev
RubenSomsen has joined #bitcoin-core-dev
arik__ has joined #bitcoin-core-dev
kouloumos has joined #bitcoin-core-dev
jesseposner has joined #bitcoin-core-dev
RubenSomsen has quit [Changing host]
RubenSomsen has joined #bitcoin-core-dev
real_or_random has joined #bitcoin-core-dev
josibake____ has joined #bitcoin-core-dev
benwestgate has joined #bitcoin-core-dev
fanquake has joined #bitcoin-core-dev
jarolrod___ has joined #bitcoin-core-dev
bw_ has joined #bitcoin-core-dev
jkczyz has joined #bitcoin-core-dev
hebasto has joined #bitcoin-core-dev
dergoegge has joined #bitcoin-core-dev
stacie_ has joined #bitcoin-core-dev
real_or_random has quit [Changing host]
jesseposner has quit [Changing host]
real_or_random has joined #bitcoin-core-dev
jesseposner has joined #bitcoin-core-dev
fanquake has quit [Changing host]
fanquake has joined #bitcoin-core-dev
stickies-v has joined #bitcoin-core-dev
elichai2 has joined #bitcoin-core-dev
sugarpuff has joined #bitcoin-core-dev
schmidty has joined #bitcoin-core-dev
rodarmor has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
<furszy>
vincenzopalazzo: I just imported it on a blank wallet, and created few change addresses with it without any problem (importdescriptors + getrawchangeaddress).
<vincenzopalazzo>
furszy, in fact my question is why my descriptor is disabled
<vincenzopalazzo>
as I mention I did not have any problem with other instances of core in my integration testing
preimage has quit [Ping timeout: 252 seconds]
<furszy>
maybe you imported two active descriptor with the same output type. One with an unlimited range vs the other one with a limited one?.
<furszy>
but.. thats just a far idea. Would be great if you can craft the step by step procedure to reproduce it.
<vincenzopalazzo>
furszy, I do not think that my import logic is wrong, because otherwise should be always wrong and not in just one instance
<vincenzopalazzo>
furszy, I will spend some time next week in debugging it and provide a patch if I will find somethings
<furszy>
👍
<fanquake>
Are all of our Cirrus jobs being insta-cancelled?
preimage has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
pablomartin4btc has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
jonatack has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
<jonatack>
MacroFake: thanks for the reply wrt Drahtbot's re-review ping criteria. Not sure it's working on some PRs, will continue observing.
nahuy16721 has joined #bitcoin-core-dev
nahuy16721 has quit [Client Quit]
vpizdu16721 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
Talkless has joined #bitcoin-core-dev
Murch has quit [Quit: Connection closed]
PaperSword has quit [Quit: PaperSword]
benwestgate1 has joined #bitcoin-core-dev
benwestgate has quit [Quit: Leaving.]
flooded has quit [Read error: Connection reset by peer]
benwestgate1 has quit [Client Quit]
<MacroFake>
Sure, if there is a (suspected) bug or shortcoming, please report it in the issue tracker
puchka has quit [Ping timeout: 245 seconds]
flooded has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
jamesob has quit [Server closed connection]
jamesob has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
vpizdu16721 has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
nanotube has quit [Server closed connection]
nanotube has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
aa has joined #bitcoin-core-dev
aa has quit [Excess Flood]
brunoerg has quit [Ping timeout: 255 seconds]
Talkless has quit [Quit: Konversation terminated!]