<bitcoin-git>
bitcoin/master faa2ad8 MarcoFalke: test: Add missing wait for version to be sent in add_outbound_p2p_connecti...
<bitcoin-git>
bitcoin/master c2da8c5 fanquake: Merge bitcoin/bitcoin#28822: test: Add missing wait for version to be sent...
<bitcoin-git>
[bitcoin] fanquake merged pull request #28822: test: Add missing wait for version to be sent in add_outbound_p2p_connection (master...2311-test-sync-ver-) https://github.com/bitcoin/bitcoin/pull/28822
brunoerg has joined #bitcoin-core-dev
qxs has quit [Ping timeout: 264 seconds]
qxs has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<bitcoin-git>
[bitcoin] fanquake opened pull request #28829: ci: win64 task does use boost:process (master...win64_does_boost_process) https://github.com/bitcoin/bitcoin/pull/28829
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
ghost43 has quit [Remote host closed the connection]
<RubenSomsen>
Actively taking review on BIP352 and responding to feedback. Biggest recent change is how labels are calculated. Every label is a completely independent 32-byte value now, could use more eyes on that change.
<darosior>
hi
<instagibbs>
RubenSomsen link to motivation on that change?
<RubenSomsen>
review on #25273 by achow101 remains the primary blocker
<gribble>
https://github.com/bitcoin/bitcoin/issues/25273 | wallet: Pass through transaction locktime and preset input sequences and scripts to CreateTransaction by achow101 · Pull Request #25273 · bitcoin/bitcoin · GitHub
<gleb>
I started reviewing the silent BIP, it's one of my top priorities now
<bitcoin-git>
[bitcoin] darosior opened pull request #28832: fuzz: rule-out too deep derivation paths in descriptor parsing targets (master...2311_fuzz_timeout_desc_parse) https://github.com/bitcoin/bitcoin/pull/28832
<glozow>
Thanks to the people who jumped to review the 26711 sub-PRs so readily - I really appreciate it!
<glozow>
There have been some offline discussions over the past couple days. IIUC we want to defer ancestor package evaluation until after cluster mempool when mempool will be much safer to work with.
<glozow>
Still need to solidify what the new plan is but I think we may aim to get v3 + 1-parent-1-child package relay done first, then cluster mempool, then the rest of package relay.
<instagibbs>
also orphan handling improvements, though those are strictly additive security for these purposes, right?
<achow101>
oh? that would push it back quite a while since cluster mempool is still early
<gleb>
glozow: will you add this info to the tracking issue?
<instagibbs>
achow101 idea would be we'd get 2-txn-package stuff out the door quickly, wait for cluster mempool for general ancestor packages
<glozow>
Yeah sorry, this is kind of stuff that was discussed in the last ~24 hours and still in the air so I haven't put up updates
<glozow>
instagibbs: I think it's basically useless without the orphanage updates
<glozow>
because of how easily churable orphanage is rn
<glozow>
churn-able*
<achow101>
hmm ok. looking forward to seeing the new plan
<achow101>
#topic Ad-hoc high priority for review
<core-meetingbot>
topic: Ad-hoc high priority for review
<maxedw>
Still a little bit of work to do on submitpackage. It was suggested to potentially for the PR Review club this Wednesday try to make the or a signet with high fees for a few hours to aid in testing.
<maxedw>
Looking for feedback on the document.
<maxedw>
After this meeting I will create an issue on github to track feedback.
<achow101>
maxedw: thanks for writing it up. skimmed through the doc and it looks good so far
puchka has quit [Ping timeout: 240 seconds]
<maxedw>
do you agree now is a good time for a tracking issue to discuss feedback?
<achow101>
I think feedback could go in the existing testing issue? #28718
<bitcoin-git>
[bitcoin] theStack opened pull request #28833: wallet: refactor: remove unused `SignatureData` instances in spkm's `FillPSBT` methods (master...202311-wallet-remove_unused_SignatureData_instances) https://github.com/bitcoin/bitcoin/pull/28833
bob_x1 has quit [Remote host closed the connection]
bob_x1 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
ibiko1 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
ibiko1 has quit [Ping timeout: 255 seconds]
bugs_ has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
puchka has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 255 seconds]
jonatack has quit [Ping timeout: 264 seconds]
preimage has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 252 seconds]
dermoth has quit [Ping timeout: 248 seconds]
dermoth has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
jimhash has joined #bitcoin-core-dev
jimhash has quit [Client Quit]
rar has joined #bitcoin-core-dev
rar has quit [Remote host closed the connection]
un2 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] sr-gi opened pull request #28834: net: Attempts to connect to all resolved addresses on `addnode` (master...addnode-tryall) https://github.com/bitcoin/bitcoin/pull/28834
un2 has quit [Remote host closed the connection]
salvatoshi has quit [Ping timeout: 255 seconds]
TheRec has quit [Read error: Connection reset by peer]
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
kevkevin has quit [Remote host closed the connection]
jonatack has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
preimage has quit [Ping timeout: 272 seconds]
benwestgate has quit [Quit: Leaving.]
brunoerg has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
tripleslash has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
dviola has quit [Quit: WeeChat 4.1.1]
tripleslash has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 258 seconds]
benwestgate has joined #bitcoin-core-dev
cgast72 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
kevkevin has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] pablomartin4btc opened pull request #28835: test: Check error details with assert_debug_log on the assumeutxo invalid hash dump - follow-up #28698 (master...test-assumeutxo-invalid-hash-dump-error-followup) https://github.com/bitcoin/bitcoin/pull/28835
brunoerg has joined #bitcoin-core-dev
cgast72 has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
ibiko1 has joined #bitcoin-core-dev
ibiko1 has quit [Ping timeout: 264 seconds]
test_ has joined #bitcoin-core-dev
test__ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 258 seconds]
vysn has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 264 seconds]
test__ has quit [Ping timeout: 240 seconds]
ryanofsky has quit [Server closed connection]
ryanofsky has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
preimage has quit [Quit: WeeChat 4.1.0]
bugs_ has quit [Quit: Leaving]
kevkevin has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]