brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
BeefyBoot_ has quit [Quit: Connection closed for inactivity]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
not_reserved has quit [Quit: Client closed]
jespada has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
zato has quit [Ping timeout: 255 seconds]
AaronvanW has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 259 seconds]
brunoerg has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git>
[bitcoin] fanquake opened pull request #28967: build: disable external-signer for Windows (master...disable_external_signer_win) https://github.com/bitcoin/bitcoin/pull/28967
kevkevin has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
bugs_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko opened pull request #28968: fuzz: Fix nullptr deref in scriptpubkeyman (master...2311-fuzz-wallet-null-deref-) https://github.com/bitcoin/bitcoin/pull/28968
AaronvanW has quit [Remote host closed the connection]
preimage has joined #bitcoin-core-dev
Guest57 has joined #bitcoin-core-dev
zato has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko opened pull request #28969: fuzz: Avoid signed-integer-overflow in wallet_notifications fuzz target (master...2311-wn-sio-) https://github.com/bitcoin/bitcoin/pull/28969
tested_ has quit [Remote host closed the connection]
tested__ has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 246 seconds]
dviola has quit [Quit: WeeChat 4.1.1]
Talkless has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
boris- has joined #bitcoin-core-dev
boris has quit [Ping timeout: 264 seconds]
AaronvanW has quit [Remote host closed the connection]
<sdaftuar>
glozow: i'm trying to think through the reorg behavior in #28948... noticed a couple things but not sure i know the best way to handle this situation.
<sdaftuar>
first observation is that calculating mempool ancestors for everything in the mempool when a reorg happens is almost certainly too large a performance hit for us to be taking... but i think we can do better anyway just be restricting the analysis to v3 transactions somehow
<sdaftuar>
however, i'm not sure exactly what we should do. imagine that a v3 transaction is reorged out of the chain and added back to the mempool, and that there are two v3 spends of that transaction in the mempool.
<sdaftuar>
are we supposed to randomly evict one of those two? evict both?
<sdaftuar>
i wonder if a better thing to do is just not worry about this situation, and do nothing if our v3 rules might be violated due to a reorg.
<instagibbs>
can you give the precise setup? parent P, C1 and C2 two children
<instagibbs>
(I don't think worrying about pins from re-orgs is that good use of time probably but would like to understand!)
<sdaftuar>
Sure, parent P is in a block, and C1 and C2 are two different v3 spends of different outputs of P, both in the mempool.
<sdaftuar>
P is reorged out and added back to the mempool.
<sdaftuar>
now it has 2 v3 descednants, C1 and C2. What if anything should we do? the PR currently tries to enforce the v3 rules still hold post-reorg.
<sdaftuar>
My inclination is to agree with you about not worrying about pins due to reorgs -- if a miner is going to try to prevent your transaction from confirming, you've got bigger problems than RBF pinning.
<sdaftuar>
if i understand correctly, i think the PR as currently drafted would evict both transactions C1 and C2, btw.
Guest52 has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
Guest52 has quit [Client Quit]
Guest16 has joined #bitcoin-core-dev
Guest16 has quit [Quit: Client closed]
<sdaftuar>
instagibbs: do we still want #27018 ("mine everythign in the mempool even if below blockmintxfee") if we are only evicting actual 0-fee transactions in #28948? (i think we do?)
<gribble>
https://github.com/bitcoin/bitcoin/issues/27018 | mempool / miner: regularly flush <=0-fee entries and mine everything in the mempool by glozow · Pull Request #27018 · bitcoin/bitcoin · GitHub
<instagibbs>
I think whatever we aren't trimming, we should mine
zato has quit [Quit: Om mani padme hum]
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
preimage has quit [Quit: WeeChat 4.1.1]
Guest45 has joined #bitcoin-core-dev
Guest45 has quit [Client Quit]
marcofleon has joined #bitcoin-core-dev
marcofleon has quit [Client Quit]
brunoerg has quit [Remote host closed the connection]
<glozow>
sdaftuar: instagibbs: i wonder if it helps to limit CMPA to 1 generation? it should be sufficient to detect v3 violations, though i’m not sure how much cheaper it is.
kevkevin has joined #bitcoin-core-dev
<instagibbs>
I think whatever we choose here will also result in how we handle ephemeral anchor txs in the same scenario
mudsip has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
brunoerg has quit [Ping timeout: 264 seconds]
kevkevin has quit [Remote host closed the connection]