<bitcoin-git>
bitcoin/master defdf67 muxator: contrib: use a raw string for a regular expression literal that contains b...
<bitcoin-git>
bitcoin/master 1430c4b fanquake: Merge bitcoin/bitcoin#28883: contrib: use a raw string for a regular expre...
<bitcoin-git>
[bitcoin] fanquake merged pull request #28883: contrib: use a raw string for a regular expression literal that contains backslashes in signet/miner (master...miner-use-raw-strings) https://github.com/bitcoin/bitcoin/pull/28883
<bitcoin-git>
[bitcoin] theStack opened pull request #28891: test: fix `AddNode` unit test failure on OpenBSD (master...202311-test-fix-net_peer_connection_tests-on-BSDs) https://github.com/bitcoin/bitcoin/pull/28891
<bitcoin-git>
[bitcoin] maflcko closed pull request #27815: CLI: Only one Request Handler can be specified. (master...cli_request_handlers) https://github.com/bitcoin/bitcoin/pull/27815
<achow101>
the most recent comment explains the current plan
<fjahr>
hi
<achow101>
the next pr for package relay is #28848
<gribble>
https://github.com/bitcoin/bitcoin/issues/28848 | bugfix, Change up submitpackage results to return results for all transactions by instagibbs · Pull Request #28848 · bitcoin/bitcoin · GitHub
<maxedw>
we did a run through of most of it at the pr review club yesterday
<maxedw>
it went well however we didn't have the highest attendance so any extra review from people here would be appreciated
<maxedw>
github issue has been created to track any feedback from here on and is linked at the top and bottom of the document
<sipa>
summoning ryanofsky
<achow101>
maxedw: have any issues been found yet?
<maxedw>
only with the guide itself
<achow101>
it seems like we could probably do the final release at this point
<achow101>
there hasn't been anything to backport to an rc3 either
<achow101>
Any other topics to discuss this week?
conman has quit [Ping timeout: 256 seconds]
<achow101>
#endmeeting
<maxedw>
thanks achow101
<bitcoin-git>
[bitcoin] maflcko opened pull request #28892: refactor: P2P transport without serialize version and type (master...2311-p2p-no-nVersion-) https://github.com/bitcoin/bitcoin/pull/28892
<bitcoin-git>
[bitcoin] furszy opened pull request #28894: wallet: batch all atomic spkms setup db writes in a single db txn (master...2023_wallet_batch_keypool_creation) https://github.com/bitcoin/bitcoin/pull/28894
Chris_Stewart_5 has quit [Read error: Connection reset by peer]
Chris_Stewart_5 has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
<cfields>
hi
<jon_atack>
achow101: a few issues found 3 months ago, hopefully pushing an update to #28248 with unit test coverage for each fix
Chris_Stewart_5 has quit [Ping timeout: 256 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
<cfields>
oh, heh, I'm an idiot. I kept waiting for the meeting to move on. I didn't realize I missed it by an hour heh.
<cfields>
Short one.
<cfields>
since I missed the meeting, cmake update anyway:
<cfields>
We're at our self-imposed deadline and it's simply not ready yet. It's only reasonable that we stick to the original plan of merging soon-after branching off, so we've decided to push back and aim for getting CMake merged shortly after branching off for v28 instead. That way we should have plenty of time to get CMake fully reviewed and tested, as opposed to shoving it in half-baked and buggy.
<cfields>
I'd like to make it very clear that hebasto has done an amazing job with keeping the work moving and staying up-to-date. He's also volunteered to keep doing so for another full release cycle. Pushing back a release is absolutely not a reflection on his work, rather, it's on me for not prioritizing review and keeping up. I'm very sorry that this will be dragging out further.
<cfields>
Thanks very much to everyone who has contributed to review so far. Nothing is changing about the review process, we just have a little more breathing room now :)
<hebasto>
lightlike: not sure if it is a release blocker, but it would be nice at least figure out the commit that changed resource usage
<sipa>
I vaguely remember another issue with arm OOM
<fanquake>
hebasto: have you been bisecting since you posted that comment
<hebasto>
nope
<sipa>
#28440
<gribble>
https://github.com/bitcoin/bitcoin/issues/28440 | Impossible to run bitcoin on a Raspberry Pi 4 with 8GB, on Raspian 64 bit, which ships a 32 bit version of Docker (ARMHF instead of ARM64) · Issue #28440 · bitcoin/bitcoin · GitHub
<fanquake>
Looks like that ended up being them messing with hardware power settings? Not sure why they were running bitcoind inside a docker container, on an rpi in the first place
<fanquake>
*and maybe also the wrong version of docker for their hardware?
<sipa>
fanquake: yes, lots of strange circumstances there, and rightfully closed i think
<sipa>
but it was the case that bitcoind *was* growing beyond what it was supposed to, with an arm7 binary
<hebasto>
my issue differs from 28440 as it happens without any containerizing
<achow101>
jon_atack: a pr that is both draft and needs rebase for the past week is not a good candidate for backporting soon
<jon_atack>
achow101: yes, it was clean and out of draft for a couple of months. i put it back into draft in order to add full unit test coverage for each fix. and working on that.
<achow101>
It's also not clear to me which/whether the bugs being fixed are regressions
<sipa>
hebasto: we don't know if 28440 wouldn't also happen without containerizing
<jon_atack>
the issue was reported in August
<jon_atack>
achow101: it is a regression, but in general that seems to be a new standard? aren't bug fixes worthwhile?
<jon_atack>
If the regression in v26.0 is left unfixed, it would be a good idea to add a warning to the "Notable Changes" section of the release notes where the changed behavior is described, as the way nodes have until now been able to ensure connections to various networks and particularly the ones with fewer peers, via addnode, is the behavior that is impacted.
<achow101>
generally for RCs we only fix regressions or showstpping bugs
<achow101>
not all bug fixes, that'd be too many and we'd just never get a release out
<achow101>
I don't think that's a new standard
<jon_atack>
Ok. All I can do is find bugs, propose fixes, and add tests. And in the worse case, suggest a warning in the release notes, and maybe make a source code patch release for impacted users.
<jon_atack>
Was also going to update the hardcoded seeds. I guess it's too late for that too.
<lightlike>
jon_atack: why don't you open a PR with just a minimal fix for the regression. It's so late in the release cycle that anything else (e.g. unit tests, refactors etc.) seem hard to get in still.
<achow101>
jon_atack: which "it"? the pr lists 7 things. are they all regressions?
<jon_atack>
lightlike: I understand/agree/empathize and can do that today if it's not too late.
<achow101>
essentially what I'm trying to figure out is what is the minimal set of changes that would fix the known regressions. the PR is currently 15 commits, and there have been no other reported issues in the rcs.
<lightlike>
jon_atack: I can't say that, but can review soon.
<jon_atack>
achow101: I've been working on a more minimal changeset of 5 fixes backed by unit tests. I think the CJDNS ones are uncontroversial and can wait, as very few people use that network at the present time.
BeefyBoot_ has joined #bitcoin-core-dev
<jon_atack>
achow101: lightlike: i can do a minimal patch in one commit, i.e. the original version of it without a data structure change from map to unordered set
<jon_atack>
i'll do that now
preimage has joined #bitcoin-core-dev
josie has quit [Read error: Connection reset by peer]
josie has joined #bitcoin-core-dev
<maflcko>
jon_atack: The hardcoded seeds update should happen before the branch-off, according to the documentation. branch-off happened several weeks ago, so this seems too late to start now and doesn't seem like a blocker in any case.
benwestgate has quit [Quit: Leaving.]
<jon_atack>
maflcko: thanks
bugs_ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #28895: p2p: do not make automatic outbound connections to addnode peers (master...2023-11-do-not-make-automatic-outbound-connection-to-addnode-peers) https://github.com/bitcoin/bitcoin/pull/28895
freesprung51 has quit [Ping timeout: 240 seconds]
freesprung51 has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 260 seconds]
jamesob has quit [Server closed connection]
jamesob has joined #bitcoin-core-dev
benwestgate has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
kashifs has quit [Ping timeout: 250 seconds]
mudsip has quit [Client Quit]
BeefyBoot_ has quit [Quit: Connection closed for inactivity]
puchka has quit [Ping timeout: 256 seconds]
Talkless has joined #bitcoin-core-dev
zato has joined #bitcoin-core-dev
b10c has quit [Server closed connection]
b10c has joined #bitcoin-core-dev
b10c has quit [Changing host]
b10c has joined #bitcoin-core-dev
asoltys has quit [Server closed connection]
asoltys has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
warren has quit [Server closed connection]
warren has joined #bitcoin-core-dev
conman has joined #bitcoin-core-dev
pablomartin has quit [Remote host closed the connection]
lowhope_ is now known as lowhope
vasild has quit [Remote host closed the connection]
bob_x1 has quit [Remote host closed the connection]
bob_x1 has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
bugs_ has quit [Quit: Leaving]
preimage has quit [Quit: WeeChat 4.1.1]
kashifs has joined #bitcoin-core-dev
zato has quit [Quit: Om mani padme hum]
BeefyBoot_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]