#bitcoin-core-dev on 2023-11-28 — searchable irc log

2023-05-25 14:25 ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt

00:00 kevkevin has quit [Ping timeout: 268 seconds]

00:10 achow101 has quit [Remote host closed the connection]

00:11 kevkevin has joined #bitcoin-core-dev

00:11 kevkevin has quit [Read error: Connection reset by peer]

00:11 kevkevin has joined #bitcoin-core-dev

00:13 kevkevin has quit [Remote host closed the connection]

00:14 kevkevin has joined #bitcoin-core-dev

00:14 kevkevin has quit [Remote host closed the connection]

00:15 kevkevin has joined #bitcoin-core-dev

00:18 kevkevin has quit [Remote host closed the connection]

00:19 kevkevin has joined #bitcoin-core-dev

00:21 kevkevin has quit [Remote host closed the connection]

00:22 kevkevin has joined #bitcoin-core-dev

00:24 kevkevin has quit [Remote host closed the connection]

00:24 pablomartin4btc has quit [Ping timeout: 256 seconds]

00:24 kevkevin has joined #bitcoin-core-dev

00:31 kevkevin has quit [Remote host closed the connection]

00:31 kevkevin has joined #bitcoin-core-dev

00:57 achow101 has joined #bitcoin-core-dev

01:04 brunoerg has quit [Remote host closed the connection]

01:04 brunoerg has joined #bitcoin-core-dev

01:05 kevkevin has quit [Remote host closed the connection]

01:05 kevkevin has joined #bitcoin-core-dev

01:09 brunoerg has quit [Ping timeout: 264 seconds]

01:17 brunoerg has joined #bitcoin-core-dev

01:25 kevkevin has quit [Remote host closed the connection]

01:26 kevkevin has joined #bitcoin-core-dev

01:37 <bitcoin-git> [bitcoin] theStack opened pull request #28951: fuzz: BIP324: damage ciphertext/aad in full byte range (master...202311-fuzz-bip324-damage_in_full_byte_range) https://github.com/bitcoin/bitcoin/pull/28951

01:46 jespada has quit [Ping timeout: 255 seconds]

01:47 willcl-ark has quit [Ping timeout: 255 seconds]

01:47 willcl-ark_ has joined #bitcoin-core-dev

01:50 jespada has joined #bitcoin-core-dev

02:15 kevkevin has quit [Remote host closed the connection]

02:32 kevkevin has joined #bitcoin-core-dev

02:37 vasild has quit [Remote host closed the connection]

02:37 vasild has joined #bitcoin-core-dev

03:05 not_reserved has joined #bitcoin-core-dev

03:07 not_reserved has quit [Client Quit]

03:07 not_reserved has joined #bitcoin-core-dev

03:29 kevkevin has quit [Remote host closed the connection]

03:34 vyHamii has joined #bitcoin-core-dev

03:47 kevkevin has joined #bitcoin-core-dev

03:53 vasild has quit [Remote host closed the connection]

03:53 vasild has joined #bitcoin-core-dev

04:05 kevkevin has quit [Remote host closed the connection]

04:24 brunoerg has quit [Remote host closed the connection]

04:25 brunoerg has joined #bitcoin-core-dev

04:30 brunoerg has quit [Ping timeout: 255 seconds]

04:47 brunoerg has joined #bitcoin-core-dev

04:52 brunoerg has quit [Ping timeout: 252 seconds]

04:53 brunoerg has joined #bitcoin-core-dev

04:56 bitdex has joined #bitcoin-core-dev

04:58 brunoerg has quit [Ping timeout: 268 seconds]

04:58 brunoerg has joined #bitcoin-core-dev

05:01 cmirror has quit [Remote host closed the connection]

05:01 cmirror has joined #bitcoin-core-dev

05:03 brunoerg has quit [Ping timeout: 264 seconds]

05:21 brunoerg has joined #bitcoin-core-dev

05:25 brunoerg has quit [Ping timeout: 256 seconds]

05:37 brunoerg has joined #bitcoin-core-dev

05:42 brunoerg has quit [Ping timeout: 268 seconds]

05:48 brunoerg has joined #bitcoin-core-dev

05:59 brunoerg has quit [Ping timeout: 268 seconds]

06:00 brunoerg has joined #bitcoin-core-dev

06:04 brunoerg has quit [Ping timeout: 260 seconds]

06:44 brunoerg has joined #bitcoin-core-dev

06:49 brunoerg has quit [Ping timeout: 268 seconds]

06:50 brunoerg has joined #bitcoin-core-dev

06:52 bitdex has quit [Remote host closed the connection]

06:53 bitdex has joined #bitcoin-core-dev

06:54 brunoerg has quit [Ping timeout: 245 seconds]

06:55 brunoerg has joined #bitcoin-core-dev

07:00 kevkevin has joined #bitcoin-core-dev

07:00 brunoerg has quit [Ping timeout: 240 seconds]

07:02 PaperSword has joined #bitcoin-core-dev

07:04 kevkevin has quit [Ping timeout: 256 seconds]

07:06 brunoerg has joined #bitcoin-core-dev

07:11 brunoerg has quit [Ping timeout: 260 seconds]

07:30 vyHamii has quit [Quit: Leaving]

07:35 brunoerg has joined #bitcoin-core-dev

07:45 brunoerg has quit [Ping timeout: 264 seconds]

08:08 brunoerg has joined #bitcoin-core-dev

08:09 kevkevin has joined #bitcoin-core-dev

08:13 brunoerg has quit [Ping timeout: 268 seconds]

08:14 kevkevin has quit [Ping timeout: 268 seconds]

08:51 salvatoshi has joined #bitcoin-core-dev

09:01 gerle has joined #bitcoin-core-dev

09:03 <bitcoin-git> [bitcoin] maflcko opened pull request #28952: fuzz: Avoid timeout in process_messages (master...2311-fuzz-p2p-timeout-) https://github.com/bitcoin/bitcoin/pull/28952

09:10 kevkevin has joined #bitcoin-core-dev

09:15 kevkevin has quit [Ping timeout: 260 seconds]

09:37 not_reserved has quit [Quit: Client closed]

09:39 brunoerg has joined #bitcoin-core-dev

09:40 brunoerg has quit [Remote host closed the connection]

09:41 brunoerg has joined #bitcoin-core-dev

09:47 brunoerg has quit [Ping timeout: 256 seconds]

09:51 brunoerg has joined #bitcoin-core-dev

09:52 brunoerg has quit [Remote host closed the connection]

09:53 brunoerg has joined #bitcoin-core-dev

09:55 zato has joined #bitcoin-core-dev

09:58 brunoerg has quit [Ping timeout: 256 seconds]

09:58 brunoerg has joined #bitcoin-core-dev

10:03 BUSY has quit [Ping timeout: 255 seconds]

10:03 brunoerg has quit [Ping timeout: 268 seconds]

10:09 brunoerg has joined #bitcoin-core-dev

10:12 kevkevin has joined #bitcoin-core-dev

10:14 brunoerg has quit [Ping timeout: 255 seconds]

10:15 BUSY has joined #bitcoin-core-dev

10:17 kevkevin has quit [Ping timeout: 245 seconds]

10:26 brunoerg has joined #bitcoin-core-dev

10:30 brunoerg has quit [Ping timeout: 245 seconds]

10:43 brunoerg has joined #bitcoin-core-dev

10:47 brunoerg has quit [Ping timeout: 240 seconds]

10:52 <bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/794f971607f2...c1b7332441f9

10:52 <bitcoin-git> bitcoin/master 4335e55 Hennadii Stepanov: ci: Run vcpkg with path prefix

10:52 <bitcoin-git> bitcoin/master 1a889f7 Hennadii Stepanov: ci: Set MSVC toolset version explicitly

10:52 <bitcoin-git> bitcoin/master 70100f8 Hennadii Stepanov: Revert "ci: Avoid toolset ambiguity that MSVC can't handle"

10:52 <bitcoin-git> [bitcoin] fanquake merged pull request #28934: ci: Set MSVC toolset version explicitly (master...231124-toolset) https://github.com/bitcoin/bitcoin/pull/28934

10:53 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1b7332441f9...dc369af3f514

10:53 <bitcoin-git> bitcoin/master ecb4683 Peter Todd: Change petertodd seeds to petertodd.net

10:53 <bitcoin-git> bitcoin/master dc369af fanquake: Merge bitcoin/bitcoin#28936: Change petertodd seeds to petertodd.net

10:53 <bitcoin-git> [bitcoin] fanquake merged pull request #28936: Change petertodd seeds to petertodd.net (master...2023-11-change-dns-seed) https://github.com/bitcoin/bitcoin/pull/28936

11:00 brunoerg has joined #bitcoin-core-dev

11:05 brunoerg has quit [Ping timeout: 255 seconds]

11:11 kevkevin has joined #bitcoin-core-dev

11:12 brunoerg has joined #bitcoin-core-dev

11:16 kevkevin has quit [Ping timeout: 276 seconds]

11:24 <bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/dc369af3f514...c252a0fc0f4d

11:24 <bitcoin-git> bitcoin/master fa0ed07 MarcoFalke: refactor: VectorWriter without nVersion

11:24 <bitcoin-git> bitcoin/master 66669da MarcoFalke: Remove unused Make() overload in netmessagemaker.h

11:24 <bitcoin-git> bitcoin/master fa9b5f4 MarcoFalke: refactor: NetMsg::Make() without nVersion

11:24 <bitcoin-git> [bitcoin] fanquake merged pull request #28892: refactor: P2P transport without serialize version and type (master...2311-p2p-no-nVersion-) https://github.com/bitcoin/bitcoin/pull/28892

11:27 not_reserved has joined #bitcoin-core-dev

11:37 kevkevin has joined #bitcoin-core-dev

11:45 kevkevin has quit [Ping timeout: 252 seconds]

12:07 AaronvanW has joined #bitcoin-core-dev

12:12 mudsip has joined #bitcoin-core-dev

12:13 mudsip has quit [Client Quit]

12:20 <bitcoin-git> [bitcoin] maflcko opened pull request #28954: ci: Reduce use of bash -c (master...2311-ci-) https://github.com/bitcoin/bitcoin/pull/28954

12:32 kevkevin has joined #bitcoin-core-dev

12:32 BUSY has quit [Ping timeout: 276 seconds]

12:36 brunoerg has quit [Remote host closed the connection]

12:37 kevkevin has quit [Ping timeout: 276 seconds]

12:42 brunoerg has joined #bitcoin-core-dev

12:42 <bitcoin-git> [bitcoin] furszy opened pull request #28955: index: block filters sync, reduce disk read operations by caching last header (master...2023_index_blockfilter_cache_header) https://github.com/bitcoin/bitcoin/pull/28955

12:44 BUSY has joined #bitcoin-core-dev

12:49 brunoerg has quit [Ping timeout: 276 seconds]

13:19 SpellChecker has joined #bitcoin-core-dev

13:27 <bitcoin-git> [bitcoin] dergoegge opened pull request #28956: Nuke adjusted time (attempt 2) (master...2023-11-nuke-adjtime) https://github.com/bitcoin/bitcoin/pull/28956

13:33 kevkevin has joined #bitcoin-core-dev

13:38 kevkevin has quit [Ping timeout: 252 seconds]

13:41 kevkevin has joined #bitcoin-core-dev

13:45 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c252a0fc0f4d...26b7bcf10ebc

13:45 <bitcoin-git> bitcoin/master af1d2ff dergoegge: [primitives] Precompute result of CTransaction::HasWitness

13:45 <bitcoin-git> bitcoin/master 26b7bcf Andrew Chow: Merge bitcoin/bitcoin#28766: Improve peformance of CTransaction::HasWitnes...

13:45 <bitcoin-git> [bitcoin] achow101 merged pull request #28766: Improve peformance of CTransaction::HasWitness (28107 follow-up) (master...2023-10-28107-followup) https://github.com/bitcoin/bitcoin/pull/28766

13:52 SpellChecker has quit [Quit: bye]

13:57 AaronvanW has quit [Remote host closed the connection]

14:12 kevkevin has quit [Remote host closed the connection]

14:12 kevkevin has joined #bitcoin-core-dev

14:23 bitdex has quit [Quit: = ""]

14:33 brunoerg has joined #bitcoin-core-dev

14:42 SpellChecker has joined #bitcoin-core-dev

14:58 brunoerg has quit [Remote host closed the connection]

14:58 brunoerg has joined #bitcoin-core-dev

15:02 bugs_ has joined #bitcoin-core-dev

15:03 brunoerg has quit [Ping timeout: 260 seconds]

15:04 brunoerg has joined #bitcoin-core-dev

15:08 brunoerg has quit [Ping timeout: 246 seconds]

15:09 pablomartin4btc has joined #bitcoin-core-dev

15:22 brunoerg has joined #bitcoin-core-dev

15:24 piku has joined #bitcoin-core-dev

15:26 brunoerg has quit [Ping timeout: 268 seconds]

15:27 brunoerg has joined #bitcoin-core-dev

15:28 szkl has quit [Quit: Connection closed for inactivity]

15:31 piku has quit [Quit: Leaving]

15:51 szkl has joined #bitcoin-core-dev

15:55 <bitcoin-git> [bitcoin] maflcko opened pull request #28958: refactor: Use Txid in CMerkleBlock (master...2311-ref-txid-) https://github.com/bitcoin/bitcoin/pull/28958

16:05 brunoerg has quit [Remote host closed the connection]

16:10 brunoerg has joined #bitcoin-core-dev

16:16 <bitcoin-git> [bitcoin] fanquake opened pull request #28959: [26.0] Finalize or rc4 (26.x...finalize_or_rc4) https://github.com/bitcoin/bitcoin/pull/28959

16:24 <bitcoin-git> [bitcoin] fanquake merged pull request #28952: fuzz: Avoid timeout in process_messages (master...2311-fuzz-p2p-timeout-) https://github.com/bitcoin/bitcoin/pull/28952

16:27 <bitcoin-git> [bitcoin] TheCharlatan opened pull request #28960: kernel: Remove dependency on CScheduler (master...noGlobalSignals) https://github.com/bitcoin/bitcoin/pull/28960

16:49 brunoerg has quit [Remote host closed the connection]

16:50 brunoerg has joined #bitcoin-core-dev

16:53 gerle has quit [Quit: https://quassel-irc.org - Komfortabler Chat. Überall.]

16:55 brunoerg has quit [Ping timeout: 252 seconds]

17:00 josh203 has joined #bitcoin-core-dev

17:00 josh203 has quit [Excess Flood]

17:01 josh203 has joined #bitcoin-core-dev

17:10 josh203 has quit [Remote host closed the connection]

17:11 josh203 has joined #bitcoin-core-dev

17:15 brunoerg has joined #bitcoin-core-dev

17:17 josh203 has quit [Remote host closed the connection]

17:18 josh203 has joined #bitcoin-core-dev

17:19 josh203 has quit [Read error: Connection reset by peer]

17:26 <bitcoin-git> [bitcoin] ajtowns closed pull request #28686: refactor: Split per-peer parts of net module into new node/connection module (master...202310-nodenode) https://github.com/bitcoin/bitcoin/pull/28686

17:31 Murch[m] has joined #bitcoin-core-dev

17:31 <Murch[m]> #proposedmeetingtopic Deficient coin selection behavior at high feerates

17:36 <bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/31ce305d46a1...fe4e83f50d5b

17:36 <bitcoin-git> bitcoin/master fac39b5 MarcoFalke: refactor: SpanReader without nVersion

17:36 <bitcoin-git> bitcoin/master fae76a1 MarcoFalke: scripted-diff: Use DataStream in most places

17:36 <bitcoin-git> bitcoin/master fe4e83f fanquake: Merge bitcoin/bitcoin#28912: refactor: VectorWriter and SpanReader without...

17:36 <bitcoin-git> [bitcoin] fanquake merged pull request #28912: refactor: VectorWriter and SpanReader without nVersion (master...2311-less-version-) https://github.com/bitcoin/bitcoin/pull/28912

17:59 brunoerg has quit [Remote host closed the connection]

18:00 salvatoshi has quit [Ping timeout: 260 seconds]

18:11 Talkless has joined #bitcoin-core-dev

18:13 <bitcoin-git> [bitcoin] kadoned opened pull request #28961: TkoinUpdate base58.hhh (master...patch-2) https://github.com/bitcoin/bitcoin/pull/28961

18:16 <bitcoin-git> [bitcoin] maflcko closed pull request #28961: TkoinUpdate base58.hhh (master...patch-2) https://github.com/bitcoin/bitcoin/pull/28961

18:16 Talkless has quit [Quit: Konversation terminated!]

18:17 Talkless has joined #bitcoin-core-dev

18:23 Talkless has quit [Quit: Konversation terminated!]

18:23 Talkless has joined #bitcoin-core-dev

18:24 Talkless has quit [Client Quit]

18:25 Talkless has joined #bitcoin-core-dev

18:28 <bitcoin-git> [bitcoin] LarryRuane closed pull request #27748: util: generalize accounting of system-allocated memory in pool resource (master...2023-05-resource-pool-system-alloc) https://github.com/bitcoin/bitcoin/pull/27748

18:29 brunoerg has joined #bitcoin-core-dev

18:36 salvatoshi has joined #bitcoin-core-dev

18:38 lbia has quit [Ping timeout: 255 seconds]

19:05 brunoerg has quit [Remote host closed the connection]

19:07 brunoerg has joined #bitcoin-core-dev

19:17 <bitcoin-git> [bitcoin] achow101 pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/fe4e83f50d5b...30a055782908

19:17 <bitcoin-git> bitcoin/master 68a9001 Martin Zumsande: test: persist -v2transport over restarts and respect -v2transport=0

19:17 <bitcoin-git> bitcoin/master 3598a1b Martin Zumsande: test: enable --v2transport in combination with --usecli

19:17 <bitcoin-git> bitcoin/master cc961c2 Sebastian Falbesoner: test: enable v2 transport for p2p_node_network_limited.py

19:17 <bitcoin-git> [bitcoin] achow101 merged pull request #28805: test: Make existing functional tests compatible with --v2transport (master...202311_test_v2transport4all) https://github.com/bitcoin/bitcoin/pull/28805

19:34 brunoerg has quit [Remote host closed the connection]

19:35 brunoerg has joined #bitcoin-core-dev

19:37 aureleoules has quit [Ping timeout: 256 seconds]

19:38 not_reserved has quit [Quit: Client closed]

19:39 brunoerg has quit [Ping timeout: 256 seconds]

19:42 kevkevin has quit [Remote host closed the connection]

19:43 preimage has joined #bitcoin-core-dev

19:45 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/30a055782908...535424a10b44

19:45 <bitcoin-git> bitcoin/master 705e3f1 TheCharlatan: refactor: Make CTxMemPoolEntry only explicitly copyable

19:45 <bitcoin-git> bitcoin/master 535424a Andrew Chow: Merge bitcoin/bitcoin#28903: refactor: Make CTxMemPoolEntry only explicitl...

19:45 <bitcoin-git> [bitcoin] achow101 merged pull request #28903: refactor: Make CTxMemPoolEntry only explicitly copyable (master...CTxMemPoolEntryNonCopy) https://github.com/bitcoin/bitcoin/pull/28903

19:46 kevkevin has joined #bitcoin-core-dev

20:00 brunoerg has joined #bitcoin-core-dev

20:01 aureleoules has joined #bitcoin-core-dev

20:05 Talkless has quit [Quit: Konversation terminated!]

20:10 brunoerg has quit [Remote host closed the connection]

20:11 <bitcoin-git> [bitcoin] maflcko opened pull request #28962: doc: Rework guix docs after 1.4 release (master...2311-doc-guix-) https://github.com/bitcoin/bitcoin/pull/28962

20:29 zato has quit [Quit: Om mani padme hum]

20:37 kevkevin has quit [Remote host closed the connection]

20:45 lbia has joined #bitcoin-core-dev

20:56 kevkevin has joined #bitcoin-core-dev

21:01 brunoerg has joined #bitcoin-core-dev

21:04 zeropoint has joined #bitcoin-core-dev

21:26 <bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/535424a10b44...75462b39d2e3

21:26 <bitcoin-git> bitcoin/master 9ac114e Jameson Lopp: Throw error if invalid parameters passed to getnetworkhashps RPC endpoint

21:26 <bitcoin-git> bitcoin/master 75462b3 Andrew Chow: Merge bitcoin/bitcoin#28554: bugfix: throw an error if an invalid paramete...

21:26 <bitcoin-git> [bitcoin] achow101 merged pull request #28554: bugfix: throw an error if an invalid parameter is passed to getnetworkhashps RPC (master...getnetworkhashps_height_validation) https://github.com/bitcoin/bitcoin/pull/28554

21:38 szkl has quit [Quit: Connection closed for inactivity]

21:43 theStack has quit [Remote host closed the connection]

21:46 utzig has quit [Write error: Connection reset by peer]

21:46 angusp has quit [Read error: Connection reset by peer]

21:46 preimage has quit [Quit: WeeChat 4.1.1]

21:46 angusp has joined #bitcoin-core-dev

21:47 utzig has joined #bitcoin-core-dev

21:48 AaronvanW has joined #bitcoin-core-dev

21:50 zeropoint has quit [Quit: leaving]

21:51 <bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/75462b39d2e3...16b5b4b67441

21:51 <bitcoin-git> bitcoin/master faa3d4f MarcoFalke: Remove duplicate NDEBUG check from compat/assumptions.h

21:51 <bitcoin-git> bitcoin/master 7777411 MarcoFalke: Remove __cplusplus from compat/assumptions.h

21:51 <bitcoin-git> bitcoin/master 8888753 MarcoFalke: Move compat/assumptions.h include to one place that actually needs it

21:51 <bitcoin-git> [bitcoin] achow101 merged pull request #28579: refactor: Remove redundant checks in compat/assumptions.h (master...2310-assume-) https://github.com/bitcoin/bitcoin/pull/28579

22:10 AaronvanW has quit [Remote host closed the connection]

22:16 theStack has joined #bitcoin-core-dev

22:19 szkl has joined #bitcoin-core-dev

22:23 brunoerg has quit [Remote host closed the connection]

22:35 bugs_ has quit [Quit: Leaving]

22:54 dzxzg has joined #bitcoin-core-dev

23:47 BeefyBoot_ has joined #bitcoin-core-dev