<bitcoin-git>
[bitcoin] vasild opened pull request #31239: test: clarify log messages when handling SOCKS5 proxy connections (master...socks5proxy_log) https://github.com/bitcoin/bitcoin/pull/31239
eval-exec has quit [Ping timeout: 252 seconds]
eval-exec has joined #bitcoin-core-dev
wannabe has joined #bitcoin-core-dev
eval-exec has quit [Remote host closed the connection]
eval-exec has joined #bitcoin-core-dev
josie_ has joined #bitcoin-core-dev
josie_ is now known as josie
Emc99 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
Emc99 has quit [Client Quit]
Emc99 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] edilmedeiros opened pull request #31240: RFC: doc: Fix dead links to mailing list archives (master...fix-mailing-list-links) https://github.com/bitcoin/bitcoin/pull/31240
<kanzure>
#proposedmeetingtopic bitcoin-dev mailing list archive links
<achow101>
There is one pre-proposed meeting topic this week. Any last minute ones to add?
<dergoegge>
hi
<lightlike>
Hi
<sipa>
hi
<maxedw>
hi
<stickies-v>
hi
<willcl-ark>
hi
<achow101>
#topic Fuzzing WG Update (dergoegge)
<theStack>
hi
<cfields>
hi
<dergoegge>
no update
<dergoegge>
I thought we're doing these monthly
<achow101>
#topic Kernel WG Update (TheCharlatan)
<TheCharlatan>
The focus is currently on "de-risking" the necessary "glue" code between the external header and the internal code. This means de-duplicating redundant logic between the various interfaces.
<josie>
dergoegge: i think some people will have updates each week, others monthly ?
<TheCharlatan>
In the working group we recently discussed approaches for handling the logging in a better way. An alternative that was not explored yet could be directly exposing a kernel logging macro.
<TheCharlatan>
The experimental rust-bitcoinkernel crate, which implements a Rust wrapper around the API as implemented in #30595, is now available through crates.io.
<TheCharlatan>
This makes it a bit easier for other developers that might also want to experiment with it.
<TheCharlatan>
I also started work on an experimental kernel-based node to validate the API.
<TheCharlatan>
This has already surfaced some stuff that I put into the API PR.
<TheCharlatan>
that's it from me
<achow101>
dergoegge: last week, seemed like most people wanted updates every week. so doing it based on who's here to minimize downtime.
<achow101>
#topic Benchmarking WG Update (josibake, l0rinc)
<josie>
since last week, willcl-ark and i have been working on a CI workflow for long running benchmarks. so far, making good progress!
<josie>
we have a workflow where someone can take their branch and open it as a PR against https://github.com/bitcoin-dev-tools/benchcoin and this will automatically kick off a benchmark and publish the final results as artifacts on the PR
<josie>
right now, the only benchmark we have working is an assumeutxo benchmark on signet (i.e., loading a snapshot and doing IBD from snapshot to chaintip with background validation paused)
<josie>
next steps will be to make this work on mainnet and figure out how to intelligently distribute workloads to our dedicated runners pool
<josie>
Novo__ has been working on rebasing fjahr 's batch validation PR, as thats one of the first ones we'd like to start benchmarking using the assumeutxo bench method
<josie>
thats all for benchmarking!
<achow101>
#topic Silent Payments WG Update (josibake, RubenSomsen)
<cfields>
which PR#?
<josie>
ive been incorporating all of the review comments / feedback from coredev on the bitcoin-core/secp256k1#1519, hoping to finish that this week
<gribble>
https://github.com/bitcoin/bitcoin/issues/1519 | GUI: change language selection format to "language - country (locale name)" by Diapolo · Pull Request #1519 · bitcoin/bitcoin · GitHub
<josie>
next will be rebasing the bitcoin core PRs on top of that. for a list of the PRs / status, im keeping the tracking issue up to date (bitcoin/bitcoin#28536)
<achow101>
#topic Cluster Mempool WG Update (sdaftuar, sipa)
<sipa>
Update on txgraph (part of cluster mempool). My plan is to have a first PR for the "txgraph" module open next week (this is the layer that reasons about dependencies/clusters/linearizations for the entire mempool, as opposed to the cluster_linearize.h file that is already merged, which is for reasoning about a single individual cluster). Txgraph will probably be a few PRs (mining/eviction logic may
<sipa>
be added later, some memory usage optimizations, reorg...
<sipa>
logic), but i hope to have the basics out next week.
<sipa>
After that, the main PR for cluster mempool can be rebased on the txgraph logic + the mempool changeset PR.
<sipa>
That's it for me, suhas doesn't seem to be around.
eval-exec has quit [Ping timeout: 252 seconds]
adil1 has joined #bitcoin-core-dev
<achow101>
#topic MuSig2 WG Update (achow101)
<achow101>
The libsecp subtree has been updated to 0.6.0 which includes the musig module. #29675 is no longer draft. the WG will be meeting after the IRC meeting to discuss breaking it up so it isn't 30 commits
<gribble>
https://github.com/bitcoin/bitcoin/issues/29675 | wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys by achow101 · Pull Request #29675 · bitcoin/bitcoin · GitHub
<achow101>
#topic Legacy Wallet Removal WG Update (achow101)
<achow101>
Still waiting on review on #30328, otherwise, no update
<glozow>
(I thought we signed up for the dates we were gonna give updates? Or did I read that wrong?)
<ryanofsky>
Sorry was afk. Multiprocess update was: Not much new, priority is to get multiprocess code enabled in next release so mining IPC interface is easily accessible. Tracking issue is #28722 with PRs to review, and there is now a Signal group linked there. That's it.
<achow101>
glozow: last week, seemed like most people wanted weekly updates from all WGs; will be doing it based on who's here (people saying hi)
adil1 has quit [Quit: adil1]
<achow101>
Perhaps we should kill this high priority for review topic. it doesn't seem like anyone is using, and if you have something high priority for review, maybe make a working group?
<glozow>
Ok my bad
<josie>
achow101: iirc, everyone seemed to favor that last meeting? or if you have a high prio, just drop it here? i could be misremembering tho
<stickies-v>
achow101: sounds good. people can still suggest ad-hoc topics too if anything urgent non-wg comes up, of course
<sipa>
we're all still figuring things ouy
<sipa>
out
<achow101>
josie: I don't recall there being discussion about this topic
<achow101>
right now there is only one pr in the board, and things that have been added to it previously don't seem to have actually gotten any more review than if they hadn't been on it
<achow101>
will remove it for now
<achow101>
#topic bitcoin-dev mailing list archive links (kanzure)
<kanzure>
lists.linuxfoundation.org is no more and is no longer hosting the mailing list static archives at this time (not just for bitcoin-dev but ~everything including some LKML stuff?)
<kanzure>
to be fair, they did give us some notice, hence the actual migration was done earlier this year
<kanzure>
there's a lot of backlinks out there, it's really sad to have this many links broken :(
<kanzure>
someone is working on asking them to re-host the static archives to preserve backlinks and fight against bit rot on the web, dunno if they will
<achow101>
kanzure: I thought they promised to keep the archive?
<kanzure>
well if they did then i did not receive that, i don't have LF contactperson details
<kanzure>
just made lightning-dev work a few minutes ago, pls test and let me know if something is broken
<kanzure>
attachments do not presently work for lightning-dev, someone can make a public-inbox archive from lightning-dev.mbox if they have a complete archive.
<achow101>
these links are sprinkled all over the place. this is gonna be a pain
<kanzure>
oh right, it occurs to me that bitcoin-core-dev is not supported on gnusha.org/url at the moment, does anyone have strong opinions about this. announcement emails always went out to bitcoin-dev AFAIK so they are captured there at least.
<achow101>
considering the demise of that list, i'm not sure that migrating it will even be useful as everyone who was previously on it won't be notified of the new list location
<achow101>
and the announcements occur in a ton of other places too, including bitcoin-dev
Emc99 has quit [Quit: Client closed]
<kanzure>
maybe post a question publicly and ask if anyone was using just the bitcoin-core-dev announcement list specifically, or thinks it should continue to exist, i would hate to break something important
Emc99 has joined #bitcoin-core-dev
<achow101>
perhaps ask on bitcoindev?
<achow101>
Any other topics to discuss?
<achow101>
#endmeeting
<josie>
let the flood of WG calls begin!
Emc99 has quit [Quit: Client closed]
<theStack>
:D
<stickies-v>
josie: in https://github.com/bitcoin-dev-tools/benchcoin, it seems `results.json` only contains a run for PR head. Since `master` is ~going to be different for each PR, doing a run on `master` too might be helpful to isolate effects from other recent commits? Then again, doubles the compute for what will presumably be heavy workloads, so might not be worth the trade off. Just wondering what your thoughts are, i guess
<josie>
stickies-v: that should be fixed soon (tm). regarding master changing, the idea is we will only sync benchcoin up with bitcoin-core master manually, once weve got agreement in the WG to choose a new base to benchmark against. long term, wed like to make it fully parameterized where you can pick a specific commit to bench your PR against (master at a certain point in time, another PR, etc)
<josie>
stickies-v: we had discussed not running master vs PR branch on each run to save compute, but ultimately felt it was better to just accept the compute so that we have more guarantees its an apples to apples comparison (like changing bitcoin.conf options)
brunoerg has quit [Remote host closed the connection]
hodlinator has joined #bitcoin-core-dev
eval-exec has joined #bitcoin-core-dev
<stickies-v>
cool, thanks. parameterizing sounds like it would be helpful
preimage has joined #bitcoin-core-dev
sliv3r__ has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
jb55 has quit [Ping timeout: 260 seconds]
achow101 has quit [Ping timeout: 276 seconds]
achow101 has joined #bitcoin-core-dev
twistedline has quit []
jb55 has joined #bitcoin-core-dev
twistedline has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] furszy opened pull request #31241: wallet: remove BDB dependency from wallet migration benchmark (master...2024_bench_migration_remove_bdb_dependency) https://github.com/bitcoin/bitcoin/pull/31241
sliv3r__ has quit [Ping timeout: 256 seconds]
<bitcoin-git>
[bitcoin] achow101 opened pull request #31242: wallet, desc spkm: Return SigningProvider only if we have the privkey (master...wallet-signingprov-no-h) https://github.com/bitcoin/bitcoin/pull/31242
<darosior>
Is there known users of the REST interface? Do we know why they can't use the RPC interface instead? It's not like the REST interface gives any more guarantees?
<bitcoin-git>
[bitcoin] achow101 opened pull request #31243: descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` (master...descriptor-direct-fill) https://github.com/bitcoin/bitcoin/pull/31243
<darosior>
Thanks. It does mention a couple usecases:
<darosior>
> The REST interface is useful for quickly iterating over the blockchain, because it can request blocks and transactions in binary form without having to serialize/deserialize into JSON.
<darosior>
And:
<darosior>
> It also has API for quickly retrieving large amounts of block headers and BIP157 compact block filter headers.
<andrewtoth>
darosior: romanz (author of electrs) has had recent improvements to the REST server merged. I don't see electrs using it but perhaps that is a direction they are taking.
<andrewtoth>
Not having to bother with auth for read only use cases is a nice bonus
<bitcoin-git>
[bitcoin] achow101 opened pull request #31248: test: Rework wallet_migration.py to use previous releases (master...migratewallet-prev-rels) https://github.com/bitcoin/bitcoin/pull/31248
sliv3r__ has quit [Quit: Client closed]
<bitcoin-git>
[bitcoin] achow101 opened pull request #31249: test: Add combinerawtransaction test to rpc_createmultisig (master...combinerawtx-test) https://github.com/bitcoin/bitcoin/pull/31249
<bitcoin-git>
[bitcoin] achow101 opened pull request #31250: wallet: Disable creating and loading legacy wallets (master...disable-legacy-wallets) https://github.com/bitcoin/bitcoin/pull/31250
Talkless has joined #bitcoin-core-dev
sliv3r__ has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
sliv3r__ has quit [Quit: Client closed]
<bitcoin-git>
[bitcoin] furszy opened pull request #31251: test: report a more detailed failure during utf8 response decoding (master...2024_test_report_invalid_response) https://github.com/bitcoin/bitcoin/pull/31251