<bitcoin-git>
bitcoin/master ad9c2cc furszy: test, bench: specialize working directory name
<bitcoin-git>
bitcoin/master fa66e08 furszy: bench: add support for custom data directory
<bitcoin-git>
bitcoin/master 4228259 Ava Chow: Merge bitcoin/bitcoin#31000: bench: add support for custom data directory
<bitcoin-git>
[bitcoin] achow101 merged pull request #31000: bench: add support for custom data directory (master...2024_bench_custom_datadir) https://github.com/bitcoin/bitcoin/pull/31000
PaperSword has quit [Remote host closed the connection]
PaperSword has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 244 seconds]
PaperSword has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
__DuBPiRaTe__ has joined #bitcoin-core-dev
__DuBPiRaTe__ has quit [Quit: Leaving]
zeropoint has quit [Quit: leaving]
jarthur_ has joined #bitcoin-core-dev
jarthur_ has quit [Client Quit]
jarthur has quit [Ping timeout: 260 seconds]
jarthur has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
pablomartin has quit [Quit: Leaving]
bitdex has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 252 seconds]
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 265 seconds]
andrewtoth has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
gf2718 has joined #bitcoin-core-dev
mcey_ has quit [Remote host closed the connection]
mcey_ has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 260 seconds]
jarthur has quit [Ping timeout: 252 seconds]
gf2718 has joined #bitcoin-core-dev
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 248 seconds]
PaperSword1 has quit [Ping timeout: 252 seconds]
gf2718 has quit [Ping timeout: 252 seconds]
gf2718 has joined #bitcoin-core-dev
adil has quit [Quit: adil]
gf2718 has quit [Ping timeout: 252 seconds]
gf2718 has joined #bitcoin-core-dev
<vasild>
ryanofsky: wrt #31011, it says "Move util/pcp.cpp and util/netif.cpp to common/ because they depend on netaddress.cpp", does it mean anything that depends on netaddress.cpp has to be in common/ ?
<vasild>
and how to determine if something depends on netaddress.cpp? I guess "#include <netaddress.h>" is not quite the same since it may only need netaddress.h for e.g. 'enum Network'
<laanwj>
vasild: i think any use of netaddress.h is considered "use of netaddress.cpp" in this context, we don't distinguish header versus implementation usage because it further complicates dependency tracking
<achow101>
There are no pre-proposed meeting topics this week. Any last minute ones to add?
kevkevin has quit [Quit: Leaving...]
<gleb>
Hi
<BlueMatt[m]>
Is Sjors here?
<maxedw>
hi
kevkevin has joined #bitcoin-core-dev
<kevkevin>
hi
<achow101>
BlueMatt[m]: doesn't seem like it yet
<brunoerg>
hi
<achow101>
#topic Erlay WG Update (sr_gi, gleb, marcofleon)
<stickies-v>
hi
nymius has quit [Client Quit]
<gleb>
On erlay side I guess that’s me
<kanzure>
hi
<gleb>
We’re having some productive discussions on moving forward in the WG chat, especially how to think of spy nodes; and how to think of the efficiency
nymius has joined #bitcoin-core-dev
<gleb>
In-pr sergi is reviewing a lot of my comments. I know several contributors are waiting for that to resolve first
<gleb>
I’m spinning up test nodes for others to connect to. Thinking Warnet or not
<gleb>
That’s it!
<achow101>
#topic Kernel WG Update (TheCharlatan)
<josie>
gleb: feel free to reach out if you want a warnet onboarding / crash course
<TheCharlatan>
Nothing new today, thank you for the quick reviews on #31269
<achow101>
#topic Benchmarking WG Update (josie, l0rinc)
<josie>
made progress on getting a mainnet assumeutxo bench running automatically when a PR is opened. the benchmark now automatically does benchcoin master vs PR branch (h/t willcl-ark)
<josie>
the final results are published to a github page, with flamegraphs included (h/t davidgumberg)
<josie>
Novo___ and i will be using the new setup this next week to investigate the batch validatoin PR
<josie>
we are also at the stage where having extra dedicated runners would be helpful. was planning to purchase some more hetzner boxes and add them, but a few people mentioned having some resources that could be used for this, planning to follow up on that this week
<josie>
thats all!
<achow101>
#topic Silent Payments WG Update (josie, RubenSomsen)
<josie>
slow and steady, working through all the feedback on the libsecp256k1 module
<josie>
i do remember on the musig2 PR, there was a suggestion on how we type arrays of unsigned char where it is expected to be an exact size. it seemed doing this could be useful for languages like rust, when generating bindings automatically?
<josie>
planning to follow up with the secp256k1 maintainers to see if this is worth doing for the silent payments module (perhaps a topic for the upcoming secp256k1 meeting this coming monday?)
<josie>
thats all!
<sipa>
josie: yeah, definitely worth bringing up
<achow101>
#topic Cluster Mempool WG Update (sdaftuar, sipa)
<sdaftuar>
hi, #31122 is still the PR to review. it seems to be getting close.
<sdaftuar>
i think pieter is getting closer with his txgraph implementation as well -- will let him add any additional info
<sipa>
i'm close to opening the first txgraph PR (the middle layer between cluster linearization algorithms, and the mempool, which deals with dependencies/clusters/linearizations/proposed changes for the entire mempool)
<sipa>
nothing else from me
<achow101>
#topic MuSig2 WG Update (achow101)
<achow101>
We had a discussion about breaking up #29675, so i've opened 2 refactors (#31242, #31243) and a PR for the PSBT fields (#31247)
<gribble>
https://github.com/bitcoin/bitcoin/issues/29675 | wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys by achow101 · Pull Request #29675 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
<gribble>
https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 · Pull Request #31243 · bitcoin/bitcoin · GitHub
<achow101>
The descriptors implementation is also in a separate draft PR ##31244, and 29675 is the final that require all of the above and adds signing
<achow101>
#topic Legacy Wallet Removal WG Update (achow101)
gf2718 has joined #bitcoin-core-dev
<achow101>
Also had a discussion about breaking up #28710, so there's now the migration test rework in #31248, and #31250 has legacy wallets disabled but not removed
<achow101>
that's all for working groups that i see here
<achow101>
Anything else to discuss?
<instagibbs>
shoutout to all the ephemeral dust review, not exactly a topic
<vasild>
achow101: I guess that once legacy wallet is removed (in 29?) softwares that use Bitcoin Core's wallet but don't support descriptor wallets will have to stick to v28?
<josie>
instagibbs: congrats on moving that forward!
<achow101>
vasild: yes
<vasild>
ok
<sipa>
vasild, achow101: though there are some RPCs we could realistically implement for descriptor wallets which are legacy-only currently (see #30175
<bitcoin-git>
[gui-qml] pablomartin4btc opened pull request #433: Persist proxy settings to settings.json (main...qml-proxy-settings-persistence) https://github.com/bitcoin-core/gui-qml/pull/433
kevkevin has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 260 seconds]
jarthur has quit [Read error: Connection reset by peer]
Talkless has quit [Remote host closed the connection]
Guest16 has joined #bitcoin-core-dev
Guest16 has quit [Client Quit]
<bitcoin-git>
[bitcoin] furszy opened pull request #31291: test: add global time to place exec tests within the same dir (master...2024_test_global_path) https://github.com/bitcoin/bitcoin/pull/31291
<darosior>
how do i enable the debug symbols but keep an optimized build with cmake?
<darosior>
what im trying to achieve: having enough information for `perf` but keeping the optimizations so the flamegraph actually reflects reality
<sipa>
my understanding is that that is the default: the default built type is RelWithDebInfo
<sipa>
does running cmake say "CMAKE_BUILD_TYPE ...................... RelWithDebInfo
<bitcoin-git>
[bitcoin] casey opened pull request #31292: Add `contrib/justfile` containing useful development workflow commands. (master...justfile) https://github.com/bitcoin/bitcoin/pull/31292
<darosior>
Yeah, so looks like the problem is elsewhere.
<darosior>
readelf also says my binary has them
<darosior>
Ah, i just didn't have the kernel debug symbols on this new machine. If anyone's coming back to read this: apt install linux-image-`uname -r`-dbg did the trick.