ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
gf2718 has quit [Read error: Connection reset by peer]
gf2718 has joined #bitcoin-core-dev
llanosjorge1991 has quit [Quit: Client closed]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
eval-exec has joined #bitcoin-core-dev
upekkha has quit []
upekkha has joined #bitcoin-core-dev
gf2718 has quit [Changing host]
gf2718 has joined #bitcoin-core-dev
ghost43 has quit [Ping timeout: 260 seconds]
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 260 seconds]
gf2718 has quit [Ping timeout: 246 seconds]
ghost43 has joined #bitcoin-core-dev
greypw1 has quit [Remote host closed the connection]
greypw1 has joined #bitcoin-core-dev
gf2718 has joined #bitcoin-core-dev
emcy__ has joined #bitcoin-core-dev
mcey_ has quit [Ping timeout: 248 seconds]
TheCharlatan has quit [Ping timeout: 252 seconds]
tarotfied has quit [Ping timeout: 248 seconds]
b10c has quit [Ping timeout: 264 seconds]
itsarjn has joined #bitcoin-core-dev
TheCharlatan has joined #bitcoin-core-dev
tdb3 has quit []
tdb3 has joined #bitcoin-core-dev
tarotfied has joined #bitcoin-core-dev
eval-exec has quit [Quit: eval-exec]
eval-exec has joined #bitcoin-core-dev
eval-exec has quit [Ping timeout: 265 seconds]
szkl has quit [Quit: Connection closed for inactivity]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 246 seconds]
kevkevin has quit [Ping timeout: 276 seconds]
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 248 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
gf2718 has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
Saturday7 has quit [Quit: ZNC 1.9.1 - https://znc.in]
kevkevin has joined #bitcoin-core-dev
Saturday7 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
mudsip has quit []
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
emcy__ has quit [Remote host closed the connection]
emcy__ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
gf2718 has quit [Ping timeout: 245 seconds]
gf2718 has joined #bitcoin-core-dev
meebey has quit [Ping timeout: 260 seconds]
tarotfied has quit [Ping timeout: 260 seconds]
tarotfied has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
meebey has joined #bitcoin-core-dev
eval-exec has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
gf2718 has quit [Ping timeout: 260 seconds]
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 265 seconds]
eval-exec has quit [Remote host closed the connection]
gf2718 has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 245 seconds]
dunxen has quit [Quit: dunxen]
gf2718 has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 252 seconds]
kevkevin has quit [Ping timeout: 276 seconds]
dunxen has quit [Remote host closed the connection]
dunxen has joined #bitcoin-core-dev
dunxen has quit [Remote host closed the connection]
dunxen has joined #bitcoin-core-dev
dunxen has quit [Remote host closed the connection]
gf2718 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
itsarjn has quit [Remote host closed the connection]
itsarjn has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
dunxen has quit [Client Quit]
kevkevin has quit [Ping timeout: 260 seconds]
Cory31 has quit [Quit: Client closed]
Cory31 has joined #bitcoin-core-dev
dunxen has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Guest1513 has joined #bitcoin-core-dev
SpellChecker_ has quit [Ping timeout: 260 seconds]
SpellChecker has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Cory31 has quit [Quit: Client closed]
Cory31 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
<vasild> Wrt #31339, so it turns out the owners of 1.2.3.4, 11.22.33.44 and 8.8.8.8, if they would bother, would know the IP address of every dev who runs the functional tests at home.
<gribble> https://github.com/bitcoin/bitcoin/issues/31339 | Avoid internet traffic from tests · Issue #31339 · bitcoin/bitcoin · GitHub
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 265 seconds]
kevkevin has quit [Ping timeout: 248 seconds]
gf2718 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Cory31 has quit [Quit: Client closed]
kevkevin has quit [Ping timeout: 276 seconds]
Cory31 has joined #bitcoin-core-dev
dunxen has quit [Ping timeout: 245 seconds]
Cory31 has quit [Quit: Client closed]
Cory31 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
kevkevin has joined #bitcoin-core-dev
itsarjn has quit [Remote host closed the connection]
itsarjn has joined #bitcoin-core-dev
Cory31 has quit [Quit: Client closed]
Cory31 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 246 seconds]
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 252 seconds]
<sipa> :o
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
gribble has quit [Remote host closed the connection]
gf2718 has joined #bitcoin-core-dev
gribble has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
gf2718 has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
gf2718 has joined #bitcoin-core-dev
<sdaftuar> 🤦
gf2718 has quit [Ping timeout: 260 seconds]
<sdaftuar> might be nice if anyone has tips for developers (in general) on how to maintain privacy while contributing to the project (not sure if that exists anywhere)
kevkevin has joined #bitcoin-core-dev
itsarjn has quit [Remote host closed the connection]
itsarjn has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
gf2718 has joined #bitcoin-core-dev
BlueMattMtrxBot has quit [Ping timeout: 260 seconds]
BlueMattMtrxBot has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
gf2718 has quit [Ping timeout: 246 seconds]
dunxen has joined #bitcoin-core-dev
jadi has quit [Quit: WeeChat 3.6]
dunxen has quit [Remote host closed the connection]
dunxen has joined #bitcoin-core-dev
gf2718 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
kevkevin has joined #bitcoin-core-dev
dunxen has quit [Quit: dunxen]
preimage has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
bugs_ has joined #bitcoin-core-dev
dermoth has quit [Remote host closed the connection]
dermoth has joined #bitcoin-core-dev
b10c has joined #bitcoin-core-dev
b10c has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 260 seconds]
kevkevin has quit [Ping timeout: 248 seconds]
dunxen has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
gf2718 has joined #bitcoin-core-dev
<b10c> vasild: I don't think it's limited to these three IPs you mentioned. You probably ask your (home) router for "x9.dummySeed.invalid" during the tests, which might forward it (I'm not sure if my home router implements RFC 2606) to the DNS server of your ISP: https://github.com/bitcoin/bitcoin/pull/31349#issuecomment-2499335672
<vasild> right
Chris_Stewart_5 has joined #bitcoin-core-dev
itsarjn has quit [Remote host closed the connection]
itsarjn has joined #bitcoin-core-dev
Cory31 has quit [Quit: Client closed]
Cory31 has joined #bitcoin-core-dev
itsarjn has quit [Ping timeout: 260 seconds]
itsarjn has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
adil has joined #bitcoin-core-dev
dunxen has quit [Changing host]
dunxen has joined #bitcoin-core-dev
adil has quit [Remote host closed the connection]
Zenton_ has quit [Remote host closed the connection]
Zenton_ has joined #bitcoin-core-dev
Zenton_ has quit [Read error: Connection reset by peer]
Zenton__ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] furszy opened pull request #31374: wallet: fix crash during watch-only wallet migration (master...2024_migration_watch-only_crash_fix) https://github.com/bitcoin/bitcoin/pull/31374
abubakarsadiq has joined #bitcoin-core-dev
Cory31 has quit [Quit: Client closed]
Cory31 has joined #bitcoin-core-dev
Zenton__ has quit [Remote host closed the connection]
bugs_ has quit [Quit: Leaving]
Zenton__ has joined #bitcoin-core-dev
dunxen has quit [Quit: dunxen]
dunxen has joined #bitcoin-core-dev
<cfields> achow101: I'm looking at fixing #28109. Are you opposed to replacing boost signals for the wallet callbacks?
<gribble> https://github.com/bitcoin/bitcoin/issues/28109 | build: Windows debug cross-build fails with `-O0` · Issue #28109 · bitcoin/bitcoin · GitHub
<cfields> or do you have a suggestion/preference for how to replace them? Otherwise I'll just hack up the minimal replacement.
<achow101> cfields: not at all
Cory31 has quit [Quit: Client closed]
<cfields> achow101: we do actually have multiple subscribers, right? as-in they can't just be replaced with std::function ?
Cory31 has joined #bitcoin-core-dev
<achow101> i believe so
<cfields> ok, thanks. I'll poke at it.
dunxen has quit [Quit: dunxen]
Zenton__ has quit [Ping timeout: 252 seconds]
<laanwj> i remember what made boost::signal attractive at the time is that adding and removing handlers is thread-safe, and also they'd automatically get removed then the subscribed object is deleted, no idea if either is still relevant
<laanwj> if not, a vector of std::function could do it too
szkl has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky opened pull request #31375: multiprocess: Add bitcoin wrapper executable (master...pr/wrap) https://github.com/bitcoin/bitcoin/pull/31375
<bitcoin-git> [bitcoin] darosior opened pull request #31376: Miner: never create a template which exploits the timewarp bug (master...2411_miner_never_timewarp) https://github.com/bitcoin/bitcoin/pull/31376
aleggg has quit [Ping timeout: 276 seconds]
Talkless has joined #bitcoin-core-dev
Talkless has quit [Remote host closed the connection]
Talkless has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f7144b24be09...72ab35a6d09c
<bitcoin-git> bitcoin/master b031b79 dergoegge: [ci] Split out native fuzz jobs for macOS and windows
<bitcoin-git> bitcoin/master 72ab35a Ava Chow: Merge bitcoin/bitcoin#31221: ci: Split out native fuzz jobs for macOS and ...
<bitcoin-git> [bitcoin] achow101 merged pull request #31221: ci: Split out native fuzz jobs for macOS and windows (take 2) (master...2024-10-native-fuzz) https://github.com/bitcoin/bitcoin/pull/31221
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/72ab35a6d09c...28fd0bc7316c
<bitcoin-git> bitcoin/master c288c79 TheCharlatan: interpreter: Use the same type for SignatureHash in the definition
<bitcoin-git> bitcoin/master 28fd0bc Ava Chow: Merge bitcoin/bitcoin#31365: interpreter: Use the same type for SignatureH...
<bitcoin-git> [bitcoin] achow101 merged pull request #31365: interpreter: Use the same type for SignatureHash in the definition (master...consensus_sighash_int_type) https://github.com/bitcoin/bitcoin/pull/31365
___nick___ has quit [Ping timeout: 252 seconds]
___nick___ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] 0xB10C opened pull request #31377: ci: allow passing extra args to docker build with CI_IMAGE_BUILD_EXTRA_ARGS (master...2024-11-CI_IMAGE_BUILD_EXTRA_ARGS) https://github.com/bitcoin/bitcoin/pull/31377
jonatack has quit [Read error: Connection reset by peer]
Talkless has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/28fd0bc7316c...5a4bc5c03669
<bitcoin-git> bitcoin/master a774c7a Lőrinc: refactor: Fix remaining clang-tidy performance-inefficient-vector errors
<bitcoin-git> bitcoin/master 152fefe Lőrinc: refactor: Preallocate PrevectorFillVector(In)Direct without vector resize
<bitcoin-git> bitcoin/master 11f3bc2 Lőrinc: refactor: Reserve vectors in fuzz tests
<bitcoin-git> [bitcoin] achow101 merged pull request #31305: refactor: Fix remaining clang-tidy performance-inefficient-vector errors (master...l0rinc/performance-inefficient-vector-operation) https://github.com/bitcoin/bitcoin/pull/31305
Guest1513 has quit [Ping timeout: 252 seconds]
___nick___ has quit [Ping timeout: 252 seconds]
___nick___ has joined #bitcoin-core-dev
itsarjn has quit [Remote host closed the connection]
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
Guest82 has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 276 seconds]
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5a4bc5c03669...733317ba9436
<bitcoin-git> bitcoin/master 3305972 Lőrinc: refactor: Fix remaining clang-tidy performance-unnecessary-copy-initializa...
<bitcoin-git> bitcoin/master 733317b Ava Chow: Merge bitcoin/bitcoin#31364: refactor: Fix remaining clang-tidy performanc...
<bitcoin-git> [bitcoin] achow101 merged pull request #31364: refactor: Fix remaining clang-tidy performance-unnecessary-copy-initialization errors (master...l0rinc/performance-unnecessary-copy-initialization) https://github.com/bitcoin/bitcoin/pull/31364
Guest82 has quit [Quit: Client closed]
gf2718 has quit [Ping timeout: 272 seconds]
preimage has quit [Quit: WeeChat 4.4.3]
<bitcoin-git> [bitcoin] achow101 pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/733317ba9436...70e20ea024ce
<bitcoin-git> bitcoin/master 398754e fanquake: depends: target Windows 10 when building for mingw-w64
<bitcoin-git> bitcoin/master 35b898c fanquake: release: target Windows 10 or later
<bitcoin-git> bitcoin/master bf47448 fanquake: test: drop check for Windows < 10
<bitcoin-git> [bitcoin] achow101 merged pull request #31172: build: increase minimum supported Windows to 10.0 (master...min_windows_10) https://github.com/bitcoin/bitcoin/pull/31172
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 265 seconds]
<bitcoin-git> [bitcoin] hebasto reopened pull request #31306: ci: Update Clang in "tidy" job (master...241117-tidy) https://github.com/bitcoin/bitcoin/pull/31306
gf2718 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] furszy opened pull request #31378: wallet: fix crash during migration due to invalid multisig descriptors (master...2024_wallet_migration_multisig_crash) https://github.com/bitcoin/bitcoin/pull/31378
gf2718 has quit [Ping timeout: 276 seconds]