ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
pablomartin4btc has joined #bitcoin-core-dev
__DuBPiRaTe__ has quit [Quit: Leaving]
jonatack has joined #bitcoin-core-dev
pablomartin4btc_ has joined #bitcoin-core-dev
pablomartin4btc has quit [Ping timeout: 252 seconds]
jonatack has quit [Ping timeout: 260 seconds]
jonatack has joined #bitcoin-core-dev
gf2718 has quit [Changing host]
gf2718 has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
jon_atack has quit [Ping timeout: 252 seconds]
zeropoint has quit [Quit: leaving]
gf2718 has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 265 seconds]
gf2718 has joined #bitcoin-core-dev
eval-exec1 has joined #bitcoin-core-dev
eval-exec has quit [Ping timeout: 260 seconds]
eval-exec1 is now known as eval-exec
mcey_ has quit [Quit: Leaving]
mcey has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 272 seconds]
jonatack has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 244 seconds]
itsarjn has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 246 seconds]
ion- has quit [Ping timeout: 246 seconds]
itsarjn has quit [Remote host closed the connection]
mcey_ has joined #bitcoin-core-dev
mcey has quit [Ping timeout: 252 seconds]
itsarjn has joined #bitcoin-core-dev
gf2718 has joined #bitcoin-core-dev
pablomartin4btc_ has quit [Quit: Leaving]
qubuepe24 has joined #bitcoin-core-dev
luke-jr_ has quit [Remote host closed the connection]
itsarjn has quit [Remote host closed the connection]
itsarjn has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 245 seconds]
emcy__ has joined #bitcoin-core-dev
mcey_ has quit [Ping timeout: 276 seconds]
gf2718 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
jonatack has joined #bitcoin-core-dev
qubuepe24 has quit [Remote host closed the connection]
ion- has joined #bitcoin-core-dev
emcy__ has quit [Remote host closed the connection]
emcy__ has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 245 seconds]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 272 seconds]
itsarjn has quit [Remote host closed the connection]
ion- has quit [Ping timeout: 248 seconds]
itsarjn has joined #bitcoin-core-dev
gf2718 has joined #bitcoin-core-dev
flow has quit [Ping timeout: 260 seconds]
gf2718 has quit [Ping timeout: 246 seconds]
flow has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
gf2718 has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 260 seconds]
itsarjn_ has joined #bitcoin-core-dev
itsarjn has quit [Ping timeout: 248 seconds]
itsarjn has joined #bitcoin-core-dev
itsarjn_ has quit [Ping timeout: 248 seconds]
gf2718 has quit [Ping timeout: 246 seconds]
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 276 seconds]
<vasild> Stupid GitHub UI question: how do I configure a branch in my repository (vasild/bitcoin), so that CI is not run whenever I push to it? I understand I must somehow set SKIP_BRANCH_PUSH=true for that branch, but I can't find that in the GitHub UI.
gf2718 has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
flow has quit [Ping timeout: 246 seconds]
gf2718 has quit [Ping timeout: 248 seconds]
gf2718 has joined #bitcoin-core-dev
jespada_ has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 264 seconds]
flow has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 260 seconds]
itsarjn has quit [Remote host closed the connection]
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 248 seconds]
<laanwj> vasild: i think [skip ci] in the commit messages does it, but don't know anything on the branch level
<vasild> I read about that in github docs, but that would skip both "on push" and "on pull request" (I guess)
gf2718 has joined #bitcoin-core-dev
<laanwj> yes, it does the same for pull requests
Duran has joined #bitcoin-core-dev
<vasild> found it, that is a per-repository variable, thanks to https://github.com/bitcoin/bitcoin/pull/30487#issuecomment-2416470424
itsarjn has joined #bitcoin-core-dev
itsarjn has quit [Ping timeout: 265 seconds]
itsarjn has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hodlinator opened pull request #31338: test: Deduplicate assert_mempool_contents() (master...2024/11/dedup_assert_mempool_contents) https://github.com/bitcoin/bitcoin/pull/31338
Guyver2 has left #bitcoin-core-dev [Closing Window]
__DuBPiRaTe__ has joined #bitcoin-core-dev
eval-exec has quit [Remote host closed the connection]
eval-exec has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/22ef95dbe3e4...cf5772278889
<bitcoin-git> bitcoin/master 8d20348 fanquake: doc: migrate from pkg-config to pkgconf in macOS build docs
<bitcoin-git> bitcoin/master fe3457c fanquake: ci: note that we should install pkgconf in future
<bitcoin-git> bitcoin/master cf57722 merge-script: Merge bitcoin/bitcoin#31335: macOS: swap docs & CI from pkg-config to pkgc...
<bitcoin-git> [bitcoin] fanquake merged pull request #31335: macOS: swap docs & CI from pkg-config to pkgconf (master...pkg_config_to_pkg_conf) https://github.com/bitcoin/bitcoin/pull/31335
gf2718 has quit [Ping timeout: 245 seconds]
ion- has joined #bitcoin-core-dev
Duran has quit [Ping timeout: 256 seconds]
emcy__ has quit [Remote host closed the connection]
emcy__ has joined #bitcoin-core-dev
emcy__ has quit [Remote host closed the connection]
emcy__ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cf5772278889...17834bd1976d
<bitcoin-git> bitcoin/master 92d3d69 Hodlinator: fuzz: Implement G_TEST_GET_FULL_NAME
<bitcoin-git> bitcoin/master 17834bd merge-script: Merge bitcoin/bitcoin#31333: fuzz: Implement G_TEST_GET_FULL_NAME
<bitcoin-git> [bitcoin] fanquake merged pull request #31333: fuzz: Implement G_TEST_GET_FULL_NAME (master...2024/11/named_fuzz_dirs) https://github.com/bitcoin/bitcoin/pull/31333
pablomartin has joined #bitcoin-core-dev
<achow101> #startmeeting
<maxedw> hi
<achow101> #bitcoin-core-dev Meeting: abubakarsadiq achow101 _aj_ ajonas b10c brunoerg cfields darosior dergoegge fanquake fjahr furszy gleb glozow hebasto instagibbs jarolrod jonatack josibake kanzure laanwj LarryRuane lightlike luke-jr maflcko maxedw Murch pinheadmz provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi tdb3 theStack TheCharlatan vasild willcl-ark
<willcl-ark> hi
<gleb> hi
<stickies-v> hi
<TheCharlatan> hi
<jonatack> hi
<fjahr> hi
<achow101> There are no pre-proposed meeting topics this week. Any last minute ones to add?
<jarolrod> Hi
<kevkevin> hi
<tdb3> hi
Earnestly has quit [Read error: Connection reset by peer]
<achow101> #topic Erlay WG Update (sr_gi, gleb, marcofleon)
<brunoerg> hi
<hodlinator> hi
<instagibbs> hi
<gleb> oh are we doing weekly now?
<b10c> hi
<achow101> gleb: weekly, if you're here
<gleb> nothing to say since last time
<achow101> #topic Kernel WG Update (TheCharlatan)
<TheCharlatan> No news here, thank you for the continued reviews.
<achow101> #topic MuSig2 WG Update (achow101)
<achow101> #31242 and #31243 have been getting review
<gribble> https://github.com/bitcoin/bitcoin/issues/31242 | wallet, desc spkm: Return SigningProvider only if we have the privkey by achow101 · Pull Request #31242 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/31243 | descriptor: Move filling of keys from `DescriptorImpl::MakeScripts` to `PubkeyProvider::GetPubKey` by achow101 · Pull Request #31243 · bitcoin/bitcoin · GitHub
<achow101> #31247 has also gotten review and I am planning on creating fixed test vectors to add to the BIP and the pr soon
<gribble> https://github.com/bitcoin/bitcoin/issues/31247 | psbt: MuSig2 Fields by achow101 · Pull Request #31247 · bitcoin/bitcoin · GitHub
<achow101> #topic Legacy Wallet Removal WG Update (achow101)
nymius has joined #bitcoin-core-dev
<achow101> #30328 and #31248 have both been getting review and hopefully both can be merged soon
<gribble> https://github.com/bitcoin/bitcoin/issues/30328 | wallet: Remove IsMine from migration code by achow101 · Pull Request #30328 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/31248 | test: Rework wallet_migration.py to use previous releases by achow101 · Pull Request #31248 · bitcoin/bitcoin · GitHub
gf2718 has joined #bitcoin-core-dev
<achow101> Not many people here today. Any other topics to discuss?
<jonatack> achow101: what is the current bdb support removal (if planned) timeline
<achow101> jonatack: gone by 29.0
<achow101> see #20160
<gribble> https://github.com/bitcoin/bitcoin/issues/20160 | Proposed Timeline for Legacy Wallet and BDB removal · Issue #20160 · bitcoin/bitcoin · GitHub
<jonatack> ty
<achow101> #endmeeting
l0rinc has joined #bitcoin-core-dev
nymius has quit [Ping timeout: 255 seconds]
l0rinc has quit [Client Quit]
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 260 seconds]
<hodlinator> Does anyone know whether mining pools / mempool.space transaction accelerators use prioritisetransaction-RPC to boost transactions based on out-of-band fees?
itsarjn has quit [Remote host closed the connection]
itsarjn has joined #bitcoin-core-dev
<instagibbs> I expect that is the case yes
gf2718 has joined #bitcoin-core-dev
Guest23 has joined #bitcoin-core-dev
Guest23 has quit [Client Quit]
<hodlinator> Would assume so too, but want to check my assumptions. :) I'd be interested to see code using it or talk to someone involved in development around that, or someone who has talked to someone doing that.
<instagibbs> getting the exact code is probably not going to happen, but I'm sure there are a couple open to discussing things
<hodlinator> related: anyone know whether pools actually respect somewhat default (in Bitcoin Core) feerate limits and standardness rules, or do they just turn all of that to zero/off to be able to see as many transactions as possible?
<instagibbs> seems to depend on the rule, b10c[m] had a dashboard which showed who was mining what Core considers non-standard
<instagibbs> e.g., f2pool was doing a lot of self-mining for ordinals and slightly-overlarge-tx for pool payouts
<b10c> and https://bitcoin-data.github.io/non-standard-transactions (which is a bit outdated by now)
bugs_ has joined #bitcoin-core-dev
Earnestly has joined #bitcoin-core-dev
<hodlinator> b10c: thanks! the top 2 graphs on that last link provide a helpful overview.
<hodlinator> seems like F2Pool especially do not care about standardness.
<bitcoin-git> [bitcoin] theStack opened pull request #31340: test: add missing segwitv1 test cases to `script_standard_tests` (master...202411-test-add_missing_segwitv1_test_cases) https://github.com/bitcoin/bitcoin/pull/31340
gf2718 has quit [Ping timeout: 252 seconds]
<kanzure> lists.linuxfoundation.org is now doing redirects but i don't know how long this will continue
gf2718 has joined #bitcoin-core-dev
ion-_ has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 260 seconds]
ion- has quit [Ping timeout: 245 seconds]
Jackielove4u has quit [Ping timeout: 260 seconds]
jonatack has quit [Ping timeout: 264 seconds]
jonatack has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Parkeragan opened pull request #31341: Add files via upload (master...master) https://github.com/bitcoin/bitcoin/pull/31341
gf2718 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake closed pull request #31341: Add files via upload (master...master) https://github.com/bitcoin/bitcoin/pull/31341
Duran has joined #bitcoin-core-dev
mcey_ has joined #bitcoin-core-dev
emcy__ has quit [Ping timeout: 248 seconds]
gf2718 has quit [Ping timeout: 252 seconds]
Guest85 has joined #bitcoin-core-dev
Guest85 has quit [Client Quit]
nymius has joined #bitcoin-core-dev
Jackielove4u has joined #bitcoin-core-dev
Duran has quit [Ping timeout: 256 seconds]
nymius has quit [Quit: nymius]
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 248 seconds]
<instagibbs> hodlinator looks like self-mining though, not sure if they "expose" the non-standardness to others
___nick___ has quit [Ping timeout: 260 seconds]
___nick___ has joined #bitcoin-core-dev
ion-_ has quit [Remote host closed the connection]
gf2718 has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 272 seconds]
gf2718 has joined #bitcoin-core-dev
<bitcoin-git> [gui-qml] jarolrod opened pull request #434: Move various state computations from the UI to the NodeModel (main...compute-states-in-nodemodel) https://github.com/bitcoin-core/gui-qml/pull/434
gf2718 has quit [Ping timeout: 252 seconds]
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 265 seconds]
pablomartin has quit [Remote host closed the connection]
___nick___ has quit [Ping timeout: 252 seconds]
___nick___ has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
jonatack has joined #bitcoin-core-dev
<jonatack> hodlinator: maybe get in touch with https://x.com/PortlandHODL who wrote the Slipstream txn accelerator for Marathon Mining
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 244 seconds]
Talkless has joined #bitcoin-core-dev
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 248 seconds]
gf2718 has joined #bitcoin-core-dev
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
gf2718 has quit [Ping timeout: 276 seconds]
___nick___ has joined #bitcoin-core-dev
gf2718 has joined #bitcoin-core-dev
gf2718 has quit [Ping timeout: 252 seconds]
gf2718 has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 264 seconds]
itsarjn has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] Parkeragan opened pull request #31342: Add files via upload (master...master) https://github.com/bitcoin/bitcoin/pull/31342
Talkless has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] willcl-ark closed pull request #31342: Add files via upload (master...master) https://github.com/bitcoin/bitcoin/pull/31342
ion- has joined #bitcoin-core-dev
<hodlinator> instagibbs: yeah, they do have https://www.f2pool.com/user/tx-acc but from the article it seems like they're mostly breaking standardness rules for their own transactions as you say.
javi404 has quit [Read error: Connection reset by peer]
<hodlinator> jonatack: thanks for the tip! I'll see if I can hold of him.
javi404 has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 260 seconds]
___nick___ has quit [Ping timeout: 252 seconds]
<instagibbs> hes pretty responsive, iiuc slipstream is a pretty expansive relaxation of standardness rules
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 265 seconds]
<bitcoin-git> [bitcoin] theStack opened pull request #31343: test: avoid internet traffic in rpc_net.py (master...202411-test-avoid_internet_connection_in_rpc_net) https://github.com/bitcoin/bitcoin/pull/31343
nanotube has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
preimage has quit [Quit: WeeChat 4.4.3]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 252 seconds]
ion- has joined #bitcoin-core-dev
ion- has quit [Ping timeout: 252 seconds]
jackielove4u9 has joined #bitcoin-core-dev
Jackielove4u has quit [Ping timeout: 255 seconds]
jackielove4u9 is now known as jackielove4u
<fjahr> he was even here and discussed it a while ago: https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2024-08-11#1045245
<gribble> https://github.com/bitcoin/bitcoin/issues/1045245 | HTTP Error 404: Not Found