flooded has quit [Remote host closed the connection]
<PaperSword>
How would one switch the networks of a Bitcoin node in the function testing framework? Example I need some test vectors that are network specific.
<_aj_>
PaperSword: set self.chain? see feature_signet or mining_mainnet?
zeropoint has quit [Quit: leaving]
<PaperSword>
_aj_: Seems like it's good for same network, but what I need is to run a bitcoin node on mainnet, run address decoding checks, then do the same for a test network
<_aj_>
PaperSword: write an add_options() that lets you use the same test case on multiple chains? (see mining_mainnet)
<PaperSword>
Thanks! I see!
<sipa>
PaperSword: maybe test vectors are a better fit for unit tests than functional tests?
<sipa>
PaperSword: alternatively, you could have mainnet and testnet checks just in separate functional tests?
<PaperSword>
This could be true.
<PaperSword>
My conundrum is that I am working on address decoding with per network errors. eg. using mainnet on signet would let the user know that they input a mainnet address on signet. So I had to modify the functional tests to now just on mainnet.
<PaperSword>
The previous test vectors were a mix.
<PaperSword>
essentially, I can prove the error messages work for a single net, not multiple at a functional level.
<PaperSword>
alternatively, you could have mainnet and testnet checks just in separate functional tests?
<PaperSword>
100%, but it gets sort of ugly with 2x file
<PaperSword>
But that would solve this instantly.
<sipa>
can't you have two functional tests in the same file? maybe you can even share thr functionality in a base class, and derive from it twice, once for each network
<sipa>
unit tests seem easier though
<_aj_>
hmm, i see a few 27.x and 28.x nodes connecting with v1 rather than v2; wonder if that's a fake node signal
<sipa>
or they have an outdated addr record for you, which doesn't have the v2 service flag?
<_aj_>
yeah could be, not seeing anything else obviously strange about them
<bitcoin-git>
[bitcoin] willcl-ark opened pull request #32678: guix: warn and abort when SOURCE_DATE_EPOCH is set (master...source-date-epoch) https://github.com/bitcoin/bitcoin/pull/32678
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
kevkevin_ has quit [Ping timeout: 276 seconds]
l0rinc has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
synexic has quit [Quit: Ping timeout (120 seconds)]
synexic has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
kevkevin has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
l0rinc has quit [Read error: Connection reset by peer]
<bitcoin-git>
[bitcoin] ismaelsadeeq opened pull request #32679: doc: update tor docs to use correct bitcoind binary path (master...06-2025-fix-tor-docs) https://github.com/bitcoin/bitcoin/pull/32679
eugenesiegel has quit [Quit: Client closed]
eugenesiegel has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
ghost43 has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
l0rinc has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
dzxzg has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
l0rinc has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] brunoerg closed pull request #32632: wallet: sqlite: there is no need to have exclusive locking when mocking (master...2025-05-wallet-sqlite) https://github.com/bitcoin/bitcoin/pull/32632
bitdex has quit [Remote host closed the connection]