achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
jespada has quit [Ping timeout: 252 seconds]
_flood has joined #bitcoin-core-dev
flooded has quit [Remote host closed the connection]
<PaperSword> How would one switch the networks of a Bitcoin node in the function testing framework? Example I need some test vectors that are network specific.
<_aj_> PaperSword: set self.chain? see feature_signet or mining_mainnet?
zeropoint has quit [Quit: leaving]
<PaperSword> _aj_: Seems like it's good for same network, but what I need is to run a bitcoin node on mainnet, run address decoding checks, then do the same for a test network
<_aj_> PaperSword: write an add_options() that lets you use the same test case on multiple chains? (see mining_mainnet)
<PaperSword> Thanks! I see!
<sipa> PaperSword: maybe test vectors are a better fit for unit tests than functional tests?
<sipa> PaperSword: alternatively, you could have mainnet and testnet checks just in separate functional tests?
<PaperSword> This could be true.
<PaperSword> My conundrum is that I am working on address decoding with per network errors. eg. using mainnet on signet would let the user know that they input a mainnet address on signet. So I had to modify the functional tests to now just on mainnet.
<PaperSword> The previous test vectors were a mix.
<PaperSword> essentially, I can prove the error messages work for a single net, not multiple at a functional level.
<PaperSword> alternatively, you could have mainnet and testnet checks just in separate functional tests?
<PaperSword> 100%, but it gets sort of ugly with 2x file
<PaperSword> But that would solve this instantly.
<sipa> can't you have two functional tests in the same file? maybe you can even share thr functionality in a base class, and derive from it twice, once for each network
<sipa> unit tests seem easier though
<_aj_> hmm, i see a few 27.x and 28.x nodes connecting with v1 rather than v2; wonder if that's a fake node signal
<sipa> or they have an outdated addr record for you, which doesn't have the v2 service flag?
<_aj_> yeah could be, not seeing anything else obviously strange about them
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 244 seconds]
Cory98 has quit [Quit: Client closed]
Cory98 has joined #bitcoin-core-dev
<PaperSword> Oh sorry for the tag! meant to say that I get the multi net functional testing working
<PaperSword> Even got to fix up some tests that were previously commented out :D
sliv3r__ has quit [Read error: Connection reset by peer]
sliv3r__ has joined #bitcoin-core-dev
cmirror has joined #bitcoin-core-dev
Cory98 has quit [Quit: Client closed]
Cory98 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
<_aj_> PaperSword: probably should drop the Main from "ValidateAddressMainTest" then
TallTim_ has joined #bitcoin-core-dev
jimhhq_ has joined #bitcoin-core-dev
jimhhq has quit [Ping timeout: 272 seconds]
jetpack_ has joined #bitcoin-core-dev
andytoshi has quit [Ping timeout: 276 seconds]
TallTim has quit [Ping timeout: 276 seconds]
jetpack has quit [Ping timeout: 272 seconds]
andytoshi has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
Cory98 has quit [Quit: Client closed]
Cory98 has joined #bitcoin-core-dev
kevkevin_ has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
kevkevin has quit [Ping timeout: 260 seconds]
PaperSword has quit [Quit: PaperSword]
Cory61 has joined #bitcoin-core-dev
Cory98 has quit [Quit: Client closed]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
Guyver2 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
kevkevin has quit [Ping timeout: 268 seconds]
robobub has quit [Quit: Connection closed for inactivity]
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/a980918f51d7...4af72d8b0892
<bitcoin-git> bitcoin/master 240a4fb fanquake: Squashed 'src/leveldb/' changes from 113db4962b..aba469ad6a
<bitcoin-git> bitcoin/master e639ae0 fanquake: Update leveldb subtree to latest upstream
<bitcoin-git> bitcoin/master 83bfe14 fanquake: build: add -Wthread-safety-pointer
<bitcoin-git> [bitcoin] fanquake merged pull request #32647: build: add -Wthread-safety-pointer (master...thread_safety_pointer) https://github.com/bitcoin/bitcoin/pull/32647
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
Cory61 has quit [*.net *.split]
greypw1495085720 has quit [*.net *.split]
ghost43 has quit [*.net *.split]
SpellChecker has quit [*.net *.split]
vasild has quit [*.net *.split]
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] willcl-ark opened pull request #32678: guix: warn and abort when SOURCE_DATE_EPOCH is set (master...source-date-epoch) https://github.com/bitcoin/bitcoin/pull/32678
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
kevkevin_ has quit [Ping timeout: 276 seconds]
l0rinc has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
synexic has quit [Quit: Ping timeout (120 seconds)]
synexic has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
kevkevin has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
l0rinc has quit [Read error: Connection reset by peer]
jonatack has quit [Ping timeout: 272 seconds]
jonatack has joined #bitcoin-core-dev
dexterlakin has joined #bitcoin-core-dev
dexterlakin has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4af72d8b0892...a5e98dc3ae63
<bitcoin-git> bitcoin/master 18cf727 Hennadii Stepanov: cmake: Replace deprecated `qt6_add_translation` with `qt6_add_lrelease`
<bitcoin-git> bitcoin/master a5e98dc merge-script: Merge bitcoin/bitcoin#32651: cmake: Replace deprecated `qt6_add_translatio...
<bitcoin-git> [bitcoin] fanquake merged pull request #32651: cmake: Replace deprecated `qt6_add_translation` with `qt6_add_lrelease` (master...250530-qt-lrelease) https://github.com/bitcoin/bitcoin/pull/32651
robszarka has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 248 seconds]
adil has joined #bitcoin-core-dev
adil has quit [Quit: adil]
bugs_ has joined #bitcoin-core-dev
entropyx has quit [Read error: Connection reset by peer]
eugenesiegel has quit [Ping timeout: 272 seconds]
entropyx has joined #bitcoin-core-dev
entropyx has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
zeropoint has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git> [gui-qml] hebasto pushed 7 commits to main: https://github.com/bitcoin-core/gui-qml/compare/25a18f000374...989bbe0d106a
<bitcoin-git> gui-qml/main b4ade11 johnny9: qml: Add caret down icon
<bitcoin-git> gui-qml/main 0ff0688 johnny9: qml: Add targetBlocks property to WalletQmlModel
<bitcoin-git> gui-qml/main f4f9b79 johnny9: qml: Introduce FeeSelection to Send
<bitcoin-git> [gui-qml] hebasto merged pull request #461: Introduce standard fee selection to Send (main...standard-fee) https://github.com/bitcoin-core/gui-qml/pull/461
l0rinc has joined #bitcoin-core-dev
dzxzg has quit [Ping timeout: 268 seconds]
<bitcoin-git> [bitcoin] ismaelsadeeq opened pull request #32679: doc: update tor docs to use correct bitcoind binary path (master...06-2025-fix-tor-docs) https://github.com/bitcoin/bitcoin/pull/32679
eugenesiegel has quit [Quit: Client closed]
eugenesiegel has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
ghost43 has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
l0rinc has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
dzxzg has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
l0rinc has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] brunoerg closed pull request #32632: wallet: sqlite: there is no need to have exclusive locking when mocking (master...2025-05-wallet-sqlite) https://github.com/bitcoin/bitcoin/pull/32632
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
robszarka has quit [Quit: Leaving]
szarka has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
thelounge49 has quit [Quit: The Lounge - https://thelounge.chat]
Christoph_ has joined #bitcoin-core-dev
thelounge49 has joined #bitcoin-core-dev
l0rinc has quit [Ping timeout: 272 seconds]
eugenesiegel has joined #bitcoin-core-dev
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
thelounge49 has quit [Quit: The Lounge - https://thelounge.chat]
thelounge49 has joined #bitcoin-core-dev
jamesob156659 has quit [Ping timeout: 260 seconds]
jamesob443688173 has quit [Ping timeout: 260 seconds]
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 268 seconds]
jamesob156659 has joined #bitcoin-core-dev
jamesob443688173 has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 265 seconds]
jespada has quit [Ping timeout: 248 seconds]
jespada has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a5e98dc3ae63...0dcb45290cf8
<bitcoin-git> bitcoin/master f98e1aa benthecarman: rpc: Note in fundrawtransaction doc, fee rate is for package
<bitcoin-git> bitcoin/master 0dcb452 Ava Chow: Merge bitcoin/bitcoin#32607: rpc: Note in fundrawtransaction doc, fee rate...
<bitcoin-git> [bitcoin] achow101 merged pull request #32607: rpc: Note in fundrawtransaction doc, fee rate is for package (master...fundawtx-pkg-doc) https://github.com/bitcoin/bitcoin/pull/32607
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0dcb45290cf8...f94167512dc9
<bitcoin-git> bitcoin/master ed179e0 Martin Zumsande: test: apply microsecond precision to test framework logging
<bitcoin-git> bitcoin/master f941675 Ava Chow: Merge bitcoin/bitcoin#32676: test: apply microsecond precision to test fra...
<bitcoin-git> [bitcoin] achow101 merged pull request #32676: test: apply microsecond precision to test framework logging (master...202506_test_log_micros) https://github.com/bitcoin/bitcoin/pull/32676
Guest2 has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 272 seconds]
Guest2 has quit [Quit: Client closed]
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
wafflefrie has quit [Quit: Connection closed for inactivity]
Christoph_ has quit [Ping timeout: 248 seconds]
wafflefrie has joined #bitcoin-core-dev