achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
jespada has quit [Ping timeout: 276 seconds]
zeropoint has quit [Quit: leaving]
<bitcoin-git> [bitcoin] theStack opened pull request #32690: depends: fix multiprocess build on OpenBSD (apply capnp patch, correct SHA256SUM command) (master...202506-depends-fix_openbsd_multiprocess_build) https://github.com/bitcoin/bitcoin/pull/32690
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 248 seconds]
bitdex has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
jadi has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
nanotube has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
jadi has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 252 seconds]
entropyx has quit [Ping timeout: 252 seconds]
entropyx has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
PaperSword has quit [Remote host closed the connection]
bitdex has quit [Ping timeout: 244 seconds]
kevkevin has quit [Ping timeout: 272 seconds]
kevkevin has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 248 seconds]
bitdex has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 252 seconds]
dviola has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 248 seconds]
PaperSword has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 244 seconds]
mvuk has quit [Ping timeout: 248 seconds]
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 252 seconds]
paulmerrell has joined #bitcoin-core-dev
paulmerrell has quit [Quit: Client closed]
jadi has joined #bitcoin-core-dev
paulmerrell has joined #bitcoin-core-dev
paulmerrell has quit [Client Quit]
kevkevin has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
vasild has quit [Ping timeout: 244 seconds]
Guyver2 has quit [Remote host closed the connection]
l0rinc has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 244 seconds]
wafflefrie has quit [Quit: Connection closed for inactivity]
twistedline has quit [Remote host closed the connection]
twistedline has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
l0rinc has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
tinova4 has quit [Quit: The Lounge - https://thelounge.chat]
tinova4 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 265 seconds]
kevkevin has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 260 seconds]
jadi has joined #bitcoin-core-dev
<bitcoin-git> [gui-qml] hebasto pushed 4 commits to main: https://github.com/bitcoin-core/gui-qml/compare/7af57088372e...023393192ce9
<bitcoin-git> gui-qml/main 7af55d5 johnny9: qml: Hide tabs and show Select Wallet if no wallet is loaded
<bitcoin-git> gui-qml/main 5b9b484 johnny9: qml: Show Add Wallet in WalletBadge if none are found
<bitcoin-git> gui-qml/main 03b568d johnny9: qml: Add Context to CreateWalletWizard
<bitcoin-git> [gui-qml] hebasto merged pull request #465: Show "Select Wallet" or "Add Wallet" in the Wallet selector if a wallet isn't loaded (main...no-wallets-loaded) https://github.com/bitcoin-core/gui-qml/pull/465
cold has quit [Ping timeout: 252 seconds]
midnight has quit [Ping timeout: 260 seconds]
Christoph_ has quit [Quit: Christoph_]
cold has joined #bitcoin-core-dev
midnight has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
adil has quit [Quit: adil]
jadi has quit [Ping timeout: 272 seconds]
jadi has joined #bitcoin-core-dev
paulmerrell has joined #bitcoin-core-dev
paulmerrell has quit [Client Quit]
hacker4web3bitco has joined #bitcoin-core-dev
<hacker4web3bitco> Hi, ask a question, why does bitcoin core limit MAX_SCRIPTCHECK_THREADS to 15, shouldn't it be something like nr_cpu_cores-1?
hacker4web3bitco has quit [Client Quit]
hacker4web3bitco has joined #bitcoin-core-dev
hacker4web3bitco has quit [Client Quit]
hacker4web3bitco has joined #bitcoin-core-dev
<vasild> hacker4web3bitco: that cap seems arbitrary to me, if somebody runs -par=20, that will be interpreted as -par=15. Introduced in https://github.com/bitcoin/bitcoin/commit/f9cae832e6f56c6abe89b3bf05d1f176c2a7c913 in 2013
<hacker4web3bitco> vasild Thanks
hacker4web3bitco has quit [Quit: Client closed]
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jespada has joined #bitcoin-core-dev
brunoerg_ has quit []
jadi has quit [Ping timeout: 252 seconds]
hacker4web3bitco has joined #bitcoin-core-dev
hacker4web3bitco has quit [Client Quit]
Talkless has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
jadi has joined #bitcoin-core-dev
hacker4web3bitco has joined #bitcoin-core-dev
mvuk has joined #bitcoin-core-dev
hacker4web3bitco has quit [Client Quit]
l0rinc has joined #bitcoin-core-dev
<sipa> fwiw, that was because at the time i benchmarked it on a very-high core (for the time) machine, and noticed that around 16 threads, the thread contention started to no longer weigh up against the gained speedup
<bitcoin-git> [gui-qml] hebasto pushed 2 commits to main: https://github.com/bitcoin-core/gui-qml/compare/023393192ce9...c7678375d081
<bitcoin-git> gui-qml/main e06c32a GBKS: Visual tweaks to the fee selector in the send form
<bitcoin-git> gui-qml/main c767837 Hennadii Stepanov: Merge bitcoin-core/gui-qml#466: Visual tweaks to the fee selector in the s...
<bitcoin-git> [gui-qml] hebasto merged pull request #466: Visual tweaks to the fee selector in the send form (main...feature/fee-selection-visual-tweaks) https://github.com/bitcoin-core/gui-qml/pull/466
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
l0rinc has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<bitcoin-git> [bitcoin] HowHsu opened pull request #32692: checkqueue: set MAX_SCRIPTCHECK_THREADS to nCores - 1 (master...master) https://github.com/bitcoin/bitcoin/pull/32692
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
Christoph_ has quit [Quit: Christoph_]
nanotube has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 260 seconds]
anrichp has joined #bitcoin-core-dev
robszarka has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
flag has joined #bitcoin-core-dev
anrichp has quit [Quit: anrichp]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 260 seconds]
jadi has quit [Ping timeout: 268 seconds]
Christoph_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] josibake opened pull request #32693: depends: fix cmake compatibility error for freetype (master...depends-specify-cmake-min-version-for-freetype) https://github.com/bitcoin/bitcoin/pull/32693
Christoph_ has quit [Ping timeout: 244 seconds]
jadi has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 252 seconds]
mudsip has quit []
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
eugenesiegel has joined #bitcoin-core-dev
kevkevin_ has joined #bitcoin-core-dev
robszarka has quit [Quit: Leaving]
kevkevin has quit [Ping timeout: 276 seconds]
eugenesiegel has quit [Quit: Client closed]
eugenesiegel has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
SpellChecker_ is now known as SpellChecker
eugenesiegel has quit [Ping timeout: 272 seconds]
Guest21 has joined #bitcoin-core-dev
Guest21 has quit [Ping timeout: 272 seconds]
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
Randolf has joined #bitcoin-core-dev
Randolf has quit [Remote host closed the connection]
Randolf has joined #bitcoin-core-dev
l0rinc has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
MLO has joined #bitcoin-core-dev
MLO has quit [Client Quit]
mateuslo has joined #bitcoin-core-dev
mateuslo has quit [Client Quit]
MLO has joined #bitcoin-core-dev
MLO has quit [Client Quit]
mateuslo has joined #bitcoin-core-dev
mateuslo has quit [Client Quit]
MLO_ has joined #bitcoin-core-dev
MLO_ has quit [Client Quit]
Talkless has quit [Quit: Konversation terminated!]
Randolf has quit [Quit: Leaving]
m_ has joined #bitcoin-core-dev
mvuk has quit [Read error: Connection reset by peer]
wafflefrie has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
kevkevin_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
dviola has quit [Read error: Connection reset by peer]
diego has joined #bitcoin-core-dev
diego is now known as Guest4677
Guest4677 has left #bitcoin-core-dev [#bitcoin-core-dev]
dviola has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] furszy opened pull request #32694: index: move disk read lookups to base class (master...2025_indexes_remove_CBlockIndex_access) https://github.com/bitcoin/bitcoin/pull/32694
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Client Quit]
Christoph_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 252 seconds]
l0rinc has joined #bitcoin-core-dev
roconnor has joined #bitcoin-core-dev
<bitcoin-git> [bitcoincore.org] achow101 pushed 2 commits to master: https://github.com/bitcoin-core/bitcoincore.org/compare/37ad64f72afa...9d60e251be55
<bitcoin-git> bitcoincore.org/master 0db6c8b Pieter Wuille: Add statement on transaction relay
<bitcoin-git> bitcoincore.org/master 9d60e25 Ava Chow: Merge bitcoin-core/bitcoincore.org#1139: Add statement on transaction relay
<bitcoin-git> [bitcoincore.org] achow101 merged pull request #1139: Add statement on transaction relay (master...relay_statement) https://github.com/bitcoin-core/bitcoincore.org/pull/1139
<roconnor> achow101: I'm trying to bitcoin-cli -regtest importdescriptors '[{"desc":"wsh(pk(tpubD6NzVbkrYhZ4YAqhvsGTCD5axU32P9MH7ySPr38icriLyJc4KcCvwVzE3rsiXaAHBC8QtYWhiBGdc6aZRmroQShGcWygQfErbvLULfJSi8j/55/*))#wwz4y8f0","timestamp":0}]'
<roconnor> with this listed in my gethdkeys (added via addhdkey)
<roconnor> "xpub": "tpubD6NzVbkrYhZ4YAqhvsGTCD5axU32P9MH7ySPr38icriLyJc4KcCvwVzE3rsiXaAHBC8QtYWhiBGdc6aZRmroQShGcWygQfErbvLULfJSi8j",
<roconnor> "has_private": true,
kevkevin has quit [Remote host closed the connection]
<roconnor> but my importdescriptors is giving me a "message": "Cannot import descriptor without private keys to a wallet with private keys enabled"
<roconnor> I suspect I'm making some sort of conceptual mistake here.
<achow101> import won't lookup whether the privkey already exists in the wallet
<achow101> each descriptor is essentially silo'd from each other, so it's evaluating your descriptor on its own
<achow101> addhdkey is more for being able to sign without having to watch for specific scripts
<roconnor> hmmm
<achow101> if you want your private keys in a descriptor, you need to import them in that descriptor too
<roconnor> I didn't try but addhdkey presumably also works with createwalletdescriptor. ... It's just that createwalletdescriptor doesn't allow custom descriptors?
<roconnor> yeah, bitcoin-cli -regtest -named createwalletdescriptor "bech32m" hdkey="tpubD6NzVbkrYhZ4YAqhvsGTCD5axU32P9MH7ySPr38icriLyJc4KcCvwVzE3rsiXaAHBC8QtYWhiBGdc6aZRmroQShGcWygQfErbvLULfJSi8j" works fine.
<roconnor> hmmm
<achow101> yes
<achow101> createwalletdescriptor is to make the autogenerated descriptors so it specifically looks for existing keys in the wallet
l0rinc has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 248 seconds]
<roconnor> There is really no way to add custom descriptors to those listed in gethdkeys?
<achow101> i mean, you can pass private=true and get the privkeys and drop those into the descriptor
<achow101> basically the same as you did with the pubkey
<roconnor> yeah, I should at least try that
<roconnor> oh that does work.
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ae024137bda9...2053c4368472
<bitcoin-git> bitcoin/master 7cfbb85 brunoerg: test: wallet: cover wallet passphrase with a null char
<bitcoin-git> bitcoin/master 2053c43 Ava Chow: Merge bitcoin/bitcoin#32675: test: wallet: cover wallet passphrase with a ...
<bitcoin-git> [bitcoin] achow101 merged pull request #32675: test: wallet: cover wallet passphrase with a null char (master...2025-06-test-wallet-passphrase-null) https://github.com/bitcoin/bitcoin/pull/32675
jespada has quit [Ping timeout: 260 seconds]
jespada has joined #bitcoin-core-dev