<bitcoin-git>
[bitcoin] zaidmstrr opened pull request #32821: rpc: Handle -named argument parsing where Base64 encoding is used (master...rpc-args) https://github.com/bitcoin/bitcoin/pull/32821
szkl has quit [Quit: Connection closed for inactivity]
jespada has quit [Ping timeout: 276 seconds]
jespada has joined #bitcoin-core-dev
spynxic has quit [Read error: Connection reset by peer]
spynxic has joined #bitcoin-core-dev
szarka has quit [Quit: Leaving]
szarka has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
bitdex has quit [Quit: = ""]
jespada has joined #bitcoin-core-dev
jespada has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
Guyver2 has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 244 seconds]
vasild has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
<phantomcircuit>
there's an issue with logging transaction id's in general, some things log txid, some log wtxid, some log both, but it's inconsistent
<phantomcircuit>
i'd like to change the logginng to only log wtxid, but that would make it more annoying to share txid's with people because almost nothing (say a website to explore the block chain) uses the wtxids
<phantomcircuit>
anybody have thoughts on this matter, i think the bike shed should be wtxid colored
l0rinc has joined #bitcoin-core-dev
VonNaturAustreVe has quit [Remote host closed the connection]
VonNaturAustreVe has joined #bitcoin-core-dev
<achow101>
phantomcircuit: log both!
<achow101>
and whatever is logged, make it clear if it is a txid or wtxid
VonNaturAustreVe has quit [Remote host closed the connection]
VonNaturAustreVe has quit [Ping timeout: 268 seconds]
<phantomcircuit>
achow101: so one reason not to do that is that the transaction and block ids are basically the only things getting logged that dont commpress well
<phantomcircuit>
if you're logging net and mempool/rej and txpackages it's kind of a firehose already, so doubling the uncompressible data is kinda annoying
<phantomcircuit>
i guess i should have said that to start with
<phantomcircuit>
iforget how to play with others my bad
<achow101>
sure, but they're each useful in different contexts
<achow101>
I don't think we should uniformly log one or the other
<phantomcircuit>
achow101: possibly if we log them both in one place and then only log the wtxid everywhere else?
<phantomcircuit>
also what's the different contexts they're useful? im definitely missing something there
<achow101>
that could work but it is harder to review to make sure that both are logged for all txs
<achow101>
different contexts as in what is actually being debugged. e.g. if you need to lookup a transaction, you need the txid. we don't have any wtxid lookups
<phantomcircuit>
you know of any reason we dont?
<achow101>
but if you're looking at some issue invovling malleability, wtxid would be helpful
<achow101>
history, and txindex indexes by txid
<achow101>
wallet too
<phantomcircuit>
achow101: so what im looking at is transaction relay where malleability is definitely an issue, so for me the wtxid is obviously much more useful, but indeed i basically cant lookup anything with the wtxid
<phantomcircuit>
which actually kinda seems like a problem