achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
jerryf has quit [Ping timeout: 272 seconds]
jerryf has joined #bitcoin-core-dev
Cory89 has joined #bitcoin-core-dev
Cory36 has quit [Ping timeout: 250 seconds]
w0xlt has quit [Ping timeout: 258 seconds]
purpleKarrot has quit [Quit: purpleKarrot]
purpleKarrot has joined #bitcoin-core-dev
purpleKarrot has quit [Quit: purpleKarrot]
purpleKarrot has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
jerryf has quit [Ping timeout: 272 seconds]
jerryf has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
Cory38 has joined #bitcoin-core-dev
Cory88 has joined #bitcoin-core-dev
Cory89 has quit [Ping timeout: 250 seconds]
Cory38 has quit [Ping timeout: 250 seconds]
emcy__ has joined #bitcoin-core-dev
_durandal has quit [Ping timeout: 258 seconds]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
Cory88 has quit [Quit: Client closed]
Cory88 has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 258 seconds]
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
tarotfied has quit [Quit: WeeChat 4.1.1]
TheRec has quit []
TheRec has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
Cory88 has quit [Quit: Client closed]
Cory88 has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
tarotfied has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
WizJin has quit [Ping timeout: 256 seconds]
adil has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 258 seconds]
yuvicc has joined #bitcoin-core-dev
yuvicc has quit [Client Quit]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
in3rsha has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 256 seconds]
l0rinc has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 258 seconds]
adil has quit [Quit: adil]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 258 seconds]
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 258 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 256 seconds]
l0rinc has quit [Quit: l0rinc]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 250 seconds]
<bitcoin-git> [bitcoin] Sjors closed pull request #33290: build: suggest -DENABLE_IPC=OFF when missing capnp (master...2025/08/missing_capnp) https://github.com/bitcoin/bitcoin/pull/33290
kevkevin has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 256 seconds]
Talkless has joined #bitcoin-core-dev
robobub has quit [Quit: Connection closed for inactivity]
Guyver2 has joined #bitcoin-core-dev
f321x has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 256 seconds]
vincenzopalazzo has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
rszarka has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 258 seconds]
robszarka has quit [Ping timeout: 256 seconds]
kevkevin has joined #bitcoin-core-dev
b10c has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
b10c has joined #bitcoin-core-dev
b10c has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/647cdb4f7e80...32e2484b67e6
<bitcoin-git> bitcoin/master c9d5f21 fanquake: depends: strip when installing qt
<bitcoin-git> bitcoin/master 32e2484 merge-script: Merge bitcoin/bitcoin#33304: depends: strip when installing qt binaries
<bitcoin-git> [bitcoin] fanquake merged pull request #33304: depends: strip when installing qt binaries (master...strip_qt_bins) https://github.com/bitcoin/bitcoin/pull/33304
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/32e2484b67e6...37c21ebe4078
<bitcoin-git> bitcoin/master 61ec886 glozow: [doc] archive v29.1 release notes
<bitcoin-git> bitcoin/master 37c21eb merge-script: Merge bitcoin/bitcoin#33309: doc: archive v29.1 release notes
<bitcoin-git> [bitcoin] fanquake merged pull request #33309: doc: archive v29.1 release notes (master...2025-09-archive-29.1) https://github.com/bitcoin/bitcoin/pull/33309
<bitcoin-git> [bitcoin] purpleKarrot opened pull request #33317: draft: CMake Goals and Guidelines (master...cmake-guidelines) https://github.com/bitcoin/bitcoin/pull/33317
b10c has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
b10c has joined #bitcoin-core-dev
b10c has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 256 seconds]
bitcoinlover has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
in3rsha has quit [Quit: Leaving]
jqq_ has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
<hodlinator> achow101_: The 29.1 release notes made me see "Old wallet versions of Bitcoin Core are generally supported." - my impression is that this has changed for v30? https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes-empty-template.md?plain=1#L32-L33
w0xlt has quit [Ping timeout: 260 seconds]
Guest4822 has left #bitcoin-core-dev [#bitcoin-core-dev]
dviola has joined #bitcoin-core-dev
<sipa> node0 stderr bitcoin-node: ipc/libmultiprocess/include/mp/proxy-io.h:279: void mp::Waiter::post(Fn &&) [Fn = (lambda at ./ipc/libmultiprocess/include/mp/type-context.h:67:19)]: Assertion `!m_fn' failed.
<kevkevin> looks like the test got hung up on this line in the ipc test: template4 = File "/home/admin/actions-runner/_work/_temp/build/test/functional/interface_ipc.py", line 156, in async_routine: await template2.result.waitNext(ctx, waitoptions)
<sipa> yeah, bitcoin-node crashed during that invocation
<sipa> i can reproduce it locally, though it's pretty rare (once in 60 runs, so far)
<kevkevin> hmm interesting, I'll try to reproduce it locally myself
<ryanofsky> that is interesting, i've never seen that assert hit before. i think it could happen if two ipc clients try to execute a different IPC calls on the same thread at the same time
<sipa> huh!
<ryanofsky> libmultiprocess assumes a 1:1 threading model where a there is one server thread for every client thread, emulating a traditional c++ call stack
<ryanofsky> allowing recursive mutexes, synchronous callbacks, etc
<sipa> should the python side do anything specific to arrange that?
<sipa> i would assume not, because there is only one thread on the python side that does all IPC calls
<ryanofsky> it should just make two IPC calls at the same time, and they should be calls that do not return instantly like waitNext
<ryanofsky> yeah, it is unexpected that current python test would cause that
<dodo> c
hacker4web3bitco has joined #bitcoin-core-dev
<ryanofsky> maybe there is a race condition where c++ code sends a response but the server thread doesn't return to being idle, and python code sends the next request quickly enough to hit the assert
bitcoinlover has quit [Ping timeout: 248 seconds]
<sipa> oh, i may have messed something up
<sipa> waitnext = template2.result.waitNext(ctx, waitoptions)
<sipa> template4 = await template2.result.waitNext(ctx, waitoptions)
<sipa> might create two asynchronous calls simultaneously?
<ryanofsky> it seems like that would just chain the calls so the server runs them back to back, and make the bug more likely to happen
<ryanofsky> but if you added an await on the first line it might prevent this
<sipa> the first one is just unnecessary - i inlined it into the second one, but forgot to remove the original
<sipa> you say "make the bug more likely", so you think that the bug isn't in this code itself, but elsewhere?
<ryanofsky> actually i misread. yeah i assumed you were using waitnext variable second line and the calls would be chained. but actually this does look like simultaneous calls
<sipa> alright, let me run it 1000 times to see if it reappears, but if not, i'm going to assume that was the culprit
<ryanofsky> no i think this code does explain the bug
<sipa> thanks!
<ryanofsky> i just first misread it as chained calls that would be pipelined when actually those are parallel calls
<sipa> right
<ryanofsky> thanks for the test, and finding this. server could definitely do better here, it could just refuse the request instead of asserting
<sipa> or at least a more helpful error message
<sipa> i could imagine third parties trying to use the interface might hit something like this too
<ryanofsky> yeah the error message is the most important thing in practice
jespada has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark opened pull request #33319: ci: reduce runner sizes on various jobs (master...economise-runner-sizes) https://github.com/bitcoin/bitcoin/pull/33319
aleggg has quit [Ping timeout: 265 seconds]
w0xlt has joined #bitcoin-core-dev
jqq_ has quit [Quit: Connection closed for inactivity]
aleggg has joined #bitcoin-core-dev
f321x_ has joined #bitcoin-core-dev
f321x has quit [Ping timeout: 272 seconds]
bitcoinlover has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
hacker4web3bitco has quit [Ping timeout: 256 seconds]
hacker4web3bitco has joined #bitcoin-core-dev
bitcoinlover has quit [Ping timeout: 258 seconds]
bitcoinlover has joined #bitcoin-core-dev
hacker4web3bitco has quit [Ping timeout: 256 seconds]
jerryf has quit [Ping timeout: 272 seconds]
brunoerg has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
hacker4web3bitco has joined #bitcoin-core-dev
Cory76 has joined #bitcoin-core-dev
bitcoinlover has quit [Ping timeout: 256 seconds]
Cory88 has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 256 seconds]
bitcoinlover has joined #bitcoin-core-dev
hacker4web3bitco has quit [Ping timeout: 256 seconds]
<bitcoin-git> [bitcoin] stickies-v opened pull request #33321: kernel: make blockTip index const (master...2025-09/kernel-blocktip-const) https://github.com/bitcoin/bitcoin/pull/33321
w0xlt has quit [Ping timeout: 258 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 250 seconds]
l0rinc has joined #bitcoin-core-dev
f321x_ has quit [Quit: f321x_]
Juliu has joined #bitcoin-core-dev
Cory76 has quit [Quit: Client closed]
Cory76 has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 248 seconds]
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] glozow pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/37c21ebe4078...e04cb9c1bdf2
<bitcoin-git> bitcoin/master 8c7f005 Ryan Ofsky: test: add is_ipc_compiled() and skip_if_no_ipc() functions
<bitcoin-git> bitcoin/master 3cceb60 Ryan Ofsky: test: Provide path to `bitcoin` binary
<bitcoin-git> bitcoin/master 3cc9a06 Ryan Ofsky: test: Add TestNode ipcbind option
<bitcoin-git> [bitcoin] glozow merged pull request #33201: Add functional test for IPC interface (master...202508_ipc_test) https://github.com/bitcoin/bitcoin/pull/33201
jon_atack has quit [Ping timeout: 258 seconds]
Cory72 has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
Cory76 has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
Juliu has left #bitcoin-core-dev [#bitcoin-core-dev]
jonatack has quit [Ping timeout: 244 seconds]
brunoerg has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
jerryf_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 272 seconds]
jon_atack has quit [Ping timeout: 265 seconds]
bitcoinlover has quit [Ping timeout: 250 seconds]
jon_atack has joined #bitcoin-core-dev
Cory89 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 245 seconds]
Cory72 has quit [Ping timeout: 250 seconds]
Cory89 has quit [Quit: Client closed]
Cory89 has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 248 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 258 seconds]
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 258 seconds]
eugenesiegel has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
<achow101_> hodlinator: old wallets generally are supported, e.g. old descriptor wallets. and also imo the migration tool counts as a form of support
achow101_ is now known as achow101
w0xlt has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 250 seconds]
jonatack has quit [Ping timeout: 258 seconds]
l0rinc has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 258 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 258 seconds]
Cory63 has joined #bitcoin-core-dev
Cory89 has quit [Ping timeout: 250 seconds]
jonatack has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 248 seconds]
mudsip has quit [Client Quit]
eugenesiegel has quit [Quit: Client closed]
jonatack has quit [Ping timeout: 260 seconds]
jonatack has joined #bitcoin-core-dev
Cory52 has joined #bitcoin-core-dev
Cory63 has quit [Ping timeout: 250 seconds]
w0xlt has joined #bitcoin-core-dev
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Read error: Connection reset by peer]
PaperSword1 is now known as PaperSword
jonatack has quit [Ping timeout: 260 seconds]
l0rinc has quit [Quit: l0rinc]
jonatack has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 256 seconds]
l0rinc has joined #bitcoin-core-dev
Jouke has joined #bitcoin-core-dev
<Jouke> 15 hours memtest86+ later, but no errors :/
<bitcoin-git> [bitcoin] ryanofsky opened pull request #33322: Update libmultiprocess subtree to improve build and logs (master...pr/subtree-4) https://github.com/bitcoin/bitcoin/pull/33322
Cory24 has joined #bitcoin-core-dev
Cory52 has quit [Ping timeout: 250 seconds]
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
Cory51 has joined #bitcoin-core-dev
Cory24 has quit [Ping timeout: 250 seconds]
Cory51 has quit [Quit: Client closed]
Cory51 has joined #bitcoin-core-dev
Guest63 has joined #bitcoin-core-dev
Guest63 has quit [Client Quit]
G49 has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
w0xlt has quit [Ping timeout: 258 seconds]
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 248 seconds]
G49 has quit [Quit: Client closed]
Talkless has quit [Quit: Konversation terminated!]
l0rinc has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 258 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43_ has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 250 seconds]
ghost43 has quit [Remote host closed the connection]
ghost43_ has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
jon_atack has quit [Read error: Connection reset by peer]
jon_atack has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e04cb9c1bdf2...36e40417de3f
<bitcoin-git> bitcoin/master c0d28c8 Hennadii Stepanov: qt: Fix compatibility with `-debuglogfile` command-line option
<bitcoin-git> bitcoin/master 36e4041 Hennadii Stepanov: Merge bitcoin-core/gui#884: Fix compatibility with `-debuglogfile` command...
<bitcoin-git> [gui] hebasto merged pull request #884: Fix compatibility with `-debuglogfile` command-line option (master...250819-debuglog) https://github.com/bitcoin-core/gui/pull/884
w0xlt has quit [Ping timeout: 260 seconds]
Jouke has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] l0rinc opened pull request #33324: RFC: blocks: add `-reobfuscate-blocks` arg to xor existing blk/rev on startup (master...l0rinc/reobfuscate-blocks) https://github.com/bitcoin/bitcoin/pull/33324