achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
dviola has joined #bitcoin-core-dev
shwouchk has joined #bitcoin-core-dev
shwouchk has quit [Client Quit]
durandal_ has quit [Ping timeout: 244 seconds]
durandal_ has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
l0rinc has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
purpleKarrot has quit [Quit: purpleKarrot]
purpleKarrot has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack1 has quit [Ping timeout: 244 seconds]
<bitcoin-git> [bitcoin] polespinasa opened pull request #33507: RPC: add sendrawtransactiontopeer (master...2025-09-29-sendrawtransactiontopeer) https://github.com/bitcoin/bitcoin/pull/33507
tarotfied has quit [Ping timeout: 240 seconds]
tarotfied has joined #bitcoin-core-dev
l0rinc has quit [Read error: Connection reset by peer]
l0rinc has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 256 seconds]
<_aj_> darosior: messing around with mainnet consensus parameters seems like a bad idea, and exposing it as a configuration option seems worse; if you want to test things and need different consensus parameters, that seems like something where regtest should be the answer
l0rinc has quit [Quit: l0rinc]
jerryf_ has joined #bitcoin-core-dev
synexic has quit [Ping timeout: 265 seconds]
jerryf has quit [Ping timeout: 272 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
synexic has joined #bitcoin-core-dev
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
Guest81 has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
Guest81 has quit [Client Quit]
dodo has quit [Remote host closed the connection]
michaelfolkson has quit [Quit: ZNC 1.8.2 - https://znc.in]
dodo has joined #bitcoin-core-dev
purpleKarrot has quit [Quit: purpleKarrot]
michaelfolkson has joined #bitcoin-core-dev
purpleKarrot has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
purpleKarrot has quit [Quit: purpleKarrot]
purpleKarrot has joined #bitcoin-core-dev
spynx has joined #bitcoin-core-dev
spynxic has quit [Read error: Connection reset by peer]
robszarka has joined #bitcoin-core-dev
ghost43 has joined #bitcoin-core-dev
ghost43_ has quit [Ping timeout: 272 seconds]
szarka has quit [Ping timeout: 244 seconds]
josie has quit [Quit: ZNC 1.8.2 - https://znc.in]
josie has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d8fe258cd610...25212dfdb4cd
<bitcoin-git> bitcoin/master d4f47f9 fanquake: ci: use latest versions of lint deps
<bitcoin-git> bitcoin/master 25212df Hennadii Stepanov: Merge bitcoin/bitcoin#33487: ci: use latest versions of lint deps
<bitcoin-git> [bitcoin] hebasto merged pull request #33487: ci: use latest versions of lint deps (master...ci_bump_deps) https://github.com/bitcoin/bitcoin/pull/33487
f321x has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
Guest18 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Guest18 has left #bitcoin-core-dev [#bitcoin-core-dev]
Guyver2 has left #bitcoin-core-dev [Closing Window]
kevkevin has quit [Ping timeout: 265 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 256 seconds]
aleggg has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
WizJin_ has quit [Read error: Connection reset by peer]
WizJin_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
brunoerg has quit [Ping timeout: 244 seconds]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark opened pull request #33508: ci: fix buildx gha cache authentication on forks (master...export-action-vars) https://github.com/bitcoin/bitcoin/pull/33508
JTL2 has joined #bitcoin-core-dev
JTL has quit [Ping timeout: 256 seconds]
f321x_ has joined #bitcoin-core-dev
f321x has quit [Ping timeout: 272 seconds]
mudsip has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] maflcko opened pull request #33509: ci: Check macos-cross (master...2509-ci-mac-cross) https://github.com/bitcoin/bitcoin/pull/33509
mudsip has quit []
kevkevin has joined #bitcoin-core-dev
furszy_ has quit [Quit: ZNC - https://znc.in]
furszy has joined #bitcoin-core-dev
f321x has joined #bitcoin-core-dev
f321x_ has quit [Ping timeout: 272 seconds]
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
rszarka has joined #bitcoin-core-dev
robszarka has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
ghost43 has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
l0rinc has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
hirish has quit [Quit: ZNC - https://znc.in]
furszy has quit [Changing host]
furszy has joined #bitcoin-core-dev
WizJin__ has joined #bitcoin-core-dev
hirish has joined #bitcoin-core-dev
WizJin_ has quit [Ping timeout: 252 seconds]
enochazariah has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<darosior> _aj_: we already have ways to mess with consensus, especially with hidden options / commands. But i can make it unavailable to the user in init.cpp if you really feel strongly
<darosior> Regtest isn't an option because what i have are test vectors for a BIP. Regtest is Core specific and the test vectors need to exhibit mainnet-specific behaviour
enochazariah has quit [Ping timeout: 250 seconds]
l0rinc has quit [Quit: l0rinc]
bugs_ has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
robobub has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Client Quit]
f321x has quit [Remote host closed the connection]
f321x has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
enochazariah has quit [Ping timeout: 250 seconds]
enochazariah has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 256 seconds]
<_aj_> darosior: if they're test vectors that don't match mainnet consensus parameters, i'm skeptical that they're very meaningful
l0rinc has joined #bitcoin-core-dev
<darosior> _aj_: well they are certainly a lot more than ones using regtest, where the actually relevant consensus parameters are different
<_aj_> darosior: changing regtests consensus params to match seems a lot less risky than changing mainnet's
<darosior> Ok it seems we aren't talking about the same thing. Nobody is suggesting to change the mainnet params.
cotsuka has quit [Remote host closed the connection]
<_aj_> darosior: would you care to be more specific?
<sipa> darosior you're just talking about making the mainnet consensus params object non-const, and having some way to modify them from within unit tests, not through command-line options?
<darosior> Ok i'll push a branch
<darosior> I just want to let unit tests set -vbparams
<darosior> Nothing more
cotsuka has joined #bitcoin-core-dev
<_aj_> for which chain?
<darosior> For the main chain
<_aj_> so you are suggesting changing mainnet params
<darosior> No, i'm suggesting to make it possible for a unit test to set the activation height of a soft fork. You are objecting as if i wanted to change the mainnet chainparams directly, which is obviously not the case.
<darosior> You are also objecting by saying that having test vectors on mainnet is pointless if it's not the right activation height. But it's unreasonable, i can't know the activation before having test vectors for the soft fork in the first place.
<_aj_> if you just want it for unit tests, then having some separate subclass of CMainParams that you access via something other than CChainParams::Main() could be plausible, but i remain skeptical that this is particularly useful
<sipa> for segwit we created a segwit-specific test network, btw
<_aj_> four of them or so iirc
<_aj_> darosior: which rule sets do you want to change the activation height of?
<darosior> I think that it's valuable for a soft fork that proposes a change to mainnet difficulty adjustment, to have test vectors that actually exercise mainnet difficulty adjustment. It's also not as if that required a massive change to Core, just let an already-existing setting not be exclusive to regtest.
<darosior> I think it's easy for us to take a Core-centric perspective and i want to make sure the test vectors have as little Core-isms as possible.
<darosior> _aj_: i want to be able to activate BIP54 when testing it. It does not have an activation height already.
<_aj_> darosior: and you're happy to have BIP34 inactive until height 227931?
<darosior> This specific unit test is exercising the timewarp and Murch-Zawy fixes. These are unrelated to BIP34.
<_aj_> darosior: then why don't you just activate it via version bits signalling?
f321x_ has joined #bitcoin-core-dev
<darosior> To do this i would need to set the vbparams, that's my point.
<_aj_> darosior: oh, when the mainnet activation params are NEVER_ACTIVE?
f321x has quit [Ping timeout: 272 seconds]
<_aj_> darosior: how are these tests supposed to work when activation parameters are determined, and eventually buried?
<darosior> You can just set the buried height in the test then.
<darosior> We have two arguments directing deployments, one for buried ones and one for version bits ones. My patch makes both available to non-regtest chains
<darosior> Just make something that already exist not exclusive to regtest. That's it. Nothing more. Doesn't even need to be exposed to end users if we think it's such a bad idea.
<_aj_> i don't think it's a good idea to expose it to core developers, let alone users
ghost43_ has joined #bitcoin-core-dev
<darosior> I can do other hacks to be able to run BIP54 test vectors inside Core, that just seemed like the obvious neat way to go about it.
<_aj_> am i understanding correctly that you're expecting other implementations to also just expose modified mainnet parameters in order to run your test vectors?
<darosior> I'm doing that for other implementations in the first place.
l0rinc has quit [Quit: l0rinc]
ghost43 has quit [Remote host closed the connection]
<darosior> To not expect them to implement Core-specific test networks such as Regtest.
l0rinc has joined #bitcoin-core-dev
<darosior> If you have a better idea for testing the timewarp fix than a bunch of chains of headers with various timestamps at difficulty adjustment bounds, suggestions welcome.
l0rinc has quit [Quit: l0rinc]
<_aj_> darosior: btcd seems to implement regtest, https://github.com/btcsuite/btcd/blob/b7d070601def0f94e3713879b19f1678949a8d68/chaincfg/genesis.go#L106 ; and your test-vectors would be a new set of chain parameters anyway
TallTim_ has joined #bitcoin-core-dev
TallTim has quit [Ping timeout: 250 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
<_aj_> darosior: i'm not sure where you're putting the enforcement code exactly; but i would expect something that gives a [start-height, start-mediantime, start-nbits, vector<ntime>, valid-or-invalid?] and calls the test functions directly would be easier to use, and easier to examine
purpleKarrot has quit [Quit: purpleKarrot]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
spynx is now known as spynxic
Talkless has joined #bitcoin-core-dev
rszarka has quit [Quit: Leaving]
szarka has joined #bitcoin-core-dev
f321x_ has quit [Quit: f321x_]
<darosior> I think i'll just open the PR to inquisition and we can argue on the specifics there. I'm most of the way there, i mined the chains etc. But i'm happy to take an alternative approach if it makes more sense.
l0rinc has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
jon_atack has quit [Ping timeout: 250 seconds]
l0rinc has joined #bitcoin-core-dev
JTL2 has quit [Quit: WeeChat 2.9]
l0rinc has quit [Quit: l0rinc]
enochazariah has quit [Quit: Client closed]
JTL has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
pedrohgs has joined #bitcoin-core-dev
Guest36 has joined #bitcoin-core-dev
pedrohgs has quit [Changing host]
pedrohgs has joined #bitcoin-core-dev
Saturday7 has quit [Ping timeout: 248 seconds]
Saturday7 has joined #bitcoin-core-dev
pedrohgs has quit [Quit: WeeChat 4.1.1]
pedrohgs has joined #bitcoin-core-dev
Guest36 has quit [Ping timeout: 250 seconds]
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/25212dfdb4cd...8f73d9522146
<bitcoin-git> bitcoin/master fc86133 furszy: wallet, log: reduce unconditional logging during load
<bitcoin-git> bitcoin/master 8f73d95 Ava Chow: Merge bitcoin/bitcoin#33299: wallet: reduce unconditional logging during l...
<bitcoin-git> [bitcoin] achow101 merged pull request #33299: wallet: reduce unconditional logging during load (master...2025_wallet_log_less) https://github.com/bitcoin/bitcoin/pull/33299
jon_atack has joined #bitcoin-core-dev
pedrohgs has quit [Quit: WeeChat 4.1.1]
jonatack has quit [Ping timeout: 255 seconds]
pedrohgs has joined #bitcoin-core-dev
pedrohgs has quit [Client Quit]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
janb84 has quit [Quit: WeeChat 4.7.1]
<bitcoin-git> [packaging] achow101 pushed 3 commits to main: https://github.com/bitcoin-core/packaging/compare/7db4fa1b01dd...dd351ba5fe0b
<bitcoin-git> packaging/main bbf7337 Ava Chow: Revert "snap: Enable `kde-neon` extension"
<bitcoin-git> packaging/main 7420996 Ava Chow: Revert "snap: Drop `desktop-launch`"
<bitcoin-git> packaging/main dd351ba Ava Chow: Merge bitcoin-core/packaging#298: Revert "snap: Enable `kde-neon` extensio...
<bitcoin-git> [packaging] achow101 merged pull request #298: Revert "snap: Enable `kde-neon` extension" and "snap: Drop `desktop-launch`" (main...fix-other-arch-builds) https://github.com/bitcoin-core/packaging/pull/298
janb84 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 250 seconds]
brunoerg has quit [Ping timeout: 255 seconds]
Guest36 has joined #bitcoin-core-dev
Guest36 has quit [Client Quit]
Deckard773 has joined #bitcoin-core-dev
Deckard773 has quit [Client Quit]
Deckard773 has joined #bitcoin-core-dev
Deckard773 has quit [Client Quit]
Deckard773 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
Deckard773 has quit [Client Quit]
jonatack has quit [Ping timeout: 265 seconds]
szkl has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
enochazariah has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ryanofsky opened pull request #33511: init: Signal m_tip_block_cv on Ctrl-C (master...pr/sigwait) https://github.com/bitcoin/bitcoin/pull/33511
l0rinc has quit [Quit: l0rinc]
Talkless has quit [Quit: Konversation terminated!]
enochazariah has quit [Ping timeout: 250 seconds]
l0rinc has joined #bitcoin-core-dev
Guest11 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
jonatack has quit [Ping timeout: 264 seconds]
l0rinc has joined #bitcoin-core-dev
Gy has joined #bitcoin-core-dev
Gy has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest16 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 265 seconds]
Guest11 has quit [Quit: Client closed]
Guest16 has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8f73d9522146...7502d4e94038
<bitcoin-git> bitcoin/master fabc261 MarcoFalke: test: Use extra_port() helper in feature_bind_extra.py
<bitcoin-git> bitcoin/master 7502d4e Ava Chow: Merge bitcoin/bitcoin#33260: test: Use extra_port() helper in feature_bind...
<bitcoin-git> [bitcoin] achow101 merged pull request #33260: test: Use extra_port() helper in feature_bind_extra.py (master...2508-test-extra-port-doc) https://github.com/bitcoin/bitcoin/pull/33260
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
kevkevin has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sipa closed pull request #31703: Use number of dirty cache entries in flush warnings/logs (master...202501_dirty_coin_count) https://github.com/bitcoin/bitcoin/pull/31703
brunoerg has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7502d4e94038...cc4a2cc6bdc4
<bitcoin-git> bitcoin/master 451ba9a Anthony Towns: datacarrier: Undeprecate configuration option
<bitcoin-git> bitcoin/master cc4a2cc Ava Chow: Merge bitcoin/bitcoin#33453: docs: Undeprecate datacarrier and datacarrier...
<bitcoin-git> [bitcoin] achow101 merged pull request #33453: docs: Undeprecate datacarrier and datacarriersize configuration options (master...2025-09-datacarrier-undep) https://github.com/bitcoin/bitcoin/pull/33453
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] achow101 pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/cc4a2cc6bdc4...f41f97240c06
<bitcoin-git> bitcoin/master e883b37 Vasil Dimov: fuzz: set the output argument of FuzzedSock::Accept()
<bitcoin-git> bitcoin/master e6a917c Vasil Dimov: fuzz: add Fuzzed NetEventsInterface and use it in connman tests
<bitcoin-git> bitcoin/master 50da743 Vasil Dimov: fuzz: add CConnman::OpenNetworkConnection() to the tests
<bitcoin-git> [bitcoin] achow101 merged pull request #28584: Fuzz: extend CConnman tests (master...fuzz_connman) https://github.com/bitcoin/bitcoin/pull/28584
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 264 seconds]
l0rinc has quit [Quit: l0rinc]
bitdex has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 265 seconds]
kevkevin has quit [Ping timeout: 264 seconds]
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
jon_atack has quit [Ping timeout: 264 seconds]
Holz has quit [Read error: Connection reset by peer]