<bitcoin-git>
[bitcoin] jalateras opened pull request #33360: rpc: Add validation for invalid taproot signatures in analyzepsbt (master...fix-analyzepsbt-taproot-validation) https://github.com/bitcoin/bitcoin/pull/33360
l0rinc has quit [Quit: l0rinc]
jon_atack has quit [Ping timeout: 252 seconds]
purpleKarrot has quit [Quit: purpleKarrot]
purpleKarrot has joined #bitcoin-core-dev
purpleKarrot has quit [Client Quit]
l0rinc has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 244 seconds]
w0xlt has quit [Ping timeout: 258 seconds]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 258 seconds]
luke-jr_ has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 250 seconds]
Cory88 has joined #bitcoin-core-dev
Cory60 has quit [Ping timeout: 250 seconds]
Cory50 has joined #bitcoin-core-dev
Cory88 has quit [Ping timeout: 250 seconds]
LainIwakura has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
busy has quit [Quit: Leaving]
MrHAPPY has quit []
l0rinc has quit [Quit: l0rinc]
cmirror has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 248 seconds]
<jeremyrubin>
ack; I got scammed by some out of date bindings :)
w0xlt has joined #bitcoin-core-dev
<jeremyrubin>
only note is that it would be preferable to include the header's hash and the mediantime, as returned by getblockheader, since then you have a more complete set of info wrt prevouts
w0xlt has quit [Ping timeout: 256 seconds]
l0rinc has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 258 seconds]
w0xlt has joined #bitcoin-core-dev
Christoph_ has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 260 seconds]
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 250 seconds]
w0xlt has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 260 seconds]
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
edouardparis has quit [Changing host]
edouardparis has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
bitcoinlover has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
w0xlt has quit [Ping timeout: 256 seconds]
Christoph_ has quit [Quit: Christoph_]
Christoph_ has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 248 seconds]
<bitcoin-git>
[bitcoin] jalateras opened pull request #33361: Fix #25980: Validate transactions in combinerawtransaction (master...fix-combinerawtransaction-25980) https://github.com/bitcoin/bitcoin/pull/33361
kevkevin has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
robobub has quit [Quit: Connection closed for inactivity]
<bitcoin-git>
[bitcoin] vasild opened pull request #33362: Run feature_bind_port_(discover|externalip).py in CI (master...ci_add1111addr) https://github.com/bitcoin/bitcoin/pull/33362
f321x has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
w0xlt has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 256 seconds]
kevkevin has quit [Remote host closed the connection]
robszarka has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 256 seconds]
jerryf has joined #bitcoin-core-dev
conman has quit [Read error: Connection reset by peer]
jerryf_ has quit [Ping timeout: 272 seconds]
emzy_ is now known as Emzy
jarthur has quit [Quit: jarthur]
PatBoy has quit [Ping timeout: 260 seconds]
LainIwakura has quit [Quit: Client closed]
PatBoy has joined #bitcoin-core-dev
thelounge49666 has quit [Read error: Connection reset by peer]
<achow101>
There are 2 preproposed meeting topics this week, any last minute ones to add?
<stickies-v>
hi
<achow101>
#topic Kernel WG Update (TheCharlatan)
<TheCharlatan>
aj left some interesting comments in #32317. The conversation there binds into the larger discussion of how many changes to the kernel motivated by external users the project can stomach.
<TheCharlatan>
no concrete outcome from that yet, but it is probably a theme that will be repeated a few times still.
<ryanofsky>
no informed opinion but my initial thought on 32317 was it make code nicer by splitting up a big function
<TheCharlatan>
other than that, others in the workgroup have been adapting their respective language bindings to the latest proposed C header api.
<TheCharlatan>
that's all
w0xlt has joined #bitcoin-core-dev
<achow101>
#topic Benchmarking WG Update (josie, l0rinc)
<l0rinc>
It's not about benchmarking, but the v3 release. People are scared for V30 and I think we could make a few changes that might help in calming the spirits:
<l0rinc>
* people complain the new versions have become slower, one of the reasons is signature verification is enabled sooner with older versions. Some logging was already added, but there are leftover corner cases covered here: #33336
<l0rinc>
* another reason for the slowdowns seems to be that the recently unbounded dbcache values are set too high and the node is swapping heavily - added a warning log for that case in this beautiful pr number #33333
<l0rinc>
* lastly a lot of people fear that their cloud node will get banned because of the block content - older nodes don't have block obfuscation enabled, added #33324
<corebot>
https://github.com/bitcoin/bitcoin/issues/33324 | RFC: blocks: add `-reobfuscate-blocks` arg to xor existing blk/rev on startup by l0rinc · Pull Request #33324 · bitcoin/bitcoin · GitHub
<achow101>
l0rinc: we will have a v30 specific topic
<l0rinc>
Thank for for the reviews and comments so far - what's the overall sentiment, could we include any of these in v30?
<l0rinc>
my mistake, nothing from my side
<achow101>
#topic Cluster Mempool WG Update (sdaftuar, sipa)
<sipa>
good progress, i've changed the main PR to review to sdaftuar's #28676
<corebot>
sipa: Error: That URL raised <Connection timed out.>
<sipa>
there are a number of txgraph PRs, but they're not on the critical path
<sipa>
i think sdaftuar's is working on addressing review comments
<sipa>
that's it from me
<achow101>
#topic QML GUI WG Update (jarolrod, johnny9dev)
<johnny9dev>
Not much at the moment. Working on adding QML testing on top of the unit test I added to get coverage on the views.
<johnny9dev>
thats all
<achow101>
#topic MuSig2 WG Update (achow101)
f321x has quit [Quit: f321x]
<achow101>
pr to review is still #29675, which has been getting some review that i've addressed
<corebot>
https://github.com/bitcoin/bitcoin/issues/29675 | wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys by achow101 · Pull Request #29675 · bitcoin/bitcoin · GitHub
<achow101>
#topic v30.0rc1
<achow101>
The rc1 has been tagged, although bins not uploaded yet. Any issues that people have noticed in testing?
<hebasto>
I think I could fix cmake issue from it shortly
<achow101>
l0rinc: are those issues regressions?
<l0rinc>
not exactly, but one is an incomplete implementation - not logging signature verification in some cases
cfields_ is now known as cfields
<sipa>
in what way are new versions slower?
<sipa>
i'd expect each new version to be observably faster, with the assumevalid point moved forward
<l0rinc>
Yeah, I should have made that clearer: fetching the blockchain has become slower with the older node versions
<sipa>
older?
<achow101>
I think it might be a bit late to be adding draft PRs during the RCs, #33324 seems to have a number of open questions
<l0rinc>
having assumevalid for lower block heights enables script verification sooner
<corebot>
https://github.com/bitcoin/bitcoin/issues/33324 | RFC: blocks: add `-reobfuscate-blocks` arg to xor existing blk/rev on startup by l0rinc · Pull Request #33324 · bitcoin/bitcoin · GitHub
w0xlt has quit [Ping timeout: 258 seconds]
<l0rinc>
achow101: that's why I'm asking, there's Andre Toth's alternative for reobfuscation
<l0rinc>
*andrew
<sipa>
l0rinc: you mean just that old versions gradually become slower as the chain grows? that seems... inevitable and obvious?
Talkless has joined #bitcoin-core-dev
LainIwakura has quit [Ping timeout: 250 seconds]
<l0rinc>
somewhat yes, but instead of explaining it every time I thought it would be more helpful to show related logs
<achow101>
l0rinc: I don't disagree with the premise, I'm just not sure that the pr can be sufficiently reviewed for the release, considering that we have now entered the rc phase
<l0rinc>
got it - what about the two logging PRs?
<achow101>
in particular, because it is a draft, and there are a number of open questions
<sipa>
seems like a nice feature, but i don't think it's related to v30 or deserves special treatment
<achow101>
the other two seem fine to me
<l0rinc>
thanks for the feedback
<darosior>
I plan on testing rc1 in the coming week.
<darosior>
Haven't yet.
<achow101>
Any other topics to discuss?
<TheCharlatan>
would be interesting to test the mining interface a bit. maybe through Sjors client?
<sipa>
we have python functional tests too, they can be expanded
<achow101>
#topic Drop support for Ubuntu 22.04 LTS as a build platform (hebasto)
TC has joined #bitcoin-core-dev
<hebasto>
purpleKarrot asked me to postpone this topic until later, as he is unable to attend today's meeting
enochazariah has quit [Quit: Client closed]
<achow101>
ok
<hebasto>
so let's skip it
<achow101>
Anything else to discuss?
<hebasto>
my apologies to all
_durandal has joined #bitcoin-core-dev
<achow101>
#endmeeting
Emc99 has quit [Quit: Client closed]
enochazariah has joined #bitcoin-core-dev
Cory39 has quit [Quit: Client closed]
durandal_ has quit [Ping timeout: 265 seconds]
durandal_ has joined #bitcoin-core-dev
Cory39 has joined #bitcoin-core-dev
_durandal has quit [Ping timeout: 260 seconds]
corebot has quit [Remote host closed the connection]
corebot has joined #bitcoin-core-dev
cotsuka has quit [Remote host closed the connection]
Cory39 has quit [Quit: Client closed]
Cory39 has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
w0xlt has joined #bitcoin-core-dev
eugenesiegel has joined #bitcoin-core-dev
Murch[m] has quit [Changing host]
Murch[m] has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
enochazariah has quit [Ping timeout: 250 seconds]
Christoph_ has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
Christoph_ has quit [Ping timeout: 248 seconds]
jon_atack has joined #bitcoin-core-dev
cotsuka has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 258 seconds]
Christoph_ has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
Christoph_ has quit [Ping timeout: 248 seconds]
cbspears918 has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
w0xlt has quit [Ping timeout: 256 seconds]
Cory39 has quit [Quit: Client closed]
Cory39 has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 256 seconds]
w0xlt has quit [Ping timeout: 258 seconds]
Ademan has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 245 seconds]
w0xlt has joined #bitcoin-core-dev
Cory41 has joined #bitcoin-core-dev
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Ping timeout: 272 seconds]
Cory39 has quit [Ping timeout: 250 seconds]
w0xlt has quit [Ping timeout: 248 seconds]
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 250 seconds]
twistedline has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
<achow101>
30.0rc1 bins are up
w0xlt has quit [Ping timeout: 258 seconds]
Christoph_ has joined #bitcoin-core-dev
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 250 seconds]
PaperSword1 is now known as PaperSword
cbspears918 has quit [Quit: Leaving]
l0rinc has quit [Remote host closed the connection]
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
Cory4 has joined #bitcoin-core-dev
Cory41 has quit [Ping timeout: 250 seconds]
Talkless has quit [Quit: Konversation terminated!]
kevkevin has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
w0xlt has joined #bitcoin-core-dev
greypw1495085720 has quit [Quit: Ping timeout (120 seconds)]
w0xlt has quit [Ping timeout: 256 seconds]
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 260 seconds]
PaperSword1 is now known as PaperSword
kevkevin has quit [Remote host closed the connection]
Cory4 has quit [Quit: Client closed]
Cory4 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
Cory4 has quit [Quit: Client closed]
Cory4 has joined #bitcoin-core-dev
cotsuka has quit [Remote host closed the connection]