memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Guest74 has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Guest74 has quit [Client Quit]
dzxzg2 has quit [Remote host closed the connection]
Guest97 has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Guest97 has quit [Client Quit]
Guest3 has joined #bitcoin-core-dev
Guest3 has quit [Client Quit]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
bomb-on has quit [Quit: aллилѹіа!]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
durandal_ has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 245 seconds]
bitdex has joined #bitcoin-core-dev
durandal_ has joined #bitcoin-core-dev
itsme has joined #bitcoin-core-dev
itsme has quit [Quit: Client closed]
justache has quit [Read error: Connection reset by peer]
sliv3r__ has quit [Ping timeout: 240 seconds]
justache has joined #bitcoin-core-dev
sliv3r__ has joined #bitcoin-core-dev
ghost43_ has quit [Ping timeout: 252 seconds]
ghost43 has joined #bitcoin-core-dev
f321x has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
afiore has quit [Remote host closed the connection]
afiore has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
f321x has quit [Remote host closed the connection]
f321x has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
bomb-on has quit [Client Quit]
bomb-on has joined #bitcoin-core-dev
f321x has quit [Remote host closed the connection]
f321x has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko opened pull request #34053: lint: Remove confusing, redundant, and brittle lint-spelling (master...2512-less-lint) https://github.com/bitcoin/bitcoin/pull/34053
l0rinc has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git>
[bitcoin] sedited opened pull request #34054: net processing: Add ibd check before processing block for txdownloadman (master...txdownloadman_ibd_check) https://github.com/bitcoin/bitcoin/pull/34054
<sipa>
brunoerg: would it be worth including the fuzz tests? it doesn't need a full fuzz build, just running the normal-build fuzz binary on the qa-assets corpus
<brunoerg>
Yes, I will add it. I tested the txgraph mutants with fuzzing + qa-assets corpus and it killed over 95% of the mutants, much better then unit+func.
<sipa>
that's because txgraph basically only has fuzz tests :p
<sipa>
cool, but that explains your report in #34057
<brunoerg>
yes, but fuzzing is known for not being able to kill mutants for obvious reasons. however, i did an empirical evaluation on some targets and showed that fuzzing can achieve a high mutation score depending on how the target is written - https://sol.sbc.org.br/index.php/sast/article/view/36885/36671.
<brunoerg>
sipa: yes, it explains. i will add fuzzing and update the report.
<dergoegge>
brunoerg: you could also add bitcoinfuzz (the script interpreter differential fuzzing should be able to kill a lot of interpreter mutants)
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko opened pull request #34059: refactor: Use NodeClock::time_point for m_addr_token_timestamp (master...2512-net-less-GetTime) https://github.com/bitcoin/bitcoin/pull/34059
brunoerg has quit [Ping timeout: 260 seconds]
bugs_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<brunoerg>
dergoegge: yes, great idea!
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
f321x_ has quit [Ping timeout: 252 seconds]
<bitcoin-git>
[bitcoin] stratospher opened pull request #34060: test: fix race condition in p2p_v2_misbehaving.py peerid assertion (master...2025_12_fix_peerid_race) https://github.com/bitcoin/bitcoin/pull/34060
<bitcoin-git>
[bitcoin] marcofleon opened pull request #34061: fuzz: Fix bugs in `clusterlin_postlinearize_tree` target (master...2025/12/clusterlin-fuzz-fixes) https://github.com/bitcoin/bitcoin/pull/34061
jonatack has quit [Ping timeout: 252 seconds]
bitdex has quit [Quit: = ""]
bomb-on has quit [Quit: aллилѹіа!]
brunoerg has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] rustaceanrob opened pull request #34063: Make `transaction_indentifier` hex string constructor evaluated at comptime (master...12-12-consteval-txid) https://github.com/bitcoin/bitcoin/pull/34063
bugs_ has quit [Quit: Leaving]
saturday7 has joined #bitcoin-core-dev
saturday- has quit [Ping timeout: 240 seconds]
f321x has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
saturday7 has quit [Ping timeout: 240 seconds]
saturday7 has joined #bitcoin-core-dev
<andrewtoth>
fanquake: I'm not sure about l0rinc, but for me when I run cmake -B build it gives me an error message that tells me to solve it by building with -DENABLE_IPC=OFF. So of course I take the easy route.
<sipa>
may be worth investigating why IPC doesn't work for you!
<sipa>
(independently of the value of benchmarking/testing)
<andrewtoth>
It says I need to install capn proto
f321x has quit [Quit: f321x]
<sipa>
yeah
<fanquake>
If it’s possible for you to resolve, great. As it’d be good for benchmarking to remain as close as possible to default/release build config
<l0rinc>
I haven't seen the mention: as andrewtoth also mentioned, when it was introduced it wasn't working reliably, was easier to ignore it. I will check again if it's still needed, thanks for the hint
<andrewtoth>
Running the upgrade command in doc/build-unix.md does not work. I get an incompatible version.
<fanquake>
what systems are you on?
<andrewtoth>
pop_os 22.04
<fanquake>
If your package mama get is installing 1.1 or 1.2 and you’re still seeing problems, please open an issue. If it’s pre 1 or 1.0, I’d suggest installing 1.2 from source
<andrewtoth>
It's installing 0.8
<sipa>
i assume "mama get" is a typo for "manager", but i like the notion of a "package mama"
<andrewtoth>
yeah I thought that's what the cool kids call it so didn't mention it
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
kevkevin has quit [Remote host closed the connection]
l0rinc has joined #bitcoin-core-dev
WizJin_ has joined #bitcoin-core-dev
WizJin__ has quit [Ping timeout: 256 seconds]
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]
WizJin__ has joined #bitcoin-core-dev
WizJin__ has quit [Max SendQ exceeded]
WizJin_ has quit [Ping timeout: 245 seconds]
WizJin__ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
WizJin__ has quit [Max SendQ exceeded]
WizJin__ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
scgbckbone has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<sipa>
andrewtoth: i guess we're not cool
<andrewtoth>
my package mama thinks I'm cool
<brunoerg>
sipa: fyi running mutation testing for #32545 - including fuzzing :) as soon as I have the results will share them.
brunoerg has quit [Read error: Connection reset by peer]
<sipa>
@0 is not valid miniscript
<sipa>
you need a key expression there
<sipa>
also i don't know about /**
<sipa>
scgbckbone: those look like they're BIP 388 wallet policies, not descriptors
___nick___ has quit [Ping timeout: 246 seconds]
___nick___ has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
bomb-on has joined #bitcoin-core-dev
<scgbckbone>
yeah, I didn't want to paste descriptor here, as it becomes mess - this is BIP388 policy - but the error I pasted is from actual descriptor
<sipa>
scgbckbone: it's certainly supposed to work; there are unit and functional tests that exercise musig descriptors
<scgbckbone>
I briefly went over the test suite but I could only see tapscrits with simple pk(musig(...)) leaves - so I thought that maybe it is not implemented yet
<sipa>
oh, i see, your question is specifically about using it inside miniscript
<sipa>
achow101: ?
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
_xamelion has quit [Remote host closed the connection]
scgbckbone has quit [Ping timeout: 272 seconds]
___nick___ has quit [Ping timeout: 264 seconds]
__nick__ has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]