achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
l0rinc has quit [Quit: l0rinc]
jadi has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] DjWhit89 opened pull request #34151: test (master...master) https://github.com/bitcoin/bitcoin/pull/34151
<bitcoin-git> [bitcoin] DrahtBot closed pull request #34151: test (master...master) https://github.com/bitcoin/bitcoin/pull/34151
<bitcoin-git> [bitcoin] DjWhit89 opened pull request #34152: chain (master...master) https://github.com/bitcoin/bitcoin/pull/34152
<bitcoin-git> [bitcoin] DrahtBot closed pull request #34152: chain (master...master) https://github.com/bitcoin/bitcoin/pull/34152
<bitcoin-git> [bitcoin] DjWhit89 opened pull request #34153: Update Bitcoin Core links in README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/34153
<bitcoin-git> [bitcoin] DrahtBot closed pull request #34153: Update Bitcoin Core links in README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/34153
nanotube has quit [Ping timeout: 264 seconds]
nanotube has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 245 seconds]
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
PaperSword has quit [Remote host closed the connection]
PaperSword has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 252 seconds]
bitdex has joined #bitcoin-core-dev
_flood has quit [Remote host closed the connection]
jonatack has quit [Read error: Connection reset by peer]
_flood has joined #bitcoin-core-dev
SpellChecker_ is now known as SpellChecker
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 265 seconds]
luke-jr has quit [Remote host closed the connection]
luke-jr has joined #bitcoin-core-dev
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
sliv3r__ has joined #bitcoin-core-dev
memset has quit [Ping timeout: 252 seconds]
bitdex has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 244 seconds]
ghost43 has quit [Ping timeout: 252 seconds]
ghost43 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko opened pull request #34154: test: Enable ruff E713 lint (master...2512-ruff-E713) https://github.com/bitcoin/bitcoin/pull/34154
l0rinc has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
Guest36 has joined #bitcoin-core-dev
Guest17 has joined #bitcoin-core-dev
Katabex is now known as katabex
Guest17 has quit [Quit: Client closed]
<Sjors[m]1> roconnor: nothing was changed in the bitcoind binary, only the new bitcoin-node binary has capnp as a dependency.
Guest36 has quit [Quit: Client closed]
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
Guyver2 has joined #bitcoin-core-dev
cold has quit [Ping timeout: 240 seconds]
cold has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
memset has quit [Ping timeout: 252 seconds]
memset has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
pablomartin has joined #bitcoin-core-dev
<brunoerg> Number of unkilled mutants for txgraph significantly dropped after adding fuzzing in the analysis (https://corecheck.dev/mutation/src/txgraph.cpp) cc @sipa
jerryf_ has quit [Remote host closed the connection]
jerryf has joined #bitcoin-core-dev
<roconnor> Sjors[m]1: oh, then I have a bit of a mystery to investigate.
<Sjors[m]1> roconnor_: indeed, I wouldn't expect bitcoind dependencies to increase. Qt might, since we switched to 6 a while ago.
<bitcoin-git> [qa-assets] brunoerg opened pull request #250: add inputs for scriptpubkeyman (main...2025-12-spkm) https://github.com/bitcoin-core/qa-assets/pull/250
l0rinc has quit [Quit: l0rinc]
<roconnor> Sjors[m]1: Ah, I seem to have made an error in my comparison. The difference lies not in v29 vs v30, but in nixpkgs' bitcoin vs bitcoind.
<roconnor> though why the bitcoind version, which is supposed to be the headless version has more dependencies is still a mystery.
<roconnor> bitcoind is supposed to be the package without Gui.
<Sjors[m]1> bitcoin spawns up bitcoind, bitcoin-node or bitcoin-qt depending on what you call it with.
<roconnor> oh yeah sorry I'm being confusing.
<Sjors[m]1> See #31375
<corebot> Sjors[m]1: Error: That URL raised <Connection timed out.>
<roconnor> So the comparision here is between bitcoind built with BUILD_GUI true vs without BUILD_GUI
<Sjors[m]1> Ok I guess the bot is still celebrating Christmas.
<roconnor> and it seems the one built without BUILD_GUI has *more* dependencies
<corebot> roconnor: Error: That URL raised <HTTP Error 404: Not Found>
<roconnor> why would disabling the gui cause libsodium to become a dependency of bitcoind?
xFFFC0000 has quit [Quit: Connection closed for inactivity]
<roconnor> Maybe the linking switches from dynamic to static for some reason?
<roconnor> libsodium is a dependency of ZeroMQ (and openldap), but ZeroMQ is enabled in both configurations
<roconnor> Are the zeromq patches not being applied when building without gui?
<roconnor> Because librt is one of the dependences I'm getting in the without-gui build, and zeromq has a specific no_librt.patch
<roconnor> wait, are these patches just not being applied when someone builds from source?
<sipa> are you doing a depends build, or actually just from source?
<roconnor> I don't know what a depends build is, but probably not.
<sipa> see depends/README.md; if you build that way, you build with the specific versions of dependencies and all applied patches to them, that would be used in a release build
<sipa> if you build from source without it, you'll build with your system's dependencies, in whatever state they are
<sipa> the difference between release builds (in guix) and depends builds is that the former still uses your system compilers and system libraries, while in guix those are controlled as well
<roconnor> I'm using the nixpkgs, so we are just using the standard packages from nixpkgs
<roconnor> well that's annoying
<roconnor> I'm certainly not going to be able to make depends if it runs curl.
<hebasto> zeromq is built with `-DWITH_LIBSODIUM=OFF` in our depends
<sipa> you can do the downloading ahead of time, if that helps
<sipa> and run the compilation in a more sandboxed environment
<roconnor> basically we'd have to patch all our dependencies with thes patch files ... though some look more important than others.
<roconnor> or we could do that.
<roconnor> I don't know what's best, but I can start with fixing up our libsodium build dependency.
<roconnor> Meanwhile it is still a bit of a mystery why enabling the gui would have made dependencies like libsodium disappear.
Guest57 has joined #bitcoin-core-dev
Guest57 has quit [Client Quit]
<roconnor> maybe it has something to do with enabling DBUS in the gui build.
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 244 seconds]
<roconnor> oooh!
<roconnor> when I build the gui under nixpkgs it's set up to wrap all the executables in another binary to set the appropriate QT_binaries. So it is that binary that has few dependencies since it calls .bitcoind-wrapped.
<roconnor> okay mystery solved, but I did learn that I have a whole bunch of transitive dependencies I ought to try to eliminate from nix bitcoin builds.
bitdex has joined #bitcoin-core-dev
katabex has left #bitcoin-core-dev [#bitcoin-core-dev]
katabex has joined #bitcoin-core-dev
katabex has left #bitcoin-core-dev [#bitcoin-core-dev]
katabex has joined #bitcoin-core-dev
katabex has left #bitcoin-core-dev [#bitcoin-core-dev]
katabex has joined #bitcoin-core-dev
katabex has left #bitcoin-core-dev [#bitcoin-core-dev]
katabex has joined #bitcoin-core-dev
<bitcoin-git> [qa-assets] maflcko merged pull request #250: add inputs for scriptpubkeyman (main...2025-12-spkm) https://github.com/bitcoin-core/qa-assets/pull/250
<bitcoin-git> [qa-assets] maflcko pushed 2 commits to main: https://github.com/bitcoin-core/qa-assets/compare/8fae9748c272...f5f602a43581
<bitcoin-git> qa-assets/main 083bd91 Bruno Garcia: add inputs for scriptpubkeyman
<bitcoin-git> qa-assets/main f5f602a maflcko: Merge pull request #250 from brunoerg/2025-12-spkm
katabex has left #bitcoin-core-dev [#bitcoin-core-dev]
katabex has joined #bitcoin-core-dev
katabex has left #bitcoin-core-dev [#bitcoin-core-dev]
katabex has joined #bitcoin-core-dev
katabex has left #bitcoin-core-dev [#bitcoin-core-dev]
katabex has joined #bitcoin-core-dev
katabex has left #bitcoin-core-dev [#bitcoin-core-dev]
katabex has joined #bitcoin-core-dev
katabex is now known as qwerty`
qwerty` is now known as katabex
katabex has left #bitcoin-core-dev [#bitcoin-core-dev]
katabex has joined #bitcoin-core-dev
<roconnor> I guess in the distributed binaries, pretty much everything is statically links.
katabex has left #bitcoin-core-dev [#bitcoin-core-dev]
katabex has joined #bitcoin-core-dev
katabex has quit [Quit: %Bye%]
katabex has joined #bitcoin-core-dev
katabex has left #bitcoin-core-dev [#bitcoin-core-dev]
Cory63 has joined #bitcoin-core-dev
Cory96 has quit [Ping timeout: 272 seconds]
Cory2 has joined #bitcoin-core-dev
Cory63 has quit [Ping timeout: 272 seconds]
<fanquake> roconnor: yes. Only a dynamic libc, since we started linking libgcc statically as well
<fanquake> Still looking at static libc #25573
<corebot> https://github.com/bitcoin/bitcoin/issues/25573 | guix: produce a `-static-pie` bitcoind by fanquake · Pull Request #25573 · bitcoin/bitcoin · GitHub
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
jadi has joined #bitcoin-core-dev
<sipa> more compiler options should be named after deserts
jadi has quit [Ping timeout: 265 seconds]
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 256 seconds]
andrewtoth has joined #bitcoin-core-dev
<roconnor> Can I find the build logs for the dependecy build online somewhere? Specifically for sqlite
<roconnor> For comparision
<roconnor> specifically to see if it is built without zlib.
Guest47 has joined #bitcoin-core-dev
Guest47 has quit [Client Quit]
mike has joined #bitcoin-core-dev
mike is now known as Guest9229
mike70 has joined #bitcoin-core-dev
Guest9229 has quit [Client Quit]
mike70 has quit [Client Quit]
bitdex has quit [Ping timeout: 252 seconds]
Cory28 has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
mike70 has joined #bitcoin-core-dev
Cory2 has quit [Ping timeout: 272 seconds]
mike70 has quit [Client Quit]
mike70 has joined #bitcoin-core-dev
mike70 has quit [Client Quit]
jadi has joined #bitcoin-core-dev
mike70 has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 260 seconds]
mike70 has quit [Ping timeout: 272 seconds]
bitdex has quit [Ping timeout: 252 seconds]
bomb-on has joined #bitcoin-core-dev
mike70 has joined #bitcoin-core-dev
mike70 has quit [Client Quit]
bitdex has joined #bitcoin-core-dev
wd has joined #bitcoin-core-dev
wd has quit [Client Quit]
jadi has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
jadi has quit [Ping timeout: 246 seconds]
bitdex has joined #bitcoin-core-dev
jadi has joined #bitcoin-core-dev
jadi has quit [Ping timeout: 256 seconds]