achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
nejos97 has quit [Ping timeout: 264 seconds]
nejos97 has joined #bitcoin-core-dev
nejos97 has quit [Ping timeout: 264 seconds]
nejos97 has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset_ has joined #bitcoin-core-dev
nejos97 has quit [Ping timeout: 264 seconds]
nejos97 has joined #bitcoin-core-dev
_flood has quit [Remote host closed the connection]
szarka has joined #bitcoin-core-dev
_flood has joined #bitcoin-core-dev
dzxzg2 has quit [Remote host closed the connection]
nejos97 has quit [Ping timeout: 256 seconds]
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
Palaver has joined #bitcoin-core-dev
Palaver has quit [Remote host closed the connection]
_flood has quit [Read error: Connection reset by peer]
_flood has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset_ has joined #bitcoin-core-dev
dzxzg has quit [Remote host closed the connection]
MrHAPPY has joined #bitcoin-core-dev
PaperSword has quit [Remote host closed the connection]
Guest98 has joined #bitcoin-core-dev
Guest98 has quit [Client Quit]
conman has quit [Ping timeout: 265 seconds]
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
MrHAPPY has quit []
memset_ has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
robszarka has joined #bitcoin-core-dev
szarka has quit [Ping timeout: 244 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
<bitcoin-git> [bitcoin] rkrux opened pull request #34010: wallet: check for `agg_pub` validity in MuSig2 signing (master...musig-key-fix) https://github.com/bitcoin/bitcoin/pull/34010
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
PaperSword has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
sliv3r__ has quit [Quit: ZNC 1.8.2+deb3.1+deb12u1 - https://znc.in]
kevkevin has joined #bitcoin-core-dev
sliv3r__ has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Pro2x9 opened pull request #34011: Create c-cpp.yml (master...master) https://github.com/bitcoin/bitcoin/pull/34011
<bitcoin-git> [bitcoin] DrahtBot closed pull request #34011: Create c-cpp.yml (master...master) https://github.com/bitcoin/bitcoin/pull/34011
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
f321x has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko closed pull request #33973: test: Add DERSIG unit tests to script_tests.json (master...script-tests) https://github.com/bitcoin/bitcoin/pull/33973
<bitcoin-git> [bitcoin] maflcko reopened pull request #33973: test: Add DERSIG unit tests to script_tests.json (master...script-tests) https://github.com/bitcoin/bitcoin/pull/33973
kevkevin has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9890058b37b8...0c9ab0f8f8c8
<bitcoin-git> bitcoin/master 167df7a Eugene Siegel: net: fix use-after-free with v2->v1 reconnection logic
<bitcoin-git> bitcoin/master 0c9ab0f merge-script: Merge bitcoin/bitcoin#33956: net: fix use-after-free with v2->v1 reconnect...
<bitcoin-git> [bitcoin] fanquake merged pull request #33956: net: fix use-after-free with v2-v1 reconnection logic (master...11262025/asan_reconnections_fix) https://github.com/bitcoin/bitcoin/pull/33956
kevkevin has joined #bitcoin-core-dev
f321x has quit [Remote host closed the connection]
f321x has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
saturday7 has quit [Ping timeout: 240 seconds]
saturday7 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] hebasto closed pull request #33924: qa: Remove no longer needed `feature_dirsymlinks.py` (master...251122-create-dir-test) https://github.com/bitcoin/bitcoin/pull/33924
l0rinc has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] l0rinc closed pull request #34005: util: generalize `util::Result` to support custom errors (master...l0rinc/generalized-Result-error) https://github.com/bitcoin/bitcoin/pull/34005
kevkevin has joined #bitcoin-core-dev
sliv3r__ has quit [Ping timeout: 264 seconds]
sliv3r__ has joined #bitcoin-core-dev
saturday- has joined #bitcoin-core-dev
saturday7 has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c9ab0f8f8c8...b8e66b901d56
<bitcoin-git> bitcoin/master ffcae82 frankomosh: test: exercise TransactionMerklePath with empty block; targets the MerkleC...
<bitcoin-git> bitcoin/master b8e66b9 merge-script: Merge bitcoin/bitcoin#33858: test: add unit test coverage for the empty le...
<bitcoin-git> [bitcoin] fanquake merged pull request #33858: test: add unit test coverage for the empty leaves path in MerkleComputation (master...merkle-empty-path) https://github.com/bitcoin/bitcoin/pull/33858
sliv3r__- has joined #bitcoin-core-dev
sliv3r__ has quit [Ping timeout: 252 seconds]
purpleKarrot has quit [Quit: purpleKarrot]
kevkevin has quit [Ping timeout: 244 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
kevkevin has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
eugenesiegel has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 11 commits to 30.x: https://github.com/bitcoin/bitcoin/compare/72675b8f5578...b1499ddf8b15
<bitcoin-git> bitcoin/30.x 338570d fanquake: contrib: more selectively pick files for macOS SDK
<bitcoin-git> bitcoin/30.x 5408e85 fanquake: macdeploy: disable compression in macOS gen-sdk script
<bitcoin-git> bitcoin/30.x 2256f89 fanquake: contrib: rename gen-sdk to gen-sdk.py
<bitcoin-git> [bitcoin] fanquake merged pull request #33997: [30.x] Backports & 30.1rc1 (30.x...30_1_rc1) https://github.com/bitcoin/bitcoin/pull/33997
<bitcoin-git> [bitcoin] fanquake pushed tag v30.1rc1: https://github.com/bitcoin/bitcoin/compare/v30.1rc1
<pinheadmz> fanquake this will be the first build with the compressed mac SDK and thatll be backported to all other builds from now on
<pinheadmz> ?
<fanquake> pinheadmz: first build yea. Note that you should also be able to build with your existing SDK in place just fine
<pinheadmz> oh really that wont break determinisim?
<pinheadmz> (only Fedora, was it?)
<fanquake> No, because the content we use from in the SDK is the same (and untarring the old and new tarball will give you that same content on disk (with some more files in the old case)
<fanquake> The non-determinism in the process of creating the tarball was what was fixed recently
<fanquake> I've backported it to 30 (so far), because our instructions should work, and be deterministic, for anyone (newly) trying to Guix build 30 today
l0rinc has quit [Quit: l0rinc]
jonatack has joined #bitcoin-core-dev
sliv3r__ has joined #bitcoin-core-dev
sliv3r__- has quit [Read error: Connection reset by peer]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b8e66b901d56...091cae6fdf89
<bitcoin-git> bitcoin/master fd4ce55 Fabian Jahr: contrib: Count entry differences in asmap-tool diff summary
<bitcoin-git> bitcoin/master 091cae6 merge-script: Merge bitcoin/bitcoin#33939: contrib: Count entry differences in asmap-too...
<bitcoin-git> [bitcoin] fanquake merged pull request #33939: contrib: Count entry differences in asmap-tool diff summary (master...2025-11-asmaptool-diff-count) https://github.com/bitcoin/bitcoin/pull/33939
<bitcoin-git> [bitcoin] Chand-ra opened pull request #34017: fuzz: Add a test case for `ParseByteUnits()` (master...parseByteUnits) https://github.com/bitcoin/bitcoin/pull/34017
<bitcoin-git> [bitcoin] stickies-v opened pull request #34018: log: exempt all category-specific logs from ratelimiting (master...2025-12/ratelimit-exempt-entire-category) https://github.com/bitcoin/bitcoin/pull/34018
l0rinc has joined #bitcoin-core-dev
BlueMatt[m] has quit [Ping timeout: 260 seconds]
gnusha has quit [Ping timeout: 260 seconds]
gnusha has joined #bitcoin-core-dev
BlueMatt[m] has joined #bitcoin-core-dev
Guest10 has joined #bitcoin-core-dev
Guest10 has quit [Client Quit]
vasild has quit [Remote host closed the connection]
<darosior> Opened the issue about outbound peer selection as requested during yesterday's meeting: https://github.com/bitcoin/bitcoin/issues/34019
vasild has joined #bitcoin-core-dev
saturday7 has joined #bitcoin-core-dev
saturday- has quit [Ping timeout: 260 seconds]
robszarka has quit [Quit: Leaving]
szarka has joined #bitcoin-core-dev
<sipa> thanks!
eugenesiegel has quit [Quit: Client closed]
eugenesiegel has joined #bitcoin-core-dev
Guest10 has joined #bitcoin-core-dev
<darosior> I remember there being discussions about boost and/or multiindex usage. Is it still a goal to get rid of either? Would introducing a new usage of boost::multi_index (for a good reason) be frowned upon?
f321x has quit [Quit: f321x]
Guest10 has quit [Quit: Client closed]
<_aj_> darosior: multi_index is needed by mempool and txrequest, so unlikely to go away. would be nice to remove it from the kernel, but that would imply a different separation between [p2p+mempool] and [validation] than we have today
saturday7 has quit [Ping timeout: 264 seconds]
<_aj_> darosior: (so using it for addrman seems fine, i guess?)
saturday7 has joined #bitcoin-core-dev
l0rinc has quit [Ping timeout: 240 seconds]
<eugenesiegel> does someone know off the top of their head what disk access in validation-related code is currently mockable? and which disk access is *not* mockable?
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/091cae6fdf89...e68517208b4c
<bitcoin-git> bitcoin/master 4cf5ea6 Hennadii Stepanov: depends: Propagate native C compiler to `sqlite` package
<bitcoin-git> bitcoin/master 710031e Hennadii Stepanov: Revert "guix: sqlite wants tcl"
<bitcoin-git> bitcoin/master e685172 merge-script: Merge bitcoin/bitcoin#33995: depends: Propagate native C compiler to `sqli...
<bitcoin-git> [bitcoin] fanquake merged pull request #33995: depends: Propagate native C compiler to `sqlite` package (master...251202-tcl) https://github.com/bitcoin/bitcoin/pull/33995
zeropoint has joined #bitcoin-core-dev
<darosior> eugenesiegel: last time i looked none of the block manager was mockable, whereas the coins db can be ran in memory
<darosior> You could run the blocks db in memory too, but iirc that required introducing more options to BlocksMan, whereas for the coins db it's already there. But then the really annoying one is block storage
<darosior> But if that's for fuzzing last time i looked into it a ramfs was good enough, especially given the massive diff of mocking util/fs and fsbrigdge
<darosior> Then there is the lock files too that you'd need to mock
<darosior> Anyways that was a mess and i just ended up using a ramfs in the end (and closing the PR too)
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
<eugenesiegel> darosior: I could use a ram disk. I guess it would just be nicer to not have to do any "special" setup. Looking at your closed PR, I see a branch by sedited that does in-memory block storage and the diff doesn't look too bad. I'm also unsure if any of this would interfere with kernel work or if there are any other considerations I'm not thinking of
jonatack has quit [Ping timeout: 265 seconds]
jonatack has joined #bitcoin-core-dev
saturday- has joined #bitcoin-core-dev
saturday7 has quit [Ping timeout: 264 seconds]
eugenesiegel has quit [Quit: Client closed]
eugenesiegel has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
jonatack has quit [Ping timeout: 264 seconds]
kevkevin has joined #bitcoin-core-dev
Guest83 has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
Guest83 has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 245 seconds]
justache has quit [Read error: Connection reset by peer]
justache has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] Sjors opened pull request #34020: mining: add getTransactions(ByWitnessID) IPC methods (master...2025/12/getrawtxs) https://github.com/bitcoin/bitcoin/pull/34020
jonatack has joined #bitcoin-core-dev
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
eugenesiegel has joined #bitcoin-core-dev
eugenesiegel has quit [Quit: Client closed]
eugenesiegel has joined #bitcoin-core-dev
xFFFC0000 has quit [Quit: Connection closed for inactivity]
PaperSword has joined #bitcoin-core-dev
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 250 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
brunoerg_ has joined #bitcoin-core-dev
<sedited> eugenesiegel, I could open that as a PR if you think it'd be useful.
brunoerg_ has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
<_aj_> sedited: (did you change your nick because you listened to https://www.youtube.com/watch?v=8O9P5Us_eVo on repeat one too many times?)
brunoerg has quit [Read error: Connection reset by peer]
brunoerg_ has joined #bitcoin-core-dev
<sedited> :D
brunoerg_ has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
brunoerg_ has joined #bitcoin-core-dev
brunoerg has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg_ has quit [Ping timeout: 264 seconds]
jonatack has quit [Ping timeout: 264 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
jonatack has quit [Ping timeout: 265 seconds]
<yancy> sedited means "seated" in Slovenian. Maybe it's a refrence to a favorite programming posture.
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
l0rinc has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
_flood has quit [Remote host closed the connection]
_flood has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
zeropoint has quit [Quit: leaving]