bomb-on has quit [Read error: Connection reset by peer]
bomb-on_ has quit [Ping timeout: 240 seconds]
mudsip has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
mudsip has quit [Client Quit]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
aleggg has quit [Ping timeout: 255 seconds]
aleggg has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko opened pull request #34080: ci: Pin native tests on cross-builds to same commit (master...2512-ci-pin) https://github.com/bitcoin/bitcoin/pull/34080
Chris_Stewart_5 has quit [Ping timeout: 265 seconds]
Chris_Stewart_5 has joined #bitcoin-core-dev
LainIwakura has joined #bitcoin-core-dev
Guest47 has joined #bitcoin-core-dev
Guest47 has quit [Quit: Client closed]
Guyver2 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
Zenton has joined #bitcoin-core-dev
Palaver has joined #bitcoin-core-dev
Palaver has quit [Remote host closed the connection]
Zenton has quit [Ping timeout: 240 seconds]
Zenton has joined #bitcoin-core-dev
cman has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
cman has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
PaperSword has joined #bitcoin-core-dev
Guest76 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
Guest76 has quit [Quit: Client closed]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
Guest84 has joined #bitcoin-core-dev
Guest84 has quit [Client Quit]
kevkevin has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
kevkevin has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
kevkevin has quit [Ping timeout: 264 seconds]
kevkevin has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
Cory54 has quit [Quit: Client closed]
Cory54 has joined #bitcoin-core-dev
LainIwakura has quit [Quit: Client closed]
<hebasto>
latest clang snapshots fail to compile `src/crypto/sha256.cpp` for some reason in the CI environment; trying to reproduce it locally
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<maflcko>
hebasto: It is an OOM
<hebasto>
maflcko: even with `-j 1`?
<maflcko>
yes, on that translation unit
<maflcko>
To clarify, it is an llvm upstream bug
scgbckbone has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 240 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
jonatack has joined #bitcoin-core-dev
Eli_Brooks has joined #bitcoin-core-dev
<Eli_Brooks>
hi guys!
hacker4web3bitco has quit [Ping timeout: 244 seconds]
SpellChecker_ has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
BUSY has quit [Ping timeout: 246 seconds]
kevkevin has quit [Ping timeout: 240 seconds]
GueSNt has joined #bitcoin-core-dev
GueSNt has quit [Client Quit]
kevkevin has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
<hebasto>
maflcko: OOM occurs when optimization is enabled; -O0 compiles fine
bugs_ has joined #bitcoin-core-dev
<vasild>
lightlike: wrt https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2620864832 -- I mean what if -privatebroadcast=0 and thus we leave the optional member empty/uninitialized and then somebody does "sendrawtransaction ... private=yes" (assuming in the future we decide to support that). In this case the optional member is empty but we need it...
mudsip has joined #bitcoin-core-dev
<lightlike>
vasild: yes, understood, that wouldn't be possible with an optional. What I meant that the reverse would be possible though (set privatebroadcast=1 and opt out of it for some transactions).
<vasild>
yes
<vasild>
So, what to do? Leave it as it is? Or use an optional and leave it for later to deal with the case where we want to support off->on override from sendrawtransaction and the optional is empty?
<vasild>
A lazy initialize should be easy - if the optional is empty and we need it, then initialize it?
bitcoinlover has quit [Ping timeout: 246 seconds]
hacker4web3bitco has quit [Ping timeout: 246 seconds]
<lightlike>
yes - I personally like using an optional more, but then again that's why I suggested it, so others should chime in.
mudsip has quit []
<vasild>
I am fine, and l0rinc seems to be ok, so I will give it a try...
Guest83 has left #bitcoin-core-dev [#bitcoin-core-dev]
Cory72 has joined #bitcoin-core-dev
mudsip has quit []
Cory89 has joined #bitcoin-core-dev
<vasild>
lightlike: _andrewtoth_: https://paste-bin.org/y4rjgwdntj the optional diff looks something like that. It raises some odd questions, like what to do if in the middle of the processing the optional is empty (e.g. when we receive a PONG) - could assert that at this point it is not empty, but I do not like such assets, they look too scary; or ignore silently, or lazily initialize it...
<pinheadmz>
vasild re: optional, i defer to the more experieinced cpp devs here but i dont mind as much creating the class as much as starting the thread and scheduling the rebroadcast (when disabled)
<pinheadmz>
opens up a bigger usage question as well and like - i know its been 2 years - why is the approach an init flag that always affects sendraw, rather than an argument to sendraw ?
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
<_andrewtoth_>
vasild, lightlike: not sure it's worth it. What do we gain from the optional? as pinheadmz noted the resources from the extra thread and scheduling are bigger than allocating a struct we never use.
cotsuka has quit [Remote host closed the connection]
<maflcko>
hebasto: Thx, but I think the bug is already fixed?
cotsuka has joined #bitcoin-core-dev
Cory24 has joined #bitcoin-core-dev
<hebasto>
maflcko: where?
<maflcko>
in the latest version, between december 13th and 15th. I have not bisected
Cory49 has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
SpellChecker has quit [Remote host closed the connection]
jerryf has quit [Remote host closed the connection]
jonatack has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
jerryf has joined #bitcoin-core-dev
Cory54 has quit [Ping timeout: 272 seconds]
<hebasto>
the fixed binaries for Ubuntu 24.04 are still not available via https://apt.llvm.org/ though; I can't verify the fix
<lightlike>
_andrewtoth_: my main reason is separation of concerns. private broadcast is an optional mode that will be probably be pretty niche for some time (at least until wallet support), and if I'm not interested in that and dont have it enabled it seems not ideal that net_processing still reaches into the module / calls its functions and I have to make sure there are no side-effects when reviewing net_processing code.
Cory24 has quit [Ping timeout: 272 seconds]
<bitcoin-git>
[bitcoin] arejula27 opened pull request #34081: build: Fix source paths for debugging in CMake (master...debug-path-cmake-adjust) https://github.com/bitcoin/bitcoin/pull/34081
jonatack has quit [Ping timeout: 252 seconds]
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
Cory45 has joined #bitcoin-core-dev
<hebasto>
gh introduces "a new $0.002 per-minute GitHub Actions cloud platform charge that will apply to self-hosted runner usage."
Cory49 has quit [Ping timeout: 272 seconds]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
Cory82 has joined #bitcoin-core-dev
<sipa>
what's the charge for github-hosted runner usage?
Cory45 has quit [Ping timeout: 272 seconds]
<janb84>
"Runner usage in public repositories will remain free"
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
durandal_ has quit [Ping timeout: 244 seconds]
_andrewtoth_ has quit [Remote host closed the connection]
<janb84>
so forked repo GHA runners will remain to be free ?
nanotube has quit [Ping timeout: 240 seconds]
Cory82 has quit [Quit: Ping timeout (120 seconds)]
Cory82 has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev
Eli_Brooks has quit [Quit: Konversation terminated!]
memset has quit [Remote host closed the connection]
Cory20 has joined #bitcoin-core-dev
memset has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
Cory82 has quit [Ping timeout: 272 seconds]
___nick___ has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theuni opened pull request #34083: Add initial vectorized chacha20 implementation for 2-3x speedup (master...chacha20-vectorized-initial) https://github.com/bitcoin/bitcoin/pull/34083
Cory85 has joined #bitcoin-core-dev
Cory79 has joined #bitcoin-core-dev
Cory20 has quit [Ping timeout: 272 seconds]
Cory85 has quit [Ping timeout: 272 seconds]
jerryf_ has joined #bitcoin-core-dev
jerryf has quit [Remote host closed the connection]
___nick___ has quit [Ping timeout: 240 seconds]
<bitcoin-git>
[bitcoin] maflcko opened pull request #34084: scripted-diff: [doc] Unify stale copyright headers (master...2506-doc-copy) https://github.com/bitcoin/bitcoin/pull/34084
<bitcoin-git>
[bitcoin] sipa opened pull request #34085: cluster mempool: exploit SFL properties in txgraph (master...202512_txgraph_sfl) https://github.com/bitcoin/bitcoin/pull/34085
jonatack has quit [Ping timeout: 240 seconds]
arejula27 has joined #bitcoin-core-dev
Cory6 has joined #bitcoin-core-dev
Cory79 has quit [Ping timeout: 272 seconds]
arejula10 has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
arejula27 has quit [Changing host]
arejula27 has joined #bitcoin-core-dev
arejula10 has quit [Client Quit]
arejula56 has joined #bitcoin-core-dev
arejula27 has quit [Quit: Client closed]
arejula56 has quit [Client Quit]
arejula27 has joined #bitcoin-core-dev
arejula65 has joined #bitcoin-core-dev
arejula27 has quit [Client Quit]
arejula65 has quit [Client Quit]
arejula27 has joined #bitcoin-core-dev
arejula27 has quit [Ping timeout: 272 seconds]
Guest4 has joined #bitcoin-core-dev
Guest4 has quit [Client Quit]
scgbckbone has quit [Quit: Client closed]
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
<_aj_>
sipa: messing around with a global inv2send queue (vs the per-peer ones we currently have). when that queue is unreasonably large, i'm spending a bunch of time re-heapifying it which seems wasteful (since it only matters if some new/removed tx changes chunking, which is relatively rare)... i guess if i could get a trigger to say that "tx X's mining score changed" (because tx Y was added and CPFP'ed
<_aj_>
it, or tx Z was mined and X's fees aren't CPFP'ing anymore) i could just update X's position in my queue without reordering any tx's that didn't trigger. maybe `txgraph.TrackTouchedRefs(vec); {modify the graph}; for (ref : vec) { reconsider(ref) }` or something?
<_aj_>
sipa: (unreasonably large ~= 1000-5000 entries, due to unreasonably lowering the mainnet broadcast rate from 14 tx/s to 6 tx/s)