<fjahr>
We still have an open PR to add the attestations into the data repo, as discussed at CoreDev. Would be great if we could get a few more eyes on this soon so we can complete the transition: https://github.com/bitcoin-core/asmap-data/pull/50
bugs_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] rkrux opened pull request #35442: test: remove usages of MAX_BIP125_RBF_SEQUENCE constant from functional tests (master...rbfsequence-test) https://github.com/bitcoin/bitcoin/pull/35442
brunoerg has quit [Ping timeout: 264 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 246 seconds]
aleggg has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
l0rinc has quit [Remote host closed the connection]
l0rinc has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
enochazariah has quit [Quit: Ping timeout (120 seconds)]
jonatack has quit [Quit: WeeChat 4.9.0]
<bitcoin-git>
[bitcoin] mjdietzx opened pull request #35443: tests: add functional test for tr musig2 miniscript decaying multisig (master...test_tr_miniscript_decaying_multiscript_descriptor) https://github.com/bitcoin/bitcoin/pull/35443
bugs_ has quit [Ping timeout: 264 seconds]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
frankomosh has joined #bitcoin-core-dev
frankomosh has quit [Client Quit]
frankomosh has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] w0xlt opened pull request #35444: wallet: make descriptor SPKM mutex non-recursive (master...wallet-descriptor-spkm-mutex-19303-simple-index) https://github.com/bitcoin/bitcoin/pull/35444
w0xlt has quit [Remote host closed the connection]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<nkaretnikov>
fjahr: i’ve never done this. is the process just doing what issue 51 says (aka running that command on master)? are there any special requirements for this (lots of disk space or network traffic)?
<darosior>
for anyone off xitter, this is the chart shown in the tweet fanquake shared above https://imgur.com/a/h0dLBY9
<fjahr>
nkaretnikov: disk space needed is about 2-3 GB, faster network traffic and machine will help finishing faster but it's not a requirement. I've even done it on hotel wifi ;) You just start it at some point before the time in the issue and you will see a countdown. Then it will start when the countdown runs out. On a fast machine it can take less than 10min, on a slow machine/network I saw 1h 20min.
frankomosh has quit [Quit: Client closed]
<fjahr>
Thanks for your interest :) Let me know if you have more questions.
<nkaretnikov>
fjahr: do you care where users run this? i would prefer not to run this at home atm, but i can run on gcp. would the be ok?
memset has quit [Remote host closed the connection]
memset has joined #bitcoin-core-dev
<darosior>
Andrew: how is that seek compaction related?
<fjahr>
nkaretnikov: Sure, that's ok. I know several people do it at home and as long as not everyone move to gcp that's a good contribution.
<nkaretnikov>
fjahr: ok, will do and report back
<fjahr>
nkaretnikov: cool!
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
andrewtoth has joined #bitcoin-core-dev
nanotube has quit [Ping timeout: 241 seconds]
<andrewtoth>
darosior: I am speculating, but the cache only fills up around ~800k blocks and gets emptied, causing reads to now go to disk
<andrewtoth>
for the big cache values
<andrewtoth>
before that there was no seek compaction since no reads hit disk. For the smaller cache sizes, they were compacting the whole time, so probably fewer files needing compaction
<andrewtoth>
For smaller cache sizes, they get seek compacted along the way. For the bigger caches, they do writes every ~hour, but those files just stay higher in the tree since they're not seek compacted. Then, when they finally start getting seek compacted, there are files at every level, which is a lot more compacting.
<darosior>
So does that mean that compaction takes an amount of time superlinear in the size of what needs to be compacted? Because they would need to compact strictly less data than those nodes with lower caches. (Presumably a lot more since as we've seen stuff gets re-compacted.)
<darosior>
If so, is it wise to enable one big seek compaction at the end of IBD?
<andrewtoth>
The majority of time in IBD is spent from 800k-900k
<andrewtoth>
darosior: it's a little more complicated than total data size. seek compaction will trigger random files to get compacted, depending on when they get read. If we do a single manual compaction, it will go through each level and compact all files there at once I think.
l0rinc has quit [Quit: l0rinc]
l0rinc has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 245 seconds]
l0rinc has quit [Quit: l0rinc]
bugs_ has quit [Quit: Leaving]
cotsuka has quit [Read error: Connection reset by peer]
<bitcoin-git>
bitcoin/master bb05986 Ava Chow: musig: Include pubnonce in session id
<bitcoin-git>
bitcoin/master 2669019 merge-script: Merge bitcoin/bitcoin#35269: musig: Include pubnonce in session id
<bitcoin-git>
bitcoin/master 2ef6679 Ava Chow: test: Check that MuSig2 signing does not reuse nonces
<bitcoin-git>
[bitcoin] sedited merged pull request #35269: musig: Include pubnonce in session id (master...musig2-pubnonce-session-id) https://github.com/bitcoin/bitcoin/pull/35269
<achow101>
darosior: "Maybe we should migrate to using a proper ID instead of the hash of the string?" <- What is a proper id though?
<achow101>
hash of the string clearly isn't stable. while hashing the first scriptPubKey(s) could work, it doesn't work when hardened derivation is involved and keys aren't available. that also introduces the potential for collisions as multiple descriptors can produce the same scripts
<achow101>
but maybe that's not necessarily a problem?
<achow101>
I feel like it kind of is though, as a non-ranged descriptor can produce the same script that a ranged descriptor does.
l0rinc has joined #bitcoin-core-dev
<achow101>
then there's descriptors and their normalized forms. we currently don't detect those as being the same descriptor, but maybe we should
<achow101>
perhaps we could do some hash of a representation of the descriptor ast that doesn't have the hardened indicator ambiguity. it could flatten xpubs with derivations to be fingerprint + derivation path, and this could work with normalized too to get the same representation. but then the id wouldn't be committing to any chaincodes.
smartin has quit [Quit: smartin]
<achow101>
I'm leaning more in the direction that there is no such thing as a descriptor id, but rather that "id" is just some random data that goes into the wallet database. how it is computed basically doesn't matter, although we should still use the old string computation method for downgrade compatibility
<darosior>
achow101: i agree with there is no such thing as a descriptor ID, but an ID does seem to be what we want to store in the database
eugenesiegel has joined #bitcoin-core-dev
<achow101>
in an ideal world, there wouldn't be an id and we'd instead of a table of descriptors with rows containing all of the relevant attributes, rather than needing this id thing to tie separate records together
brunoerg has quit [Remote host closed the connection]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
eugenesiegel has quit [Ping timeout: 245 seconds]
brunoerg_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
ozdeadman has quit [Ping timeout: 264 seconds]
ozdeadman has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
adys873 has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
adys873 has quit [Ping timeout: 272 seconds]
infernix has quit [Ping timeout: 276 seconds]
<bitcoin-git>
[bitcoin] achow101 opened pull request #35445: wallet, descriptor: Revert `StringType::COMPAT` for Miniscript expressions and drop the concept of a Descriptor ID that can be validated (master...fix-miniscript-desc-id) https://github.com/bitcoin/bitcoin/pull/35445
brunoerg_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]