achow101 changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 16:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
deadmanoz has quit [Ping timeout: 252 seconds]
deadmanoz has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
cman has joined #bitcoin-core-dev
conman has quit [Ping timeout: 245 seconds]
luke-jr has quit [Ping timeout: 248 seconds]
luke-jr has joined #bitcoin-core-dev
ShebaLamb has joined #bitcoin-core-dev
ShebaLamb has quit [Ping timeout: 276 seconds]
ShebaLamb has joined #bitcoin-core-dev
S3RK_ has joined #bitcoin-core-dev
S3RK has quit [Ping timeout: 244 seconds]
dongcarl00026491 has quit [Quit: Ping timeout (120 seconds)]
dongcarl00026491 has joined #bitcoin-core-dev
jarthur has quit [Quit: BRB]
ShebaLamb has quit [Ping timeout: 248 seconds]
tarotfied has quit [Ping timeout: 248 seconds]
jonatack has joined #bitcoin-core-dev
tarotfied has joined #bitcoin-core-dev
tarotfied has quit [Changing host]
tarotfied has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 256 seconds]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 256 seconds]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 256 seconds]
jonatack has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
luke-jr has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
jonatack has joined #bitcoin-core-dev
luke-jr has quit [Quit: Konversation terminated!]
adil has quit [Quit: adil]
luke-jr has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 265 seconds]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
MrHAPPY has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
MrHAPPY has quit []
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
ozdeadman has joined #bitcoin-core-dev
deadmanoz has quit [Ping timeout: 252 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
hacker4web3bitco has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] optout21 opened pull request #35570: refactor: Change some validation.cpp methods to return BlockValidationState (master...2605-validation-state-return) https://github.com/bitcoin/bitcoin/pull/35570
l0rinc has quit [Quit: l0rinc]
rustaceanrob has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 248 seconds]
luke-jr has quit [Quit: Konversation terminated!]
luke-jr has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] willcl-ark opened pull request #35571: ci: use warp docker buildkit cache (master...fixup-providers) https://github.com/bitcoin/bitcoin/pull/35571
luke-jr has quit [Quit: Konversation terminated!]
luke-jr has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
svanstaa has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
bomb-on has quit [Ping timeout: 248 seconds]
bomb-on has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
rustaceanrob has quit [Ping timeout: 252 seconds]
adil has quit [Quit: adil]
Guest46 has joined #bitcoin-core-dev
Guest46 has quit [Client Quit]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
rustaceanrob has joined #bitcoin-core-dev
l0rinc has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
vasild has quit [Ping timeout: 245 seconds]
cotsuka has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
luke-jr has quit [Read error: Connection reset by peer]
luke-jr_ has joined #bitcoin-core-dev
deadmanoz has joined #bitcoin-core-dev
deadmano- has quit [Ping timeout: 264 seconds]
memset has quit [Remote host closed the connection]
jonatack has quit [Read error: Connection reset by peer]
memset has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
luke-jr_ has quit [Read error: Connection reset by peer]
luke-jr_ has joined #bitcoin-core-dev
rustaceanrob has quit [Ping timeout: 252 seconds]
jonatack has quit [Ping timeout: 252 seconds]
jon_atack has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 252 seconds]
bugs_ has joined #bitcoin-core-dev
rustaceanrob has joined #bitcoin-core-dev
adys8736 has quit [Quit: The Lounge - https://thelounge.chat]
adys8736 has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [#bitcoin-core-dev]
emzy has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
emzy has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
diego2 has left #bitcoin-core-dev [#bitcoin-core-dev]
dviola has joined #bitcoin-core-dev
ozdeadman has quit [Ping timeout: 248 seconds]
ozdeadman has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
jon_atack has quit [Ping timeout: 252 seconds]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
hacker4web3bitco has quit [Ping timeout: 246 seconds]
jonatack has joined #bitcoin-core-dev
rustaceanrob has quit [Ping timeout: 244 seconds]
jonatack has quit [Ping timeout: 256 seconds]
rustaceanrob has joined #bitcoin-core-dev
luke-jr_ has quit [Quit: Konversation terminated!]
luke-jr_ has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 276 seconds]
luke-jr_ has quit [Read error: Connection reset by peer]
luke-jr_ has joined #bitcoin-core-dev
rustaceanrob has quit [Ping timeout: 252 seconds]
mudsip has quit []
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 248 seconds]
l0rinc has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 248 seconds]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 244 seconds]
<bitcoin-git> [bitcoin] l0rinc closed pull request #35562: fuzz: remove unsupported coins cache cursor fuzz probe (master...l0rinc/remove-constant-Cursor-fuzz) https://github.com/bitcoin/bitcoin/pull/35562
<bitcoin-git> [gui] ShauryaaSharma opened pull request #942: qt: prevent console hang on large RPC responses (master...fix-qt-console-large-rpc-output) https://github.com/bitcoin-core/gui/pull/942
<bitcoin-git> [gui] ShauryaaSharma opened pull request #943: qt: warn about rescan in wallet migration dialogs (master...fix-qt-migration-rescan-warning) https://github.com/bitcoin-core/gui/pull/943
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
rustaceanrob has joined #bitcoin-core-dev
rustaceanrob has quit [Ping timeout: 244 seconds]
bugs_ has quit [Quit: Leaving]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
dermoth has quit [Remote host closed the connection]
dermoth has joined #bitcoin-core-dev
luke-jr_ has quit [Quit: Konversation terminated!]
luke-jr_ has joined #bitcoin-core-dev
l0rinc has quit [Quit: l0rinc]
luke-jr has joined #bitcoin-core-dev
luke-jr_ has quit [Read error: Connection reset by peer]
cotsuka has quit [Read error: Connection reset by peer]
cotsuka has joined #bitcoin-core-dev
andrewtoth has quit [Remote host closed the connection]
<nkaretnikov> andrewtoth: i did take a look at #35465 and associated issues, but i would need to probably spend weeks to better understand the related code. given that it’s marked ready for merge, i’m not sure it’d be worth it. fwiw i did ran claude’s /review on it just in case https://gist.github.com/nkaretnikov/25700686320a82c0908d01ba5cf3cdbc but i cannot tell whether these are worth looking into. in general, i feel like this PR
<nkaretnikov> and related leveldb issues would benefit from more reproducibility: people often just post screenshots and results, but not the code that was used to generate those. if possible, more tests should be added for issues that people report, e.g., #35298, to avoid regressions. since some settings would take days to reproduce to trigger compaction, the tests could use smaller numbers via mocking, with a comment explaining how that
<nkaretnikov> would scale to values used in the code. but it might be also worth thinking about some infrastructure that would run continuously and monitor these metrics, similar to what is usually done with fuzzing.
<corebot> https://github.com/bitcoin/bitcoin/issues/35465 | coins: compact chainstate regularly by l0rinc · Pull Request #35465 · bitcoin/bitcoin · GitHub
<corebot> https://github.com/bitcoin/bitcoin/issues/35298 | chainstate leveldb is rewritten every 30 or 60 minutes · Issue #35298 · bitcoin/bitcoin · GitHub
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]