<bitcoin-git>
[gui] john-moffett opened pull request #680: Fixes MacOS 13 segfault by preventing certain notifications after main window is destroyed (master...202211MacSegfaultOnQuit) https://github.com/bitcoin-core/gui/pull/680
<bitcoin-git>
[bitcoin] brunoerg opened pull request #26507: test: remove unused vars in `feature_block` (master...2022-11-unused-feature-block-test) https://github.com/bitcoin/bitcoin/pull/26507
<larryruane>
Can `CChain::Next()` https://github.com/bitcoin/bitcoin/blob/master/src/chain.h#L459 be called without holding `cs_main`? Everywhere I see it called, `cs_main` is held, but I'm not sure if it needs to be. (I'm reviewing a PR in which it's called without `cs_main` being held.)
<bitcoin-git>
[bitcoin] achow101 opened pull request #26499: wallet: Abandon descendants of orphaned coinbases (master...fix-wallet-orphaned-reward) https://github.com/bitcoin/bitcoin/pull/26499
<bitcoin-git>
[bitcoin] hebasto opened pull request #26498: doc: Mention required workload when building with MSVC (master...221114-ms-doc) https://github.com/bitcoin/bitcoin/pull/26498
<bitcoin-git>
[bitcoin] dergoegge opened pull request #26497: fuzz: Make ConsumeNetAddr (sometimes) produce valid onion addresses (master...2022-11-fuzz-valid-onion-addrs) https://github.com/bitcoin/bitcoin/pull/26497
<sipa>
if you cloned the bitcoin core repo, you already have that config file, because it is part of the repo
<bytes1440000>
I am already shadow banned on github because notifications not expected, and some issues here. Maybe I need a new account because bitcoin core is not just some devs, there are some people who cannot read things they dont like.
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #26489: test: Split overly large util_tests.cpp file (master...2211-test-split-🌐) https://github.com/bitcoin/bitcoin/pull/26489
2022-11-10
<bitcoin-git>
[bitcoin] sdulfari opened pull request #26487: log: improve some validation log messages to include hashPrevBlock (master...hash-prev-blk-error-msg) https://github.com/bitcoin/bitcoin/pull/26487
<gribble>
https://github.com/bitcoin/bitcoin/issues/25600 | p2p: Advertise `NODE_FULL_RBF` and connect to 4 outbound full-rbf peers if `-mempoolfullrbf` is set by ariard · Pull Request #25600 · bitcoin/bitcoin · GitHub
<achow101>
luke-jr: looks like you are in bitcoin but not in bitcoin-core. I'm suruprised it took us this long to notice
<bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #24199: Add cs_main annotation to WriteBatchSync(), drop lock in CDiskBlockIndex (master...remove-cs_main-lock-in-CDiskBlockIndex) https://github.com/bitcoin/bitcoin/pull/24199
<bitcoin-git>
[bitcoin] achow101 reopened pull request #24150: refactor: move index class members from protected to private (master...move-index-class-members-from-protected-to-private) https://github.com/bitcoin/bitcoin/pull/24150
<bitcoin-git>
[bitcoin] achow101 closed pull request #25097: test: Unit tests for taproot/tapscript coverage in `interpreter.cpp` (master...23279-taproot-unit-tests) https://github.com/bitcoin/bitcoin/pull/25097
<bitcoin-git>
[bitcoin] achow101 closed pull request #24199: Add cs_main annotation to WriteBatchSync(), drop lock in CDiskBlockIndex (master...remove-cs_main-lock-in-CDiskBlockIndex) https://github.com/bitcoin/bitcoin/pull/24199
<bitcoin-git>
[bitcoin] achow101 closed pull request #24150: refactor: move index class members from protected to private (master...move-index-class-members-from-protected-to-private) https://github.com/bitcoin/bitcoin/pull/24150
<bitcoin-git>
[bitcoin] achow101 closed pull request #19420: http: Track active requests and wait for last to finish (master...2020-06-track-requests) https://github.com/bitcoin/bitcoin/pull/19420
<bitcoin-git>
[bitcoin] achow101 closed pull request #19078: test: Add salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078
<bitcoin-git>
[bitcoin] ariard closed pull request #25600: p2p: Advertise `NODE_FULL_RBF` and connect to 4 outbound full-rbf peers if `-mempoolfullrbf` is set (master...2022-07-fullrbf-p2p) https://github.com/bitcoin/bitcoin/pull/25600
<bitcoin-git>
[bitcoin] fanquake opened pull request #26474: [23.x] guix: use `--build={arch}-guix-linux-gnu` in cross toolchain (23.x...23_x_aarch64_on_aarch64) https://github.com/bitcoin/bitcoin/pull/26474
<bitcoin-git>
[bitcoin] hebasto opened pull request #26473: test: Randomize data in `getarg_tests/logargs` test (master...221108-logargs) https://github.com/bitcoin/bitcoin/pull/26473
<bytes1440000>
Will "bitcoin core devs" ever consider importance of knots maintained by luke dashjr?
<bitcoin-git>
[bitcoin] russeree opened pull request #26469: rpc: getblock: implement with block height as input parameter. (master...merge_getblock_getblock_hash) https://github.com/bitcoin/bitcoin/pull/26469
<vasild>
PaperSword: you probably already figured it out, but: yes, yes. See ToIntegral() and RPCArg::m_names, or try bitcoin-cli -named getblock blockhash=00000000000000000b46c6a2bd4725568f62b7a859a53bf63de962099a5c3753 verbose=0
<bitcoin-git>
[bitcoin] achow101 opened pull request #26467: bumpfee: Allow the user to choose which output is change (master...bumpfee-choose-change-txout) https://github.com/bitcoin/bitcoin/pull/26467
<sipa>
To me, monotonicity of tx validity is such a fundamental principle underlying bitcoin, that I'd need a very good reason to even consider acking it.
<_aj_>
height_or_hash is pretty awkward with bitcoin-cli, you have to say '"00000abcdef12345.."' so that an int looks different to a string
<gribble>
https://github.com/bitcoin/bitcoin/issues/16439 | cli/gui: support "@height" in place of blockhash for getblock on client side by ajtowns · Pull Request #16439 · bitcoin/bitcoin · GitHub
<_aj_>
PaperSword: past feedback has been that that's better done on the client side, so that branch implements in bitcoin-cli and the gui, rather than serverside. #16439
<bitcoin-git>
[bitcoin] theStack opened pull request #26462: wallet: fix crash on loading descriptor wallet containing legacy key type entries (master...202211-wallet_fix_crash_on_descriptor_wallet_load) https://github.com/bitcoin/bitcoin/pull/26462
2022-11-05
<bytes1440000>
more: michaelfolkson i will create something different because he ACKs on "faith", Greg Maxwell wrote a paragraph but wasn't aware rust-bitcoin is also affected
<bitcoin-git>
[bitcoin] luke-jr reopened pull request #21319: RPC/Blockchain: Optimise getblock for simple disk-hex case (master...getblock_optimise) https://github.com/bitcoin/bitcoin/pull/21319
<luke-jr>
[23:27:19] <luke-jr> I'm confused about the relay txs thing. jonatack seems to be implying the meaning has changed in his PRs (latest https://github.com/bitcoin-core/gui/pull/676), but I don't see that anywhere?
<bitcoin-git>
[bitcoin] jonatack opened pull request #26457: [24.x] backports for tx relay changes in getpeerinfo/netinfo/gui (24.x...24_x_backports) https://github.com/bitcoin/bitcoin/pull/26457
2022-11-04
<luke-jr>
I'm confused about the relay txs thing. jonatack seems to be implying the meaning has changed in his PRs (latest https://github.com/bitcoin-core/gui/pull/676), but I don't see that anywhere?
<bitcoin-git>
[bitcoin] petertodd opened pull request #26454: Allow `bumpfee` for txs that don't signal BIP-125 (master...2022-feebump-without-optin) https://github.com/bitcoin/bitcoin/pull/26454
<bitcoin-git>
[bitcoin] fanquake merged pull request #26418: Fix signing of multi_a and rawtr scripts with wallets that only have corresponding keys (master...fix-psbt-multia) https://github.com/bitcoin/bitcoin/pull/26418
<sipa>
Taproot spends have been standard since https://github.com/bitcoin/bitcoin/pull/20165, in 0.21.0 (though only relevant for mainnet since 0.21.1, as .0 didn't have activation).