cfields: I just ran into this comment and thought it was excusing a data race, rather than a state machine race, wasted a while checking that all access to the structure were currently guarded about cs_main and then sending some lecturing to matt about there being no safe data races. :)
I do thing some of our PR discussion really ought to end up in comments and commit messages...
jonasschnelli: let me know when you rebase, I want to test it. When testing tumblebit, I am using same wallet for tumbler and the client, which is confusing, so I want to separate both. I use lots of wallet features, so it will be a good test case.
NicolasDorier: Thanks. Yes. Multiwallet would be nice in 0.14
jonasschnelli: will it be possible to scale the number of wallet ? or delete some ? A case I have: I am watching only some temporary escrow addresses, and currently I have no way of deleting them. Will I be able to segregate the watched addresses into several wallet, and delete the wallet when I do not need to track anymore ?
Not planed. Also, some stuff needs to be written first.
ok thanks, will review stuff more deeply soon