< NicolasDorier> jonasschnelli: luke-jr : about multi wallet support https://github.com/bitcoin/bitcoin/projects/2#card-205286 , is it ready to be tested or still stuff in the pipeline ? I plan to play with it if that is the case
< jonasschnelli> NicolasDorier: I guess I need to rebase https://github.com/bitcoin/bitcoin/pull/8764/files
< jonasschnelli> NicolasDorier: maybe review: https://github.com/bitcoin/bitcoin/pull/8776/files
< jonasschnelli> #8776
< gribble> https://github.com/bitcoin/bitcoin/issues/8776 | Wallet refactoring leading up to multiwallet by luke-jr · Pull Request #8776 · bitcoin/bitcoin · GitHub
< NicolasDorier> ok thanks, doing it.
< gmaxwell> cfields: https://github.com/bitcoin/bitcoin/pull/9075/commits/7c98ce584ec23bcddcba8cdb33efa6547212f6ef#r87104196 < you have my support to insist on better comments in the future.
< gmaxwell> cfields: I just ran into this comment and thought it was excusing a data race, rather than a state machine race, wasted a while checking that all access to the structure were currently guarded about cs_main and then sending some lecturing to matt about there being no safe data races. :)
< gmaxwell> I do thing some of our PR discussion really ought to end up in comments and commit messages...
< NicolasDorier> jonasschnelli: let me know when you rebase, I want to test it. When testing tumblebit, I am using same wallet for tumbler and the client, which is confusing, so I want to separate both. I use lots of wallet features, so it will be a good test case.
< jonasschnelli> NicolasDorier: Thanks. Yes. Multiwallet would be nice in 0.14
< NicolasDorier> jonasschnelli: will it be possible to scale the number of wallet ? or delete some ? A case I have: I am watching only some temporary escrow addresses, and currently I have no way of deleting them. Will I be able to segregate the watched addresses into several wallet, and delete the wallet when I do not need to track anymore ?
< jonasschnelli> Not planed. Also, some stuff needs to be written first.
< NicolasDorier> ok thanks, will review stuff more deeply soon
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2db4cbcc437f...dce853ef76ef
< bitcoin-git> bitcoin/master fa558be MarcoFalke: test: Include tx data in EXTRA_DIST
< bitcoin-git> bitcoin/master dce853e MarcoFalke: Merge #9436: test: Include tx data in EXTRA_DIST...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #9436: test: Include tx data in EXTRA_DIST (master...Mf1612-inclTest) https://github.com/bitcoin/bitcoin/pull/9436
< luke-jr> is it possible CCoinsViewDB::Cursor is broken too? :/
< luke-jr> 467ff1966b03755492851de3b90caebdbd6912833b7805323970157f5a34b1e4 is confirmed on testnet, but doesn't seem to show up
< sipa> luke-jr: did you flush!
< sipa> ?
< luke-jr> sipa: flush?
< luke-jr> FlushStateToDisk()? is that needed?
< sipa> yes
< luke-jr> aha, that's probably my issue then, thanks
< sipa> otherwise the utxo entries are pcoinsTip only, which is a CCoinsViewCache on top of CCoinsViewDB
< sipa> *in
< luke-jr> do I need cs_main for this? (how about for the cursor?)
< sipa> i believe it creates a snapshop
< sipa> snapshot
< sipa> you may need a lock to flush and grab the iterator
< sipa> but are then allowed to iterate without lock
< luke-jr> hmm
< sipa> (this is from memory, i have not checked)
< luke-jr> sipa: thanks, the flush fixed it