< bitcoin-git>
bitcoin/master 87c35f5 Matt Corallo: Remove orphan state wipe from UnloadBlockIndex....
< bitcoin-git>
bitcoin/master e736772 Matt Corallo: Move network-msg-processing code out of main to its own file
< bitcoin-git>
bitcoin/master 76faa3c Matt Corallo: Rename the remaining main.{h,cpp} to validation.{h,cpp}
< bitcoin-git>
[bitcoin] sipa closed pull request #9260: Mrs Peacock in The Library with The Candlestick (killed main.{h,cpp}) (master...net_processing_file) https://github.com/bitcoin/bitcoin/pull/9260
< cfields>
let the rebasing begin :)
< sipa>
now: the big rebasing game
< sipa>
jinx
< cfields>
haha
< BlueMatt>
hey-o!
< cfields>
BlueMatt: there are a few includes cleanups that can be done that should help with memory
< cfields>
BlueMatt: not sure if you had a few in the queue, or if i should go ahead and PR
< BlueMatt>
feel free to peruse that and PR whatever you did
< sipa>
damn, validation.cpp is *still* 8000 lines
< cfields>
ok
< cfields>
BlueMatt: boost/filesystem/path.hpp in validation.h was the only one i really had my eye on
< BlueMatt>
now that I read the feedback, cfields' comments pointed out that filterRounder changed behavior just slightly - instead of rounding based on DEFAULT_MIN_RELAY_TX_FEE it now rounds based on -minrelaytxfee, oops
< BlueMatt>
doesnt matter all that much, but the original behavior is probably more correct
< BlueMatt>
welll, actually
< BlueMatt>
hum, dunno, needs pointed out for discussion, not sure if its better that users can change that rounding or not
< sipa>
users changing the rounding is probably a slight privacy leak
< sipa>
which is afaik the reason for rounding in the first place
< cfields>
BlueMatt: hmm, i thought i verified the behavior didn't change there. Not sure how i noticed the mempool weirdness without seeing that too
< BlueMatt>
it is, technically, but I'd be surprised if it wasnt already visible what your -minrelaytxfee is
< BlueMatt>
but, ok, will pr a fix and see what folks say
< bitcoin-git>
[bitcoin] TheBlueMatt opened pull request #9268: Fix rounding privacy leak introduced in #9260 (master...2016-12-feefilterrounder) https://github.com/bitcoin/bitcoin/pull/9268
< * BlueMatt>
-> dinner, in a whole new world :p
< morcos>
woo hoo!
< * sipa>
gives BlueMatt a disney movie
< * jtimon>
still needs to google more about mrs peacock, but prefers to keep rebasing for now (I had things to rebase before renaming main, but one more step towards using git blame in main/validation)
< sipa>
jtimon: do you know the game cluedo?
< jtimon>
I don't think have played, but yes, it's famous
< sipa>
the game ends when a player figures out who the murdered is, where the murder happened, and with what weapon
< jtimon>
just enjoy with anything make main smaller
< sipa>
*murderer
< alpalp>
the game also ends if you guess wrong
< sipa>
jtimon: well, main.cpp now has size 0 :p
< jtimon>
right, calling main validation is going to take some time...
< jtimon>
btw, I was serious about rewritting any part of https://github.com/bitcoin/bitcoin/pull/8328 that can be agreed on, just without any clear agreement, there's no point and keeping that open for long (since it's guaranteed to be arebase hell)
< jtimon>
what about moving bitcoinconsensus.o from script to consensus?
< jtimon>
anyway, first rebase
< sipa>
BlueMatt: how do you measure compiler memory usage?
< sipa>
BlueMatt: i succesfully compiled with flto, and i never saw memory usage of a single process go above ~700MB (i was just watching with top, this may not be very accurate)
< cfields>
hmm, actually, CConnman could easily just hold the interface pointer, since it's abstract
< cfields>
sipa: isn't lto much less intensive on the individual compilation units?
< bitcoin-git>
[bitcoin] laanwj closed pull request #9267: Disable fee estimates for a confirm target of 1 block (0.13...backport9239) https://github.com/bitcoin/bitcoin/pull/9267
< wumpus>
strange, bitcoin-git shows the close notice but not the merge on the 0.13 branch
< wumpus>
first thought I forgot to push, but I didn't
< btcdrak>
wumpus: I have the same problem with notifications for another repo.
< wumpus>
btcdrak: may be just an intermittent issue, it's the first time I notice at least
< bitcoin-git>
[bitcoin] jtimon closed pull request #7779: Discussion: Consensus: There's only one type of consensus flags (master...0.12.99-consensus-unify-flags) https://github.com/bitcoin/bitcoin/pull/7779