< Lightsword>
luke-jr, think you can rebase #7533?
< gribble>
https://github.com/bitcoin/bitcoin/issues/7533 | RPC: sendrawtransaction: Allow the user to ignore/override specific rejections by luke-jr · Pull Request #7533 · bitcoin/bitcoin · GitHub
< luke-jr>
Lightsword: I can, if there's reason to.
< Lightsword>
luke-jr, would be nice to have for 0.14 if possible
< luke-jr>
yes
< gmaxwell>
luke-jr: it would be more useful if it interacted with mempool saving in a productive way.
< luke-jr>
gmaxwell: ?
< gmaxwell>
well IIRC the only real justification for that change is to bypass policy (though probably not non-mandatory script verify flags) to poke things into your mempool.
< gmaxwell>
But those things wouldn't be restored after restart.
< luke-jr>
so basically just have mempool loading ignore all policy somehow?
< gmaxwell>
Or save the fact that particular transaction bypassed it.
< Lightsword>
yeah, you would probably only want to bypass mempool loading for those that bypassed with sendrawtransaction since that feature is mostly useful for miners wanting to bypass policy without having to patch core
< luke-jr>
mempool.dat format doesn't look very extensible :x
< Lightsword>
gmaxwell, wouldn’t it make more sense rather than saving minfee to just load all then evict those that don’t match policy? is the priority for manual prioritizations set currently there?
< Lightsword>
then maybe extend that to have policy bypass flags
< Lightsword>
my thoughts are that configs that affect mempoolminfee are often changed across restarts
< gmaxwell>
Lightsword: minfee is additional state. imagine your mempool is full. Then a block arives that clears out 1MB of it. Your minfee doesn't instantly drop to zero (or the configured relay minfee)-- that would be dumb, because if it doesn't change at all it's likely newly arriving transactions will fill up the mempool again in short order.
< gmaxwell>
so instead it decays back to the minimum at a rate that depends on how empty the mempool is.
< gmaxwell>
part of the point of the mempool saving is so that your node isn't in a highly irregular state right after start.
< jcorgan>
/cl
< bitcoin-git>
[bitcoin] luke-jr opened pull request #9422: Refactor mempool.dat to be extensible, and store missing info (master...mempool_dat_extensible) https://github.com/bitcoin/bitcoin/pull/9422
< bitcoin-git>
[bitcoin] rebroad closed pull request #9030: Don't process blocktxns when we have the block already. (master...BlocktxnExits) https://github.com/bitcoin/bitcoin/pull/9030
< achow101>
any plans for an rc2?
< gmaxwell>
hasn't been a deed for one. only thing missed was the version bump, but I think wladimir said that if that was all, we wouldn't do another rc.
< bitcoin-git>
[bitcoin] gmaxwell opened pull request #9424: Change LogAcceptCategory to use uint32_t rather than sets of strings. (master...log_category_simplify) https://github.com/bitcoin/bitcoin/pull/9424
< luke-jr>
probably makes sense to put off rc2/final until after Christmas, since testing is likely reduced in the meantime?