< bitcoin-git> [bitcoin] goku1997 opened pull request #9324: Increase block size to 8MB for Bitcoin Ocho. Bitcoin Ocho is the future. (master...master) https://github.com/bitcoin/bitcoin/pull/9324
< bitcoin-git> [bitcoin] sipa closed pull request #9324: Increase block size to 8MB for Bitcoin Ocho. Bitcoin Ocho is the future. (master...master) https://github.com/bitcoin/bitcoin/pull/9324
< gmaxwell> oh no sipa closed /the future/
< BlueMatt> https://github.com/bitcoin/bitcoin/blob/master/src/addrman.cpp#L38 its not the first time he's blocked things from the future
< luke-jr> if only all our trolls were this ridiculous
< owowo> the future was yesterday.
< bitcoin-git> [bitcoin] rebroad opened pull request #9325: Allow first cmpctblock/blocktxn received to be processed (rather than first requested) (master...ProcessFirstCmpct) https://github.com/bitcoin/bitcoin/pull/9325
< sipa> jonasschnelli: yup
< gmaxwell> jonasschnelli: openssl 1.1 made a breaking change to their API. AFAICT there is no fix for the libsecp256k1 tests except fixing the configure script to not try to build them-- they removed functionality the tests were using. I opened an issue, it's a trivial thing to address-- but without an impacted machine a bit of a pain to know if the test is right
< * gmaxwell> goes to update his debian testing system to see if it breaks.
< jonasschnelli> But I guess we also need fixing in crypto_tests.cpp (OldEncrypt()) in the non-libsecp256k1 part of the code
< gmaxwell> Or we just drop those tests.
< jonasschnelli> Yeah
< luke-jr> Shouldn't --enable-openssl-tests=no still work if passed to Core's configure, even if it shows a warning?
< gmaxwell> at least that one can be fixed though, the struct is made opaque and can be constructed on the heap with EVP_MD_CTX_create.
< luke-jr> (I agree it makes sense to remove them, but as a stop-gap fix for users until the new version)
< gmaxwell> well we should fix this now for 0.13.2 too.
< gmaxwell> I find it a bit absurd that debian continually ships massively out of date software but then just changes openssl's API in a stable release willynilly.
< TD-Linux> gmaxwell, well it looks like that affects stretch and jessie is the one with out of date software....
< gmaxwell> welp. doesn't reproduce on streach for me. :-/
< gmaxwell> (not in bitcoind compile, nor libsecp256k1 compile.)
< aj> gmaxwell: libssl1.1-dev installed?
< gmaxwell> aj: thanks, that broke it! interesting that update/upgrade didn't pull that in.
< aj> gmaxwell: or apparently just libssl-dev now. there's openssl1.0 and libssl1.0-dev for testing now by the looks so it might have helpfully upgraded to let you keep developing against the 1.0 api...
< gmaxwell> explains why we've only had ~two reports so far.
< gmaxwell> https://github.com/bitcoin-core/secp256k1/pull/433 okay thats the libsecp256k1 part, I'll go do the bitcoin-core part.
< bitcoin-git> [bitcoin] gmaxwell opened pull request #9326: Fix wallet/test/crypto_tests.cpp for OpenSSL 1.1 API. (master...openssl_api11) https://github.com/bitcoin/bitcoin/pull/9326
< jonasschnelli> ^ taged
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9329: [Qt] Console: allow empty arguments (master...2016/12/fix_qt_empty_args) https://github.com/bitcoin/bitcoin/pull/9329
< jonasschnelli> Can someone confirm that ./src/qt/test/test_bitcoin-qt ends with an malloc/free issue? "pointer being freed was not allocated"?
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9330: [Qt] Console: add security warning (master...2016/12/qt_add_sec) https://github.com/bitcoin/bitcoin/pull/9330
< ryanofsky_> src/qt/test/test_bitcoin-qt seems to be working for me, don't see freed pointer message (at 76fcd9d)
< jonasschnelli> ryanofsky_: current master?
< jtimon> mmhmm, shouldn't https://github.com/bitcoin/bitcoin/blob/master/src/serialize.h#L259 use std::numeric_limits<uint32_t>::max() instead of std::numeric_limits<unsigned int>::max() ?
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9331: [qa] Add test for rescan feature of wallet key import RPCs (master...pr/test-import-rescan) https://github.com/bitcoin/bitcoin/pull/9331
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys (on top of #9331) (master...pr/script-label) https://github.com/bitcoin/bitcoin/pull/9332
< afk11> Hi all, anyone with a synced testnet node able to help me? Looking for the hex of a block with testnet transactions, every API I can find returns base-data only (and my node is down) :/ 000000005ded58feee127958d6619f8fedb2e67a7524067b474449a5e908c2fa is one, just need output of `getblock [hash] false`
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9333: [trivial] Add comment documenting CWalletTx::mapValue (master...pr/comment-mapvalue) https://github.com/bitcoin/bitcoin/pull/9333
< morcos> jonasschnelli: where did we leave things on #8501? I was under the impression that you agreed it made sense to have a bit more flexible framework to support multiple timescales?
< gribble> https://github.com/bitcoin/bitcoin/issues/8501 | Add mempool statistics collector by jonasschnelli · Pull Request #8501 · bitcoin/bitcoin · GitHub
< instagibbs> morcos, leaving the coin selection stuff alone, sorry for all the rebasing :)
< gmaxwell> oh jesus, some sufficiently old openssl doesn't have EVP_MD_CTX_new/EVP_MD_CTX_free
< sipa> add it to configure, and ifdef our own definition in?
< gmaxwell> I'm just going to ifdef around a version check and use heap/stack depending on the version.
< bitcoin-git> [bitcoin] sipa opened pull request #9334: Update to latest libsecp256k1 (master...secp) https://github.com/bitcoin/bitcoin/pull/9334
< gmaxwell> #9290 and #9302 want to be merged. Also, does someone dislike #9236? it's been ready for merge for almost two weeks.
< gribble> https://github.com/bitcoin/bitcoin/issues/9290 | Make RelayWalletTransaction attempt to AcceptToMemoryPool. by gmaxwell · Pull Request #9290 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9302 | Return txid even if ATMP fails for new transaction by sipa · Pull Request #9302 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9236 | Fix races for strMiscWarning and fLargeWork*Found, make QT runawayException use GetWarnings by gmaxwell · Pull Request #9236 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] richardkiss opened pull request #9335: Fix spelling. (master...feature/typo) https://github.com/bitcoin/bitcoin/pull/9335
< bitcoin-git> [bitcoin] richardkiss opened pull request #9336: Change SIG_NULLFAIL => NULLFAIL. (master...feature/unify_nullfail) https://github.com/bitcoin/bitcoin/pull/9336
< bitcoin-git> [bitcoin] richardkiss closed pull request #9336: Change SIG_NULLFAIL => NULLFAIL. (master...feature/unify_nullfail) https://github.com/bitcoin/bitcoin/pull/9336