< arowser> make distdir failed on master branch
< arowser> No rule to make target `test/data/blanktx.hex', needed by `distdir'
< arowser> ./autogen.sh && ./configure && make distdir
< BlueMatt> arowser: probably due to #7562
< BlueMatt> looking....
< gribble> https://github.com/bitcoin/bitcoin/issues/7562 | Bump transaction version default to 2 by btcdrak · Pull Request #7562 · bitcoin/bitcoin · GitHub
< BlueMatt> btcdrak: hmm?
< BlueMatt> arowser: hum, works for me....very strange
< btcdrak> BlueMatt: just that there is an unused file which should be deleted.
< BlueMatt> btcdrak: yes, hence why i linked to that pr, but arowser said they cant build with it
< BlueMatt> which seems strange
< arowser> its wired, I found it in different build, not only for linux, for mac :http://blkdb.com:8080/view/All/job/apple-darwin11_MacOSX10.11/17/console
< arowser> make -d distdir
< btcdrak> arowser: delete the blank.hex file it's not used
< arowser> Delete test/data/blanktx.hex in src/Makefile.test.include?
< arowser> btcdark: blank.hex not exists in disk
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b99a093afed8...79da3979b7cc
< bitcoin-git> bitcoin/master 815f414 Karl-Johan Alm: Uses built-in byte swap if available (Apple) and if bswap_XX is undefined....
< bitcoin-git> bitcoin/master 79da397 Wladimir J. van der Laan: Merge #9366: Fix: OSX QT compile: use built-in swap if available, or defer...
< bitcoin-git> [bitcoin] laanwj closed pull request #9366: Fix: OSX QT compile: use built-in swap if available, or defer (master...macosx-qt-build-fix2) https://github.com/bitcoin/bitcoin/pull/9366
< bitcoin-git> [bitcoin] kallewoof closed pull request #9372: Fix: OSX QT compile: move bswap_XX into Bitcoin:: to avoid collision with existing definitions (master...rename-bswap_XX) https://github.com/bitcoin/bitcoin/pull/9372
< btcdrak> arowser I'll make a quick PR
< bitcoin-git> [bitcoin] TheBlueMatt opened pull request #9375: Relay compact block messages prior to full block connection (master...2016-12-compact-fast-relay) https://github.com/bitcoin/bitcoin/pull/9375
< arowser> btcdark: ok, thanks
< bitcoin-git> [bitcoin] btcdrak opened pull request #9376: Remove unused test files and references (master...fixmissing) https://github.com/bitcoin/bitcoin/pull/9376
< btcdrak> BlueMatt: is 9375 intended for backport?
< BlueMatt> btcdrak: no
< BlueMatt> I think the previous compact blocks pull is sufficient for 0.13.2
< btcdrak> BlueMatt: ok
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/79da3979b7cc...b416095371f5
< bitcoin-git> bitcoin/master 5dd626a Pieter Wuille: Make fuzzer actually test CTxOutCompressor
< bitcoin-git> bitcoin/master b416095 Wladimir J. van der Laan: Merge #9354: Make fuzzer actually test CTxOutCompressor...
< bitcoin-git> [bitcoin] laanwj closed pull request #9354: Make fuzzer actually test CTxOutCompressor (master...fixfuzz) https://github.com/bitcoin/bitcoin/pull/9354
< wumpus> let's try to do 0.13.2 today?
< btcdrak> wumpus: #9352 and #9357 look mergable now
< gribble> https://github.com/bitcoin/bitcoin/issues/9352 | Attempt reconstruction from all compact block announcements by sdaftuar · Pull Request #9352 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/9357 | [0.13 backport] Attempt reconstruction from all compact block announcements by sdaftuar · Pull Request #9357 · bitcoin/bitcoin · GitHub
< wumpus> agreed
< btcdrak> I'm reviewing the other two as well.
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b416095371f5...a7f76512d9ea
< bitcoin-git> bitcoin/master 7017298 Suhas Daftuar: Allow compactblock reconstruction when block is in flight
< bitcoin-git> bitcoin/master 813ede9 Suhas Daftuar: [qa] Update compactblocks test for multi-peer reconstruction
< bitcoin-git> bitcoin/master a7f7651 Wladimir J. van der Laan: Merge #9352: Attempt reconstruction from all compact block announcements...
< bitcoin-git> [bitcoin] laanwj closed pull request #9352: Attempt reconstruction from all compact block announcements (master...optimistic-cb-2) https://github.com/bitcoin/bitcoin/pull/9352
< jonasschnelli> wumpus: what do you think about the fundrawtransaction addr reuse problem for 0.13.2?
< wumpus> jonasschnelli: just leave it
< jonasschnelli> I have a minimal fix in a couple of minutes
< wumpus> could be backported for 0.13.3, but this is not urgent
< jonasschnelli> Okay. Fine for me, we can fix it in 0.14
< jonasschnelli> or yes, 0.13.3 then
< btcdrak> I think 9347 is mergeable too
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to 0.13: https://github.com/bitcoin/bitcoin/compare/fb987b364511...03b6f621ccf9
< bitcoin-git> bitcoin/0.13 4ced313 Suhas Daftuar: Allow compactblock reconstruction when block is in flight
< bitcoin-git> bitcoin/0.13 53b656f Suhas Daftuar: [qa] Update compactblocks test for multi-peer reconstruction
< bitcoin-git> bitcoin/0.13 03b6f62 Wladimir J. van der Laan: Merge #9357: [0.13 backport] Attempt reconstruction from all compact block announcements...
< wumpus> and after that, tag rc1?
< bitcoin-git> [bitcoin] laanwj closed pull request #9347: [0.13.2] wallet/rpc backports (0.13...Mf1612-013back) https://github.com/bitcoin/bitcoin/pull/9347
< wumpus> oh there's still #9262
< gribble> https://github.com/bitcoin/bitcoin/issues/9262 | Prefer coins that have fewer ancestors, sanity check txn before ATMP by instagibbs · Pull Request #9262 · bitcoin/bitcoin · GitHub
< wumpus> seems it is still in flux
< wumpus> can we pass on that one?
< btcdrak> wumpus: seems solid to me
< wumpus> well there are still un-addresed comment so it cetainly can't be merged in this state
< wumpus> and it looks non-trivial to backport too
< btcdrak> for the backported stuff, I'm not sure refactoring makes sense. seems better in a separate PR after.
< wumpus> I think if we want to do a rc before the holidays we should do it now
< wumpus> probably refactoring will only make it more difficult to backport
< BlueMatt> wumpus: yea, sorry, was trying to get to 9262 today but other bugs resulted in me not getting to it until I was too tired to want to review something :(
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/a7f76512d9ea...db45ad85164d
< bitcoin-git> bitcoin/master 89c8d2c Jonas Schnelli: [Qt] Console: allow empty arguments
< bitcoin-git> bitcoin/master 6a32c0f Luke Dashjr: Qt/Test: Check handling of empty arguments in RPC debug console
< bitcoin-git> bitcoin/master 390bd14 Jonas Schnelli: [Qt] Console: don't allow empty arguments when using the comma-syntax
< bitcoin-git> [bitcoin] laanwj closed pull request #9329: [Qt] Console: allow empty arguments (master...2016/12/fix_qt_empty_args) https://github.com/bitcoin/bitcoin/pull/9329
< wumpus> is anyone working on backporting 9262?
< btcdrak> it seems to clear cherr-pick except for the benchmarking file which is a clean add.
< btcdrak> s/clear/clean/
< btcdrak> at least at first glance....
< wumpus> thanks for checking btcdrak
< wumpus> I had assumed it to be worse with all the changes in wallet post-0.13
< bitcoin-git> [bitcoin] jonasschnelli opened pull request #9377: fundrawtransaction: Keep change-output keys by default, make it optional (master...2016/12/fix_frt_adr) https://github.com/bitcoin/bitcoin/pull/9377
< btcdrak> wumpus: so the cherry-pick compiles ok, test_bitcoin, bencher etc all work. didnt run rpc-tests yet
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/db45ad85164d...a336d13a587c
< bitcoin-git> bitcoin/master 0632939 Alex Morcos: Flush wallet after abandontransaction
< bitcoin-git> bitcoin/master a336d13 Wladimir J. van der Laan: Merge #9311: Flush wallet after abandontransaction...
< bitcoin-git> [bitcoin] laanwj closed pull request #9311: Flush wallet after abandontransaction (master...flushwalletonabandon) https://github.com/bitcoin/bitcoin/pull/9311
< bitcoin-git> [bitcoin] laanwj closed pull request #8734: Send NOTFOUND when we don't have the block data. (master...NotfoundIfPruned) https://github.com/bitcoin/bitcoin/pull/8734
< bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/a336d13a587c...7f72568e6b15
< bitcoin-git> bitcoin/master c63198f Gregory Maxwell: Make QT runawayException call GetWarnings instead of directly access strMiscWarning....
< bitcoin-git> bitcoin/master e3ba0ef Gregory Maxwell: Eliminate data races for strMiscWarning and fLargeWork*Found....
< bitcoin-git> bitcoin/master 749be01 Gregory Maxwell: Move GetWarnings() into its own file.
< bitcoin-git> [bitcoin] laanwj closed pull request #9236: Fix races for strMiscWarning and fLargeWork*Found, make QT runawayException use GetWarnings (master...strMiscraceless) https://github.com/bitcoin/bitcoin/pull/9236
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/2c5fc0dba32a6ede1d611554a04a996183aa8ee9
< bitcoin-git> bitcoin/0.13 2c5fc0d Wladimir J. van der Laan: doc: Add initial pulls + authors list for 0.13.2
< cannon-c> whats new for 0.13.2 ?
< cannon-c> noteable
< btcdrak> cannon-c: check the last commit link above
< wumpus> also be aware that 0.13.2 is still under construction, it is not a release yet
< wumpus> and that it is a minor release, so there will be no new features, just bugfixes
< cannon-c> thank you. Reading now
< bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.13: https://github.com/bitcoin/bitcoin/commit/7201dd7732fa69b498b1d647c66c2460af9bed7b
< bitcoin-git> bitcoin/0.13 7201dd7 Wladimir J. van der Laan: qt: Pre-rc1 translations update
< instagibbs> wumpus, waiting on anything for #9262 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/9262 | Prefer coins that have fewer ancestors, sanity check txn before ATMP by instagibbs · Pull Request #9262 · bitcoin/bitcoin · GitHub
< wumpus> instagibbs: sipa's nit about doing three map lookups I guess?
< instagibbs> Ok, I'm just worried about squashing more changes invalidating ACKs
< btcdrak> instagibbs: dont squash then
< instagibbs> btcdrak, that's the plan, OCD on backburner
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9378: [trivial] Add documentation for CWalletTx::fFromMe member. (master...pr/fromme-doc) https://github.com/bitcoin/bitcoin/pull/9378
< bitcoin-git> [bitcoin] ryanofsky closed pull request #9351: Remove CWalletTx::fFromMe member. (master...pr/atw-fromme) https://github.com/bitcoin/bitcoin/pull/9351
< btcdrak> what happened to botbot?
< btcdrak> looks like it borked out for a day :/
< bitcoin-git> [bitcoin] morcos opened pull request #9380: Separate different uses of minimum fees (master...minfees) https://github.com/bitcoin/bitcoin/pull/9380
< BlueMatt> I think #9262 has enough acks to get an 0.13.2 started when wumpus wakes up
< gribble> https://github.com/bitcoin/bitcoin/issues/9262 | Prefer coins that have fewer ancestors, sanity check txn before ATMP by instagibbs · Pull Request #9262 · bitcoin/bitcoin · GitHub
< gmaxwell> BlueMatt: got a backport PR?
< BlueMatt> gmaxwell: btcdrak was saying last night that it applies cleanly to 0.13 and tests pass
< luke-jr> last night there was a discussion that it can just be cherry-picked
< gmaxwell> someone should still open the PR for it!
< luke-jr> IIRC in the past, wumpus has requested PRs not be opened for simple cherry-pick backports *shrug*
< btcdrak> gmaxwell: I have a backport
< bitcoin-git> [bitcoin] ryanofsky opened pull request #9381: Remove CWalletTx merging logic from AddToWallet (master...pr/atw-nomerge) https://github.com/bitcoin/bitcoin/pull/9381
< bitcoin-git> [bitcoin] btcdrak opened pull request #9382: [backport 0.13] Prefer coins that have fewer ancestors, sanity check txn before ATMP (0.13...backport9262) https://github.com/bitcoin/bitcoin/pull/9382