< bitcoin-git> [bitcoin] qmma70 opened pull request #13490: Rewind when active block tip is higher than nStopAtHeight (master...rewind) https://github.com/bitcoin/bitcoin/pull/13490
< gmaxwell> uh, that would make stop at height less useful for me. :(
< gmaxwell> sjors request for a 'determinstic blockchain snapshot' as I understand what he's saying wouldn't be achieved by that
< sipa> isn't there an easier solution to make sure ABC just doesn't pass the stopatheight value?
< luke-jr> or just have a tx spend index, so we can calculate past UTXO states if that's the goal
< gmaxwell> why tie it with stop at height, we could have a version of invalidateblock that rewinds to a particular block.
< sipa> well the fact that -stopatheight doesn't actually stop at that height is a bug afaik, and it should be fixed
< sipa> but going past it and then rolling back seems like an enormously roundabout way of accomplishing that
< gmaxwell> ::nods::
< sipa> actually i don't understand how this is possible at all, except in case there is a reorg just around that height
< gmaxwell> in any case if someone needs a utxo set at a particular place it should be triggered by blockhash
< bitcoin-git> [bitcoin] sipa opened pull request #13491: Improve handling of INVALID in IsMine (master...201806_cleanmine) https://github.com/bitcoin/bitcoin/pull/13491
< bitcoin-git> [bitcoin] promag opened pull request #13492: Fix reply not sent when event loop terminates prematurely (master...2018-06-http-shutdown) https://github.com/bitcoin/bitcoin/pull/13492
< bitcoin-git> [bitcoin] ken2812221 closed pull request #13485: Ensure that http event loop is empty before the loop exit (master...http_shutdown) https://github.com/bitcoin/bitcoin/pull/13485
< bitcoin-git> [bitcoin] fanquake opened pull request #13493: gui: Add leading 0 to QT_VERSION check for QFontDatabase (master...remove-qtversion-qfontdatabase) https://github.com/bitcoin/bitcoin/pull/13493
< HearingVo> Can someone provide me with some BitCoin?
< promag> jonasschnelli: friendly ping #13111
< gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub
< gnappuraz> Hi, I have a question regarding some bitcoin source code i'm trying to understand. Is this the right place?
< jonasschnelli> promag: Yes. Will review this afternoon
< promag> gnappuraz: just ask
< promag> jonasschnelli: nice
< gnappuraz> I was looking at the wallet.h file, there is a mapWallet map<uint256, CWalletTx>... I was trying to figure out what this map exactly contains
< gnappuraz> it seems the main memory storage to bookkeep the transactions seen so far. Not sure if invalid txs and txs from forks are there too though
< jonasschnelli> gnappuraz: What do you mean with invalid txns?
< jonasschnelli> Yes. It is the main storage for transactions filtered out of the blockchain and mempool that are relevant to the wallet keys
< gnappuraz> also orphans?
< jonasschnelli> But they are checked for confirmation or conflicts during presentation... so you can't assume that all transactions in mapWallet are confirmed, etc.
< jonasschnelli> Orphans possible, yes.
< gnappuraz> ok thank you very much!
< jonasschnelli> Its just a set of transactions that have relevance to your keys/scripts in your wallet...
< jonasschnelli> If you want to render a balance, etc. you need to check / calculate if the transactions counts, etc.
< gnappuraz> if instead I need to fetch txs that are not related to my wallet?
< jonasschnelli> gnappuraz: depends... if you know the blockhash/heigh and the txid, you can use getrawtransaction
< jonasschnelli> If you only know the txid, you may need the -txindex=1 (enabled tx index)
< gnappuraz> right, thanks
< jonasschnelli> The wallet is a partial indexing service for the blockchain,... it "indexes" transactions relevant to the keys/scripts in the wallet
< jonasschnelli> (it not only indexes, it "extracts" the transactions)
< gnappuraz> i understand
< fanquake> wumpus: You commented on the wrong PR re squashing commits
< wumpus> fanquake: yep, resolved now
< fanquake> qt4 changes looking good
< fanquake> managed to engage the wrong @wumpus again
< promag> thanks jonas, will sort it out
< fanquake> provoostenator: As far as I can tell I've gotten ios cross builds working. Will PR some depends changes shortly.
< murrayn> was there not a time, not so long ago, where transaction age was a factor in prioritization? am i misremembering?
< wumpus> utxo age was
< bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d6cf4bd7eb3b...45c00f841612
< bitcoin-git> bitcoin/master 3352da8 practicalswift: Add "export LC_ALL=C" to all shell scripts
< bitcoin-git> bitcoin/master 47776a9 practicalswift: Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C"
< bitcoin-git> bitcoin/master 45c00f8 Wladimir J. van der Laan: Merge #13454: Make sure LC_ALL=C is set in all shell scripts...
< bitcoin-git> [bitcoin] laanwj closed pull request #13454: Make sure LC_ALL=C is set in all shell scripts (master...avoid-locale-dependent-range-expressions) https://github.com/bitcoin/bitcoin/pull/13454
< wumpus> it used to be the sorting criterion for the free transaction area that some miners maintained in blocks
< promag> jonasschnelli: pushed a fix
< jonasschnelli> promag: will test asap
< promag> jonasschnelli: ty
< promag> jonasschnelli: now in the main window the wallet selector hidden when there is only 1 wallet loaded
< promag> *is hidden*
< rabidus> oispa liivit
< rabidus> oops sorry, wrong channel :(
< promag> jonasschnelli: we should create a model for wallets no?
< promag> btw, any objection to change QObject::connect to qt5 syntax (after qt4 is dropped)?
< fanquake> promag sounds good
< bitcoin-git> [bitcoin] practicalswift opened pull request #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C (master...lc-all-lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13494
< ahp1992> hi
< ahp1992> hello all
< promag> thank fanquake
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/45c00f841612...d67eff8002d7
< bitcoin-git> bitcoin/master 7b23e6e practicalswift: Follow-up to #13454: Fix broken build by exporting LC_ALL=C
< bitcoin-git> bitcoin/master d67eff8 MarcoFalke: Merge #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C...
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C (master...lc-all-lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13494
< ahp1992> let me know, how can i study to do own currency using bitcoin core.
< fanquake> ahp1992 off-topic here.
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d67eff8002d7...2d071f5a7055
< bitcoin-git> bitcoin/master 55771b7 lucash.dev@gmail.com: Removed unused == operator from CMutableTransaction.
< bitcoin-git> bitcoin/master 2d071f5 Wladimir J. van der Laan: Merge #13443: Removed unused == operator from CMutableTransaction....
< bitcoin-git> [bitcoin] laanwj closed pull request #13443: Removed unused == operator from CMutableTransaction. (master...remove-CMutableTransaction-equals) https://github.com/bitcoin/bitcoin/pull/13443
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2d071f5a7055...450055bdbdcb
< bitcoin-git> bitcoin/master 1e1eb63 Pieter Wuille: Improve coverage of SHA256 SelfTest code
< bitcoin-git> bitcoin/master 450055b Wladimir J. van der Laan: Merge #13438: Improve coverage of SHA256 SelfTest code...
< bitcoin-git> [bitcoin] laanwj closed pull request #13438: Improve coverage of SHA256 SelfTest code (master...201806_selftestsha) https://github.com/bitcoin/bitcoin/pull/13438
< jonasschnelli> sipa: would it be possible to have 3 different BCHs in Bech32X (three length of checksum)?
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/450055bdbdcb...ac3224c8eea9
< bitcoin-git> bitcoin/master fafa270 MarcoFalke: Make ReceivedBlockTransactions return void
< bitcoin-git> bitcoin/master ac3224c Wladimir J. van der Laan: Merge #13412: Make ReceivedBlockTransactions return void...
< bitcoin-git> [bitcoin] laanwj closed pull request #13412: Make ReceivedBlockTransactions return void (master...Mf1806-refactorReturnCodeValidation) https://github.com/bitcoin/bitcoin/pull/13412
< bitcoin-git> [bitcoin] wodry opened pull request #13496: Test: Harden lint-filenames.sh (master...harden-test-lint-filenames.sh) https://github.com/bitcoin/bitcoin/pull/13496
< sipa> jonasschnelli: sure, what lengths
< jonasschnelli> I think 7, 14, and 21 (correction)
< jonasschnelli> Or maybe 7, 14, 28
< jonasschnelli> 7 is ~5%, 14: ~10%, 28: ~20%
< jonasschnelli> (for 512bit)
< bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ac3224c8eea9...088240685456
< bitcoin-git> bitcoin/master faa18ca MarcoFalke: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds
< bitcoin-git> bitcoin/master 0882406 Wladimir J. van der Laan: Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds...
< bitcoin-git> [bitcoin] laanwj closed pull request #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds (master...Mf1806-walletPrunedFundsSegfault) https://github.com/bitcoin/bitcoin/pull/13437
< bitcoin-git> [bitcoin] jnewbery opened pull request #13498: [wallet] Fixups from account API deprecation (master...account_deprecation_fixups) https://github.com/bitcoin/bitcoin/pull/13498
< sipa> jonasschnelli: around?
< jonasschnelli> sipa: yes (phonetyping)
< sipa> jonasschnelli: i have a few thoughts on a format for describing sets of scriptPubKey
< sipa> it's probably more complicated than what you're thinking about, but it's also pretty much what i'd want the entire wallet to migrate to
< sipa> i'll do a writeup/prototype over the next few days if you're interested
< jonasschnelli> sure. I think we could first use it for the scantxoutset
< sipa> yeah
< sipa> but it would also support things like multisig of multiple hd paths etc
< jonasschnelli> I think that's great... i guess it's related to your thoughts on PSBT
< sipa> yes
< sipa> and also for supporting hw wallets directly in core, and forward compatibility with schnorr etc
< jonasschnelli> Good.
< jonasschnelli> I wanted to comment about the encoding...
< jonasschnelli> Do you think pure binary serialization is unacceptable?
< sipa> for psbt?
< jonasschnelli> yes
< sipa> sure, that'd be the most common thing to do
< jonasschnelli> or where do you see advantages of base64 and z85, etc.
< sipa> but we can't put pure binary in an RPC response
< jonasschnelli> yes. sure.
< sipa> the common assumption i think is using hex
< jonasschnelli> yeah... I guess size won't matter to much on that layer
< sipa> but as i know how annoying raw transactions in hex can be to copy paste, i wanted to suggest something smaller
< sipa> and z85 looks pretty neat actually
< jonasschnelli> yes. I like it.
< sipa> it's 5 characters per 4 bytes
< jonasschnelli> but PSBT could also have it own file type... end user could email and dbl-click etc
< sipa> it probably should
< jonasschnelli> For RPC it will be a long chuck of text. both with hex or z85.
< sipa> yes
< sipa> but 1.6x shorter with z85
< jonasschnelli> Yes. But hassle on the client side... eventually opt-in?
< sipa> yeah, the burden of implementing z85 would be a deterrent i guess
< sipa> base64 is more common
< jonasschnelli> Yes.
< sipa> i don't care much; i just brought it up because it would be good to standardize on one
< jonasschnelli> I think z85 brings in some perfection and I generally think it's worth to explore
< sipa> cfields: what clang version will be used for 0.17 osx builds?
< jonasschnelli> and it not very complex so if one can deal with PSBT, z85 seem a trivial puzzlepiece
< jonasschnelli> *its
< bitcoin-git> [bitcoin] JeremyRubin reopened pull request #12763: Add RPC Whitelist Feature from #12248 (master...whitelistrpc) https://github.com/bitcoin/bitcoin/pull/12763
< bitcoin-git> [bitcoin] jamesob closed pull request #12407: Ensure nStatus is set properly for all invalid blocks (master...jamesob/2018-02-mark-headers-invalid) https://github.com/bitcoin/bitcoin/pull/12407
< nkohen> Does anyone know what the intended functionality of combinerawtransaction is with bitcoind?
< sipa> nkohen: create a raw transaction for a 2-of-2 multisig, give it to both parties, each sign their part with a single signature; combinerawtransaction will turn it into a full transaction
< nkohen> Thanks!
< bitcoin-git> [bitcoin] achow101 opened pull request #13500: [wallet] Decouple wallet version from client version (master...decouple-wallet-version) https://github.com/bitcoin/bitcoin/pull/13500
< gmaxwell> sipa: is z85 as copy and paste friendly as base64?
< sipa> gmaxwell: probably not
< sipa> it's designed to not need escaping in typical programming languages when surrounded by quotation marks, though
< sipa> wait, what do you mean by copy-paste friendly?
< bitcoin-git> [bitcoin] promag opened pull request #13501: Remove race on shutdown between event loop exit and http reply (master...2018-06-loopexit) https://github.com/bitcoin/bitcoin/pull/13501
< gmaxwell> sipa: mostly not having weird escape characters that will cause misbehavior when pasted.
< gmaxwell> it has / which is unfortunate for pasting into IRC.
< sipa> gmaxwell: it excludes \ ' " ; ,
< sipa> and |
< sipa> if it would have excluded < / >, and included , ; | instead it would be clean html
< gmaxwell> I'm surprised it doesn't include ,;| as those are generally safe AFAIK.
< sipa> yup
< sipa> hmm, there are are 94 non-space printable ascii characters
< sipa> so 9 must be excluded
< sipa> \ ' " ; , | ` ~
< sipa> i must be missing one still
< gmaxwell> https://tools.ietf.org/html/rfc1924 has < and > but leaves out the slashes.
< gmaxwell> it gives rationale for each of the omitted characters.
< sipa> that's specific for ipv6 addresses, though
< sipa> for example the chose to exclude [ ]
< gmaxwell> Right. & is also an escape character that should be aboided.
< gmaxwell> (at that document argues,
< gmaxwell> <>"'`/\&. seem more obvious safe characters to exclude to me.
< sipa> or just base64... only 6.25% less efficient
< sipa> and far more common
< gmaxwell> it is sad that base64 has / but at least it's a common and well understood thing.
< sipa> the base85 trick of encoding 32-bit integers is neat, though