< bitcoin-git>
[bitcoin] qmma70 opened pull request #13490: Rewind when active block tip is higher than nStopAtHeight (master...rewind) https://github.com/bitcoin/bitcoin/pull/13490
< gmaxwell>
uh, that would make stop at height less useful for me. :(
< gmaxwell>
sjors request for a 'determinstic blockchain snapshot' as I understand what he's saying wouldn't be achieved by that
< sipa>
isn't there an easier solution to make sure ABC just doesn't pass the stopatheight value?
< luke-jr>
or just have a tx spend index, so we can calculate past UTXO states if that's the goal
< gmaxwell>
why tie it with stop at height, we could have a version of invalidateblock that rewinds to a particular block.
< sipa>
well the fact that -stopatheight doesn't actually stop at that height is a bug afaik, and it should be fixed
< sipa>
but going past it and then rolling back seems like an enormously roundabout way of accomplishing that
< gmaxwell>
::nods::
< sipa>
actually i don't understand how this is possible at all, except in case there is a reorg just around that height
< gmaxwell>
in any case if someone needs a utxo set at a particular place it should be triggered by blockhash
< bitcoin-git>
[bitcoin] promag opened pull request #13492: Fix reply not sent when event loop terminates prematurely (master...2018-06-http-shutdown) https://github.com/bitcoin/bitcoin/pull/13492
< bitcoin-git>
[bitcoin] ken2812221 closed pull request #13485: Ensure that http event loop is empty before the loop exit (master...http_shutdown) https://github.com/bitcoin/bitcoin/pull/13485
< bitcoin-git>
[bitcoin] fanquake opened pull request #13493: gui: Add leading 0 to QT_VERSION check for QFontDatabase (master...remove-qtversion-qfontdatabase) https://github.com/bitcoin/bitcoin/pull/13493
< HearingVo>
Can someone provide me with some BitCoin?
< gnappuraz>
Hi, I have a question regarding some bitcoin source code i'm trying to understand. Is this the right place?
< jonasschnelli>
promag: Yes. Will review this afternoon
< promag>
gnappuraz: just ask
< promag>
jonasschnelli: nice
< gnappuraz>
I was looking at the wallet.h file, there is a mapWallet map<uint256, CWalletTx>... I was trying to figure out what this map exactly contains
< gnappuraz>
it seems the main memory storage to bookkeep the transactions seen so far. Not sure if invalid txs and txs from forks are there too though
< jonasschnelli>
gnappuraz: What do you mean with invalid txns?
< jonasschnelli>
Yes. It is the main storage for transactions filtered out of the blockchain and mempool that are relevant to the wallet keys
< gnappuraz>
also orphans?
< jonasschnelli>
But they are checked for confirmation or conflicts during presentation... so you can't assume that all transactions in mapWallet are confirmed, etc.
< jonasschnelli>
Orphans possible, yes.
< gnappuraz>
ok thank you very much!
< jonasschnelli>
Its just a set of transactions that have relevance to your keys/scripts in your wallet...
< jonasschnelli>
If you want to render a balance, etc. you need to check / calculate if the transactions counts, etc.
< gnappuraz>
if instead I need to fetch txs that are not related to my wallet?
< jonasschnelli>
gnappuraz: depends... if you know the blockhash/heigh and the txid, you can use getrawtransaction
< jonasschnelli>
If you only know the txid, you may need the -txindex=1 (enabled tx index)
< gnappuraz>
right, thanks
< jonasschnelli>
The wallet is a partial indexing service for the blockchain,... it "indexes" transactions relevant to the keys/scripts in the wallet
< jonasschnelli>
(it not only indexes, it "extracts" the transactions)
< gnappuraz>
i understand
< fanquake>
wumpus: You commented on the wrong PR re squashing commits
< wumpus>
fanquake: yep, resolved now
< fanquake>
qt4 changes looking good
< fanquake>
managed to engage the wrong @wumpus again
< promag>
thanks jonas, will sort it out
< fanquake>
provoostenator: As far as I can tell I've gotten ios cross builds working. Will PR some depends changes shortly.
< murrayn>
was there not a time, not so long ago, where transaction age was a factor in prioritization? am i misremembering?
< bitcoin-git>
bitcoin/master 3352da8 practicalswift: Add "export LC_ALL=C" to all shell scripts
< bitcoin-git>
bitcoin/master 47776a9 practicalswift: Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C"
< bitcoin-git>
bitcoin/master 45c00f8 Wladimir J. van der Laan: Merge #13454: Make sure LC_ALL=C is set in all shell scripts...
< bitcoin-git>
[bitcoin] laanwj closed pull request #13454: Make sure LC_ALL=C is set in all shell scripts (master...avoid-locale-dependent-range-expressions) https://github.com/bitcoin/bitcoin/pull/13454
< wumpus>
it used to be the sorting criterion for the free transaction area that some miners maintained in blocks
< promag>
jonasschnelli: pushed a fix
< jonasschnelli>
promag: will test asap
< promag>
jonasschnelli: ty
< promag>
jonasschnelli: now in the main window the wallet selector hidden when there is only 1 wallet loaded
< promag>
*is hidden*
< rabidus>
oispa liivit
< rabidus>
oops sorry, wrong channel :(
< promag>
jonasschnelli: we should create a model for wallets no?
< promag>
btw, any objection to change QObject::connect to qt5 syntax (after qt4 is dropped)?
< fanquake>
promag sounds good
< bitcoin-git>
[bitcoin] practicalswift opened pull request #13494: Follow-up to #13454: Fix broken build by exporting LC_ALL=C (master...lc-all-lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13494
< bitcoin-git>
[bitcoin] jamesob closed pull request #12407: Ensure nStatus is set properly for all invalid blocks (master...jamesob/2018-02-mark-headers-invalid) https://github.com/bitcoin/bitcoin/pull/12407
< nkohen>
Does anyone know what the intended functionality of combinerawtransaction is with bitcoind?
< sipa>
nkohen: create a raw transaction for a 2-of-2 multisig, give it to both parties, each sign their part with a single signature; combinerawtransaction will turn it into a full transaction
< nkohen>
Thanks!
< bitcoin-git>
[bitcoin] achow101 opened pull request #13500: [wallet] Decouple wallet version from client version (master...decouple-wallet-version) https://github.com/bitcoin/bitcoin/pull/13500
< gmaxwell>
sipa: is z85 as copy and paste friendly as base64?
< sipa>
gmaxwell: probably not
< sipa>
it's designed to not need escaping in typical programming languages when surrounded by quotation marks, though
< sipa>
wait, what do you mean by copy-paste friendly?
< bitcoin-git>
[bitcoin] promag opened pull request #13501: Remove race on shutdown between event loop exit and http reply (master...2018-06-loopexit) https://github.com/bitcoin/bitcoin/pull/13501
< gmaxwell>
sipa: mostly not having weird escape characters that will cause misbehavior when pasted.
< gmaxwell>
it has / which is unfortunate for pasting into IRC.
< sipa>
gmaxwell: it excludes \ ' " ; ,
< sipa>
and |
< sipa>
if it would have excluded < / >, and included , ; | instead it would be clean html
< gmaxwell>
I'm surprised it doesn't include ,;| as those are generally safe AFAIK.
< sipa>
yup
< sipa>
hmm, there are are 94 non-space printable ascii characters