01:11 < mryandao> l

01:14 < sipa> m

01:16 < gmaxwell> f

02:23 < luke-jr> k

03:03 < bitcoin-git> [bitcoin] steverusso opened pull request #13372: Docs: Linked to 'Building on FreeBSD' in build-unix.md (master...link-to-building-on-freebsd) https://github.com/bitcoin/bitcoin/pull/13372

06:35 < wumpus> sipa: the idea to use VARINT for the service bits is that the higher bits are not used, so on the average case this will save some bytes per entry

06:35 < wumpus> sipa: and ok, I'm fine with removing the onioncat padding for torv2, it seemed easiest for implementations

06:36 < wumpus> sipa: but if you think the VARINT doesn't help I'll change it back to just uint64_t

06:40 < sipa> wumpus: my point is more that if you're going to make it variable length... why limit to 64 bits?

07:00 < mryandao> has anyone tried to do a `git request-pull` without a github account?

07:02 < mryandao> would sending the pending changes to the mailing list prompt any of the maintainers to address the PR?

07:09 < wumpus> sipa: my point is more to have a limit, what would you suggest to limit it to?

07:10 < wumpus> sipa: my reasoning was: 64 bits is more than enough for now, so there's no actual need to allow longer values

07:11 < wumpus> mryandao: that's not really our way of working, I don't think anyone has ever posted a patch to the mailing list

07:11 < wumpus> it's even harder to get things to be reviewed that way then on it is on github

07:22 < sipa> wumpus: right, but you can have a serialization that supports longer, even though you currently don't use (or accept) it?

07:22 < sipa> this is just a nit... i'm totally fine with a varint or just 64 bit, and extend it later again if needed

07:25 < wumpus> sipa: right, that'd be ok to me

07:30 < wumpus> I've updated the torv2 format to strip the onioncat prefixing

14:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12744: WIP: eliminate dependency on boost::program_options (master...program_options) https://github.com/bitcoin/bitcoin/pull/12744

17:11 < bitcoin-git> [bitcoin] eudisd opened pull request #13373: Qt: Update Wallet Encryption Titles To Better Describe Process (master...feature/bitcoin-#13245) https://github.com/bitcoin/bitcoin/pull/13373

17:47 < bitcoin-git> [bitcoin] kaplanmaxe opened pull request #13374: utils and libraries: checking for bitcoin address in translations (master...check-addr-translations) https://github.com/bitcoin/bitcoin/pull/13374

20:32 < bitcoin-git> [bitcoin] undercoverGod opened pull request #13375: utils and libraries: address check in update-translations.py (master...master) https://github.com/bitcoin/bitcoin/pull/13375