02:48 < achow101> gmaxwell: the final alert that core produces actually totally protects vulnerable nodes

02:48 < achow101> this is because setCancel also includes the id for the final alert, so no other final alerts can actually be created while that is in effect

13:21 < bitcoin-git> [bitcoin] laanwj opened pull request #13528: qt: Move BitcoinGUI initializers to class, fix initializer order warning (master...2018_06_bitcoingui_initializers) https://github.com/bitcoin/bitcoin/pull/13528

13:32 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3a4549301ab2...5eca4e86d4ef

13:32 < bitcoin-git> bitcoin/master 32d153f Pieter Wuille: For AVX2 code, also check for AVX, XSAVE, and OS support

13:32 < bitcoin-git> bitcoin/master 5eca4e8 Wladimir J. van der Laan: Merge #13471: For AVX2 code, also check for AVX, XSAVE, and OS support...

13:32 < bitcoin-git> [bitcoin] laanwj closed pull request #13471: For AVX2 code, also check for AVX, XSAVE, and OS support (master...201806_avxossupport) https://github.com/bitcoin/bitcoin/pull/13471

14:03 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5eca4e86d4ef...dc53f7f25140

14:03 < bitcoin-git> bitcoin/master bad068a Wladimir J. van der Laan: build: Build system changes to support only Qt5

14:03 < bitcoin-git> bitcoin/master 907f73b Wladimir J. van der Laan: gui: Remove QT_VERSION fallbacks for Qt < 5...

14:03 < bitcoin-git> bitcoin/master 462c71f Wladimir J. van der Laan: test: Update travis to not test Qt4 anymore...

14:03 < bitcoin-git> [bitcoin] laanwj closed pull request #13458: gui: Drop qt4 support (master...2018_06_remove_qt4_support) https://github.com/bitcoin/bitcoin/pull/13458

14:31 < MarcoFalke> wumpus: I think #13480 can go in as-is

14:31 < gribble> https://github.com/bitcoin/bitcoin/issues/13480 | Avoid copies in range-for loops and add a warning to detect them by theuni · Pull Request #13480 · bitcoin/bitcoin · GitHub

14:34 < wumpus> MarcoFalke: ok

14:36 < wumpus> MarcoFalke: yes,looks good to me

14:37 < MarcoFalke> low priority, but good to keep the number of open pulls small

14:37 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc53f7f25140...31145a3d7c74

14:37 < bitcoin-git> bitcoin/master 466e16e Cory Fields: cleanup: avoid hidden copies in range-for loops

14:37 < bitcoin-git> bitcoin/master d92204c Cory Fields: build: add warning to detect hidden copies in range-for loops

14:37 < wumpus> right

14:37 < bitcoin-git> bitcoin/master 31145a3 Wladimir J. van der Laan: Merge #13480: Avoid copies in range-for loops and add a warning to detect them...

14:37 < bitcoin-git> [bitcoin] laanwj closed pull request #13480: Avoid copies in range-for loops and add a warning to detect them (master...no-for-copies) https://github.com/bitcoin/bitcoin/pull/13480

14:47 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/31145a3d7c74...03f3925bac96

14:47 < bitcoin-git> bitcoin/master 0000000 DesWurstes: Obsolete #!/bin/bash shebang

14:47 < bitcoin-git> bitcoin/master 03f3925 Wladimir J. van der Laan: Merge #13510: Scripts and tools: Obsolete #!/bin/bash shebang...

14:48 < bitcoin-git> [bitcoin] laanwj closed pull request #13510: Scripts and tools: Obsolete #!/bin/bash shebang (master...master) https://github.com/bitcoin/bitcoin/pull/13510

14:53 < promag> wumpus: 2 small prs for your consideration #12559 #12842

14:53 < gribble> https://github.com/bitcoin/bitcoin/issues/12559 | Avoid locking cs_main in some wallet RPC by promag · Pull Request #12559 · bitcoin/bitcoin · GitHub

14:53 < gribble> https://github.com/bitcoin/bitcoin/issues/12842 | Prevent concurrent savemempool by promag · Pull Request #12842 · bitcoin/bitcoin · GitHub

14:54 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/03f3925bac96...66e1a08d6fbf

14:54 < bitcoin-git> bitcoin/master 471a499 Chun Kuan Lee: Move rpc/util.cpp from libbitcoin-util to libbitcoin-server

14:54 < bitcoin-git> bitcoin/master 66e1a08 Wladimir J. van der Laan: Merge #13486: build: Move rpc/util.cpp from libbitcoin-util to libbitcoin-server...

14:55 < bitcoin-git> [bitcoin] laanwj closed pull request #13486: build: Move rpc/util.cpp from libbitcoin-util to libbitcoin-server (master...move_util_to_common) https://github.com/bitcoin/bitcoin/pull/13486

15:19 < bitcoin-git> [bitcoin] promag opened pull request #13529: wip: Use new Qt5 connect syntax (master...2018-06-use-qt5-connect-syntax) https://github.com/bitcoin/bitcoin/pull/13529

15:19 < promag> would like some concept ack ^^

16:33 < bitcoin-git> [bitcoin] laanwj closed pull request #13211: Use a semaphore or pipe for shutdown notification (skeees, laanwj) (master...2018_05_shutdown_notification) https://github.com/bitcoin/bitcoin/pull/13211

16:39 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/66e1a08d6fbf...9ab4c2a24658

16:39 < bitcoin-git> bitcoin/master 927e115 wodry: Test: Harden lint-filenames.sh

16:39 < bitcoin-git> bitcoin/master 9ab4c2a Wladimir J. van der Laan: Merge #13496: Test: Harden lint-filenames.sh...

16:40 < bitcoin-git> [bitcoin] laanwj closed pull request #13496: Test: Harden lint-filenames.sh (master...harden-test-lint-filenames.sh) https://github.com/bitcoin/bitcoin/pull/13496

16:44 < bitcoin-git> [bitcoin] laanwj closed pull request #13292: Re-add bench_bitcoin to gitian binaries (master...2018/05/bench_gitian) https://github.com/bitcoin/bitcoin/pull/13292

16:49 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9ab4c2a24658...08516e0e65d5

16:49 < bitcoin-git> bitcoin/master fa0fc1b MarcoFalke: bench: Add block assemble benchmark

16:49 < bitcoin-git> bitcoin/master 08516e0 Wladimir J. van der Laan: Merge #13219: bench: Add block assemble benchmark...

16:50 < bitcoin-git> [bitcoin] laanwj closed pull request #13219: bench: Add block assemble benchmark (master...Mf1805-benchBlockAssemble) https://github.com/bitcoin/bitcoin/pull/13219

16:52 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/08516e0e65d5...868cf431be1f

16:52 < bitcoin-git> bitcoin/master 54c3bb4 João Barbosa: wallet: Unlock spent outputs

16:52 < bitcoin-git> bitcoin/master fd9b3a7 João Barbosa: test: Output should be unlocked when spent

16:52 < bitcoin-git> bitcoin/master 868cf43 Wladimir J. van der Laan: Merge #13160: wallet: Unlock spent outputs...

16:53 < bitcoin-git> [bitcoin] laanwj closed pull request #12739: Fix unlocking of an already spent output (master...bugfix/fix-lockunspent-deadlock) https://github.com/bitcoin/bitcoin/pull/12739

16:53 < bitcoin-git> [bitcoin] laanwj closed pull request #13160: wallet: Unlock spent outputs (master...2018-05-unlock-spent-output) https://github.com/bitcoin/bitcoin/pull/13160

16:54 < bitcoin-git> [bitcoin] laanwj closed pull request #13493: gui: Add leading 0 to QT_VERSION check for QFontDatabase (master...remove-qtversion-qfontdatabase) https://github.com/bitcoin/bitcoin/pull/13493

17:25 < bitcoin-git> [bitcoin] laanwj opened pull request #13530: bench: Add missing pow.h header (master...2018_06_add_missing_header) https://github.com/bitcoin/bitcoin/pull/13530

17:36 < bitcoin-git> [bitcoin] achow101 closed pull request #12136: Implement BIP 174 Partially Signed Bitcoin Transactions serialization and RPCs (master...psbt) https://github.com/bitcoin/bitcoin/pull/12136

17:41 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/868cf431be1f...b1dc39df6ec8

17:41 < bitcoin-git> bitcoin/master cec84c2 Wladimir J. van der Laan: bench: Add missing pow.h header...

17:41 < bitcoin-git> bitcoin/master b1dc39d Wladimir J. van der Laan: Merge #13530: bench: Add missing pow.h header...

17:42 < bitcoin-git> [bitcoin] laanwj closed pull request #13530: bench: Add missing pow.h header (master...2018_06_add_missing_header) https://github.com/bitcoin/bitcoin/pull/13530

17:44 < bitcoin-git> [bitcoin] laanwj closed pull request #12938: Avoid unused locals for CScript::IsWitnessProgram (master...test-only-iswitnessprogram) https://github.com/bitcoin/bitcoin/pull/12938

18:15 < bitcoin-git> [bitcoin] laanwj closed pull request #10800: build: add lto configure option (master...enable-lto) https://github.com/bitcoin/bitcoin/pull/10800

18:16 < phantomcircuit> too many acronyms in the discussion about coin selection friends

18:16 < phantomcircuit> SRD? BNB?

18:18 < bitcoin-git> [bitcoin] laanwj closed pull request #10594: Bugfix: net: Apply whitelisting criteria to outgoing connections (master...whitelist_outgoing) https://github.com/bitcoin/bitcoin/pull/10594

18:24 < achow101> phantomcircuit: BnB = Branch and bound: exact matching algorithm. SRD = single random draw: randomly choose coins

18:24 < phantomcircuit> achow101, ah ok

18:24 < phantomcircuit> ty

18:24 < phantomcircuit> that entire conversation makes much more sense now

20:28 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #13531: doc: Clarify that mempool txiter is const_iterator (master...Mf1806-docTxiter) https://github.com/bitcoin/bitcoin/pull/13531

20:37 < bitcoin-git> [bitcoin] wodry opened pull request #13532: Log warning when deprecated network name 'tor' is used (master...log-deprecation-warning-when-onlynenet=tor-is-used) https://github.com/bitcoin/bitcoin/pull/13532